2007-10-25T08:38:15 <ThomasWaldmann> moin
2007-10-25T11:57:15 <CIA-31> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2238:2e6e853ffefc 1.6/MoinMoin/i18n/__init__.py: i18n: format text only when requested, better logging
2007-10-25T12:32:40 <ThomasWaldmann> fsck, 1321 matches for _(...)
2007-10-25T12:33:03 <xorAxAx> you are currently inverting the format kwarg?
2007-10-25T12:33:26 <ThomasWaldmann> no, just estimating the work for that
2007-10-25T12:33:31 <xorAxAx> ah, hehe
2007-10-25T12:33:51 <ThomasWaldmann> (and I guess I will first implement other kwargs needed)
2007-10-25T12:34:53 <ThomasWaldmann> but I guess we will have to review them all, for multiple reasons
2007-10-25T12:36:45 <ThomasWaldmann> the i18n loading already behaves much less strange now
2007-10-25T12:37:10 <ThomasWaldmann> but formatted=True is currently a runtime perfomance impact
2007-10-25T14:47:35 <dreimark> moin
2007-10-25T15:11:33 <francesco_> hi all! i would ask a simple question: From the Parser Plugin, can i distinguishing when a user run wikipage preview to a normal Show action?
2007-10-25T15:13:25 <francesco_> distinguish when a user run editform preview from a normal show action, of a page?
2007-10-25T15:20:56 <johill> ThomasWaldmann: yeah thanks, I'll look at the scripts
2007-10-25T16:38:48 <ThomasWaldmann> francesco_: you have access to the request object
2007-10-25T16:39:07 <ThomasWaldmann> (and thus, to the url)
2007-10-25T16:39:16 <ThomasWaldmann> francesco_: why do you ask?
2007-10-25T16:49:05 <francesco_> oh...yes! i have just finished to write my plugin code for this part.
2007-10-25T16:50:45 <francesco_> i have asked a stupid question, but when i press Enter it was too late.
2007-10-25T16:52:37 <francesco_> and...so...sorry, yes, it was a very stupid question to ask in moin develope channel.
2007-10-25T17:20:19 <francesco_> bye.
2007-10-25T18:26:23 <dreimark> xorAxAx: http://moinmoin.wikiwikiweb.de/MoinMoinBugs/1.6devWikiSyncDoesNotDetectOldMoin recognized ?
2007-10-25T18:27:31 <xorAxAx> dreimark: i know that page
2007-10-25T18:27:45 <xorAxAx> and the cause is not yet investigated why its not raised
2007-10-25T18:31:08 <dreimark> is it needed to reject wikisync if version < 1.6 to prevent confusions?
2007-10-25T18:31:44 <dreimark> bbl
2007-10-25T18:32:37 <xorAxAx> argh ...
2007-10-25T20:12:46 <ttjj> do you know that the Xapian python bindings introduce a posix only dependency with symlink ?
2007-10-25T20:13:27 <ttjj> Built and installed Xapian and Stemmer today, but moin index will not work because of lack of support of symlinks in win32
2007-10-25T20:14:25 <ThomasWaldmann> why that?
2007-10-25T20:14:30 <xorAxAx> ttjj: i think i commented that out in that twisted code
2007-10-25T20:14:36 <xorAxAx> ttjj: and it worked nevertheless
2007-10-25T20:15:42 <ttjj> Well. Looking at the index code, it seems to use symlinks for locking - so you might just have been lucky. It is not commented out for cgi which is what I am using
2007-10-25T20:16:19 <xorAxAx> ttjj: i mean, i did it locally
2007-10-25T20:16:30 <ttjj> It's a pity as I have a 17k+ page wiki which needs better indexing and although the taget is Enterpriise Linux I have to develop it on a PC running windows
2007-10-25T20:16:30 <xorAxAx> yes, its the locking of the twisted xapian wrapper
2007-10-25T20:16:59 <ThomasWaldmann> "twisted" ?
2007-10-25T20:17:27 <xorAxAx> well, divmod
2007-10-25T20:17:40 <xorAxAx> all of divmod's code is twisted
2007-10-25T20:18:12 <xorAxAx> but i didnt have enough time to test that local change
2007-10-25T20:18:29 <xorAxAx> nowadays its on a machine that i cannot access anymore
2007-10-25T20:19:09 <ttjj> (I actually wrote a simulate symlink and readlink module to get around this and then it fell over somewhere else)
2007-10-25T20:19:20 <ttjj> Has anyone tested it on win32?
2007-10-25T20:19:21 <ThomasWaldmann> ttjj: you could file a bug for this. either at divmod (best imho) or in the moin wiki (or both)
2007-10-25T20:19:26 <xorAxAx> ttjj: yes i did
2007-10-25T20:19:31 <xorAxAx> ThomasWaldmann: the upstream is dead AFAIK
2007-10-25T20:19:38 <ttjj> Will do
2007-10-25T20:19:41 <xorAxAx> ttjj: worked fine in some small tests
2007-10-25T20:20:23 <ttjj> Thanks bye
2007-10-25T21:53:19 <CIA-31> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2239:328dc99bb0cb 1.6/MoinMoin/ (action/fullsearch.py i18n/__init__.py request/__init__.py): add 'percent' kw to getText (must be True when using result as left side of % operator), refactored some code, better comments
2007-10-25T21:56:17 <ThomasWaldmann> ok, who wants to help refactoring all _() calls?
2007-10-25T21:57:32 <TheSheep> ThomasWaldmann: what do I do?
2007-10-25T21:58:28 <TheSheep> ThomasWaldmann: I mean, which files should I take?
2007-10-25T21:59:15 <ThomasWaldmann> TheSheep: thanks for helping, you could take action/
2007-10-25T21:59:33 <ThomasWaldmann> there are 2 things to do:
2007-10-25T22:00:03 <ThomasWaldmann> formatted kw: currently default is True, but this is bad
2007-10-25T22:00:36 <ThomasWaldmann> so one should add formatted=True (after reviewing the string, if this is really wanted)
2007-10-25T22:01:01 <TheSheep> we want it when the string contains wiki markup, right?
2007-10-25T22:01:06 <ThomasWaldmann> so that every call has a formatted kw, either True or False
2007-10-25T22:01:27 <ThomasWaldmann> yes, if we want it to be processed through the wiki parser/formatter
2007-10-25T22:01:58 <ThomasWaldmann> (it will have a runtime cpu impact with the current code, so it should be avoided)
2007-10-25T22:03:03 <ThomasWaldmann> percent kw: this is new and defaults to False. if should be given as percent=True when the (formatted) result string will be used as left side of a % operator.
2007-10-25T22:03:25 <ThomasWaldmann> (see also my latest push)
2007-10-25T22:03:43 <ThomasWaldmann> all will happen in the 1.6 repo
2007-10-25T22:06:21 * ThomasWaldmann will start with the toplevel dir
2007-10-25T22:07:20 <ThomasWaldmann> TheSheep: percent kw is not needed when formatted==False
2007-10-25T22:11:53 <TheSheep> argh
2007-10-25T22:12:00 <TheSheep> %s/fromatted/formatted/g
2007-10-25T22:13:47 <TheSheep> should all comments containgin things like MoinMoin be formatted?
2007-10-25T22:13:47 <ThomasWaldmann> btw, it a string has a page name without markup in it, then formatted=False
2007-10-25T22:13:55 <TheSheep> ah, ok
2007-10-25T22:14:17 <ThomasWaldmann> (because it would work only with camelcase and fail anyway for every other page name)
2007-10-25T22:14:34 <ThomasWaldmann> comments?
2007-10-25T22:14:45 <TheSheep> strings
2007-10-25T22:14:47 <TheSheep> sorry
2007-10-25T22:15:57 <TheSheep> ideed, defaulting to True might have been a mistake :D
2007-10-25T22:18:51 <TheSheep> now this is weird
2007-10-25T22:19:30 <TheSheep> _(
2007-10-25T22:19:30 <TheSheep> 'Restored Backup: %(filename)s to target dir: %(targetdir)s.\nFiles: %(filecount)d, Directories: %(dircount)d' %
2007-10-25T22:19:33 <TheSheep> locals())
2007-10-25T22:19:42 <TheSheep> shouldn't % be outside of _()
2007-10-25T22:19:43 <TheSheep> ?
2007-10-25T22:20:02 <ThomasWaldmann> this is a bug, right
2007-10-25T22:21:13 <TheSheep> yay, my first bug *^__^*
2007-10-25T22:30:47 <TheSheep> ThomasWaldmann: what if a string contains both wiki formatting and %s'es?
2007-10-25T22:31:31 <TheSheep> ah, thats formatted=True, percent=True
2007-10-25T22:32:31 <ThomasWaldmann> yes
2007-10-25T22:33:07 <ThomasWaldmann> the % it already contains (before running through the parser/formatter) will get through "as is"
2007-10-25T22:33:56 <ThomasWaldmann> just the %XX%XX (e.g. in href=...) must be escaped (and this is triggered by formatted=True, percent=True)
2007-10-25T22:35:29 <TheSheep> but the _() is called before the %
2007-10-25T22:35:37 <TheSheep> so the urls are not in there yet
2007-10-25T22:36:48 <TheSheep> n%. n%. n%. fun!
2007-10-25T22:39:26 <ThomasWaldmann> hm?
2007-10-25T22:39:54 <ThomasWaldmann> the problem are the urls generated by the wiki parser/formatter
2007-10-25T22:40:17 <ThomasWaldmann> e.g. if CamelCase is something nonascii in some language
2007-10-25T22:40:31 <ThomasWaldmann> then it will have %XX in the url
2007-10-25T22:40:40 <TheSheep> ah, ok
2007-10-25T22:40:46 <ThomasWaldmann> if this is used as left-side of %, it will raise an exception
2007-10-25T22:41:46 <ThomasWaldmann> percent=True will use a special formatter, that replaces all % in html tags by %%
2007-10-25T22:55:21 <TheSheep> there are some strings that refer to system pages using CamelCase name, but no markup
2007-10-25T22:55:27 <TheSheep> should I add the markup to them?
2007-10-25T23:00:03 <TheSheep> tests finished: 16 failed in 0.87 seconds <-- is this normal?
2007-10-25T23:03:57 <ThomasWaldmann> 1.6 still has the old tests, no py.test yet
2007-10-25T23:04:29 <ThomasWaldmann> no, don't add markup
2007-10-25T23:04:41 <TheSheep> ok, commiting
2007-10-25T23:04:50 <ThomasWaldmann> but use formatted=True for those
2007-10-25T23:05:11 <ThomasWaldmann> (sys pages usually are camelcase)
2007-10-25T23:05:44 <TheSheep> argh
2007-10-25T23:05:51 * ThomasWaldmann is reviewing his diff before committing :)
2007-10-25T23:05:56 <TheSheep> ThomasWaldmann: what if somone has CamelCase disabled?
2007-10-25T23:06:15 <ThomasWaldmann> i dont think we support that
2007-10-25T23:06:15 <TheSheep> ThomasWaldmann: shouldn't the links be still generated?
2007-10-25T23:06:19 <xorAxAx> disabled?
2007-10-25T23:06:45 <xorAxAx> is there an option?
2007-10-25T23:06:49 <ThomasWaldmann> and we shouldnt invalidate too many translations by changing orig strings now
2007-10-25T23:07:27 <TheSheep> xorAxAx: there used to be
2007-10-25T23:07:35 <xorAxAx> TheSheep: i have never seen one
2007-10-25T23:07:47 <TheSheep> xorAxAx: maybe I'm mixing it up with other engine :/
2007-10-25T23:08:01 <xorAxAx> TheSheep: but you can use the nocamelcase parser if you dont want no camelcase
2007-10-25T23:08:10 <xorAxAx> (which is simply subclassing the original one)
2007-10-25T23:08:17 <TheSheep> xorAxAx: ah, that must be it
2007-10-25T23:08:44 <TheSheep> ok, so now I need to find all CamelCase links and set formatting=True on them
2007-10-25T23:14:18 <TheSheep> abort: push creates new remote branches!
2007-10-25T23:14:22 <TheSheep> hmmm...
2007-10-25T23:14:40 * TheSheep blinks
2007-10-25T23:16:34 <CIA-31> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2240:48e2234997a9 1.6/MoinMoin/action/ (27 files): actions: reviewed _() strings and added "formatted" kw
2007-10-25T23:16:35 <CIA-31> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2241:7f38deb416a7 1.6/MoinMoin/action/ (SyncPages.py subscribe.py): actions: formatted=True on strings with CamelCase links
2007-10-25T23:16:58 <TheSheep> ThomasWaldmann: which one next?
2007-10-25T23:26:00 <ThomasWaldmann> TheSheep: you choose
2007-10-25T23:26:08 <ThomasWaldmann> (not the top dir)
2007-10-25T23:26:16 <TheSheep> ok, parsers :)
2007-10-25T23:26:42 <TheSheep> hmm... why there are pyc files in the repo?
2007-10-25T23:26:55 <TheSheep> ah, no, these are from running tests
2007-10-25T23:28:09 <CIA-31> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2242:59505dc6cf43 1.6/MoinMoin/ (8 files): MoinMoin: reviewed _() calls and added formatted/percent kwargs
2007-10-25T23:28:11 <CIA-31> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2243:608e5de09a3d 1.6/MoinMoin/action/ (27 files): merged main
2007-10-25T23:28:36 * ThomasWaldmann takes auth
2007-10-25T23:30:11 <ThomasWaldmann> finished :D
2007-10-25T23:33:03 <ThomasWaldmann> config is also nothing todo
2007-10-25T23:33:29 <ThomasWaldmann> converter is also nothing todo
2007-10-25T23:34:04 <ThomasWaldmann> filter is also nothing todo
2007-10-25T23:34:29 * ThomasWaldmann takes formatter
2007-10-25T23:34:55 <CIA-31> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2244:4543e006c266 1.6/MoinMoin/parser/ (text_moin_wiki.py text_rst.py text_xslt.py): parser: reviewed _() strings and added formatted kw
2007-10-25T23:34:56 <CIA-31> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2245:eedf9828caf2 1.6/MoinMoin/ (8 files): merge main
2007-10-25T23:35:17 * TheSheep takes macro
2007-10-25T23:38:59 * ThomasWaldmann takes mail
2007-10-25T23:41:10 <grzywacz> night
2007-10-25T23:43:05 * ThomasWaldmann takes request
2007-10-25T23:43:12 <dreimark> * takes a new clone
2007-10-25T23:46:38 <CIA-31> moin: Reimar Bauer <rb.proj AT googlemail DOT com> default * 2246:3e978c3380cd 1.6/MoinMoin/action/AttachFile.py: AttachFile.getFilename: creates attachment dir on requesting filename
2007-10-25T23:46:46 * ThomasWaldmann takes search
2007-10-25T23:47:29 <TheSheep> found another % inside _() in macro/login.py
2007-10-25T23:47:55 <starshine> I'm at work right now but I suppose we'll have to check the themes too :/
2007-10-25T23:48:04 <dreimark> :)
2007-10-25T23:50:22 * ThomasWaldmann takes security
2007-10-25T23:51:48 * ThomasWaldmann takes stats
2007-10-25T23:52:58 <CIA-31> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2247:fc4f5e0c9269 1.6/MoinMoin/macro/ (18 files): macro: reviewed _() strings and added formatted kw
2007-10-25T23:53:00 <CIA-31> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2248:0bcd2ff89306 1.6/MoinMoin/action/AttachFile.py: merge main
2007-10-25T23:55:13 * TheSheep takes filter
2007-10-25T23:56:02 * TheSheep takes config
2007-10-25T23:57:08 <TheSheep> hmm... multiconfig.py defines _()
2007-10-25T23:57:28 <ThomasWaldmann> TheSheep: dont change config
2007-10-25T23:57:29 <TheSheep> should I add keywords anyways?
2007-10-25T23:57:39 <ThomasWaldmann> (see my comment above)
2007-10-25T23:57:57 <ThomasWaldmann> (23:33) < ThomasWal> config is also nothing todo
2007-10-25T23:58:03 <TheSheep> ah, sorry
2007-10-25T23:58:38 * TheSheep takes wikixml
2007-10-25T23:58:54 <ThomasWaldmann> support is nothing todo
2007-10-25T23:58:57 * TheSheep takes xmlrpc
2007-10-25T23:59:26 * TheSheep takes widget
2007-10-25T23:59:45 * TheSheep takes util
MoinMoin: MoinMoinChat/Logs/moin-dev/2007-10-25 (last edited 2007-10-29 19:11:41 by localhost)