MoinMoin: MoinMoinChat/Logs/moin-dev/2010-10-23

   1 2010-10-23T08:01:08  *** kursor has joined #moin-dev
   2 2010-10-23T08:02:34  *** kursor has quit IRC
   3 2010-10-23T08:02:51  *** kursor has joined #moin-dev
   4 2010-10-23T08:07:50  *** xjjk has quit IRC
   5 2010-10-23T08:07:57  *** xjjk has joined #moin-dev
   6 2010-10-23T08:20:46  *** xjjk has quit IRC
   7 2010-10-23T08:32:57  *** xjjk has joined #moin-dev
   8 2010-10-23T12:25:19  <ThomasWaldmann> moin
   9 2010-10-23T12:59:56  *** greg_f has joined #moin-dev
  10 2010-10-23T15:41:15  *** grzywacz has joined #moin-dev
  11 2010-10-23T17:08:32  <dreimark> moin
  12 2010-10-23T17:11:18  <ThomasWaldmann> re
  13 2010-10-23T17:56:51  *** realmike has joined #moin-dev
  14 2010-10-23T18:38:05  *** kursor has quit IRC
  15 2010-10-23T19:04:12  * dreimark greetings from gplex
  16 2010-10-23T19:07:05  <ThomasWaldmann> greetings to everybody there
  17 2010-10-23T19:07:35  <realmike> hi
  18 2010-10-23T19:08:36  <realmike> i wrote a script to migrate pmwiki to moinmoin. part of it is a patch to moin to accept pmwiki's password hashes in addition to moin's "sha1" hashes.
  19 2010-10-23T19:09:07  <realmike> is that something that would be interesting for moin? (otherwise, i'll keep it as a separate patch to distribute with the migration script)
  20 2010-10-23T19:09:13  <dreimark> realmike: yes
  21 2010-10-23T19:09:47  <dreimark> is it all python?
  22 2010-10-23T19:10:20  <realmike> the password hash patch, yes
  23 2010-10-23T19:10:58  <realmike> the migration script consists of a modified pmwiki (php) that produces intermediate xml and a python script to convert that to moin markup
  24 2010-10-23T19:11:01  <ThomasWaldmann> i guess less problematic would be a procedure to get the users to reset their pw
  25 2010-10-23T19:11:15  <dreimark> add a feature request and the patch on it
  26 2010-10-23T19:11:22  <realmike> the script was for www.gnewsense.org, with >3000 users. we didn't want to do that
  27 2010-10-23T19:11:56  <realmike> i'll rework the patch for moin 1.9.3 (was written for (1.7.x) and add a patch
  28 2010-10-23T19:11:57  <ThomasWaldmann> is it a standard hash?
  29 2010-10-23T19:12:10  <realmike> APR1 - apache md5
  30 2010-10-23T19:12:40  <realmike> (at least that's what www.gnewsense.org used. i think pmwiki accepts anything that's in a .htpasswd)
  31 2010-10-23T19:13:44  <realmike> i noticed that 1.9.3 has very nice clean code in user.py that should make it easy to upgrade the hashes to SSHA once users have logged in
  32 2010-10-23T19:13:44  <ThomasWaldmann> ok, will have to see the patch
  33 2010-10-23T19:17:17  <dreimark> realmike: http://moinmo.in/HtmlConverter may be add a link to the pmwiki convertor on that page
  34 2010-10-23T19:17:40  <ThomasWaldmann> btw make sure that moin uses ssha if user changes such a md5 pw
  35 2010-10-23T19:18:47  <dreimark> realmike: or create a page describing it a little bit and a link to the convertor
  36 2010-10-23T19:20:14  * dreimark session planning now
  37 2010-10-23T19:20:16  <dreimark> bbl
  38 2010-10-23T19:26:26  <realmike> will start today. thanks
  39 2010-10-23T20:02:30  *** greg_f has quit IRC
  40 2010-10-23T20:15:12  *** waldi has quit IRC
  41 2010-10-23T20:15:12  *** waldi has joined #moin-dev
  42 2010-10-23T20:31:50  *** kursor has joined #moin-dev
  43 2010-10-23T21:11:17  *** kursor has quit IRC
  44 2010-10-23T22:45:53  *** TWHaiku has joined #moin-dev
  45 2010-10-23T22:59:34  *** TWHaiku has quit IRC
  46 2010-10-23T23:23:29  <realmike> i uploaded a patch for the password hashes i talked about earlier: http://moinmo.in/FeatureRequests/ImportedPasswordHashes
  47 2010-10-23T23:24:16  * ThomasWaldmann looks
  48 2010-10-23T23:31:54  <ThomasWaldmann> when does import crypt fail?
  49 2010-10-23T23:36:48  <ThomasWaldmann> realmike: ^^
  50 2010-10-23T23:41:41  <ThomasWaldmann> ah, it's platform dependend, unix only
  51 2010-10-23T23:41:48  <ThomasWaldmann> do you really need that?
  52 2010-10-23T23:42:47  <realmike> that's for the DES crypt, one of the hashes that gnewsense.org actually used
  53 2010-10-23T23:44:17  <ThomasWaldmann> ok
  54 2010-10-23T23:44:18  <realmike> not sure how common it is
  55 2010-10-23T23:44:26  <ThomasWaldmann> patch looks good, did you test it?
  56 2010-10-23T23:45:44  <realmike> yes. the original version works on www.gnewsense.org with moin 1.7.3. i just ported it to 1.9.3 today
  57 2010-10-23T23:46:13  <ThomasWaldmann> ported means exactly?
  58 2010-10-23T23:46:25  <realmike> i didn't test {MD5}, but that's the same algortihm as  {APR1} with a different salt length
  59 2010-10-23T23:47:04  <realmike> md5crypt.py is unchanged, the parts in user.py are slightly changed because the surrounding methods/variables are different
  60 2010-10-23T23:47:20  <realmike> and i tested it on my local 1.9.3 install
  61 2010-10-23T23:47:34  <ThomasWaldmann> ok
  62 2010-10-23T23:47:43  <ThomasWaldmann> you don't use hg, do you?
  63 2010-10-23T23:48:37  <realmike> i don't have a moin checkout yet, no
  64 2010-10-23T23:48:50  <ThomasWaldmann> ok, wait a sec
  65 2010-10-23T23:52:18  <ThomasWaldmann> hmm, one could add your name to the (c) for the code you changed
  66 2010-10-23T23:54:28  <realmike> sure, i wouldn't object to that. (but wouldn't mind otherwise either)
  67 2010-10-23T23:56:58  <ThomasWaldmann> $ patch -p1 < imported_pwd_hashes.patch
  68 2010-10-23T23:56:59  <ThomasWaldmann> patch: **** Only garbage was found in the patch input.
  69 2010-10-23T23:57:08  <ThomasWaldmann> strange
  70 2010-10-23T23:57:43  <realmike> hm. i made it with "diff -Nr moin-1.9.3 moin-1.9.3-patch > imported_pwd_hashes.patch"
  71 2010-10-23T23:58:13  <realmike> or did patch perform a code review of my changes :-)