1 2013-05-15T00:06:40 *** dcramer_
2 2013-05-15T00:42:41 *** dcramer_
3 2013-05-15T00:56:16 *** dcramer_
4 2013-05-15T02:24:53 *** sharky93
5 2013-05-15T03:05:16 *** dcramer_
6 2013-05-15T04:42:17 *** dcramer_
7 2013-05-15T05:00:34 *** sunumonster
8 2013-05-15T05:00:35 *** eSyr
9 2013-05-15T05:03:28 *** sunumonster
10 2013-05-15T05:03:28 *** eSyr
11 2013-05-15T05:34:54 *** dcramer_
12 2013-05-15T05:41:27 *** allure
13 2013-05-15T06:17:31 *** allure
14 2013-05-15T06:17:31 *** allure
15 2013-05-15T08:13:00 *** ana-balica
16 2013-05-15T08:14:12 *** ana-balica
17 2013-05-15T08:37:45 *** ana_ananasova
18 2013-05-15T08:50:23 *** sharky93
19 2013-05-15T08:50:30 <sharky93> moin
20 2013-05-15T08:56:13 <sharky93> i am getting connection time-outs while trying to upload to codereview.appspot but ping responses are OK, could there be some other issue ? is there another way other than using "upload.py" ?
21 2013-05-15T09:09:05 *** greg_f
22 2013-05-15T09:11:34 <ThomasWaldmann> upload.py is the recommended way and usually works.
23 2013-05-15T09:14:14 <sharky93> this is what i get -> "urllib2.URLError: <urlopen error [Errno 110] Connection timed out>"
24 2013-05-15T09:17:25 <ThomasWaldmann> maybe try again later or via another connection
25 2013-05-15T09:18:01 <ThomasWaldmann> their website responds a bit slow to me, too
26 2013-05-15T09:18:12 <ThomasWaldmann> (but works)
27 2013-05-15T09:30:12 *** ashutosh1461
28 2013-05-15T09:31:39 <ashutosh1461> moin
29 2013-05-15T09:43:19 *** dav1d
30 2013-05-15T09:48:54 <ThomasWaldmann> hi dav1d :)
31 2013-05-15T09:49:02 <ThomasWaldmann> moin ashutosh1461
32 2013-05-15T09:49:04 <dav1d> hi ThomasWaldmann
33 2013-05-15T09:49:35 <ThomasWaldmann> ashutosh1461: sorry if the codereview is going rather slowly right now, but i am busy with misc. other stuff
34 2013-05-15T09:51:42 <ThomasWaldmann> dav1d: https://moinmo.in/MoinMoin2.0 there are the important links, http://moinmo.in/GoogleSoc2013/InitialProjectIdeas there the initial project ideas
35 2013-05-15T10:09:33 <ashutosh1461> ThomasWaldmann, i understand :)
36 2013-05-15T10:14:29 <ThomasWaldmann> btw, potential student can have some thoughts about personal multiprocessing, so that if some I/O is blocking (e.g. codereview), you can switch to another task :D
37 2013-05-15T10:15:53 <dav1d> ThomasWaldmann: UI Improvements, good idea :P
38 2013-05-15T10:16:03 <dav1d> moin2 looks so 90ies :P
39 2013-05-15T10:17:57 <dav1d> Network api sounds like fun
40 2013-05-15T10:18:11 <dav1d> but why *rpc, instead of something RESTful
41 2013-05-15T10:18:29 <sharky93> ThomasWaldmann, context switching takes some time :D
42 2013-05-15T10:18:31 <dav1d> or for fancy JS, websockets
43 2013-05-15T10:20:02 <dav1d> python3 port, is flask yet ported?
44 2013-05-15T10:21:06 <dav1d> ThomasWaldmann: ^
45 2013-05-15T10:32:08 *** ashutosh_singla1
46 2013-05-15T10:32:09 *** ashutosh1461
47 2013-05-15T10:34:24 *** ana-balica
48 2013-05-15T10:50:18 <dreimark> moin
49 2013-05-15T10:50:31 <dreimark> dav1d: flask awaits porting too
50 2013-05-15T10:51:07 <dav1d> oh there are actually plans for porting flask, were the wsgi unicode/bytes issues figured out?
51 2013-05-15T10:56:11 *** ana-balica
52 2013-05-15T10:59:23 *** ashutosh_singla1
53 2013-05-15T11:16:07 *** sunumonster
54 2013-05-15T11:35:48 *** H0arry
55 2013-05-15T11:35:53 <H0arry> Moin.
56 2013-05-15T11:38:09 <dreimark> hi H0arry
57 2013-05-15T12:13:56 *** ana-balica
58 2013-05-15T12:28:18 *** brunomartin
59 2013-05-15T13:06:11 *** dave_largo
60 2013-05-15T13:26:45 <sharky93> Fix for #366, https://codereview.appspot.com/9104050/
61 2013-05-15T13:26:50 <sharky93> ThomasWaldmann, dreimark ^
62 2013-05-15T13:27:06 <sharky93> "upload.py" finally worked!
63 2013-05-15T13:28:11 <sharky93> This is how it looks, -> http://imagebin.org/257667
64 2013-05-15T14:32:40 *** sunumonster
65 2013-05-15T14:37:13 <ThomasWaldmann> sharky93: btw, is that the same button style as the other buttons on that page?
66 2013-05-15T14:39:19 <ThomasWaldmann> dav1d: afaik, wsgi is define now for py3 and some people are working on werkzeug/flask. but i don't know details.
67 2013-05-15T14:59:21 <ThomasWaldmann> sharky93: review done. TheSheep ^
68 2013-05-15T15:11:28 <dreimark> sharky93: btw. i would expect a guesture not an extra button, and Remove File sounds wrong
69 2013-05-15T15:14:25 <ThomasWaldmann> guesture?
70 2013-05-15T15:16:31 <ThomasWaldmann> (and i also think "remove file" is not wrong, as it obviously refers to the file name shown to the direct left of the button)
71 2013-05-15T15:16:57 *** SteveMcIntyre
72 2013-05-15T15:17:12 *** SteveMcIntyre
73 2013-05-15T15:19:02 <ThomasWaldmann> also, you need to make a specific better suggestion, otherwise this is leading nowhere
74 2013-05-15T15:19:11 <ThomasWaldmann> dreimark: ^
75 2013-05-15T15:25:43 <ThomasWaldmann> hmm, we could relabel that "upload file" button to "add file" (so it is adding and removing a file to/from the post data)
76 2013-05-15T16:02:04 <ThomasWaldmann> Ran 281 tests in 1.300s
77 2013-05-15T16:02:50 <ThomasWaldmann> ^ jinja2 unit tests, FAST
78 2013-05-15T16:09:40 *** ana-balica
79 2013-05-15T16:13:53 <sharky93> ThomasWaldmann, yes it is the default button style as defined for that theme. we can maybe use "Clear" instead of "Remove File" which does give a feel of deleting something..
80 2013-05-15T16:14:41 <sharky93> the reason for different width's is because it is theme dependent. 85% as tested for "FooBar" and 75% as tested with "Modernized" theme.
81 2013-05-15T16:15:56 <sharky93> plus i had no part to play here -> https://codereview.appspot.com/9104050/diff/1/MoinMoin/themes/foobar/static/css/common.css i modified the stylus file, rest is as handled by running the stylus command.
82 2013-05-15T16:16:05 <sharky93> dreimark, TheSheep ^
83 2013-05-15T16:21:04 <TheSheep> stylus?
84 2013-05-15T16:27:40 <ThomasWaldmann> sharky93: can the button be just as wide as required by its content + a litte more?
85 2013-05-15T16:28:17 <ThomasWaldmann> TheSheep: css compiler
86 2013-05-15T16:29:15 <ThomasWaldmann> sharky93: in general, changesets must not have unintended changes. if they have, fix that first.
87 2013-05-15T16:30:42 <sharky93> ThomasWaldmann, but i am not in control of the change, all that is being handled by the CSS compiler. it somehow looks that the CSS has unintended change but it may be the styluss' way of handling that.
88 2013-05-15T16:31:03 <sharky93> everything else is displayed as it was earlier.
89 2013-05-15T16:32:16 *** ashutosh1461
90 2013-05-15T16:36:20 <sharky93> ThomasWaldmann, ok, the width is now auto-defined for the button, as you said, the content + a little more :)
91 2013-05-15T16:41:26 <ashutosh1461> sharky93, ThomasWaldmann how about using little cross like button to clear the text like http://img.viralpatel.net/2011/02/clearable-textbox-jquery.png
92 2013-05-15T16:52:09 <sharky93> ashutosh1461, yes we agreed on deciding that later on, first putting in the functionality with an inline button.
93 2013-05-15T17:38:18 *** greg_f
94 2013-05-15T17:39:48 *** dwcramer
95 2013-05-15T17:54:45 *** dcramer_
96 2013-05-15T18:24:02 *** ana-balica
97 2013-05-15T18:33:49 *** dwcramer
98 2013-05-15T18:34:19 *** dcramer_
99 2013-05-15T19:06:12 *** ashutosh1461
100 2013-05-15T19:17:14 *** ana-balica
101 2013-05-15T19:28:51 *** dwcramer
102 2013-05-15T19:37:19 *** dwcramer
103 2013-05-15T20:07:34 <sharky93> added comments and a new patchset @ https://codereview.appspot.com/9104050/
104 2013-05-15T20:25:44 *** allure
105 2013-05-15T20:49:58 *** ana_ananasova
106 2013-05-15T20:52:57 *** ana_ananasova
107 2013-05-15T21:06:18 *** sharky93
108 2013-05-15T21:06:47 *** dave_largo
109 2013-05-15T21:30:52 *** dwcramer
110 2013-05-15T22:12:34 *** dwcramer
111 2013-05-15T22:57:05 *** brunomartin
112
