1 2014-02-14T00:14:02 *** derdon
2 2014-02-14T00:16:53 *** penguinRaider
3 2014-02-14T00:18:26 *** penguinRaider
4 2014-02-14T00:24:51 <ThomasWaldmann> penguinRaider: review done
5 2014-02-14T00:31:49 <penguinRaider> ThomasWaldmann, thanks I will do that again
6 2014-02-14T02:13:43 *** sudo_dirk
7 2014-02-14T02:15:15 *** sudo_dirk
8 2014-02-14T02:22:02 *** skathpalia
9 2014-02-14T02:23:36 <skathpalia> ThomasWaldmann, I have done the required changes in my new patch https://codereview.appspot.com/61650043 which is fix to https://bitbucket.org/thomaswaldmann/moin-2.0/issue/400/creation-of-new-default-wiki-html-item
10 2014-02-14T02:24:27 <skathpalia> Can you please review
11 2014-02-14T02:39:43 *** skathpalia
12 2014-02-14T03:09:09 *** ajitesh
13 2014-02-14T03:47:36 *** moinBot
14 2014-02-14T03:48:18 *** moinBot`
15 2014-02-14T04:52:40 *** ajitesh
16 2014-02-14T06:30:41 *** penguinRaider
17 2014-02-14T07:19:09 *** penguinRaider
18 2014-02-14T07:39:49 *** gp94
19 2014-02-14T07:40:02 *** gp94_
20 2014-02-14T08:11:27 *** gp94
21 2014-02-14T09:01:07 *** greg_
22 2014-02-14T09:04:34 *** greg_f
23 2014-02-14T09:23:59 *** Cthulhux
24 2014-02-14T09:26:46 *** Cthulhux
25 2014-02-14T11:30:21 *** Cthulhux
26 2014-02-14T11:34:58 *** Cthulhux
27 2014-02-14T11:57:56 *** derdon
28 2014-02-14T12:07:55 *** dimazest
29 2014-02-14T12:34:10 *** penguinRaider
30 2014-02-14T12:42:26 *** dave_largo
31 2014-02-14T13:18:29 <ajitesh> Even after using the bs version link provided http://moin-20.readthedocs.org/en/latest/devel/development.html?templates-and-themes#templates-and-themes ... i see a lot of changes in the basic.css on compiling basic.less..
32 2014-02-14T13:34:58 *** penguinRaider
33 2014-02-14T13:40:11 *** penguinRaider
34 2014-02-14T13:46:17 <ThomasWaldmann> sharky93: ^^
35 2014-02-14T14:06:39 *** penguinRaider
36 2014-02-14T14:22:35 *** skathpalia
37 2014-02-14T14:33:06 *** ajitesh
38 2014-02-14T14:34:38 <skathpalia> ThomasWaldmann, I made the required changes regarding the bug #400. You can review it here https://codereview.appspot.com/61650043/
39 2014-02-14T14:45:03 *** penguinRaider
40 2014-02-14T14:45:48 *** penguinRaider
41 2014-02-14T14:58:23 *** resurrectorx
42 2014-02-14T15:08:24 *** resurrectorx_
43 2014-02-14T15:08:58 *** resurrectorx
44 2014-02-14T15:09:12 *** resurrectorx_
45 2014-02-14T15:09:42 <resurrectorx> transport123
46 2014-02-14T15:13:24 <ThomasWaldmann> resurrectorx: do you need a new password now? :D
47 2014-02-14T15:16:28 *** resurrectorx
48 2014-02-14T15:20:17 *** ajitesh
49 2014-02-14T15:52:37 <skathpalia> ThomasWaldmann, I have added a new line in the code you can review it :)
50 2014-02-14T15:58:21 <skathpalia> ThomasWaldmann, Should I send the pull request now?
51 2014-02-14T16:14:52 *** Cthulhux
52 2014-02-14T16:14:52 *** Cthulhux
53 2014-02-14T16:20:24 <penguinRaider> ThomasWaldmann, I modified the code and comment as you said please review again https://codereview.appspot.com/63500043/
54 2014-02-14T16:33:16 <ThomasWaldmann> oops.
55 2014-02-14T16:40:53 <ThomasWaldmann> 577 elif name is None: # incase name is None
56 2014-02-14T16:40:53 <ThomasWaldmann> how is a comment like such helpful?
57 2014-02-14T16:41:34 <penguinRaider> ThomasWaldmann, yeah not helpful I guess I will modify it
58 2014-02-14T16:41:54 <penguinRaider> ThomasWaldmann, Also I made another mistake I corrected that in the next one
59 2014-02-14T16:43:01 <ThomasWaldmann> tell me when finished and published
60 2014-02-14T16:43:25 <ThomasWaldmann> and maybe just slowly read through your stuff and have a 2nd thought about it
61 2014-02-14T16:43:36 <ThomasWaldmann> you can do that yourself before I do :)
62 2014-02-14T16:44:37 <penguinRaider> ThomasWaldmann, Thanks I will correct that and make comments more meaningful
63 2014-02-14T16:48:11 <ThomasWaldmann> https://moinmo.in/MoinMoinBugs/GetSubscribersSlow \o/
64 2014-02-14T16:48:39 <ThomasWaldmann> "when O(N) bites you in the ass" fixed.
65 2014-02-14T17:12:30 * ThomasWaldmann resubmitted the gsoc 2014 questionaire, now with 4 mentors
66 2014-02-14T17:37:03 <skathpalia> ThomasWaldmann, I added the new line in my patch . You can review it here https://codereview.appspot.com/61650043/
67 2014-02-14T17:56:38 * ThomasWaldmann looks...
68 2014-02-14T17:58:18 <ThomasWaldmann> skathpalia: you didn't answer my questions there
69 2014-02-14T17:59:57 <skathpalia> Oh forgot to answer that I am adding comment :)
70 2014-02-14T18:02:29 *** greg_
71 2014-02-14T18:08:59 <penguinRaider> ThomasWaldmann, https://codereview.appspot.com/63500043 added some meaningful comments
72 2014-02-14T18:14:41 <ThomasWaldmann> penguinRaider: see there
73 2014-02-14T18:15:55 <ajitesh> ThomasWaldmann, i did some work on the index page gui.. i pasted an image online.. wanted to know if its good enough.. http://imagebin.org/293380
74 2014-02-14T18:16:42 <skathpalia> ThomasWaldmann, basic_data_editor was not defined thats why I used data_editor and data_editor has no attribute class thats why I removed it
75 2014-02-14T18:25:23 <ThomasWaldmann> skathpalia: ok, i see it now. i though you were talking about css class.
76 2014-02-14T18:25:29 <ThomasWaldmann> thought*
77 2014-02-14T18:26:03 <ThomasWaldmann> skathpalia: so, if you tested it enough, proceed
78 2014-02-14T18:27:05 <skathpalia> Ok then I am sending the pull request :)
79 2014-02-14T18:29:31 * ThomasWaldmann does some more 1.9 work
80 2014-02-14T18:38:07 *** dimazest
81 2014-02-14T18:43:19 <penguinRaider> ThomasWaldmann, by query I meant the method and calling it with anything other than name like by revid, itemid.
82 2014-02-14T18:43:37 <penguinRaider> ThomasWaldmann, what should I name it I am stuck with the naming a bit :-(
83 2014-02-14T18:44:07 <penguinRaider> ThomasWaldmann, also for the IndexError will it be okay if I do error handling
84 2014-02-14T18:44:09 <penguinRaider> ?
85 2014-02-14T18:56:07 <skathpalia> ThomasWaldmann, sent the pull request :)
86 2014-02-14T18:56:26 *** penguinRaider
87 2014-02-14T18:56:54 *** penguinRaider
88 2014-02-14T18:57:35 *** skathpalia
89 2014-02-14T19:00:51 *** skathpalia
90 2014-02-14T19:10:42 <ThomasWaldmann> skathpalia: ok, will have a look later
91 2014-02-14T19:12:31 <skathpalia> Ok :)
92 2014-02-14T19:13:33 *** dreimark
93 2014-02-14T19:42:14 <ajitesh> ThomasWaldmann, i did some work on the index page gui.. i pasted an image online.. wanted to know if its good enough.. http://imagebin.org/293380
94 2014-02-14T19:42:30 <ajitesh> also any suggestions..
95 2014-02-14T19:46:42 *** skathpalia
96 2014-02-14T19:58:56 *** RogerHaase
97 2014-02-14T20:03:13 <ajitesh> RogerHaase, i did some work on the index page gui.. i pasted an image online.. wanted to know if its good enough.. also any suggestions from you.. http://imagebin.org/293380
98 2014-02-14T20:14:09 <RogerHaase> ajitesh: I am looking at it - much better! I am wondering about the 2 rectangles with Global Index, one plain, one with select all,... options. I think an improvement would be to remove the plain rectangle.
99 2014-02-14T20:19:17 <ajitesh> RogerHaase, I reaslised that both the rectangles will not always show the same thing.. so i thought it'd be better to leave it there.. example - i did some work on the index page gui.. i pasted an image online.. wanted to know if its good enough.. http://imagebin.org/293401
100 2014-02-14T20:19:51 <ajitesh> sorry wrong thing got copied --
101 2014-02-14T20:20:07 <ajitesh> I reaslised that both the rectangles will not always show the same thing.. so i thought it'd be better to leave it there.. example - http://imagebin.org/293401
102 2014-02-14T20:41:12 <RogerHaase> ajitesh: now I am confused. I am looking at modernized theme, mouseover of index tab shows tooltip of Global Index, status bar shows url of /+index/. Mouse over of item index shows tooltip of List Subitems, status bar shows url of /+index/Home. But clicking either shows location line of "~/Global Index" -- that seems wrong
103 2014-02-14T20:45:11 <ajitesh> RogerHaase, I agree.. i guess thats an error.. all other item tabs show "~/<item>" in the location line..
104 2014-02-14T20:49:20 <RogerHaase> ajitesh: yes, looking at test.moinmo.in (which is running old code), clicking on Index tab has null location, just page trail, clicking on item Index shows location line of Home. - so it has been fixed, but needs to be fixed again.
105 2014-02-14T20:51:42 <RogerHaase> I will create an issue report
106 2014-02-14T20:57:40 <ajitesh> RogerHaase, ok.. shall i fix it ? :)
107 2014-02-14T21:03:17 <RogerHaase> ajitesh: sure, add your name to issue report...
108 2014-02-14T21:04:55 *** dave_largo
109 2014-02-14T21:19:30 *** ReimarBauer
110 2014-02-14T21:43:45 *** RogerHaase
111 2014-02-14T21:53:54 <ajitesh> ThomasWaldmann, code review needed : https://codereview.appspot.com/64160043/
112 2014-02-14T21:54:35 <ajitesh> w.r.t. https://bitbucket.org/thomaswaldmann/moin-2.0/issue/403/select-all-and-action-links-not-working-in
113 2014-02-14T22:21:09 *** RogerHaase
114 2014-02-14T22:47:38 *** RogerHaase
115