1 2015-06-23T00:03:18 *** vipul20
2 2015-06-23T02:04:18 *** yask
3 2015-06-23T04:53:35 *** skathpalia
4 2015-06-23T04:56:18 <skathpalia> moin
5 2015-06-23T05:52:10 <yask> moin :)
6 2015-06-23T07:51:43 *** yask
7 2015-06-23T07:52:04 *** yask
8 2015-06-23T07:58:30 *** vipul20
9 2015-06-23T07:58:30 *** vipul20
10 2015-06-23T08:01:26 *** skathpalia
11 2015-06-23T08:02:01 *** skathpalia
12 2015-06-23T08:03:13 *** greg_f
13 2015-06-23T08:07:46 *** skathpalia
14 2015-06-23T08:13:23 *** skathpalia
15 2015-06-23T08:41:16 *** skathpalia
16 2015-06-23T09:01:38 *** skathpalia
17 2015-06-23T09:03:30 *** skathpalia
18 2015-06-23T09:07:10 *** skathpalia
19 2015-06-23T10:29:47 <waldi> ThomasWaldmann: i'm not sure if i can make the meeting. they say: don't drive and irc, and i may be still on the road
20 2015-06-23T12:02:40 *** skathpalia
21 2015-06-23T12:11:45 *** yask
22 2015-06-23T12:25:56 *** yask
23 2015-06-23T12:31:30 *** skathpalia
24 2015-06-23T12:40:43 *** dave_largo
25 2015-06-23T14:03:59 *** dave_largo
26 2015-06-23T14:04:26 *** dave_largo
27 2015-06-23T14:41:34 *** skathpalia
28 2015-06-23T15:27:39 *** skathpalia
29 2015-06-23T15:32:07 *** skathpalia
30 2015-06-23T15:33:38 *** saurabhkathpalia
31 2015-06-23T15:42:18 *** saurabhkathpalia
32 2015-06-23T15:58:25 *** saurabhkathpalia
33 2015-06-23T16:03:13 <ThomasWaldmann> meeting time
34 2015-06-23T16:03:17 <ThomasWaldmann> who's here?
35 2015-06-23T16:03:28 <yask> Moin
36 2015-06-23T16:03:37 <saurabhkathpalia> moin
37 2015-06-23T16:03:50 <vipul20> moin
38 2015-06-23T16:04:41 <ThomasWaldmann> ajtesh and waldi, are you with us?
39 2015-06-23T16:05:57 <ThomasWaldmann> hmm, looks like not. yask, vipul20 you both did prepare your pastes?
40 2015-06-23T16:06:32 *** randomax
41 2015-06-23T16:06:44 <yask> Yep!
42 2015-06-23T16:06:49 <vipul20> yes
43 2015-06-23T16:07:00 <ThomasWaldmann> ok, yask, please begin, your stage!
44 2015-06-23T16:08:00 <yask> DONE:
45 2015-06-23T16:08:01 <yask> Made changes for the theme to use the xstatic version of bootstrap and made changes to `make.py` to compile modernized less theme by `$./m css`.
46 2015-06-23T16:08:01 <yask> Got the code reviewed by mentors: Worked on the suggestions mentioned.
47 2015-06-23T16:08:01 <yask> The code was reviewed by Ajitesh, Roger Hasse and Waldi.
48 2015-06-23T16:08:01 <yask> Almost Done:
49 2015-06-23T16:08:01 <yask> Footer , breadcrumbs, css rules for other pages such as index, tags and user.
50 2015-06-23T16:08:01 <yask> I’ll be making CR for this after the previous CR is completely done. (Hopefully Today)
51 2015-06-23T16:08:02 <yask> BLOCKERS:
52 2015-06-23T16:08:02 <yask> There is a doubt regarding something RogerHasse commented.
53 2015-06-23T16:08:03 <yask> NEXT:
54 2015-06-23T16:08:03 <yask> Redesigning the user setting page using Bootstrap forms.(For Modernised as well as Basic).
55 2015-06-23T16:08:04 <yask> Work in basic theme.
56 2015-06-23T16:08:04 <yask> Question:
57 2015-06-23T16:08:05 <yask> Roger Hasse commented yesterday in my CR for using Bootstrap’s classes like this:
58 2015-06-23T16:08:43 <yask> link https://codereview.appspot.com/242460043/#ps60001
59 2015-06-23T16:10:34 <ThomasWaldmann> so, you used the existing xstatic version and not the latest one?
60 2015-06-23T16:11:09 <yask> Yes! It worked fine.
61 2015-06-23T16:11:45 <yask> We can upgrade xstatic later I thought , after I finish up stuff till mid term evalutation
62 2015-06-23T16:12:11 <ThomasWaldmann> you need to update your blog, that is a psf requirement
63 2015-06-23T16:12:52 <yask> Yea , I do : http://iyask.me/blog/2015/06/17/gsoc-update/ :)
64 2015-06-23T16:12:54 <ThomasWaldmann> (for the past 6d)
65 2015-06-23T16:13:04 <yask> Okkey!
66 2015-06-23T16:14:18 <ThomasWaldmann> would be also ok for the meeting, to see a more verbose summary, so maybe yask and vipul20 could update the blog on monday or tue morning.
67 2015-06-23T16:15:09 <yask> About RogerHasse's comments regarding use of this : " <div class="container"> " ?
68 2015-06-23T16:16:36 <ThomasWaldmann> url?
69 2015-06-23T16:16:46 <ThomasWaldmann> a 1808
70 2015-06-23T16:17:05 <yask> https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global_history.html#newcode16
71 2015-06-23T16:18:06 <yask> But we are already using in basic theme Bootstrap’s pre-defined classes such as `container-fluid` `row` , `col-md-x1` , `navbar`, `nav-tabs`... etc ? "
72 2015-06-23T16:19:07 <ThomasWaldmann> the question is not whether we use bootstrap stuff in a bootstrap theme
73 2015-06-23T16:19:28 <ThomasWaldmann> but you used bootstrap stuff in content area and we do not have bootstrap in the non-bootstrap theme
74 2015-06-23T16:21:22 <yask> Hmm , but now both our theme work on top of bootstrap?
75 2015-06-23T16:22:13 <ThomasWaldmann> i don't think so
76 2015-06-23T16:22:24 <ThomasWaldmann> and you shouldn't make it so they do
77 2015-06-23T16:24:15 <ThomasWaldmann> do you have current before / after screenshots?
78 2015-06-23T16:24:55 <yask> So , I should make separate template for themes using bootstrap ?
79 2015-06-23T16:25:00 <yask> Yes
80 2015-06-23T16:25:42 <ThomasWaldmann> maybe make your blog post after the meeting and publish them there
81 2015-06-23T16:26:11 <ThomasWaldmann> and next time, please do that before the meeting (vipul: you too, please)
82 2015-06-23T16:27:00 <ThomasWaldmann> yask: roger is the most active person regarding theming right now, so maybe just follow his advise. he did much more work there recently than I did.
83 2015-06-23T16:27:33 <yask> Okkey!
84 2015-06-23T16:28:13 <ThomasWaldmann> and try to get stuff into a commitable state asap
85 2015-06-23T16:28:38 <ThomasWaldmann> it doesn't look good if it is midterm and there are none or only few commits.
86 2015-06-23T16:28:40 *** saurabhkathpalia
87 2015-06-23T16:29:18 <ThomasWaldmann> randomax: any feedback from you?
88 2015-06-23T16:29:38 *** skathpalia
89 2015-06-23T16:29:54 <ThomasWaldmann> skathpalia: any feedback from you?
90 2015-06-23T16:30:41 <skathpalia> No :)
91 2015-06-23T16:31:17 <ThomasWaldmann> yask: if you redesign user settings, either without bootstrap or only for basic/bootstrap theme, modernized has no bootstrap.
92 2015-06-23T16:32:31 <ThomasWaldmann> and if you can finally commit that stuff, please have a good commit comment
93 2015-06-23T16:32:46 <yask> Well, I am porting modernized theme to work on top of bootstrap. It will have bootstrap.
94 2015-06-23T16:33:35 *** skathpalia
95 2015-06-23T16:33:43 <yask> It used stylus , now it uses less
96 2015-06-23T16:33:53 *** skathpalia
97 2015-06-23T16:34:32 <ThomasWaldmann> ah, ok, then communicate that to roger.
98 2015-06-23T16:35:02 <ThomasWaldmann> and maybe before midterm, try to have something finished, rather than a ton of half.finished.
99 2015-06-23T16:35:52 <ThomasWaldmann> ok, guess we are through if noone else has questions. thanks yask, vipul20 it's your stage.
100 2015-06-23T16:36:51 <vipul20> DONE:
101 2015-06-23T16:36:51 <vipul20> Worked on some previous pending work: https://codereview.appspot.com/246020043/ (file upload) , https://codereview.appspot.com/242340043/
102 2015-06-23T16:36:51 <vipul20> Worked on UI: https://codereview.appspot.com/247160044/
103 2015-06-23T16:36:51 <vipul20> Screenshots:
104 2015-06-23T16:36:51 <vipul20> http://i.imgur.com/l8jJvlQ.png , http://i.imgur.com/jyKlC3K.png , http://i.imgur.com/poVia4D.png , http://i.imgur.com/x8ej8GE.png
105 2015-06-23T16:36:51 <vipul20> before/after screenshots here in the blog: http://vipulsharma20.blogspot.in/
106 2015-06-23T16:36:51 <vipul20> New field (blocks) added: https://codereview.appspot.com/248280043/ is it needed ?
107 2015-06-23T16:36:52 <vipul20> TODO:
108 2015-06-23T16:36:52 <vipul20> Make patch ready for the evaluation asap
109 2015-06-23T16:38:14 <skathpalia> vipul20, One thing regarding the UI if already ticket suggestions
110 2015-06-23T16:38:24 * ThomasWaldmann looked at the blogpost
111 2015-06-23T16:38:36 <skathpalia> The UI of that needs to be changes
112 2015-06-23T16:38:40 <skathpalia> *changed
113 2015-06-23T16:39:02 <skathpalia> You can do that in your next commit
114 2015-06-23T16:39:38 <vipul20> if there are suggestions available then there will be one scrollable div and everything else will move down a bit
115 2015-06-23T16:39:55 <vipul20> same happened before this new UI
116 2015-06-23T16:40:03 <skathpalia> Yeah that thing I saw
117 2015-06-23T16:40:40 <skathpalia> I thing that the list can be brought somewhat up so that it looks something like dropdown menu
118 2015-06-23T16:41:05 <ThomasWaldmann> btw, in codereview i've seen that still names are in use, even at places where a itemid already exists and could be used for reference.
119 2015-06-23T16:41:30 <ThomasWaldmann> all that will break if someone renames an item
120 2015-06-23T16:42:11 <skathpalia> Also when there are no suggestions then the the scrollable div should go up again, as of now it remains down only even if no suggestion is there
121 2015-06-23T16:42:55 <vipul20> the thing is a ticket has only the name in create view so the file will not be able to refer_to to any itemid initially
122 2015-06-23T16:42:58 <skathpalia> Also moving of div can be done slowly by specifying some time in transition in css
123 2015-06-23T16:43:38 <skathpalia> vipul20, These ^ are the few changes that can be done
124 2015-06-23T16:43:42 <skathpalia> in UI
125 2015-06-23T16:43:57 <skathpalia> You can do this in a separate codereview
126 2015-06-23T16:45:12 <vipul20> does the div still appears even when there is no suggestion ? because in mine it does not show any div in that case
127 2015-06-23T16:45:12 <vipul20> skathpalia^
128 2015-06-23T16:45:50 <vipul20> it disappears once there are no suggestions
129 2015-06-23T16:47:39 <ThomasWaldmann> btw, midterm evals begin in 3 days and end no later than 3rd july (maybe psf has slightly more restrictive timing for suborgs)
130 2015-06-23T16:47:52 <skathpalia> first try entering something which has some suggestion then the the div of other elements will move down
131 2015-06-23T16:48:17 <vipul20> yes done that
132 2015-06-23T16:48:33 <skathpalia> Then just delete all the text in summary textfield and then try entering something which has no suggesions
133 2015-06-23T16:49:12 <skathpalia> still the the fields such that difficulty etc will be shifted downwards
134 2015-06-23T16:49:34 <skathpalia> I mean it is still shifted downwards, it doesn't come up
135 2015-06-23T16:49:55 <ThomasWaldmann> yask: show your project plans to roger, as he is not a mentor, he likely didn't see them. this is the stuff that should have happened in community phase btw.
136 2015-06-23T16:50:41 <randomax> regarding yask i'd like to suggest that he work on separate branch
137 2015-06-23T16:51:06 <randomax> till a time where his new theme is fully adaptable and mostly free of errors
138 2015-06-23T16:51:27 <randomax> it'll be easier that way for him to get stuff committed
139 2015-06-23T16:51:55 <vipul20> skathpalia: wrote "ticket" and got these suggestions: first: http://i.imgur.com/dCEeCoH.png deleted and then wrote "absurd" and got this http://i.imgur.com/Um3lGjT.png
140 2015-06-23T16:53:00 <ThomasWaldmann> that field under "provide metadata" is missing a label
141 2015-06-23T16:53:23 <ThomasWaldmann> or how are users supposed to know what to type into there?
142 2015-06-23T16:54:07 <vipul20> yes that I'll do it in the new UI, I've noted it down to correct
143 2015-06-23T16:54:10 <skathpalia> Oh just checked it
144 2015-06-23T16:54:23 <skathpalia> May be I got it wrong
145 2015-06-23T16:55:10 <vipul20> ThomasWaldmann: regarding refer_to itemid thing the ticket initially, during create view doesn't have any itemid just the name
146 2015-06-23T16:55:40 <ThomasWaldmann> yes, you wrote that already
147 2015-06-23T16:56:07 <vipul20> oh, sorry I thought you missed that
148 2015-06-23T16:56:16 <ThomasWaldmann> that doesn't make me happy though. you are saving stuff that is prone to break.
149 2015-06-23T16:56:39 <ThomasWaldmann> and IIRC you did not even add a TODO to the code for that.
150 2015-06-23T16:58:20 <vipul20> is there any other workaround ? its right if it is renamed then it will be lost
151 2015-06-23T16:58:48 <vipul20> but the ticket will get an id
152 2015-06-23T16:59:21 <ThomasWaldmann> iirc the workaround was to save an item and then delete name from it. not sure where it is used.
153 2015-06-23T16:59:49 <ThomasWaldmann> guess somebody should really fix create_item so it can work not just with a name.
154 2015-06-23T17:00:17 <ThomasWaldmann> but maybe that's nothing to try 3d before midterm.
155 2015-06-23T17:00:26 <ThomasWaldmann> pity that cb phase was mostly wasted.
156 2015-06-23T17:04:04 <vipul20> I need to make some commits asap. Obviosuly, it doesn't look good with no or less commits in the evals :(
157 2015-06-23T17:04:33 <ThomasWaldmann> yeah
158 2015-06-23T17:04:53 <ThomasWaldmann> but try to finish the stuff before committing :D
159 2015-06-23T17:05:33 <ThomasWaldmann> no more questions by me, how about you skathpalia ?
160 2015-06-23T17:06:12 <ThomasWaldmann> yask: vipul20: and please start from an up-to-date repo before committing stuff
161 2015-06-23T17:06:17 <vipul20> I am still struggling with the file upload thing.. as per the current CR
162 2015-06-23T17:06:32 <skathpalia> no
163 2015-06-23T17:06:43 <yask> Okkey
164 2015-06-23T17:08:09 <ThomasWaldmann> vipul20: if you can't get the itemid issue resolved, you need to at least document that the code there has to be improved later.
165 2015-06-23T17:08:31 <ThomasWaldmann> it's not nice to commit stuff where breakage is known but undocumented in the code.
166 2015-06-23T17:08:54 <ThomasWaldmann> (and be rather specific about what the issue is)
167 2015-06-23T17:09:24 <ThomasWaldmann> ok, we are out of time for today.
168 2015-06-23T17:09:28 <vipul20> ok, sure I'll do that. Also, any feedbacks on the UI as per the screenshots pasted ?
169 2015-06-23T17:09:44 <ThomasWaldmann> if there are more questions, just grab your mentors...
170 2015-06-23T17:10:29 <ThomasWaldmann> for UI comments, I have to use it, which is a bit hard as long as it lives on CR only
171 2015-06-23T17:10:39 <waldi> moin. it took longer
172 2015-06-23T17:11:05 <ThomasWaldmann> waldi: we are just wrapping up
173 2015-06-23T17:11:53 <ThomasWaldmann> vipul20: btw, do you mean screenshots in blog, or the single ones you linked?
174 2015-06-23T17:12:20 <vipul20> ThomasWaldmann: both are same
175 2015-06-23T17:12:32 <ThomasWaldmann> http://i.imgur.com/l8jJvlQ.png summary box hangs over right border
176 2015-06-23T17:12:40 <vipul20> the blog also contains previous UI's screenshots
177 2015-06-23T17:14:04 <ThomasWaldmann> http://i.imgur.com/poVia4D.png "describe the ticket" and "message" are a bit strange.
178 2015-06-23T17:14:42 <ThomasWaldmann> http://i.imgur.com/x8ej8GE.png also that "edit metadata"
179 2015-06-23T17:14:55 <vipul20> it is same as previous UI. I've not changed the content just the layout.
180 2015-06-23T17:15:14 <ThomasWaldmann> ok, so next time, if both are same, only link to the better location
181 2015-06-23T17:15:23 <ThomasWaldmann> every link you post causes work...
182 2015-06-23T17:16:47 <ThomasWaldmann> ok, I need to run. meeting over for me. :D
183 2015-06-23T17:19:08 *** skathpalia
184 2015-06-23T17:33:08 *** greg_f
185 2015-06-23T18:15:41 *** randomax
186 2015-06-23T19:13:42 *** RogerHaase
187 2015-06-23T21:21:20 *** dave_largo
188 2015-06-23T21:54:20 *** RogerHaase
189
