Description
@SIG@ does not create a link to the users homepage if the user name is a not a WikiName.
Details
MoinMoin Version |
1.3.3 |
Workaround
Apply this patch to PageEditor.py. Then you will get links for @SIG@ and also for @User@ but not for @USERNAME@ which I did not change.
{{{*** PageEditor.py.fixed Tue Mar 1 17:35:18 2005
--- PageEditor.py.orig Wed Feb 9 22:11:43 2005 *************** *** 624,631 ****
'TIME': lambda t=now: "DateTime(%s)" % t, 'DATE': lambda t=now: "Date(%s)" % t, 'USERNAME': lambda s=self: s._user_variable(),
! 'USER': lambda s=self: '-- ["%s"]' % (s._user_variable(),), ! 'SIG': lambda s=self, t=now: '-- ["%s"] DateTime(%s)'
- % (s._user_variable(), t,),
- }
--- 624,631
'TIME': lambda t=now: "DateTime(%s)" % t, 'DATE': lambda t=now: "Date(%s)" % t, 'USERNAME': lambda s=self: s._user_variable(),
! 'USER': lambda s=self: "-- %s" % (s._user_variable(),), ! 'SIG': lambda s=self, t=now: "-- %s DateTime(%s)"
- % (s._user_variable(), t,),
- }
}}}
Discussion
Since free-form links (["Link"]) seem to be standard now MoinMoin should probably be patched as suggested. -- DavidLinke 2005-03-01 17:31:28
- ...
Patch make sense, any link can be written as free link. Since in 1.3 one can run a wiki without free links - we need to add a check for the variable, and use the patched version only if its ok for that wiki.
When the config variable is gone, remove the check.
Fixed by using extended link for users with non WikiName, for USERNAME, USER and SIG. Keeping CamelCase names as is for better readability.
Plan
- Priority:
- Assigned to:
- Status: fixed in patch-732