Description

Minor usability issue:

Calling the action "RevertToThisRevision" from the more actions menu causes on the current revision a type error "int argument required"

Steps to reproduce

1. Don't view an older revision of a page

2. Simply call action RevertToThisRevision on a page. I did that because I had no idea about the purpose of this action first. So what will most users probably do? Try it out and see what happens!!

3. Call the action and you will get a type error..

Example

Component selection

• actionsMenu in theme/_init_.py

Details

Workaround

Discussion

Unless the other actions for the action "RevertToThisRevision" the rev argument is needed if the current, newest revision is displayed (I think..) or calling of this action has to be disabled. No patch for that since I don't know any easy solution... However for robustness of usage I think some solution is needed that does not trigger a type error but rather some message box "Cannot revert to current revision" or "Revision displayed is alredy the current revision" (current message "You did not change the page content, not saved!" is not very clear in my eyes)... -- OliverSiemoneit 2007-03-08 18:42:01

• Probably we should move that action from the action menu to the editbar and show it only if a previous version is selected. -- ReimarBauer 2007-03-08 21:45:14

Plan

• Priority:

• Assigned to: ThomasWaldmann

• Status: fixed in 1.6 branch

CategoryMoinMoinBugFixed