Description

In a wiki farm the links to the help pages in the page editor (editor=text) can lead to another wiki from the same farm.

Steps to reproduce

1. Have a wiki farm running with a a single running process for the requests (for example with WSGIDaemonProcess moin-wsgi ... processes=1 threads=1).
2. Restart the web server.

3. Access one wiki (http://test/wiki1)

4. Edit any page on this wiki: http://test/wiki1/?action=edit&editor=text

5. Review the urls of the help links (http://test/wiki1/HilfeZumEditieren in german language, ...)

   • correct url

6. Access another wiki (http://test/wiki2)

7. Edit any page on this wiki: http://test/wiki2/?action=edit&editor=text

8. Review the urls of the help links (http://test/wiki1/HilfeZumEditieren in german language, ...)

   • misleading url

9. Restart the web server.

10. Access the other wiki (http://test/wiki2)

11. Edit any page on this wiki: http://test/wiki2/?action=edit&editor=text

12. Review the urls of the help links (http://test/wiki2/HilfeZumEditieren in german language, ...)

    • correct url

13. Access another wiki (http://test/wiki1)

14. Edit any page on this wiki: http://test/wiki1/?action=edit&editor=text

15. Review the urls of the help links (http://test/wiki2/HilfeZumEditieren in german language, ...)

    • misleading url

When another process starts serving it will always use the url base of the first wiki accessed for the links.

The above always leads to the situation that the base url of the first wiki accessed will be used for all further requests within a process.

Example

Component selection

• I think the quickhelp is showed by line 489 in sendEditor() in MoinMoin/EditPage.py:

  request.write(_(quickhelp, wiki=True))

• But I have no clue where this call is processed further on.
• I grepped through the source and this seems to be the only use of request.write(..., wiki=True).

Details

To spot the problem more easily I reduced the number of processes / threads to 1 with WSGIDaemonProcess moin-wsgi ... processes=1 threads=1.

The problem is there with or without shared underlay.

Workaround

Discussion

• Tested: Fixed by http://hg.moinmo.in/moin/1.9/rev/af9872c96dcb .

Plan

• Priority:
• Assigned to:

• Status: fixed by http://hg.moinmo.in/moin/1.9/rev/af9872c96dcb (please test it)

CategoryMoinMoinBugFixed