Description
In the formatter groups.py, many formatting functions are modified so that no output is produced. However, some common formatting functions, such as macro, are omitted from the list of functions. This results in extraneous output whenever group pages are evaluated.
Steps to reproduce
Make a group page SomeGroup
Add to the group page some macro producing output, such as <<FullSearch( )>>
Use some cli script that accesses the said Group, with eg. request.groups.get("SomeGroup")
- Observe that the error 'Please use a more selective search term instead of " "' is printed on your screen.
The error does reproduce using a browser, which results in broken html.
Example
the page SomeGroup
* [[exampleuser]] ---- <<FullSearch( )>>
Component selection
MoinMoin.formatter.groups
Details
MoinMoin Version |
1.9.4 |
OS and Version |
Ubuntu 10.04 |
Python Version |
2.6.6 |
Server Setup |
wsgi |
Server Details |
|
Language you are using the wiki in (set in the browser/UserPreferences) |
en |
Workaround
Patch proposal:
Discussion
Thanks for the patch. I applied it as generating output is not needed for this formatter. I also applied it to the pagelinks formatter.
But the fundamental problem had to be solved also: even if such a formatter generated some output, it should of course not get output (and sent to console or browser), but it needs to get redirected and ignored.
Plan
- Priority:
- Assigned to:
Status: fixed by http://hg.moinmo.in/moin/1.9/rev/a9e7ad80340e and http://hg.moinmo.in/moin/1.9/rev/b8d55e162af5