Description

MoinMoin emits some messages in a rather ugly way (see details section).

Your task is to create some theme method to emit such messages in a clean way, refactor the code to use the new method, check if that stuff can be also used for the send_page msg= keyword (for this, sometimes multiple messages need to be "collected" and later emitted in a clean way).

This task needs about 12 h to finish and has to be completed within 10 days.

Steps to reproduce

1. do this...

Example

Component selection

• general

Details

From an accessibility's point of view this is a bug, from an other point of view this is maybe only a usability issue: There are several "messages" which are injected by PageEditor.py directly at the beginning of a page like

• [Content of new page loaded from %s]
• [Template %s not found]
• [You may not read %s]
• [Content loaded from draft]

What is problematic about that?

1.)The injection of these hints into the page is totally out of control of the theme code and could ruin the layout:

2.) Not only does it spoil your page layout, moreover the messages aren't styleable by the theme since there are no css classes or ids specified in these messages. This could be important since these hints can easily be overlooked, have a look here:

If you work quick and don't know Moin well, you will normally overrun this errormessage. So it would be better maybe to style them differently, with red color, draw a box arround them...

3.) From accessibility's point of view it is problematic either. Have a look at this screenshot where you can see the Simplemente theme with css disabled - thus showing the real page structure as it appears to a blind person.

The "message" is injected in the code where it is not recognizable for people using the skip link navigation. Skip link navigation should always be the first code on the page which assures furher redirection. Second problem: There is also no way to move this message to another place and mark it with a hidden h1 heading so that people easily can recoginze this extra message.

Therefore: It would be better to have the PageEditor.py hints integrated in the normal message output. Or: make these hints stylable and(!) positionalbe for the theme code.

Workaround

Discussion

Plan

• Priority:

• Assigned to: FedericoLorenzi

• Status: Fixed in 1.7, see http://hg.moinmo.in/moin/1.7/rev/49b9e807a51d http://hg.moinmo.in/moin/1.7/rev/4d60ea3a4ca7 http://hg.moinmo.in/moin/1.7/rev/ba14d391c2ba http://hg.moinmo.in/moin/1.7/rev/a310264ad186

CategoryMoinMoinBugFixed