Description
Aliasing does not work for attachments
[attachment:moin.png click]
click on the link for this image does not work. The image is already there. If this is no bug then how could we set an alias for an image?
Steps to reproduce
see Description
Example
Details
This Wiki
Workaround
Discussion
In older moinmoin Version this was already working 1.1 - 1.2.4. Probably it wasn't not well documented. The function I like to have is seeing the text and by clicking on it loading the image in the window. If you use this syntax with a pdf file it works the same as in older moin versions.
For more informations click here
For more informations click [attachment:moin.pdf here]
You see it already works with pdf documents and we have a lot time used this functionality. At the moment some of our wikis pages don't look very well. I don't know if it's a feature or a bug. I know we like this feature very much! -- ReimarBauer 2004-12-22 16:56:13
First we should check what change in the parser between 1.2 and 1.3. Maybe its just a small fix to make this work again. -- NirSoffer 2004-12-23 02:09:12
See: /DiffsFrom12To13
Patch
Probably there is a better way to solve this problem. This is my patch of wiki.py. -- ReimarBauer 2004-12-31 10:30:25
This patch is now able to handle
{{{attachment:img2.png [attachment:img.png label] [#label attachment:img.png]}}} -- ReimarBauer 2005-01-01 12:24:03
Reimar, thanks for your patch. After patching it in and refactoring it, AlexanderSchremmer and me decided that it is maybe better to search how it broke after 1.2. We found that it was broken by me in 1.3--patch-59 and that there was simply a "not" missing in there. So we decided for that minimal fix. I attach the state of your patch after my work on it, just in case we need it later: attachlink_rbtw.diff There is also a strange place in that patch, see the comment in there. -- ThomasWaldmann 2005-01-16 18:35:26
Plan
- Priority: medium
Assigned to: ThomasWaldmann
- Status: the markup regression from 1.2 to 1.3 is fixed (please test here!). Additional stuff from RB's patch is not included yet.
The fix will be in MoinMoin 1.3.2