Description

<<AttachList>>

  • [get | view] (2010-02-25 12:59:45, 0.2 KB) [[attachment:example.zip]]
 All files | Selected Files: delete move to page copy to page

shows the unzip link always and is ignoring the readonly parameter of _build_filelist

Component selection

Details

MoinMoin Version

1.8 / 1.9

OS and Version

Python Version

Server Setup

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

Workaround

Discussion

I think we should remove the unzip link 

   1 diff -r 327e180af6d9 MoinMoin/action/AttachFile.py
   2 --- a/MoinMoin/action/AttachFile.py     Mon Feb 22 10:22:19 2010 +0100
   3 +++ b/MoinMoin/action/AttachFile.py     Thu Feb 25 13:52:23 2010 +0100
   4 @@ -338,7 +338,7 @@
   5  
   6              try:
   7                  is_zipfile = zipfile.is_zipfile(fullpath)
   8 -                if is_zipfile:
   9 +                if is_zipfile and not readonly:
  10                      is_package = packages.ZipPackage(request, fullpath).isPackage()
  11                      if is_package and request.user.isSuperUser():
  12                          links.append(fmt.url(1, getAttachUrl(pagename, file, request, do='install')) +

Plan

CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/AttachListShowsAlwaysUnzip (last edited 2010-02-25 13:10:45 by ReimarBauer)