Description

moinmoin 1.6.1 quotes the ampersand in interwiki links with a %26 encoding. This seems to be broken as browsers are transmitting it literally and e.g. CGI scripts do not recognize it as a delimiter of parameters. Special entities have to be written like '&' or '&'.

E.g. I want to use it like

[[Acronym:foo&string=substring|XXX]]

moinmoin 1.5.8 generated the wanted

http://www.acronymfinder.com/af-query.asp?String=exact&Acronym=foo&string=substring

while 1.6.1 generates

http://www.acronymfinder.com/af-query.asp?String=exact&Acronym=foo%26string%3Dsubstring

which is not understood by firefox 2.0.0.12.

Please note, that the first '&' (from interwiki.txt definition) is encoded as &, while the '&' from the wiki page is written as %26. Ditto for '='.

Code is ok, when link is written link manually.

Component selection

• general
• interwiki

Details

Workaround

Discussion

This is intentional, the above should be written as [[Acronym:foo|acronym finder: foo|&string=substring]], acronym finder: foo.

• That shows another bug. Is there maybe a conversion bug? -- JohannesBerg 2008-03-22 14:44:14

  • Yes, this wrong "?" is a bug.

• mmh... I have hundreds of 1.5.8 pages using the old syntax and update to 1.6.1 broke them all

  Is there some documentation about the '|&...' stuff; your example above generates broken code (

  http://www.acronymfinder.com/af-query.asp?String=exact&Acronym=foo?string=substring

  -> two '?' instead of a '&')

  • Have a look at CHANGES. I see it is bad for your content if you have used this style much, but the 1.6 style is cleanly separating page name and url arguments, while 1.5 only worked for some cases. Try to link to WikiPedia:Smith & Wesson with moin 1.5.x...

Plan

• Priority:
• Assigned to:

• Status: the "bug" this bug report originally is about is no bug and intended behaviour (you can see 1.5 behaviour as broken if you like), fixed the incorrect query args separator by http://hg.moinmo.in/moin/1.6/rev/490f961b3552 and http://hg.moinmo.in/moin/1.7/rev/cb22f4c4a0fd

CategoryMoinMoinBugFixed