Description

Nathan Reynolds reported this on IRC, I haven't tried it, sorry. Apparently it is not possible to revert to an underlay revision of a page. He created a brand new wiki, and edited the FrontPage. When he wanted to revert to the first revision of FrontPage, this wouldn't work because the first revision isn't even displayed in "Get Info" (because it lives in underlay).

Steps to reproduce

1. edit an underlayed page so it moves to data
2. try reverting that change

Details

Should work on this wiki if it uses underlay, Nathan was using Apache/with mod_py

Workaround

Reverting to underlay can be done by simply deleting the page (select Delete Page from the More Actions menu). The underlay page will be revealed. You can recreate the page again to hide the underlay page again.

Discussion

The question is -- how can one fix this? The edit would have to note which revision of the page in underlay it was modified from, as underlay can change below.

This is not really a bug, maybe move this into the FAQ. -- NirSoffer 2005-02-22 01:32:26

This is a bug. You cannot expect users to not revert link-spam on their wiki if the link-spam-bot edited a page that was still in underlay. Also, the only way to recover the page is to manually copy it from MoinMaster or from the underlay directory. -- JohannesBerg 2005-02-22 11:41:27

• Underlay pages are protected with acl, link-spam bots can not edit those pages, unless you add the bot user to MoinPagesEditorsGroup, so the point about link-spam is not relevant.

• About recovering, read Workaround section...

-- NirSoffer 2005-02-22 11:45:52

• Your workaround is invalid: it reveals the current underlay page revision rather than the one the page was derived from. Also, it loses information about the history of the page afaict. -- JohannesBerg 2005-03-02 18:14:28

  • This is exactly what delete page is suppose to do, reveal the updated underlay page. Underlay is read only and auto updating, no history is kept. Your copy is saved with all history expect the first version from which it was made from. This is a another (small) bug. To solve this original version rare problem, we should simply copy it as revision 1 to the new page directory, e.g copy the page directory as is from underlay to data, then create the new revision as revision 2. This will allow to revert to "underlay" without deleting the page.
    • Yes, that's exactly what is needed and would fully solve this bug. I don't think it is another bug. You proposed using 'delete page' as a workaround and all I did was point out that it isn't the correct thing to do. So I think all that needs to be done is copy the original underlay page into pages as the first revision.

Practically, delete page is just what you want most of the time, even if its not the "correct" things to do. This fix should be easy - but it might create problems with other code that does not expect to find revision number 1, or can create problems with upgrading existing wikis. For example, what are you going to do with existing wikis that does not have the underlay page as revision 1?

Unless users demand a fix, we better not touch it in 1.3. -- NirSoffer 2005-03-04 22:25:19

• I'll fill a bug against "delete page" action. When a page exists both in data/ and underlay/, the page in data/ is shown. (Yes. It is a feature!) But if the page is deleted by "delete page", the page in underlay/ is shown. (another feature!) But we cannot revert to the page before deletion.

  A Suggestion: in Info page, we can show both in data/ and underlay/. If the current page is shown in data/, we show it first. Otherewise, the data in underlay/ is shown first. -- CDPark 2005-04-07 02:41:33

Plan

• Priority: low
• Assigned to:
• Status:

CategoryMoinMoinBugConfirmed