Description

The footer is missed in GUI editor page. This bug shows no differences in modern theme, but may cause a different view with a theme which has a footer.

Steps to reproduce

1. Change the theme to one which has a footer give at least ONE example where the problem shows (best would be a theme installed here)

2. Edit a page with GUI mode.

Example

Text mode:

GUI mode:

Details

Workaround

Insert the following line at the end of sendEditor function in PageGraphicalEditor.py.

   1 wikiutil.send_footer(self.request, self.page_name) 

• The general idea might be right (I will look at it), but just "inserting" this with no other change is definitely not the right way.

Discussion

One of the goals of the new editor screens was to reduce space not used by the editor (thus, maximizing available screen space for the editing task). So what do you use the footer for that misses without that change? -- ThomasWaldmann 2006-01-19 10:26:13

• Unfortunately I couldn't find any theme using an overriden footer() here. BTW, I'm using sinorca4moin theme in my home and it overrides the footer function. This causes a different view b/w text mode and gui mode because the GUI editor ends without sending a footer. I'm with where current page editor goes to but some visitors to my home have reported that they were confused at editing because its view suddenly changes. Thus I've tried to conserve the header and footer even with editing. -- SeungikLee 2006-01-19 11:00:48

We now generate the gui editor footer the same way as the text editor footer. There is more need for cleanup, though.

Plan

• Priority: medium

• Assigned to: ThomasWaldmann

• Status: fixed in moin--main--1.5--patch-392

CategoryMoinMoinBugFixed