Description

Logging in with openid and associating with an existing account is broken.

Steps to reproduce

  1. log in with openid
  2. select an existing username
  3. should ask for password, but does nothing at all

Example

Component selection

Details

MoinMoin Version

1.9 dev as of today

OS and Version

Python Version

Server Setup

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

Workaround

n/a

Discussion

diff --git a/MoinMoin/action/login.py b/MoinMoin/action/login.py
index 826ef09..a158293 100644
--- a/MoinMoin/action/login.py
+++ b/MoinMoin/action/login.py
@@ -34,7 +34,8 @@ class LoginHandler:
         _ = self._
         request = self.request
         form = html.FORM(method='POST', name='logincontinue', action=self.pagename)
-        form.append(html.INPUT(type='hidden', name='login', value='login'))
+        form.append(html.INPUT(type='hidden', name='action', value='login'))
+        form.append(html.INPUT(type='hidden', name='login', value='1'))
         form.append(html.INPUT(type='hidden', name='stage',
                                value=request._login_multistage_name))

Plan


CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/OpenIDExistingBroken (last edited 2009-12-16 08:59:42 by ThomasWaldmann)