Description

Filtering PDF and MS Office attachments does not work on MS Windows.

Steps to reproduce

  1. Download and install antiword and xpdf for Windows.
    • /!\ Don't forget to define the ANTIWORDHOME environment variable correctly.

  2. Make sure that antiword.exe and pdftotext.exe can be found on the PATH.
  3. Create a page with a MS Word attachment.
  4. Rebuild the Xapian index as described on HelpOnXapian

  5. Start MoinMoin

  6. Try a full-text search. The MS Word attachment will not be found.

With debug mode you can see that the filter fails with a "No such file or directory" error.

Example

-

Component selection

Details

MoinMoin Version

1.7.1

OS and Version

MS Windows XP Professional

Python Version

2.4.3

Server Setup

standalone

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

Workaround

Discussion

A platform-independent patch should be created.


I did not yet test it, but from looking at the code I think that http://hg.moinmo.in/moin/1.7/rev/4e904da48c4c is a good solution.

Note however, that this might affect other filter plugins, because execfilter will now always add quotes around the filename, even if the command string already contains quotes. Thus, it should be stated in the release notes or change log that user-provided filters should not use filename quoting anymore, because this is done now automatically inside execfilter. -- HenningVonBargen 2008-08-14 15:24:07

Plan


CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/XapianFilterPluginsBrokenOnWindows (last edited 2008-08-15 11:02:52 by ThomasWaldmann)