Description

if getEditorData() returns an IP address as editor and kind is ip, getEditor() will remove the rest of the address after the first octet, showing by instance '192' for the IP address given in Example.

Steps to reproduce

EditLogLine.hostname is an IP address.

Example

hostname is 192.168.23.15

Details

Workaround

be sure that hostname is a fqdn.

Discussion

I'm not sure this is a bug but it definetely looks wrong to have 192 instead of 192.168.23.15.

This stuff was done primarily to shorten the sometimes very long fqdn hostnames. Shortening IPs wasn't a primary goal, but more a side effect, that has shown to be useful, too.

The reason was to avoid too broad column on RecentChanges, to have more space for the more interesting data.

But you can see the full IP (and the fqdn) by moving the mouse over the display.

I understand for fqdn, but for IP's.. It really don't make any sense.. Maybe is just me

Its not only you, the truncated IP's are useless and don't make sense. Getting the full IP address from the title is very annoying, because there is no way to copy and paste from tooltips. This is another problem caused by the table design of recent changes macro. We need a new design that shows full readable information about the editor, either name or full IP address.

For IPs we could display full stuff, it can't get really wide. But I think the usefulness is rather questionable, as one usually is not interested in the concrete IP, but only needs a hint of editor being identical to other edits shown in RC. I would definitely veto full display of fqdns, as they can get really long and no matter what RC design we use, this would simply be lots of usually unnecessary information one has to skip when reading RC. For the rare cases you need to copy the IP address (like when tracking against-the-law edits), I think you can live with even writing them down on a piece of paper. -- ThomasWaldmann 2005-03-08 09:31:53

• Except that isn't true either, my IP currently is 2001:470:1f00:624:20e:a6ff:fe51:858c. Now, the moinmoin wiki isn't IPv6 enabled yet, but mine is. Dunno how IPv6 addresses are currently handled though, I'd say they're displayed in full because they don't contain dots. -- JohannesBerg 2005-03-08 10:14:29

Oh. Yuck. ... Looks like we have to extend that splitting to v6. -- ThomasWaldmann 2005-03-08 10:16:42

• You don't want to just display the "2001" though because almost all IPv6 (production) addresses start with that (or 2002). Above IPv6 address contains a lot of information: 2001:471:1f00:624/64 is my site prefix, and the rest is calculated by the ethernet MAC address. Maybe using the last and the 4th component would give a fairly close approximation of uniqueness, but that's almost useless to display. -- JohannesBerg 2005-03-08 10:36:46

Address like line187-52.blablabla.internetserviceprovider.bla.bl are long and not very useful, but IP V4 numbers are. We should show full IP V4 address, until we must move to IP V6, when we will have to find a solution to the long addresses. Writing on a piece of paper suck.

The display stuff in editlog code should be removed. editlog should return exactly whats in the log, modifying the data for display must be done in the display code, in RecentChanges. -- NirSoffer 2005-03-08 18:45:42

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinNoBug