MoinMoin: MoinMoinChat/Logs/moin-dev/2005-11-23

2005-11-23T00:55:59  *** cwillu has joined #moin-dev
2005-11-23T00:56:28  <cwillu> but I'm not sure I want my incompetent ramblings on record!
2005-11-23T00:56:50  <starshine> :D
2005-11-23T00:57:01  <starshine> you're repairing IIS' misbehaviors
2005-11-23T00:57:24  <starshine> it doesn't matter if your ramblings are incompetent, so long as IIS and moin shake hands and make friends
2005-11-23T00:57:37  <cwillu> lol
2005-11-23T00:57:52  <starshine> how many of these trickybits have you fixed today?
2005-11-23T00:57:55  <cwillu> you know off hand, is there a particular way the filename is supposed to be (or commonly) sent?
2005-11-23T00:58:28  <starshine> well, I could surf it with lynx, having trace on, and then look at the tracelog for the http traffic.
2005-11-23T00:58:47  * starshine is at work right now
2005-11-23T01:03:54  <cwillu> lol
2005-11-23T01:04:15  <cwillu> I see mozilla passing the same headers
2005-11-23T01:04:17  <starshine> there's a windows version of lynx around if you look really hard..
2005-11-23T01:04:23  <starshine> yeah that should do nicely
2005-11-23T01:04:30  <cwillu> unless it's iis doing something behind the scenes before isapi gets its dirty hands on it
2005-11-23T01:04:45  <starshine> isn't that the point of isapi ..?
2005-11-23T01:05:23  <cwillu> I'm looking at what the isapi plugin gets sent
2005-11-23T01:05:48  <cwillu> hmm
2005-11-23T01:08:34  <cwillu> hmm, I'm seeing refs with spaces after the ;
2005-11-23T01:08:42  <cwillu> so that's probably unrelated
2005-11-23T01:09:05  <cwillu> granted this is in the context of ie5.5 :(
2005-11-23T01:13:27  <starshine> um is the server you are messing with outside-world visible?
2005-11-23T01:13:48  <cwillu> nope;
2005-11-23T01:14:04  <cwillu> technically, I'm not here either :p
2005-11-23T01:14:19  <cwillu> yay for third party wireless access points :)
2005-11-23T01:14:47  <cwillu> once in isapi, I've got almost identical headers from mozilla and ie,
2005-11-23T01:15:01  <cwillu> ie includes the full path to the file, mozilla just the file name (I'm not tripping on that yet anyway)
2005-11-23T01:15:05  <starshine> .o( almost? ut oh
2005-11-23T01:15:14  <cwillu> this is expected :p
2005-11-23T01:15:29  <starshine> oh ok.
2005-11-23T01:15:32  <cwillu> they're both tripping/not parsing the content-type
2005-11-23T01:16:57  <starshine> http://home.pacific.net.sg/~kennethkwok/lynx/
2005-11-23T01:37:04  <cwillu> ooo
2005-11-23T01:37:08  <cwillu> new error message!
2005-11-23T01:37:36  <cwillu> missing argv!
2005-11-23T01:48:19  <cwillu> neat
2005-11-23T01:48:23  <cwillu> I have no idea what I changed
2005-11-23T01:48:30  <cwillu> but it started doing something half-way sensible
2005-11-23T01:51:26  <starshine> hehehehe
2005-11-23T01:51:31  <cwillu> hmm
2005-11-23T01:51:32  <starshine> argument vector.
2005-11-23T01:52:17  <cwillu> I'm supplying basically everything I can get my hands on via headers _and_ environment
2005-11-23T01:52:24  <cwillu> apparently some combiniation of those was correct
2005-11-23T01:52:26  <starshine> argc (count) argv (vector, in other words, the array of commandline arguments, should be argc of them), argh (haha my opinion of the envp Environment Pointer which is where you find the shell vars)
2005-11-23T01:52:40  <cwillu> did I mention that I apparently have no manner of listing the headers available via isapi?
2005-11-23T01:53:09  <cwillu> I can see the outgoing, I can get a list of some defaults, but otherwise I have to try a key, and watch for the exception
2005-11-23T01:53:20  <cwillu> but I'm improving
2005-11-23T01:53:28  <starshine> you mean there's no isapi call for it, or there's no decent isapi reference?
2005-11-23T01:53:46  <cwillu> moin now tells me "Filename of attachment not specified!" which may just be that file path diff between moz and ie :)
2005-11-23T01:53:55  <cwillu> there's nothing in the new python bindings for it
2005-11-23T01:54:07  <cwillu> and I'm not sure there is in isapi, but I'd be surprised if there wasn't
2005-11-23T01:54:26  <cwillu> hmm, same err on moz
2005-11-23T01:57:30  <cwillu> getting close :)
2005-11-23T01:59:23  <starshine> :D :D
2005-11-23T01:59:34  <cwillu> hmm
2005-11-23T01:59:53  <cwillu> how's your FieldStorage api understanding?
2005-11-23T02:00:29  <starshine> FieldStorage?  I know how the things are physically placed in the data tree..
2005-11-23T02:00:35  <cwillu> I get a FieldStorage with the keys ['file', 'rename', 'action', 'do']
2005-11-23T02:00:56  <cwillu> and the repr is [FieldStorage('file', 'ocr.txt', '.....]
2005-11-23T02:01:14  <cwillu> I can fs['file'], and I get back another field storage
2005-11-23T02:01:18  <starshine> ah.  I haven't used that.  I got my hands grubby in the auth code, before TW cleaned it up.
2005-11-23T02:01:38  <cwillu> I get index errors :(
2005-11-23T02:02:05  <cwillu> ahh
2005-11-23T02:02:11  <cwillu> I misunderstand! I misunderstand!
2005-11-23T02:02:56  <cwillu> 'file' is a FieldStorage named 'file', with the filename ocr.txt, and the contents ........
2005-11-23T02:03:36  <cwillu> which still doesn't explain why the filename of the attachment is apparently not specified
2005-11-23T02:03:59  <cwillu> booooooooyaaaaaaaaaaaaaaaaaaaaaaaaa!!
2005-11-23T02:04:14  <cwillu> Attachment 'test' (remote name 'None') with 155 bytes saved.
2005-11-23T02:04:47  <starshine> woot
2005-11-23T02:05:08  <cwillu> boom
2005-11-23T02:05:14  <cwillu> ie works too
2005-11-23T02:05:22  <cwillu> differences due to file path of course
2005-11-23T02:05:38  <starshine> but that
2005-11-23T02:05:41  <cwillu> and its not using the original filename even though its available, but these are small matters :)
2005-11-23T02:05:52  <cwillu> ie, I just have to trim off the path (os.path should do the trick)
2005-11-23T02:05:54  <starshine> it's just where it puts it because of prefs in the otherbrowser, right?
2005-11-23T02:06:12  <starshine> it'd be a nice touch for it to offer the original filename
2005-11-23T02:06:15  <cwillu> ie supplies the entire path as the filename
2005-11-23T02:06:31  <cwillu> whereas every other browse just gives the filename, seeing as the path has no meaning to the remote host generally
2005-11-23T02:06:33  <starshine> hm.
2005-11-23T02:09:06  <cwillu> hmm
2005-11-23T02:09:20  <cwillu> I am still missing the filepath, brief hallucination re: moz
2005-11-23T02:09:28  <cwillu> but I do have the data
2005-11-23T02:11:44  <cwillu> brb
2005-11-23T02:15:16  <cwillu> lol
2005-11-23T02:15:27  <cwillu> _why_ are we using file__filename__ as a magic keyword?  lol
2005-11-23T02:25:27  <cwillu> boom
2005-11-23T02:25:51  <cwillu> double boom
2005-11-23T02:26:08  <cwillu> now, to clean up my mess :)
2005-11-23T02:34:52  <cwillu> so, why don't binary attachments work?  :)
2005-11-23T02:42:26  <cwillu> hmm
2005-11-23T02:42:38  <cwillu> do big text attachments work either?
2005-11-23T02:44:05  <cwillu> nope
2005-11-23T02:44:11  <cwillu> not reading the whole thing I guess
2005-11-23T03:01:08  <starshine> I bet it's some sort of buffering thing
2005-11-23T03:01:38  <starshine> maybe more than one call is available to provide it.
2005-11-23T03:01:47  <cwillu> got it already :p
2005-11-23T03:01:56  <cwillu> there's this attribute you see
2005-11-23T03:02:07  <cwillu> ecb.AvailableData
2005-11-23T03:02:10  <cwillu> its a normal string
2005-11-23T03:02:20  <cwillu> then there's ecb.AvailableBytes and ecb.TotalBytes
2005-11-23T03:02:30  <cwillu> and a method ecb.ClientRead
2005-11-23T03:02:34  <cwillu> or ReadClient, sorry
2005-11-23T03:02:40  <cwillu> which also returns a string
2005-11-23T03:02:50  <cwillu> but doesn't affect the original data, or any of the counts
2005-11-23T03:03:17  <cwillu> but it also doesn't read any data from the original AvailableData
2005-11-23T03:03:48  <cwillu> and it hangs if you call it with no pending data :)
2005-11-23T03:04:37  <cwillu> can you tell I'm having fun?  :)
2005-11-23T03:04:51  <starshine> :D
2005-11-23T03:05:07  <cwillu> But.
2005-11-23T03:05:12  <cwillu> big attachments now work
2005-11-23T03:05:14  <cwillu> as do small
2005-11-23T03:05:23  <cwillu> and everything else works while those are working
2005-11-23T03:05:26  <cwillu> and binary works
2005-11-23T03:05:35  <cwillu> and I get file names
2005-11-23T03:05:37  <starshine> woot
2005-11-23T03:05:41  <cwillu> Woot.
2005-11-23T03:05:51  <cwillu> (think english professor tone)
2005-11-23T03:05:57  <cwillu> Woot, indeed.
2005-11-23T03:06:06  <cwillu> but the real test:
2005-11-23T03:06:24  <cwillu> does the graphic editor work?  :)
2005-11-23T03:06:54  <cwillu> hmm
2005-11-23T03:06:58  <starshine> if you're not on safari it does ;>
2005-11-23T03:07:04  <cwillu> that was an existing one, but it did
2005-11-23T03:07:05  <cwillu> safari
2005-11-23T03:07:10  <cwillu> I laugh out loud at thee
2005-11-23T03:07:19  <starshine> yeah the mac version of konqueror..
2005-11-23T03:07:26  <cwillu> the macs I take on tomorrow :p
2005-11-23T03:07:50  <cwillu> the only force that can resist the corporate will to use microsoft:
2005-11-23T03:07:54  <cwillu> graphic designers :)
2005-11-23T03:07:59  <starshine> don't worry, safari shouldn't be offered the gui-edit.
2005-11-23T03:08:03  <starshine> :D
2005-11-23T03:08:12  <cwillu> drawing editor, not gui editor :p
2005-11-23T03:08:19  <cwillu> the little java twiki thing
2005-11-23T03:08:21  <starshine> ohhh tkdrawplugin
2005-11-23T03:08:29  <starshine> should work as long as your java is good
2005-11-23T03:08:33  <starshine> it's an applet.
2005-11-23T03:08:37  <cwillu> and attachments are good :p
2005-11-23T03:08:42  <cwillu> which is the question, isn't it :)
2005-11-23T03:08:46  <starshine> yep..
2005-11-23T03:09:40  <cwillu> hehe
2005-11-23T03:09:43  <cwillu> I'm gigglings
2005-11-23T03:09:57  <starshine> that's mad scientist laughter you know
2005-11-23T03:09:58  <cwillu> i can create and edit, and they all save
2005-11-23T03:10:00  <cwillu> yay
2005-11-23T03:10:01  <cwillu> hehe
2005-11-23T03:10:05  <starshine> i18n> it's alive mwahahahaha
2005-11-23T03:10:06  <cwillu> muahahahahahahah1!!!!
2005-11-23T03:10:13  <cwillu> gotta get the '1'  in there :)
2005-11-23T03:11:03  <cwillu> lol
2005-11-23T03:11:08  <cwillu> so I've got these strings
2005-11-23T03:11:12  <cwillu> and I pull them into a StringIO
2005-11-23T03:11:21  <cwillu> and then I pull them back out to a single string
2005-11-23T03:11:32  <cwillu> at which point I stuff them back into another stringio to go into field storage
2005-11-23T03:11:34  <cwillu> bah
2005-11-23T03:12:25  <cwillu> after creating which, I check to see if I've created one
2005-11-23T03:22:43  <cwillu> and I believe the changes are all isolated to one method in MoinIIS.py;  the replacement method (setup_args) has been posted to MoinMoin_ISAPI
2005-11-23T03:26:17  <cwillu> Okay, so disappearing titles (touch the css files), file attachments (and the drawing applet along for the ride), redirects (and response headers in general), I think that's enough for one day
2005-11-23T03:28:36  <starshine> I think you've earned your brewski of choice cwillu
2005-11-23T03:29:31  <cwillu> now I can actually start on the interesting stuff;  ms acl integration, user homes, actually getting the user's full name and using that instead of the username
2005-11-23T03:38:44  <starshine> :)
2005-11-23T03:49:07  *** starshine is now known as starshine_away
2005-11-23T03:57:19  *** cwillu has quit IRC
2005-11-23T04:31:00  *** starshine_away is now known as starshine
2005-11-23T05:29:15  *** starshine is now known as starshine_away
2005-11-23T07:44:26  *** lydon has joined #moin-dev
2005-11-23T07:46:08  <lydon> moin
2005-11-23T08:05:33  <ThomasWaldmann> moin
2005-11-23T08:10:10  *** Fabi has joined #moin-dev
2005-11-23T08:14:58  *** starshine_away is now known as starshine
2005-11-23T09:11:37  <xorAxAx> starshine: no, that should not go here, because it is not about development of moinmoin
2005-11-23T09:11:54  <xorAxAx> starshine: it was about development of the ISAPI module which is written by a third-party
2005-11-23T09:18:28  <starshine> oh. ok
2005-11-23T09:18:33  * starshine didn't know
2005-11-23T09:32:41  *** xorAxAx changes topic to "MoinMoin Developer Channel - User or Third-Party issues should go to #moin. Note that you are publicly logged here."
2005-11-23T09:32:53  *** xorAxAx changes topic to "MoinMoin Developer Channel - User or third-party issues should go to #moin. Note that you are publicly logged here."
2005-11-23T09:35:07  <xorAxAx> ThomasWaldmann: there still an open ACL issue on the questions page makred with your name
2005-11-23T09:38:26  <xorAxAx> ThomasWaldmann: and moinmaster is still red
2005-11-23T10:22:28  *** starshine is now known as starshine_away
2005-11-23T10:40:43  <xorAxAx> ThomasWaldmann: WTH, we are distributin packager.exe?
2005-11-23T10:40:51  <xorAxAx> ThomasWaldmann: that one needs to be pruned
2005-11-23T10:40:59  <xorAxAx> jonas is right here
2005-11-23T10:43:14  <xorAxAx> ah, you deleted it
2005-11-23T10:43:18  <xorAxAx> or somebody else
2005-11-23T12:03:14  *** nwp_ has quit IRC
2005-11-23T12:32:28  *** Fabi has quit IRC
2005-11-23T13:10:58  *** nwp has joined #moin-dev
2005-11-23T16:09:14  *** lydon has quit IRC
2005-11-23T17:02:55  *** starshine_away is now known as starshine
2005-11-23T17:26:58  * xorAxAx notes that all timings and benchmark on function level have to be redone
2005-11-23T17:27:16  <xorAxAx> current python-dev discussions reveal that hotshot is fairly broken
2005-11-23T17:27:44  * xorAxAx suggest to revert to profile.py and migrate to lsprof when its ready for "production" testing
2005-11-23T17:28:54  <xorAxAx> ThomasWaldmann: whats the current state of the integration of the irc log pusher?
2005-11-23T18:12:29  * xorAxAx bcced tom re the funny mail
2005-11-23T20:25:30  *** starshine is now known as starshine_away
2005-11-23T22:10:43  *** Fabi has joined #moin-dev
2005-11-23T22:45:04  *** diego has joined #moin-dev
2005-11-23T22:46:04  <diego> Are ReimarBauer or AlexanderSchremmer in here by any chance?
2005-11-23T22:46:30  <xorAxAx> diego: AlexanderSchremmer is, but you maybe want to ask in #moin :)
2005-11-23T22:46:57  <diego> i wanted to discuss a patch i just uploaded ( http://moinmoin.wikiwikiweb.de/FeatureRequests/UploadMultipleAttachmentFiles/RulesForUnzip?action=diff )
2005-11-23T22:47:00  <diego> wouldn't this be the place?
2005-11-23T22:49:30  <xorAxAx> hmm, its the correct place :)
2005-11-23T22:49:57  <xorAxAx> ah, the "winzip-patch"
2005-11-23T22:50:22  <xorAxAx> can you upload a diff against the 1.5 code?
2005-11-23T22:50:22  <diego> xorAxAx: are you Alexander?
2005-11-23T22:50:24  <xorAxAx> yes
2005-11-23T22:50:54  <diego> i grabbed a snapshot a couple days ago, would a diff on that be ok?
2005-11-23T22:51:01  <xorAxAx> yeah
2005-11-23T22:51:12  <xorAxAx> but the snapshot on the downloads page is older than the beta
2005-11-23T22:51:16  <xorAxAx> thank thomas for that :)
2005-11-23T22:51:20  <diego> heh
2005-11-23T22:52:20  <diego> can you take a look at the diff i uploaded and tell me if the coding style is ok? I'm new to contributing to the project
2005-11-23T22:55:11  <diego> also, was it proper procedure for me to add a @copyright line?
2005-11-23T23:03:12  <xorAxAx> the return tuple is a bit weird, a single type would be enough
2005-11-23T23:03:43  <diego> ok
2005-11-23T23:03:51  <xorAxAx> and there are os.path functions to split off names and the path
2005-11-23T23:03:57  <xorAxAx> and @copyright is ok
2005-11-23T23:06:24  <diego> mm..would os.path functions be better? i noticed line 637 {{{ valid_pathname = lambda name: (name.find('/') == -1) and (name.find('\\') == -1) }}} used '/', and I thought os.path's functions change behaviors depending on the platform
2005-11-23T23:06:58  <diego> if i don't return a tuple, should i return False or an int if there's an error?
2005-11-23T23:09:14  <xorAxAx> diego: python has exceptions :)
2005-11-23T23:09:41  <xorAxAx> either you return something that evaluates to False when checked in the error case or you use exceptions
2005-11-23T23:09:47  <xorAxAx> everything in between is unpythonic :)
2005-11-23T23:09:56  <diego> heh, ok
2005-11-23T23:10:07  <diego> i think False is fine for now
2005-11-23T23:11:12  <xorAxAx> if you want further general hints, you can google "PEP 8"
2005-11-23T23:11:51  <diego> i've read that, it's just been a while
2005-11-23T23:13:58  <diego> let me test the 1.5 patch and i'll submit that (no os.path change though without further direction from you)
2005-11-23T23:18:45  <diego> ok seems to work
2005-11-23T23:19:09  <diego> ooh i forgot to test with empty directories
2005-11-23T23:20:35  <diego> err..does zip support empty directories?
2005-11-23T23:25:56  <diego> ok, zip does, file-roller may not, and it behaves as i think it should with empty directories. uploading patch then
2005-11-23T23:28:14  *** Fabi has quit IRC
2005-11-23T23:29:05  <xorAxAx> diego: the standard itself doesnt
2005-11-23T23:29:16  <xorAxAx> diego: java e.g. patches zip files to support such empty dirs
2005-11-23T23:29:26  <xorAxAx> with pseudo files that cannot be extracted
2005-11-23T23:29:55  <diego> ah. i was testing them with winrar
2005-11-23T23:31:10  <xorAxAx> in the old days, you packed a small file "delete.me" into those dirs
2005-11-23T23:31:49  <diego> in the old days, i probably wasn't even a thought :)
2005-11-23T23:34:35  <diego> xorAxAx: http://moinmoin.wikiwikiweb.de/FeatureRequests/UploadMultipleAttachmentFiles/RulesForUnzip?action=diff&rev2=40&rev1=39
2005-11-23T23:36:22  <xorAxAx> diego: ok, i will check it
2005-11-23T23:36:27  <xorAxAx> and comment on the page
2005-11-23T23:36:39  <xorAxAx> diego: so, how old are you? :-)
2005-11-23T23:36:43  <diego> xorAxAx: thanks
2005-11-23T23:36:44  <diego> 17
2005-11-23T23:37:04  <xorAxAx> hmm, ok. not much younger than me
2005-11-23T23:37:17  <xorAxAx> just 4 years :)
2005-11-23T23:37:20  <diego> heh
2005-11-23T23:38:09  <diego> 4 years ago i had no php, mysql, python, and linux experience :)
2005-11-23T23:41:41  <xorAxAx> i created my first zip when i was 9
2005-11-23T23:44:51  <diego> impressive?
2005-11-23T23:54:29  <xorAxAx> diego: nah, just the right tool, xtree
2005-11-23T23:54:34  <xorAxAx> that one rocks
2005-11-23T23:54:50  <xorAxAx> you can try ytree for a short checkout, xtree could do more back then, though
2005-11-23T23:55:22  <diego> mmm...I'll just act like I have better things to do
2005-11-23T23:55:38  <xorAxAx> diego: btw, your attachfile patch looks dirty
2005-11-23T23:56:22  <xorAxAx> such things should be never scattered like that in the code. either the quoting functions needs to be called or not
2005-11-23T23:56:30  <xorAxAx> just quoting one char will not be enough
2005-11-23T23:56:46  <diego> huh?
2005-11-23T23:58:19  <xorAxAx> like %20 is just one of 256 characters
2005-11-23T23:58:31  <diego> oooh, that patch
2005-11-23T23:58:38  <diego> i thought you were talking about the zip subdir one
2005-11-23T23:59:17  <diego> i wasn't expecting the %20 patch to really be used by many people, let me revisit it though
2005-11-23T23:59:33  <diego> is there a possibility it'd be included in 1.5 if i did it the right way?