MoinMoin: MoinMoinChat/Logs/moin-dev/2005-12-16

2005-12-16T00:05:19  <xorAxAx> [PERIODIC ANNOUNCEMENT] Logs can be found on http://moinmoin.wikiwikiweb.de/MoinMoinChat/Logs/moin-dev
2005-12-16T00:18:13  <nwp_> _keturn: sounds like you're aiming for something similar to me... how far along are you so far?
2005-12-16T00:35:14  <_keturn> nwp: a little.  no running code yet, but I hope that's not too far off.
2005-12-16T00:36:18  <_keturn> except I'm not really doing LDAP
2005-12-16T00:37:33  <xorAxAx> _keturn: but? :-)
2005-12-16T00:40:26  <starshine> what are you doing instead?
2005-12-16T00:40:30  <_keturn> OpenID
2005-12-16T00:40:37  <xorAxAx> ah, you are the open id guy
2005-12-16T00:43:49  <starshine> .o( compare notes might still be a good thing to do.
2005-12-16T00:44:02  <starshine> s/e/ing/
2005-12-16T00:44:48  <ThomasWaldmann> _keturn: if you succeed with the client, we need the server next (for interwiki style auth) :)
2005-12-16T00:48:15  * _keturn looks through the many methods on Request, trying to figure out how to get "absolute URI of this request without the query string"
2005-12-16T00:50:22  <_keturn> or maybe query string is okay.  but there's still makeURI(), .url and .request_url
2005-12-16T00:51:38  <xorAxAx> _keturn: i would split it from request_uri
2005-12-16T01:47:22  * _keturn loads INSTALL.html
2005-12-16T01:47:28  <_keturn> ow my eyes the red it burns
2005-12-16T02:32:03  <_keturn> is there a secret button that connects testwiki to a web server without me having to do any work?
2005-12-16T02:36:42  *** starshine is now known as starshine_away
2005-12-16T04:44:48  *** starshine_away is now known as starshine
2005-12-16T08:18:59  *** starshine is now known as starshine_away
2005-12-16T08:23:15  <ThomasWaldmann> _keturn: iirc the testwiki uses the default config values, so if you just start moin.py, it might work
2005-12-16T08:24:01  <ThomasWaldmann> maybe fix sys.path in it, so it finds the moinmoin code
2005-12-16T09:36:53  *** starshine_away is now known as starshine
2005-12-16T12:29:38  <xorAxAx> Fabi: why dont you do it like i suggested it?
2005-12-16T12:29:49  <xorAxAx> Fabi: i.e. implementing an action that renders the userform macro
2005-12-16T12:30:07  <xorAxAx> then you will be on the correct page after hitting submit automatically
2005-12-16T12:31:05  * xorAxAx is gone
2005-12-16T12:31:19  <Fabi> ...
2005-12-16T12:34:36  <starshine> um, but you could have been from anywhere
2005-12-16T12:34:57  <starshine> and if you click login, login is still a userform
2005-12-16T12:36:09  <starshine> xorAxAx: and since he specified "login"
2005-12-16T12:45:53  <ThomasWaldmann> btw, sunday is likely to be rc1-day, so dont fuck it up now :)
2005-12-16T12:46:38  <starshine> ThomasWaldmann: do you think his suggestion would successfully go back to the referring wikipage?
2005-12-16T12:47:09  <ThomasWaldmann> actions don't change the page, so it should work
2005-12-16T12:47:22  <ThomasWaldmann> but it could also be done in 1.5.1
2005-12-16T12:47:48  <ThomasWaldmann> that userform stuff is not the nicest code...
2005-12-16T12:49:14  <TheSheep> it would be nice to split the login and user preferences
2005-12-16T12:50:10  <TheSheep> into separate forms and actions (and probably modules)
2005-12-16T13:04:15  <xorAxAx> re
2005-12-16T13:04:22  <xorAxAx> Fabi: isnt it clear?
2005-12-16T13:04:31  <xorAxAx> Fabi: you can submit the post request to any page
2005-12-16T13:04:37  <xorAxAx> Fabi: lets say you are on the page X
2005-12-16T13:04:48  <xorAxAx> Fabi: the user clicks the action login
2005-12-16T13:04:56  <xorAxAx> Fabi: the action login displays the firm
2005-12-16T13:04:59  <xorAxAx> s/ir/or/
2005-12-16T13:05:08  <xorAxAx> Fabi: the post request goes to page x
2005-12-16T13:05:16  <xorAxAx> Fabi: the user sees a message and his old page x
2005-12-16T13:05:34  <xorAxAx>  todo: write a very short action and call it from the theme
2005-12-16T13:05:43  <xorAxAx> much simpler than messing with existing code
2005-12-16T13:06:19  <Fabi> the point is I'd like to display the User Pref page
2005-12-16T13:06:28  <Fabi> but the action could do this...
2005-12-16T13:07:06  <Fabi> hmm. doesn't work
2005-12-16T13:07:22  <Fabi> because the form invokes the userform action
2005-12-16T13:07:31  <Fabi> that would return the wrong page
2005-12-16T13:07:41  <starshine> ...
2005-12-16T13:07:41  <Fabi> need to extend the userform action
2005-12-16T13:07:54  <Fabi> to redirect after successfull login
2005-12-16T13:07:55  <xorAxAx> "userform action" what is that?
2005-12-16T13:07:57  <starshine> ok I'm with TW, this is too complex for 5 minutes til release kind of changes.
2005-12-16T13:08:35  <starshine> xorAxAx: when you click 'login' you get a form page, generated by userform.py same as UserPreferences are when logged in
2005-12-16T13:08:37  <Fabi> userform action is invoke if you press the login button
2005-12-16T13:08:41  <xorAxAx> Fabi: are you sure that it is hard-coded?
2005-12-16T13:08:56  <starshine> Fabi: but once logged in you are two references deep not one?
2005-12-16T13:09:12  <xorAxAx> starshine: hmm?
2005-12-16T13:09:16  <Fabi> starshine, *??*
2005-12-16T13:09:39  <starshine> because the "new" UserPreferences (full form) had the old UserPreferences (login page) as its referent
2005-12-16T13:09:56  <Fabi> starshine, yep
2005-12-16T13:10:13  <xorAxAx> Fabi: if it is hard-coded, simply remove the hard-coding
2005-12-16T13:10:19  <xorAxAx> Fabi: implementing redirect is not necessary
2005-12-16T13:10:27  <Fabi> why?
2005-12-16T13:10:28  <xorAxAx> action="" is valid
2005-12-16T13:10:32  <xorAxAx> and correct
2005-12-16T13:11:31  <starshine> Fabi: I think splitting them is a better approach, then loginform can pass either back to origin or tell UserPreferences what the origin was.
2005-12-16T13:11:31  <Fabi> we have three steps:
2005-12-16T13:12:11  <Fabi> true, but doesn't solve the problem
2005-12-16T13:12:27  <starshine> well, it doesn't solve it today.
2005-12-16T13:12:28  <Fabi> the point is I want to keep the login form as a macro
2005-12-16T13:12:47  <Fabi> to ahve an editable page around it
2005-12-16T13:13:27  <xorAxAx> Fabi: yeah, doesnt contradict my suggestion
2005-12-16T13:13:39  <xorAxAx> Fabi: then simply render the page _("UserPreferences") using that action
2005-12-16T13:13:48  <starshine> hrmm
2005-12-16T13:14:13  <Fabi> xorAxAx, this breaks if you hit the login button
2005-12-16T13:14:28  <xorAxAx> Fabi: why?
2005-12-16T13:14:31  <Fabi> especially is your password was wrong
2005-12-16T13:14:43  <Fabi> s/is/if/
2005-12-16T13:15:33  <Fabi> we need to extend the userform action
2005-12-16T13:15:39  <Fabi> somehow
2005-12-16T13:16:06  <xorAxAx> which userform action?
2005-12-16T13:16:17  <xorAxAx> ah, the one that does the save?
2005-12-16T13:16:27  <starshine> um
2005-12-16T13:16:27  <Fabi> yes, there is only one
2005-12-16T13:16:43  <starshine> highlander problem
2005-12-16T13:16:57  <xorAxAx> Fabi: i dont see the problem with "your password was wrong"
2005-12-16T13:17:07  <xorAxAx> Fabi: we can redirect in that case
2005-12-16T13:17:14  <xorAxAx> (in the action)
2005-12-16T13:17:19  <Fabi> no the highlander problem is: "There should have only been one"
2005-12-16T13:17:26  <starshine> the thing is a single userform.py because once upon a forever ago someone thought only one file should be touching the userfile. (I think.)
2005-12-16T13:17:33  <starshine> lol
2005-12-16T13:17:58  <starshine> c/~ but so long as I stand herein there shall be two... no winner be found...
2005-12-16T13:18:30  <starshine> *real people* don't think of the login and the prefs as the same page though
2005-12-16T13:18:54  <starshine> it confuses the hell out of them to jump to a page called UserPreferences to login
2005-12-16T13:19:12  <starshine> though we cover this up nicely.
2005-12-16T13:19:18  <TheSheep> star: then it could be solved splitting the file into name/pass/id one and prefs one
2005-12-16T13:19:29  <starshine> yes
2005-12-16T13:19:38  <TheSheep> but thats a big change
2005-12-16T13:19:43  <starshine> and we already split off pagetrails so it can be tickled a lot
2005-12-16T13:19:51  <TheSheep> in terms of backward compatibility
2005-12-16T13:19:51  <Fabi> Ok, I see we doN#t get far this was
2005-12-16T13:19:58  <Fabi> s/was/way/
2005-12-16T13:20:03  <Fabi> I start a wiki page
2005-12-16T13:20:09  <xorAxAx> Fabi: ok
2005-12-16T13:20:14  <starshine> ...the problem is too complex for the last minute :D
2005-12-16T13:20:38  <TheSheep> "The true meaning of >>backward compatibility<< becomes more apparent, if we remove the word >>comatibilty<<." :)
2005-12-16T13:20:59  <starshine> ThomasWaldmann: your comment about splitting the name from prefs is a matter of storage not of presentation
2005-12-16T13:21:30  <starshine> Fabi wanted to address the presentation detail, that when a user is "done" they want to go back to MyWakiWikiPage
2005-12-16T13:21:47  <starshine> where they decided they had to click login, to get some right.
2005-12-16T13:22:50  <TheSheep> why can't it be done with an UserPreferences action that would just render the UserPreferences page, again?
2005-12-16T13:23:26  <Fabi> it can
2005-12-16T13:23:44  <starshine> .o( define "done" and you have a good chance at this
2005-12-16T13:24:04  <TheSheep> #define done accomplished
2005-12-16T13:24:06  <starshine> ...as long as you have successfully carried a sense of origin with you.
2005-12-16T13:24:21  <Fabi> UserPreferencesRedesign
2005-12-16T13:24:25  <starshine> Fabi: thanks
2005-12-16T13:24:41  <Fabi>  UserPreferencesRedesign/LoginPage looks like a nice place
2005-12-16T13:53:01  <TheSheep> how do I display the formatted page's content?
2005-12-16T13:53:22  <TheSheep> can't find a sample in the code, somehow
2005-12-16T13:56:46  <TheSheep> hmm... page.send_page ?
2005-12-16T13:58:38  <xorAxAx> TheSheep: wrong channel :)
2005-12-16T14:01:34  *** starshine is now known as starshine_away
2005-12-16T14:05:55  <TheSheep> sorry
2005-12-16T17:31:17  *** starshine_away is now known as starshine
2005-12-16T17:32:26  *** nwp_ has quit IRC
2005-12-16T18:44:58  *** starshine is now known as starshine_away
2005-12-16T18:53:00  *** Fabi has quit IRC
2005-12-16T19:12:39  <_keturn> So, I added to user_form_fields in the config, and user_form_defaults, but that doesn't seem to mean if I type in a value in that form and hit "save" that it's saved.  What am I missing?
2005-12-16T19:27:59  <_keturn> does tla/archzoom not have 'annotate'?
2005-12-16T19:28:06  <xorAxAx> no, it does not
2005-12-16T19:28:15  <xorAxAx> one item of the large list of design issues
2005-12-16T19:28:28  <xorAxAx> new versions of baz have it AFAIK
2005-12-16T19:28:35  <xorAxAx> and fai. but fai is not developed anymore
2005-12-16T19:30:43  *** TheSheep is now known as DasSheep
2005-12-16T19:34:14  <_keturn> I don't get it.  is the config value user_form_fields only for *removing* fields?  because there's no code in userform..handleData to handle them.  Unless they are *checkbox* fields, in which case they do get set.
2005-12-16T19:35:21  <xorAxAx> possible
2005-12-16T19:35:22  <_keturn> The code around userform.py:262, below "# User CSS URL", looks suspicious, because that code was obviously yanked from the inside of a loop and isn't in a loop currently.
2005-12-16T19:35:29  <xorAxAx> i am not sure who wrote handledata
2005-12-16T19:35:33  <xorAxAx> looks like he didnt consider that
2005-12-16T19:47:34  *** starshine_away is now known as starshine
2005-12-16T20:35:47  *** starshine is now known as starshine_away
2005-12-16T20:44:10  *** Fabi has quit IRC
2005-12-16T20:56:46  <_keturn> okay, I would like to submit a patch to fix that
2005-12-16T21:00:16  <_keturn> It is just a patch to one file.  (Although I suppose I should split out the test from my auth plugin test and submit that too.)  Would you like a normal diff or a crazy tla patchset bomb?
2005-12-16T21:04:24  <xorAxAx> a plain unified diff :)
2005-12-16T21:11:32  <_keturn> geeze, eight files in that changeset and "show-changeset" doesn't use a single one of them to display my log message?
2005-12-16T21:12:29  <xorAxAx> i have never found out what tl smoked when he designed tla
2005-12-16T21:15:54  <_keturn> should I send that to the ml or what?
2005-12-16T21:19:20  <xorAxAx> hmm, is it very big?
2005-12-16T21:19:34  <xorAxAx> then you should put it onto the wiki :)
2005-12-16T21:28:15  <_keturn> http://moinmoin.wikiwikiweb.de/MoinMoinPatch/SaveConfigurableUserFormFields
2005-12-16T22:31:03  *** starshine_away is now known as starshine
2005-12-16T22:35:01  <xorAxAx> _keturn: am i blind - already_handled isnt read
2005-12-16T22:52:06  <xorAxAx> the vertical line issue is still there, ThomasWaldmann
2005-12-16T23:08:51  <ThomasWaldmann> unless we have a better idea it will stay
2005-12-16T23:09:42  <ThomasWaldmann> maybe we can use same trick as for link icons
2005-12-16T23:10:17  * DasSheep thinks it would work
2005-12-16T23:21:53  <_keturn> xorAxAx: good spotting!
2005-12-16T23:23:40  <xorAxAx> _keturn: :)
2005-12-16T23:23:58  <xorAxAx> _keturn: i think i am one of the few people actually reading patches before merging them :)
2005-12-16T23:53:19  *** Fabi has quit IRC
2005-12-16T23:57:37  <_keturn> What's the "trusted" attribute on User about?