MoinMoin: MoinMoinChat/Logs/moin-dev/2005-12-19

2005-12-19T00:00:12  *** Fabi has quit IRC
2005-12-19T00:00:36  <ThomasWaldmann> ok, fabi has no more commits X)
2005-12-19T00:00:40  <ThomasWaldmann> anyone else?
2005-12-19T00:05:28  <xorAxAx> [PERIODIC ANNOUNCEMENT] Logs can be found on http://moinmoin.wikiwikiweb.de/MoinMoinChat/Logs/moin-dev
2005-12-19T00:11:21  * ThomasWaldmann makes rc1 now
2005-12-19T01:18:45  *** starshine_away is now known as starshine
2005-12-19T02:31:59  *** starshine is now known as starshine_away
2005-12-19T05:52:25  *** starshine_away is now known as starshine
2005-12-19T06:42:55  *** nwp has quit IRC
2005-12-19T06:42:55  *** nwp_ has quit IRC
2005-12-19T10:02:54  *** starshine is now known as starshine_away
2005-12-19T10:07:58  <ThomasWaldmann> Fabi: btw, did you add some src comment why your fix is a fix (html as backup)?
2005-12-19T10:08:12  <Fabi> no
2005-12-19T10:08:31  <Fabi> should be obvious
2005-12-19T10:08:31  <ThomasWaldmann> please do or I promise this will break again next time someone touches that code
2005-12-19T10:08:45  <Fabi> first decode input then do something with it
2005-12-19T10:09:05  <ThomasWaldmann> you only moved around the cancel stuff
2005-12-19T10:09:08  <Fabi> ok, I' add a comment
2005-12-19T10:09:18  <Fabi> yes
2005-12-19T10:09:23  <ThomasWaldmann> and it happens even when not using cancel
2005-12-19T10:09:29  <Fabi> and some quoting stuff, too
2005-12-19T10:09:35  <Fabi> I did not change a sigle line
2005-12-19T10:12:44  <ThomasWaldmann> i only see that the comment processing moved (i moved that to wikiutil.clean_comment meanwhile btw), nothing else
2005-12-19T10:18:36  <Fabi> comment processing?
2005-12-19T10:19:26  <ThomasWaldmann> remap_chars / translate
2005-12-19T10:19:58  <Fabi> yes and the cancle handling moved, too
2005-12-19T10:23:18  <Fabi> *squish*
2005-12-19T10:36:30  <ThomasWaldmann> ?
2005-12-19T10:51:39  <Fabi> got another bug
2005-12-19T10:52:15  <Fabi> I just closed MoinMoinBugs/ActionInfoFails. I asume patch 336 fixes that problem
2005-12-19T10:54:02  <ThomasWaldmann> right, forgot that one
2005-12-19T10:55:14  <ThomasWaldmann> if you have time, check that new getval bug (WikiDicts)
2005-12-19T10:55:48  <ThomasWaldmann> getval itself isn't that important maybe (not widely used), but if the dict itself is the problem, we maybe have an acl problem, too
2005-12-19T10:56:35  <Fabi> I'll have a look
2005-12-19T10:56:53  <Fabi> I don't know what kind of comment to add to do_edit()
2005-12-19T11:03:21  <ThomasWaldmann> "do an edit"
2005-12-19T11:03:25  <ThomasWaldmann> :)
2005-12-19T11:03:31  <ThomasWaldmann> bbl
2005-12-19T14:59:28  *** starshine_away is now known as starshine
2005-12-19T15:21:39  *** starshine is now known as starshine_away
2005-12-19T15:42:55  <xorAxAx> ThomasWaldmann: re that puzzle, do you think that the comments i added were not direct enough?
2005-12-19T15:53:06  * Fabi -> DaNi's Doktorpruefung
2005-12-19T15:53:14  <Fabi> cu
2005-12-19T15:53:50  *** Fabi has quit IRC
2005-12-19T15:54:23  <xorAxAx> er muss beisitzen? %-)
2005-12-19T17:10:52  *** starshine_away is now known as starshine
2005-12-19T17:23:29  * starshine read that as "doctor proofing"
2005-12-19T18:43:36  * keturn argues with himself about whether it's worth going out into the slush and rain to get to his moin code.
2005-12-19T18:43:49  <keturn> stupid network going down.
2005-12-19T20:27:11  <ThomasWaldmann> moin
2005-12-19T20:27:55  * starshine installs some umbrella code ;P
2005-12-19T21:22:49  *** nwp has quit IRC
2005-12-19T21:22:49  *** nwp_ has quit IRC
2005-12-19T21:36:28  *** starshine is now known as starshine_away
2005-12-19T21:49:30  *** starshine_away is now known as starshine
2005-12-19T22:02:37  *** starshine is now known as starshine_away
2005-12-19T23:29:39  *** starshine_away is now known as starshine