MoinMoin: MoinMoinChat/Logs/moin-dev/2006-07-16

2006-07-16T10:02:38  <Kepplar> moin
2006-07-16T12:13:35  <ThomasWaldmann> moin
2006-07-16T12:40:35  <ThomasWaldmann> waah, BUG
2006-07-16T12:40:49  <xorAxAx> more than 100 even
2006-07-16T12:40:56  <ThomasWaldmann> MoinMoin: AktuelleÄnderungen (zuletzt geändert am 2005-02-25 16:56:34 durch AlexanderSchremmer)
2006-07-16T12:41:13  <ThomasWaldmann> Date: Sun, 16 Jul 2006 10:18:07 GMT
2006-07-16T12:41:13  <ThomasWaldmann> Last-Modified: Fri, 25 Feb 2005 16:56:34 GMT
2006-07-16T12:41:13  <ThomasWaldmann> Content-Type: text/html;charset=utf-8
2006-07-16T12:41:13  <ThomasWaldmann> Vary: User-Agent
2006-07-16T12:41:13  <ThomasWaldmann> Server: TwistedWeb/2.4.0
2006-07-16T12:41:45  <xorAxAx> hmm?
2006-07-16T12:42:19  <ThomasWaldmann> on a normal page that would be ok, but not on pages with dynamically generated content
2006-07-16T12:42:31  <xorAxAx> yep
2006-07-16T12:54:12  <ThomasWaldmann> only bites if you are not logged in, though
2006-07-16T12:55:30  <xorAxAx> the vary line is broken as well
2006-07-16T12:55:41  <xorAxAx> it has to be lang, cookie etc., not UA
2006-07-16T13:04:41  <ThomasWaldmann> there is a comment above it about ua
2006-07-16T13:10:11  <ThomasWaldmann> we have code for vary: accept-language btw
2006-07-16T13:15:06  <ThomasWaldmann> also for Vary: Cookie
2006-07-16T13:15:29  <ThomasWaldmann> strange that I didnt see that stuff in the headers, though
2006-07-16T13:25:33  <ThomasWaldmann> setHttpHeaders for modpy is likely broken
2006-07-16T13:25:40  <Kepplar> Hmm
2006-07-16T13:26:35  <ThomasWaldmann> it doesnt use append, but [key], so for some header type, it is likely it only emits last header of some specific type (key)
2006-07-16T13:31:27  <ThomasWaldmann> same is true for twisted
2006-07-16T14:11:18  <ThomasWaldmann> xorAxAx: look at i18n/__init__.py:288
2006-07-16T14:12:17  <ThomasWaldmann> do we need to set that vary: header there or can't it be set in general (at the same place the other vary: headers are set)?
2006-07-16T14:12:59  <ThomasWaldmann> (also checking for request.cfg.language_ignore_browser there)
2006-07-16T14:17:38  <ThomasWaldmann> i guess it is even wrong how it is done now
2006-07-16T14:19:00  <ThomasWaldmann> it only emits vary: accept-language on answers to requests with a valid wiki language. if it falls back to default_language or english, it doesn't emit a Vary: Accept-Language header at all.
2006-07-16T14:20:20  <xorAxAx> it should always emit it in request
2006-07-16T14:23:12  <ThomasWaldmann> ok, i change that...
2006-07-16T16:06:28  <ThomasWaldmann> bbl
2006-07-16T16:06:38  <ThomasWaldmann> Kepplar: hg pull
2006-07-16T16:06:45  <ThomasWaldmann> + merge
2006-07-16T16:20:34  <Kepplar> ok
2006-07-16T22:21:23  <ThomasWaldmann> moin
2006-07-16T22:41:50  <Kepplar> moin
2006-07-16T22:42:23  <Kepplar> ThomasWaldmann: im not sure how to deduce whats happening specificatially from an exception
2006-07-16T22:42:28  <Kepplar> IOError lets assume
2006-07-16T22:43:37  <ThomasWaldmann> reformulate your question
2006-07-16T22:51:25  <Kepplar> Sorry
2006-07-16T22:51:26  <Kepplar> er
2006-07-16T22:52:06  <Kepplar> I'm worked out the Exception model I'm going to implement. But I'm going to write my own custom Exceptions that the storage implementation layer must use
2006-07-16T22:52:18  <Kepplar> For flatfile this is often raised by IOError
2006-07-16T22:52:38  <Kepplar> Is it possible to work out from IOError what specifically is happening in more detail?
2006-07-16T23:07:34  <ThomasWaldmann> use grep
2006-07-16T23:24:22  <Kepplar> sorry?
2006-07-16T23:29:51  <xorAxAx> Kepplar: yes, put a "print dir(e)" into the exception handler to see its attributes
2006-07-16T23:30:14  <Kepplar> ah
2006-07-16T23:30:14  <Kepplar> nice
2006-07-16T23:30:20  <Kepplar> thats what i was looking for :)
2006-07-16T23:30:20  <Kepplar> ta
2006-07-16T23:30:33  <Kepplar> Oh btw, i got Muse tickets for this november =0#
2006-07-16T23:30:36  <Kepplar> =)
2006-07-16T23:30:48  <xorAxAx> muse is cool
2006-07-16T23:31:04  <Kepplar> Muse are my favourite group I think. In the UK they sell out in hours
2006-07-16T23:31:14  <Kepplar> This will be my third time seeing them Life
2006-07-16T23:31:15  <Kepplar> live*
2006-07-16T23:31:26  <xorAxAx> ugh, main stream :)
2006-07-16T23:31:42  <Kepplar> yea :/
2006-07-16T23:45:28  <xorAxAx> ThomasWaldmann: http://moin.pocoo.org:8080/moin-1.6-main?fd=274b021f26b1;file=MoinMoin/Page.py -- that change is incorrect
2006-07-16T23:46:42  <xorAxAx> ThomasWaldmann: because the file time isnt the main factor of cachability. consider e.g. the fullsearch macro or other request actions that make the request not cachable
2006-07-16T23:49:07  <xorAxAx> ThomasWaldmann: fields in the vary header have to be separated by commas (cp. section 2.1 of the HTTP RFC)
2006-07-16T23:49:26  <xorAxAx> i.e. i suggest reverting the above checkin
2006-07-16T23:49:49  <xorAxAx> (linked above)
2006-07-16T23:50:05  <xorAxAx> if there are still issues with twisted, it has an incorrect default value for the last modified header or something like that
2006-07-16T23:50:34  <xorAxAx> (and see section 14.44 of the HTTP RFC about vary exactly)