2007-09-11T00:15:27 <dreimark> that inline test fails currently
2007-09-11T00:17:43 <ThomasWaldmann> inline: was part of the 1.5 mess X)
2007-09-11T00:18:40 <ThomasWaldmann> strictly taken, inline: should have inlined the attachment
2007-09-11T00:19:30 <ThomasWaldmann> but it didnt do that in every case
2007-09-11T00:27:08 <dreimark> currently I cant test that case on test17, unsupported format character 'a' (0x61) at index 41
2007-09-11T00:27:25 <xorAxAx> ThomasWaldmann: can you please add www to moinmo.in?
2007-09-11T00:27:48 <xorAxAx> (additionally)
2007-09-11T00:30:17 <dreimark> gn
2007-09-11T09:48:36 <lanius> ThomasWaldmann: this seems more like a bug in the Permissions system which will be used by the storage layer was well
2007-09-11T12:12:16 <johill> dreimark: it could, I guess
2007-09-11T12:16:42 <ThomasWaldmann> the strange thing is that there is code handling the "deleted page" case by taking acls from rev n-1
2007-09-11T15:15:44 <lanius> have to take a deeper look...
2007-09-11T15:16:15 <dreimark> ThomasWaldmann: attachment spam on MM
2007-09-11T15:16:31 <dreimark> please kill Cone Dredge
2007-09-11T15:59:40 <dreimark> bbl
2007-09-11T16:22:56 * ThomasWaldmann killed Cone Dredge
2007-09-11T17:08:58 <ThomasWaldmann> does anyone oppose dropping the <link> tags in the html <head> referring to attachments?
2007-09-11T17:11:13 <ThomasWaldmann> (moin emits them even if the user has no acl rights)
2007-09-11T17:17:44 <xorAxAx> i havent yet recognized good use cases for them
2007-09-11T17:17:57 * ThomasWaldmann neither
2007-09-11T17:18:21 <ThomasWaldmann> ThomasAH told me that galeon use(d|s) them
2007-09-11T17:19:34 <xorAxAx> firefox can display them as well
2007-09-11T17:19:40 <xorAxAx> using some extension
2007-09-11T17:19:54 <xorAxAx> but you can always invoke the attachment action to see a lis
2007-09-11T17:19:54 <xorAxAx> t
2007-09-11T17:20:14 <xorAxAx> in fact, lynx users might be annoyed because lynx shows them as well
2007-09-11T17:20:30 <xorAxAx> (imagine a screen reader reading the names instead of the page itself)
2007-09-11T17:37:44 <ThomasWaldmann> bah, YAXSS
2007-09-11T17:39:55 <xorAxAx> hmm?
2007-09-11T17:46:28 <ThomasWaldmann> yet another...
2007-09-11T17:47:03 <xorAxAx> hehe
2007-09-11T18:16:22 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2830:c4ab7c81146d 1.7/ (MoinMoin/PageEditor.py docs/CHANGES): Fixed XSS issue in RenamePage/DeletePage action
2007-09-11T18:16:25 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2831:8f21cc746e81 1.7/MoinMoin/ (2 files in 2 dirs): merged main
2007-09-11T18:16:36 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2159:069b5c602045 1.6/ (MoinMoin/PageEditor.py docs/CHANGES): Fixed XSS issue in RenamePage/DeletePage action
2007-09-11T18:23:03 <ThomasWaldmann> dreimark: http://hg.moinmo.in/moin/1.5/rev/4a7de0173734 is missing a CHANGES entry
2007-09-11T18:28:30 <ThomasWaldmann> haha
2007-09-11T18:28:53 <ThomasWaldmann> moin sends attached file links with rel="Appendix"
2007-09-11T18:29:31 <ThomasWaldmann> was there maybe some confusion with attachment -> Anhang -> Appendix!?
2007-09-11T18:31:55 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 848:c99dd42f2c66 1.5/docs/CHANGES: CHANGES: added missing entry about GetVal fix
2007-09-11T18:37:35 <grzywacz> hello
2007-09-11T18:46:14 <ThomasWaldmann> moin grzywacz
2007-09-11T18:49:30 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 849:c8a7086b20c3 1.5/ (MoinMoin/wikiutil.py docs/CHANGES): respect ACLs when sending <link rel=Appendix ...> for attachments
2007-09-11T18:51:13 <ThomasWaldmann> dreimark: I'll add that CHANGES entry to 1.6/1.7, have to port my last change anyway
2007-09-11T18:55:31 <dreimark> ThomasWaldmann: ok,
2007-09-11T19:04:41 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2160:e4dc8f932d70 1.6/ (MoinMoin/theme/__init__.py docs/CHANGES): respect ACLs when sending <link rel="Appendix" ...> for attachments
2007-09-11T19:06:04 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2832:bda6fe7c015b 1.7/ (MoinMoin/theme/__init__.py docs/CHANGES): respect ACLs when sending <link rel="Appendix" ...> for attachments
2007-09-11T21:30:42 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2833:ea9a38d2ec09 1.7/MoinMoin/script/migration/_conv160_wiki.py: 1.6 converter: if ImageLink target is inline:..., then replace it with attachment: as we do not support inline: any more
2007-09-11T21:39:07 <dreimark> ThomasWaldmann: http://test17.wikiwikiweb.de/ReimarBauer?action=AttachFile&do=get&target=test_Pagedeletion.py
2007-09-11T21:39:28 <dreimark> I have no idea why this test fails if its called
2007-09-11T21:40:05 <dreimark> and if I put it into test_PageEditor at the end it goes well
2007-09-11T21:41:29 <dreimark> it tells AccessDenied: You are not allowed to delete this page!
2007-09-11T21:47:19 <ThomasWaldmann> maybe create a new PageEditor object for deleting
2007-09-11T21:48:20 <dreimark> ThomasWaldmann: nope
2007-09-11T22:02:22 <ThomasWaldmann> dreimark: if you are not Known, you have no delete rights
2007-09-11T22:03:16 *** ThomasWaldmann changes topic to "MoinMoin Developer Channel - User or third-party issues should go to #moin. Note that you are publicly logged here: http://moinmo.in/MoinMoinChat/Logs/moin-dev"
2007-09-11T22:13:54 <dreimark> ThomasWaldmann: I have to set gain_superuser_rights(self.request)
2007-09-11T22:14:27 <dreimark> and that is something completly different to the superuser var
2007-09-11T22:14:56 <ThomasWaldmann> yeah, that code should be rewritten, renamed and extended
2007-09-11T22:15:22 <dreimark> I have fixed the GetVal test
2007-09-11T22:25:50 <dreimark> needs further tests
2007-09-11T22:55:43 <dreimark> ThomasWaldmann: it looks like it goes well now with every test which does not use events
2007-09-11T22:56:22 <dreimark> if I exclude test_PageEditor and test_events it works
2007-09-11T22:56:56 <dreimark> I have only tested with those which are called before test_GetVal
2007-09-11T22:59:38 <xorAxAx> LOL
2007-09-11T22:59:59 <xorAxAx> the wiki used by google for the soc meeting planning truncates the wiki page when running their gui editor
2007-09-11T23:02:15 <ThomasWaldmann> that enforces refactoring :)
2007-09-11T23:04:08 <xorAxAx> hehe
2007-09-11T23:17:36 <grzywacz>
2007-09-11T23:17:36 <grzywacz>
2007-09-11T23:17:37 <grzywacz>
2007-09-11T23:17:42 <grzywacz>
2007-09-11T23:17:47 <grzywacz>
2007-09-11T23:18:17 <xorAxAx> grzywacz: i can completly understand that you prefer empty space
2007-09-11T23:18:52 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2834:7d4a6e369a5a 1.7/MoinMoin/ (_tests/test_PageEditor.py macro/_tests/test_GetVal.py): test_GetVal fixed, Creation Delete test for test_PageEditor
2007-09-11T23:21:33 <dreimark> if I exclude test_PageEditor and test_events it before test_GetVal goes well from the second call. It seems to need one call to change something
2007-09-11T23:21:50 <dreimark> then every call afterwards works too
2007-09-11T23:21:55 <ThomasWaldmann> know i know how it looks when the head crashes on the space key
2007-09-11T23:22:16 <xorAxAx> dreimark: well, something is mutating global state
2007-09-11T23:22:16 <ThomasWaldmann> s/^k//
2007-09-11T23:22:25 <xorAxAx> dreimark: and the source of that has to be fixed :)
2007-09-11T23:22:46 <dreimark> I fear it has something to do with events
2007-09-11T23:23:09 <xorAxAx> well, events dont modify global state
2007-09-11T23:23:24 <xorAxAx> (only event handler plugin loading does)
2007-09-11T23:23:35 <xorAxAx> did you have a look at the unit tests?
2007-09-11T23:24:37 <dreimark> something like events.get_handlers(request.cfg)--ß
2007-09-11T23:24:39 <dreimark> ?
2007-09-11T23:25:04 <xorAxAx> no
2007-09-11T23:25:09 <dreimark> request.cfg.event_handlers = [event_handler]?
2007-09-11T23:25:20 <xorAxAx> yes
2007-09-11T23:26:19 <dreimark> its in both routines
2007-09-11T23:26:29 <xorAxAx> and they dont change it back=
2007-09-11T23:28:18 <dreimark> doesn't look like
2007-09-11T23:28:41 <xorAxAx> weird
2007-09-11T23:28:44 <dreimark> someone who knows events better as me should fix that
2007-09-11T23:28:45 <xorAxAx> maybe grzywacz knows why :)
2007-09-11T23:28:56 <xorAxAx> dreimark: well, there is not much to know about it :)
2007-09-11T23:29:05 <xorAxAx> event_handlers is a list of functions
2007-09-11T23:29:16 <xorAxAx> but that looks like a broken test
2007-09-11T23:30:49 <dreimark> ok, have to leave
2007-09-11T23:30:52 <dreimark> gn
2007-09-11T23:31:05 <xorAxAx> c u dreimark
MoinMoin: MoinMoinChat/Logs/moin-dev/2007-09-11 (last edited 2007-10-29 19:12:47 by localhost)
