MoinMoin: MoinMoinChat/Logs/moin-dev/2007-09-17

2007-09-17T00:05:52  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2163:4ae8e12f2246 1.6/ (41 files in 13 dirs): backports from 1.7 branch: parsers, formatters, 1.6 migration scripts (see 1.7 branch for full history)
2007-09-17T00:05:54  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2164:1d4463f48b9d 1.6/MoinMoin/ (23 files in 8 dirs): change [[macro]] to <<macro>> in all built-in markup
2007-09-17T00:05:55  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2165:012ed404c96a 1.6/MoinMoin/ (_tests/test_PageEditor.py config/multiconfig.py user.py): change ["free link"] to [[free link]] in all built-in markup
2007-09-17T00:05:57  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2166:7d9cbec3a5aa 1.6/MoinMoin/script/migration/wikimarkup_converter.py: remove outdated file (replaced by _conv160*.py)
2007-09-17T00:05:58  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2167:d50a30166191 1.6/MoinMoin/_tests/test_wikidicts.py: fixed failing test
2007-09-17T00:06:01  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2168:1cb5c1e7147b 1.6/MoinMoin/parser/text_moin_wiki.py: wiki parser: better regex for links to avoid ambiguities between link params and transclusion params when the transclusion is the link description
2007-09-17T00:06:05  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2169:9349d8fdb1fd 1.6/MoinMoin/logfile/ (__init__.py editlog.py eventlog.py): backported logfile package from 1.7 (migration scripts need it)
2007-09-17T00:06:10  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2170:49af9f6a514d 1.6/ (70 files in 18 dirs): merged wiki parser backport from 1.7
2007-09-17T00:52:01  <ThomasWaldmann> everyone feel invited to test moinmaster.wikiwikiweb.de, it runs on 1.6 code and converted data
2007-09-17T01:51:17  * ThomasWaldmann converts i18n pages
2007-09-17T02:17:04  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2171:c7d4c9eaf3d2 1.6/MoinMoin/i18n/ (34 files): updated i18n
2007-09-17T09:29:18  <ThomasWaldmann> dreimark: what is that new i18n code supposed to do?
2007-09-17T09:30:59  <ThomasWaldmann> looks like it replaces e.g. %A1 to %%A1, but does not replace %5D to %%5D
2007-09-17T09:31:13  * ThomasWaldmann suggests completely reverting this stuff
2007-09-17T09:31:23  <dreimark> yeah
2007-09-17T09:31:37  <dreimark> its ugly
2007-09-17T09:31:49  <dreimark> and slow
2007-09-17T09:32:58  <xorAxAx> WTF?
2007-09-17T09:33:24  <ThomasWaldmann> good morning xorAxAx :)
2007-09-17T09:33:37  <xorAxAx> good morning
2007-09-17T09:34:19  <ThomasWaldmann> watched too much papa roach this night? :D
2007-09-17T09:34:46  <xorAxAx> no, just had a look at the changeset
2007-09-17T09:35:49  <ThomasWaldmann> you followed the discussion about the original problem?
2007-09-17T09:35:50  <dreimark> and what's your idea to solve that % -> %% ?
2007-09-17T09:37:09  <xorAxAx> ThomasWaldmann: no, but the changeset itself looks bonkers
2007-09-17T09:37:12  <xorAxAx> esp. without a test
2007-09-17T09:38:19  <xorAxAx> i dont understand the problem
2007-09-17T09:38:26  <xorAxAx> can anyone describe it shortly?
2007-09-17T09:38:29  <ThomasWaldmann> the problem dreimark tried to solve is that i18n with wiki markup can contain %XX (in urls) and if it is used on left side of % operator, this leads to problems
2007-09-17T09:38:53  <xorAxAx> ???
2007-09-17T09:39:09  <ThomasWaldmann> e.g. %C3 gives unsupported format char C
2007-09-17T09:39:10  <xorAxAx> ok, well
2007-09-17T09:39:35  <xorAxAx> basically you would need a formatter arg
2007-09-17T09:39:48  <xorAxAx> or a subclassed formatter
2007-09-17T09:39:58  <xorAxAx> i dont see how anything else could solve it cleanly
2007-09-17T09:40:10  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> default * 2172:61fc78b9cad5 1.6/MoinMoin/i18n/__init__.py: i18n.__init__ reverted to 2160:e4dc8f932d70
2007-09-17T09:40:15  <xorAxAx> (i think a subclassed formatter would be best
2007-09-17T09:40:20  <ThomasWaldmann> i guess it might be even harder than this
2007-09-17T09:40:21  <xorAxAx> dreimark: did you use hg backout?
2007-09-17T09:40:24  <xorAxAx> ThomasWaldmann: why?
2007-09-17T09:40:44  <dreimark> xorAxAx: hg revert -are 2160 __init__.py
2007-09-17T09:40:51  <xorAxAx> dreimark: ok
2007-09-17T09:40:56  <xorAxAx> dreimark: wait
2007-09-17T09:40:58  <ThomasWaldmann> because something is maybe not using the formatter (not sure)
2007-09-17T09:41:00  <dreimark> -are
2007-09-17T09:41:04  <dreimark> - are is are
2007-09-17T09:41:18  <dreimark> are
2007-09-17T09:41:19  <xorAxAx> dreimark: that will destroy any other new changes if there were any later ones
2007-09-17T09:41:33  <xorAxAx> dreimark: backout is much better for more complex scenarios
2007-09-17T09:41:43  <xorAxAx> (you can also check if there are new changes of course)
2007-09-17T09:41:50  <xorAxAx> ThomasWaldmann: ?
2007-09-17T09:42:04  <xorAxAx> ThomasWaldmann: the i18n is sometimes piped through the wikiparser/formatter toolchain
2007-09-17T09:42:28  <dreimark> I did hg diff before and it was only my changes removed
2007-09-17T09:42:40  <xorAxAx> most often even. and in those cases, the formatter needs to generate correctly double-escaped stuff for places where the user didnt explicitly use %
2007-09-17T09:42:42  <dreimark> and I reverted only one routine not all
2007-09-17T09:42:51  <xorAxAx> (i.e. in URLs only i think)
2007-09-17T09:42:59  <xorAxAx> dreimark: yeah
2007-09-17T09:43:00  <dreimark> its not only in urls
2007-09-17T09:43:05  <xorAxAx> dreimark: where else?
2007-09-17T09:43:23  <dreimark> strange signs in words too
2007-09-17T09:43:28  <xorAxAx> ?
2007-09-17T09:43:35  <xorAxAx> example please
2007-09-17T09:46:14  <dreimark> check for fullsearch.py err = _('Your search query in french
2007-09-17T09:46:27  <xorAxAx> ?
2007-09-17T09:47:21  <xorAxAx>  2351: "Le texte de cette recherche, « {{{%s}}} », est incorrect. Veuillez consulter "
2007-09-17T09:47:32  <xorAxAx> so where is the problem?
2007-09-17T09:49:43  <dreimark> may be your editor does not show the words right
2007-09-17T09:49:58  <dreimark> oops, my mistake look in spanish
2007-09-17T09:50:08  <dreimark> http://moinmo.in/MoinMoinBugs/1.6ErrorWhenFindNoResults
2007-09-17T09:51:02  <dreimark> La búsqueda de {{{\"%s\"}}} no es válida. Por favor visita
2007-09-17T09:52:47  <dreimark> xorAxAx:
2007-09-17T10:01:52  <dreimark> bbl some talks
2007-09-17T10:04:26  <xorAxAx> that still looks ok, where is the problem?
2007-09-17T10:29:54  <dreimark> it is translated to som %D too
2007-09-17T10:30:11  <dreimark> escaped
2007-09-17T10:33:10  <xorAxAx> dreimark: why what code?
2007-09-17T10:49:29  <dreimark> xorAxAx: tested here again xorAxAx is right only urls. I should transfer my example test to real tests always too.
2007-09-17T10:51:54  <dreimark> I would prefer someone of you would fix it more cleanly and I could learn from that :)
2007-09-17T10:53:40  <dreimark> and in general I do wonder a bit why its not a builtin in function in python to escape % too ifs wanted.
2007-09-17T12:39:49  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2173:b28c054340be 1.6/MoinMoin/search/results.py: search results: fix calculation of current/total result pages to use integers only (fixes DeprecationWarnung for range() with floats)
2007-09-17T13:25:46  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2174:5a5dc39a8a87 1.6/MoinMoin/security/antispam.py: antispam: MoinMaster wiki shall not fetch updates from itself
2007-09-17T13:27:38  <TheSheep> O.o
2007-09-17T13:28:33  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2175:ff3be59076fc 1.6/MoinMoin/parser/text_moin_wiki.py: <object> does not allow 'alt' attr
2007-09-17T13:32:14  <TheSheep> ThomasWaldmann: it does, you just put the alt text as the contents of the element, between <object> and </object>
2007-09-17T13:32:39  <ThomasWaldmann> yeah, but it definitely has no alt attr :)
2007-09-17T13:42:15  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2176:4d601d25eb5a 1.6/MoinMoin/Page.py: Save action: avoid exception for non-ascii pagenames
2007-09-17T17:48:57  <dreimark> is it to late for a new config var in multiconfig.py for 1.6?
2007-09-17T17:49:18  <dreimark> I would prefer something like mission_statement = you''
2007-09-17T17:51:20  <dreimark> And used in user.mailAccountData  inserted before Somebody  has requested to subm ...
2007-09-17T17:52:56  <dreimark> so its easy to add some info about the wiki into the mail
2007-09-17T17:55:17  <ThomasWaldmann> isn't the url contained in the mail?
2007-09-17T17:57:17  <ThomasWaldmann> btw, you should really switch off that magic in your irc client. it does more confusion than help.
2007-09-17T18:05:15  <dreimark> searching for that switch
2007-09-17T18:06:17  <dreimark> ThomasWaldmann: I think more on something like: Welcome  to  MyWiki. This wiki is about ...
2007-09-17T18:10:27  <dreimark> but its not urgent.
2007-09-17T18:21:24  <ThomasWaldmann> that stuff has to be on the Front Page
2007-09-17T18:21:44  <ThomasWaldmann> so if we have a link to the wiki in the mail, this should be enough
2007-09-17T18:30:21  <dreimark> The situation is different if  you create an account for someone and do send the password. You do want to tell something about the wiki and don't want to do it in a second mail
2007-09-17T18:36:12  <ThomasWaldmann> yeah, that's what a hyperlink is for :)
2007-09-17T18:36:49  <ThomasWaldmann> "You have been invited to the <sitename> wiki, please see all details about it on <siteurl>."
2007-09-17T18:37:46  <dreimark> :)
2007-09-17T18:39:33  <dreimark> btw. we have a new diff on moinmaster ?
2007-09-17T18:40:29  <ThomasWaldmann> it is 1.6 (what did change?)
2007-09-17T18:40:48  <dreimark> looks like hg diff
2007-09-17T18:41:10  <ThomasWaldmann> url?
2007-09-17T18:41:39  <dreimark> http://master.moinmo.in/action/diff/HelpOnSynchronisation?action=diff&date=1181652591000000
2007-09-17T18:42:11  <ThomasWaldmann> looks like ever
2007-09-17T18:42:56  <ThomasWaldmann> (but the hg display looks a bit different since the 0.9.3 -> 0.9.4 upgrade)
2007-09-17T18:48:24  <dreimark> hmm, http://moinmo.in/ReimarBauer?action=AttachFile&do=view&target=diff.png
2007-09-17T18:48:34  <dreimark> that's how it looks for me
2007-09-17T18:50:47  <dreimark> ThomasWaldmann: ?
2007-09-17T18:51:24  <ThomasWaldmann> [X] Unterschiede farbig markiert anzeigen
2007-09-17T18:51:58  <ThomasWaldmann> (on UserPreferences)
2007-09-17T18:53:11  <dreimark> its missing in my userprefs
2007-09-17T18:53:31  <dreimark> no its show fancy diffs
2007-09-17T18:54:52  <dreimark> its not translated, could be that I ve switched that off today in the morning as I have checked another lang
2007-09-17T19:12:07  <dreimark> bbl
2007-09-17T19:44:16  <grzywacz> hi
2007-09-17T19:45:01  <xorAxAx> hi grzywacz
2007-09-17T20:05:21  <ThomasWaldmann> moin grzywacz
2007-09-17T20:06:29  <grzywacz> hello ThomasWaldmann
2007-09-17T22:12:04  <dreimark> bb