MoinMoin: MoinMoinChat/Logs/moin-dev/2008-01-23

2008-01-23T00:00:38  <ThomasWaldmann> bolekk_: what was the problem?
2008-01-23T00:02:30  <bolekk_> ThomasWaldmann: 1. function FCK.CreateLink in 2.2 returned only one link, now it returns an array of links (+ takes an additional argument)
2008-01-23T00:03:26  <ThomasWaldmann> ah, ok
2008-01-23T00:04:04  <bolekk_> ThomasWaldmann: 2. In 2.5.1 there is no 'startsWith' string function implemented
2008-01-23T00:05:11  <bolekk_> actually the whole fckcoreextensions.js file (some useful functions) is missing and moin relies on it in some places
2008-01-23T00:06:32  <bolekk_> in particular, we use startsWith function in 3 places, is it a good idea to implement it now (as ours) in e.g. some separate plugin ?
2008-01-23T00:06:52  <bolekk_> maybe not in a plugin
2008-01-23T00:08:08  <ThomasWaldmann> strange. how does FCKeditor do it internally now?
2008-01-23T00:08:11  <bolekk_> second solution is to just use some string operations instead, not too much code actually
2008-01-23T00:09:42  <bolekk_> do what ? use 'startsWith' ? I don't know, maybe it is renamed and moved somewhere else. Or maybe it is simply replaced with simpler stirng operations
2008-01-23T00:09:58  <bolekk_> return ( this.substr( 0, value.length ) == value ) ;
2008-01-23T00:10:03  <ThomasWaldmann> use grep on the old src and then look at the new
2008-01-23T00:10:29  <bolekk_> this was its previous implementation, not much to create a new function
2008-01-23T00:10:45  <bolekk_> I did it, no results on the new source
2008-01-23T00:11:06  <ThomasWaldmann> so he "expanded" all calls?
2008-01-23T00:12:24  <bolekk_> it was called from 8 places, i'll check one or two ..
2008-01-23T00:14:37  <bolekk_> heh, they renamed it into 'StartsWith' :>
2008-01-23T00:15:13  <bolekk_> good thing to now, I'll save 3 lines of code:p
2008-01-23T00:15:55  <ernestas> 3 lines + 3 lines +... and you have no code left anymore :) anyway, gn
2008-01-23T00:16:30  <bolekk_> gn ernestas
2008-01-23T00:17:41  <ThomasWaldmann> hehe
2008-01-23T00:20:13  <bolekk_> the selection plugin seems to be working now as well, the problem was in the way it detected the browser. It checked the existance of some browser-specific functions of FCK.EditorDocument
2008-01-23T00:21:13  <bolekk_> but now at the time of this checking FCK.EditorDocument = none, I'm guessing that the loading order could have changed
2008-01-23T00:22:01  <bolekk_> I replaced it with FCKBrowserInfo.IsGecko & FCKBrowserInfo.IsIE
2008-01-23T00:22:12  <bolekk_> I'll test it more extensively
2008-01-23T00:23:34  <ThomasWaldmann> hey, sounds good :)
2008-01-23T00:24:06  <ThomasWaldmann> btw, when you have some insights about that code, please put in some comments :)
2008-01-23T00:26:25  <bolekk_> into the code or task tracker ?
2008-01-23T00:27:19  <ThomasWaldmann> into the code
2008-01-23T00:27:38  <bolekk_> these IsIE, IsGecko funcitons were available also in 2.2 , I wonder why they weren't used..
2008-01-23T00:53:57  <bolekk_> good night
2008-01-23T00:55:05  <CIA-35> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 856:db212dfc58ef 1.5/ (MoinMoin/action/AttachFile.py docs/CHANGES): fix XSS issues in AttachFile action
2008-01-23T01:32:23  <CIA-35> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2517:fb56e317fadd 1.6/ (MoinMoin/script/migration/_conv160_wiki.py docs/CHANGES): support STONEAGE_IMAGELINK for very old versions of ImageLink with interchanged target and image
2008-01-23T01:32:27  <CIA-35> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2518:5a2d82899c9b 1.6/MoinMoin/ (_tests/test_user.py user.py): merged main
2008-01-23T01:44:15  * ThomasWaldmann hopes we get rid of that AttachFile annoyance soon
2008-01-23T02:31:40  <ThomasWaldmann> we got 425 downloads of moin 1.6.0 from a single IP yesterday 8(
2008-01-23T07:24:32  <ninnnu> For GHOPpers: http://groups.google.com/group/ghop-announce/browse_thread/thread/e5dd796f845e5c5d
2008-01-23T09:18:11  <dreimark> moin
2008-01-23T10:13:06  <cb22> ninnnu: thanks
2008-01-23T10:13:41  <cb22> never even knew there was such a list
2008-01-23T11:36:56  <bolekk> moin
2008-01-23T12:00:24  <ThomasWaldmann> moin
2008-01-23T14:33:07  <kikka> hello
2008-01-23T15:27:47  <rpodgorny> hi! is there really a change in the 1.6 behaviour that the attachments get linked with do=view instead of do=get? how do i get the old behaviour back?
2008-01-23T18:11:38  <johill> dreimark: sorry, only just recovering from a bad cold with 40 fever and not online for long
2008-01-23T18:11:56  <johill> dreimark: send mail about anything you need answered this week, I won't be catching up to irc
2008-01-23T19:18:22  <grzywacz> moin
2008-01-23T20:20:50  <cb22> just wondering if i could please get some comments on the table at http://moinmo.in/ParserMarket the one with GDL and Gallery2 in.
2008-01-23T21:41:47  <dreimark> johill: get well soon, xorAxAx has helped me, I will send a mail later.
2008-01-23T21:46:52  <dreimark> cb22: if ParserMarket/Gallery2/ReleaseNotes alwyas in each line used same written,think about changing the cell to use more lines
2008-01-23T21:47:28  <dreimark> This Gallery2 parser is u... Gallery2 should better not link to a version
2008-01-23T21:47:49  <dreimark> because that needs many fixes later on too or people will get always old versions
2008-01-23T21:48:18  <dreimark> a backlink to the "main" page would be better
2008-01-23T21:48:50  <dreimark> REQUIRED IMAGES should be linked to the images
2008-01-23T21:49:48  <dreimark> some parts of this page I will refactor with the next update, some parts are outdated, because of 1.6
2008-01-23T22:00:22  <dreimark> the table is nice, may be use the same description form the subpage
2008-01-23T22:00:45  <dreimark> I think this could be done by Include
2008-01-23T22:02:13  <cb22> dreimark: yes, that would be nice. is it possible to just inclde a little bit like that?
2008-01-23T22:02:46  <dreimark> http://moinmo.in/HelpOnMacros/Include
2008-01-23T22:02:54  <dreimark> from to is what you want
2008-01-23T22:03:54  <cb22> thanks :) i'm going to have a lot more time to work on this on the weekend
2008-01-23T22:04:20  <dreimark> fine
2008-01-23T22:04:25  <cb22> anyways, gn all
2008-01-23T22:04:53  <dreimark> nn cb22
2008-01-23T22:42:56  <dreimark> someone like to claim Issue 25 - too late for any google prizes
2008-01-23T22:44:02  <dreimark> good night