2008-05-08T00:06:15 <ThomasWaldmann> zenhase: please update the wiki page with the current status
2008-05-08T00:52:01 <zenhase> xorAxAx: no. it's a disaster
2008-05-08T00:52:17 <zenhase> ThomasWaldmann: FieldStorage uses tempfile
2008-05-08T00:53:33 <ThomasWaldmann> i am fixing it right now
2008-05-08T00:56:12 <zenhase> uhm, sorry. i should have said something that i was away for the evening
2008-05-08T00:59:01 <zenhase> how are you fixing it?
2008-05-08T01:02:10 <ThomasWaldmann> just not reading item.value if the item is a cgi.FieldStorage and item.file is not None
2008-05-08T01:02:30 <ThomasWaldmann> instead, pass item.file instead of item.value
2008-05-08T01:03:36 <ThomasWaldmann> add_attachment gets a change so it detects if it gets a str (direct file content) or a file (file content in e.g. a tempfile)
2008-05-08T01:04:10 <zenhase> uhm
2008-05-08T01:04:38 <zenhase> i tried something like this earlier today
2008-05-08T01:04:56 <zenhase> but my first quick fix at this threw some errors with decodeArgs
2008-05-08T01:05:07 <zenhase> so i still pondered on the problem
2008-05-08T01:09:58 * ThomasWaldmann tries first upload
2008-05-08T01:10:07 <zenhase> http://paste.pocoo.org/show/48533/
2008-05-08T01:10:34 <zenhase> this was the fix in request ... also modified Load.py and AttachFile.py in actions accordingly
2008-05-08T01:10:44 <zenhase> this is what i got http://paste.pocoo.org/show/48531/
2008-05-08T01:24:27 <ThomasWaldmann> it uses self.file for other reasons, too :|
2008-05-08T01:32:36 <zenhase> hmm?
2008-05-08T01:33:00 <ThomasWaldmann> works when checking for .filename instead of .file
2008-05-08T01:33:56 <zenhase> ah ok
2008-05-08T01:34:31 <zenhase> ah, i got it :/
2008-05-08T01:34:57 <zenhase> it uses .file almost all the time ... it's stringio for the small ones, tempfile for everything bigger
2008-05-08T01:35:23 <zenhase> well, as i said ... cgi.py is a huge pile of crap imo :o
2008-05-08T01:35:42 <zenhase> the code is utterly unreadable and ill-structured
2008-05-08T02:03:01 <gizmach> gn
2008-05-08T02:08:13 <ThomasWaldmann> gn gizmach
2008-05-08T02:09:32 <ThomasWaldmann> zenhase: ok, my fix seems to work. I'll look at it tomorrow again (when more awake than now) and either post a patch for review or commit it.
2008-05-08T02:09:43 <ThomasWaldmann> gn
2008-05-08T08:21:18 <ThomasWaldmann> moin
2008-05-08T08:46:25 <dreimark> moin
2008-05-08T08:52:02 <ThomasWaldmann> does anyone here have a mod_python and/or twisted test environment?
2008-05-08T09:21:22 <gizmach> moin
2008-05-08T09:29:24 <dreimark> gizmach: that (97, []) is it always 97 ? or waht is the reason for that number?
2008-05-08T09:37:06 <gizmach> dreimark: for succed binding it's always 97
2008-05-08T09:37:56 * moon ´ÔÀº ºÎÀçÁßÀ̽ʴϴÙ.(I have some meeting outdoor :-))
2008-05-08T09:39:29 <xorAxAx> moon: your message was black on black, also it might make sense to turn off the away message
2008-05-08T09:43:11 <gizmach> dreimark: and when I got an error while binding, it just raise an error when I tried to do ldapObject.result() it didn't write some (number,[something])
2008-05-08T10:10:22 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3568:6fe1ea4d9d1a 1.7/MoinMoin/ (5 files in 3 dirs): use the open temporary file for file uploads (fixes big memory consumption for big file uploads) - Twisted and mod_python is completely untested
2008-05-08T10:17:55 * gizmach is trying to find some food
2008-05-08T10:21:47 <ThomasWaldmann> nwp: are you still using mod_python?
2008-05-08T10:32:38 <gizmach> back
2008-05-08T10:32:57 <gizmach> no food in neighbourg :D
2008-05-08T11:04:48 <dreimark> gizmach: oh, so you are still hungry?
2008-05-08T11:05:21 <gizmach> dreimark: yes :( but I'll go a bit later to eat something more than just snack
2008-05-08T11:05:36 <gizmach> dreimark: but now I'm going to look at some moin code :)
2008-05-08T11:06:33 <dreimark> can you please add the name of the exception to the description
2008-05-08T11:06:56 <johill> oi. I wonder if the 1.6 cookie scheme is also vulnerable to splicing
2008-05-08T11:06:58 <dreimark> feel free to ask if you got questions
2008-05-08T11:07:44 <johill> hmm. no. good :)
2008-05-08T11:07:49 <gizmach> dreimark: sure :)
2008-05-08T11:08:00 * gizmach just opens ldap_login.py
2008-05-08T11:08:29 <dreimark> johill: you do revert to the http://securitytracker.com/id?1019923 ?
2008-05-08T11:08:36 <dreimark> refer
2008-05-08T11:09:12 <johill> dreimark: yes, I just read it on lwn tho
2008-05-08T11:15:54 <gizmach> dreimark: added, hope it's that you wanted
2008-05-08T11:16:15 <dreimark> johill: zlib http://securitytracker.com/alerts/2008/Apr/1019823.html
2008-05-08T11:17:18 <dreimark> gizmach: thanks
2008-05-08T11:17:38 <gizmach> dreimark: it was my pleasure :)
2008-05-08T11:24:35 <johill> dreimark: zlib? do we care?
2008-05-08T11:25:21 <johill> oh, python zlib. funky
2008-05-08T11:25:29 <johill> why does it not just link teh regular zlib anyway?
2008-05-08T11:26:03 <johill> ah it does
2008-05-08T11:26:11 <johill> the wrapper is just buggered
2008-05-08T12:11:22 <gizmach> bye all
2008-05-08T12:40:53 <dreimark> johill: various filter, tarfile, bdiff
2008-05-08T12:42:03 <johill> right. but can the argument there ever be injected by a malicious user?
2008-05-08T12:42:39 <xorAxAx> in bdiff it can
2008-05-08T12:43:01 <xorAxAx> johill: cpy usually links with the system zlib
2008-05-08T12:45:50 <johill> yeah I read all that wrongly first
2008-05-08T12:47:27 <dreimark> bbl
2008-05-08T13:34:42 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2644:b5cab2999450 1.6/MoinMoin/search/Xapian.py: Xapian indexing: index CategoryFoo correctly as CategoryFoo, not Foo (only works for default category regex (english), needs more work)
2008-05-08T13:34:43 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2645:fca832a19d32 1.6/MoinMoin/ (5 files in 3 dirs): use the open temporary file for file uploads (fixes big memory consumption for big file uploads) - Twisted and mod_python is completely untested (backport from 1.7)
2008-05-08T13:34:44 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2646:801e1c808bc3 1.6/docs/CHANGES: updated CHANGES
2008-05-08T13:36:23 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3569:7593b6b4590c 1.7/MoinMoin/search/Xapian.py: Xapian indexing: index CategoryFoo correctly as CategoryFoo, not Foo (only works for default category regex (english), needs more work)
2008-05-08T14:14:08 <dreimark> johill: small FR for token expiration
2008-05-08T14:14:46 <dreimark> can we get the msg. Your token is invalid! at the moment one uses the url with an invalid token
2008-05-08T14:15:56 <dreimark> and not after entering a new password
2008-05-08T14:20:04 * moon ´ÔÀÌ ºÎÀçÁß¿¡¼ µ¹¾Æ¿À¼Ì½À´Ï´Ù.(I have some meeting outdoor :-))
2008-05-08T14:30:46 <ThomasWaldmann> moon: please switch off your away message
2008-05-08T14:31:25 <moon> yes, I turn off message. sorry :-)
2008-05-08T14:31:51 <ThomasWaldmann> bbl
2008-05-08T14:34:53 <johill> dreimark: not easily, actually
2008-05-08T14:35:21 <johill> because the code is now factored to just apply the token w/ new passwd
2008-05-08T14:35:34 <johill> anyway, back in maybe 2h
2008-05-08T15:08:28 <xorAxAx> moon: esp. because the message is not in utf-8
2008-05-08T15:08:55 <xorAxAx> but i guess koreans are cjk unification opponents like the japanese are :)
2008-05-08T15:10:43 <moon> xorAxAx: I just know that. my irc client is modification version of mirc. maybe modificator change away message.
2008-05-08T15:11:24 <xorAxAx> moon: mirc got utf-8 support only a few months ago
2008-05-08T15:34:53 <dreimark> I got a 500 from RC on one of my fcgi wikis
2008-05-08T15:41:25 <dreimark> edit-log was about 3MB and almost all entries from unizip
2008-05-08T15:56:57 * dreimark looks at RC
2008-05-08T16:03:08 <dreimark> TheSheep: I do think about a prev and next button on the attachfile view to scroll to a preview of the files there
2008-05-08T16:05:40 <dreimark> for 1.8
2008-05-08T16:20:37 <TheSheep> dreimark: probably better to just have an alphabetic index once you hit some limit
2008-05-08T16:21:29 <TheSheep> you know, so that you hve some preview context
2008-05-08T16:36:11 <dreimark> ThomasWaldmann: http://moinmo.in/ReimarBauer?action=AttachFile&do=view&target=AttachFile_unzip_edit-log.patch
2008-05-08T16:36:28 <dreimark> if one has always lots of files to unzip
2008-05-08T16:36:58 <dreimark> RC got's extremly slow and sometimes I get a 500
2008-05-08T16:37:24 <dreimark> I think not every unzip line needs to be added to edit-log
2008-05-08T16:39:30 <dreimark> xorAxAx: http://moinmo.in/MoinMoinBugs/SpidersCanNotRenderAsDocbook
2008-05-08T16:41:13 * dreimark does not know should cry or laugh
2008-05-08T17:24:23 <gizmach> moin
2008-05-08T17:35:04 <xorAxAx> dreimark: well, i dislike the spider machinery
2008-05-08T17:36:41 <gizmach> dreimark: find answer
2008-05-08T17:37:17 <johill> xorAxAx: seconded
2008-05-08T18:08:42 * dreimark too
2008-05-08T18:10:32 <dreimark> htg bbl
2008-05-08T18:45:48 <ThomasWaldmann> dreimark: i have doubts that "at all %d files unzipped" % count is good english - any comments from a native speaker?
2008-05-08T18:46:13 <ThomasWaldmann> maybe rather "total %(count)d files unzipped"?
2008-05-08T18:47:05 <johill> even while I'm not native "at all" is definitely not right ;)
2008-05-08T18:47:09 <ThomasWaldmann> also it is technically a problem, because the place where this comment is put usually contains the filename
2008-05-08T18:47:29 <ThomasWaldmann> johill: not right at all :)
2008-05-08T18:47:34 <johill> heh
2008-05-08T18:47:47 <johill> "unzipped %d files from %s"?
2008-05-08T18:47:57 <johill> (of course, unzipped isn't really right either)
2008-05-08T18:48:46 <johill> (since a zipper is a "Reißverschluss")
2008-05-08T18:49:20 <johill> maybe better "unpacked"
2008-05-08T18:49:32 <johill> anyway, hungry
2008-05-08T20:25:07 <ThomasWaldmann> re
2008-05-08T20:42:53 <gizmach> re
2008-05-08T21:15:03 <ThomasWaldmann> gizmach: and, how's py.test?
2008-05-08T21:16:16 <gizmach> ThomasWaldmann: in sleeping mode just like me... I tried it on some things not related to moin.... Now looking at ldap_auth
2008-05-08T21:54:41 <ThomasWaldmann> i think we should rename ./moin.py in 1.7
2008-05-08T21:55:13 <ThomasWaldmann> new name? moinmoin.py? moin_serve.py? start_moin.py?
2008-05-08T21:55:52 <ThomasWaldmann> (this is to solve the confusion moin.py standalone server vs. moin script command)
2008-05-08T21:58:05 <vpv> +1, moin_serve.py would be nice (or leave it as is and rename the script command to moin_script.py or something=
2008-05-08T21:59:15 <ThomasWaldmann> i guess the latter would make more doc changes necessary
2008-05-08T22:34:42 <dreimark> hmm +1 for the latter one changed to moin_setup or moin_configure or something similiar and doing the doc changes
2008-05-08T22:35:12 <dreimark> because since 1.7 it can be used to serve too
2008-05-08T22:36:38 <dreimark> ThomasWaldmann:
2008-05-08T22:41:42 <dreimark> if it is too much doc changes we should shift the change to 1.8
2008-05-08T22:42:48 <ThomasWaldmann> moin_setup/configure is too specific (and wrong)
2008-05-08T22:44:00 <ThomasWaldmann> and changing the server start script (which is a wrapper around the moin command in 1.7) is much easier than changing the command name
2008-05-08T22:44:47 <ThomasWaldmann> also, the command has often to get typed in, so it should be short - the server is often just clicked or autostarted somehow
2008-05-08T22:45:10 <dreimark> know too and is easier currently and I do have no problem in renaming it later again
2008-05-08T22:45:48 <dreimark> I do think we will rename it later
2008-05-08T22:46:22 <dreimark> (my feeling)
2008-05-08T22:49:18 <dreimark> it is something like the swiss knife while the other is only something like an alias to a specific function
2008-05-08T22:49:39 <dreimark> which "new" user will try out often
2008-05-08T22:50:09 <ThomasWaldmann> the point is to solve the problem that new users confuse both things
2008-05-08T22:51:33 <dreimark> if we rename the server start script to desktopedition or moin_desktop it is quite clear
2008-05-08T22:51:43 <dreimark> for other purposes too
2008-05-08T22:52:10 <dreimark> relaxed security, special config, standalon ...
2008-05-08T22:53:44 <dreimark> I do agree with the suggestion to rename this one
2008-05-08T22:55:10 <dreimark> (I do think we will later add a attribute to the other moin command too)
2008-05-08T22:56:52 * ThomasWaldmann looks at stemming
2008-05-08T23:02:48 <ThomasWaldmann> quick poll: beta2 or rc1 next weekend? :)
2008-05-08T23:04:32 <dreimark> rc1
2008-05-08T23:07:00 <dreimark> one should fix the rtl pages for &template on master17
2008-05-08T23:07:57 * dreimark will ask nir tom.
2008-05-08T23:18:10 <ThomasWaldmann> MoinMoin.search.queryparser:335+ does anybody get the sense?
2008-05-08T23:29:17 <dreimark> strange, first time I recognized util.chartypes
2008-05-08T23:30:19 <dreimark> gn
2008-05-08T23:31:17 <ThomasWaldmann> gn dreimark
MoinMoin: MoinMoinChat/Logs/moin-dev/2008-05-08 (last edited 2008-05-07 22:15:02 by IrcLogImporter)
