MoinMoin: MoinMoinChat/Logs/moin-dev/2008-05-12

2008-05-12T05:50:15  <GomoX> Hey
2008-05-12T05:50:26  <livibetter> Hi! see you again
2008-05-12T05:50:36  <GomoX> You can help me in here? :P
2008-05-12T05:50:46  <livibetter> no, just ask your question, they can
2008-05-12T05:50:52  <GomoX> Ok
2008-05-12T05:50:59  <GomoX> I am trying to write a macro
2008-05-12T05:51:12  <GomoX> that will produce a WikiLink
2008-05-12T05:51:48  <GomoX> I cannot just output an href since that is not a "real" wikilink
2008-05-12T05:51:54  <GomoX> How do you do this?
2008-05-12T05:52:55  <lesterc> livibetter: didn't know about this channel either!
2008-05-12T05:53:09  <livibetter> hehe...
2008-05-12T05:53:42  <livibetter> GomoX: please be patience, they will answer
2008-05-12T05:53:57  <GomoX> Ok, no hurry :)
2008-05-12T05:54:35  <livibetter> I have look deeper in source, do you mind share your macro you have now with me?
2008-05-12T05:54:52  <livibetter> I may learn something from it
2008-05-12T05:55:55  <livibetter> * should be I haven't looked
2008-05-12T05:56:46  <lesterc> GomoX: from memory you can either return raw html or wiki markup from macro.
2008-05-12T06:01:36  <GomoX> it doesn't get parsed
2008-05-12T06:01:45  <GomoX> If I return "MyWikiLink" from a macro
2008-05-12T06:01:51  <GomoX> I get plaintext, not a link
2008-05-12T06:02:40  <livibetter> you want to translate WikiLink to a link?
2008-05-12T06:02:58  <GomoX> yes
2008-05-12T06:03:35  <livibetter> then you can try to find out how MoinMoin do that
2008-05-12T06:09:50  <GomoX> not as easy as it sounds :/
2008-05-12T06:19:13  <livibetter> try wikiutil.py link_tag()
2008-05-12T06:22:56  <GomoX> livibetter: that looks like it will create a regular link, not a wikilink
2008-05-12T06:23:21  <livibetter> I thought that's you want... hehe
2008-05-12T06:24:09  <GomoX> I want a wikilink
2008-05-12T06:24:27  <GomoX> When you manuall edit a page and enter "This is a WikiWord"
2008-05-12T06:24:48  <GomoX> it gets parsed and linked automatically
2008-05-12T06:26:09  <livibetter> it will look like "This is a <a href="http://.../WikiWord">WikiWord</a>"?
2008-05-12T06:27:04  <GomoX> yes
2008-05-12T06:27:18  <GomoX> but it will also be colored depending on whether the page exists or not
2008-05-12T06:27:22  <livibetter> you can read MoinMoin's code
2008-05-12T06:27:34  <livibetter> about how it parse and format a page
2008-05-12T06:27:50  <GomoX> that's what I'm trying to do but it's not like reading a book, i am not familiar with the source at all
2008-05-12T06:28:55  <livibetter> sorry, I can't help. I don't have enough knowledge for it.
2008-05-12T06:30:38  <GomoX> no problem i'll find it eventually
2008-05-12T06:30:39  <GomoX> thanks
2008-05-12T06:31:01  <GomoX> Another question
2008-05-12T06:31:19  <GomoX> Do you know how you create and save a new page directly from python?
2008-05-12T06:32:30  <livibetter> no... but I think you can check those unit test files
2008-05-12T09:06:54  <dreimark> moin
2008-05-12T09:08:11  <dreimark> GomoX: thats a question likely for the channel #moin
2008-05-12T09:08:19  <dreimark> see http://moinmo.in/ReimarBauer/UnderConstruction#head-9a6d6c274a43667b85350433e61145a1b64bc10e
2008-05-12T09:10:19  <GomoX> ouch, german
2008-05-12T09:33:43  <ThomasWaldmann> moin
2008-05-12T10:59:30  <dreimark> bbl
2008-05-12T12:49:39  <ThomasWaldmann> who added "ACL groups" and "Jabber" to SystemAdmin?
2008-05-12T12:50:28  <xorAxAx> hg annotate :)
2008-05-12T12:51:38  <ThomasWaldmann> yeah, if noone announces to fix it on their own :)
2008-05-12T12:52:20  <ThomasWaldmann> the jabber column creates lots of useless "xmpp:" links
2008-05-12T12:53:03  <ThomasWaldmann> the ACL group column shows silly stuff (and we have no such thing as an "ACL group" btw., we just have groups)
2008-05-12T12:55:10  <ThomasWaldmann> e.g. OliverGraf is in "ACL groups": SystemPagesInJapaneseGroup, SystemPagesInEnglishGroup, SystemPagesInFrenchGroup, SystemPagesGroup, SystemPagesInFinnishGroup, SystemPagesInLithuanianGroup, MoinPagesEditorGroup
2008-05-12T12:55:46  <xorAxAx> :)
2008-05-12T13:03:46  <ThomasWaldmann> dreimark: please fix the group stuff
2008-05-12T13:04:48  <ThomasWaldmann> dreimark: s/acl group/group/g is the minimum change required in UI and code
2008-05-12T13:07:36  <ThomasWaldmann> dreimark: and also please optimize that code generating the list (it calculates pagename_link even if it does not use it, it expands groups even though we have them already expanded [iirc])
2008-05-12T13:11:50  <ThomasWaldmann> dreimark: http://hg.moinmo.in/moin/1.7/rev/19aef8a04be6 see there
2008-05-12T13:33:36  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3584:5be4f4a8fa65 1.7/MoinMoin/userform/admin.py: SystemAdmin user browser: handle empty email/jabber addresses correctly
2008-05-12T13:43:04  <ThomasWaldmann> dreimark: i am currently fixing UI and attribute names
2008-05-12T13:59:52  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3585:fc32d580fe37 1.7/MoinMoin/userform/admin.py: SystemAdmin user browser: fix names/labels, optimize group membership calculation, cosmetic fixes
2008-05-12T14:01:11  <ThomasWaldmann> dreimark: ^^ have a look at that changeset. and please fix your other code (e.g. wikidicts tests) to not unneccessarily call expand groups
2008-05-12T14:34:00  * ThomasWaldmann fixed AttachFile/Load action's misleading text
2008-05-12T14:48:04  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3586:35366465d4fe 1.7/MoinMoin/action/ (AttachFile.py Load.py): AttachFile/Load: remove misleading/outdated text, Load: fix UI cosmetics, reuse i18n texts
2008-05-12T14:48:06  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3587:1acfce5064d2 1.7/MoinMoin/i18n/ (42 files): update i18n
2008-05-12T14:56:21  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2648:8bb451a610dd 1.6/ (3 files in 2 dirs): AttachFile/Load: remove misleading/outdated text, Load: fix UI cosmetics, reuse i18n texts
2008-05-12T15:05:12  <gizmach> moin
2008-05-12T15:10:25  <ThomasWaldmann> hi gizmach
2008-05-12T15:44:04  <ThomasWaldmann> gizmach: how's ldap?
2008-05-12T15:45:50  <gizmach> ThomasWaldmann: I'm going to see it in a half an hour. I stopped in writing tests process. Probably I'll have some questions for you later:)
2008-05-12T16:52:11  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3588:cd2f895a534a 1.7/MANIFEST.in: update MANIFEST.in: new standalone server files, remove exlude for arch/tla (we don't use it any more since long)
2008-05-12T16:57:59  <ThomasWaldmann> TheSheep: that a.download css was that from you?
2008-05-12T16:58:06  <ThomasWaldmann> (see screen.css)
2008-05-12T16:58:38  <ThomasWaldmann> it sets width to 7em - is that necessary? because the german text does not fit in that.
2008-05-12T16:59:15  <TheSheep> I was afraid of that
2008-05-12T16:59:54  <ThomasWaldmann> does some browser do silly stuff when just working without width?
2008-05-12T16:59:59  <TheSheep> I wonder what would be a "safe" width? (except for 100%)
2008-05-12T17:01:26  <ThomasWaldmann> heh, without width it IS 100% :P
2008-05-12T17:05:27  <ThomasWaldmann> TheSheep: how about removing display: block and width: 7em?
2008-05-12T17:05:45  <ThomasWaldmann> then it looks like intended, at least in Opera9
2008-05-12T17:08:33  <ThomasWaldmann> FF3b5 also OK
2008-05-12T17:09:22  <TheSheep> ThomasWaldmann: where are you testing it?
2008-05-12T17:09:33  <TheSheep> I'd like to check in msie
2008-05-12T17:09:37  <ThomasWaldmann> on lo :)
2008-05-12T17:09:56  <TheSheep> ok
2008-05-12T17:10:25  <ThomasWaldmann> i just deleted those 2 lines from screen.css
2008-05-12T17:10:49  <ThomasWaldmann> yeah, a MSIE check would be ok.
2008-05-12T17:11:02  <ThomasWaldmann> can you test it locally or shall I commit it?
2008-05-12T17:15:08  <TheSheep> ThomasWaldmann: my version is out of synch, it would be much faster if you commited
2008-05-12T17:15:17  <ThomasWaldmann> ok, wait
2008-05-12T17:17:47  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3589:fde54141253d 1.7/wiki/htdocs/modern/css/screen.css: fix the i18ned 'download' link rendering on AttachFile do=view page (tested with FF3b5 and Opera9)
2008-05-12T17:18:37  <ThomasWaldmann> http://test17.moinmo.in/TestWiki17?action=AttachFile&do=view&target=foo.png see there
2008-05-12T17:19:11  <ThomasWaldmann> http://test17.moinmo.in/TestWiki17?action=AttachFile&do=view&target=traceback.html and there
2008-05-12T17:20:16  <TheSheep> looks perfect
2008-05-12T17:20:21  <TheSheep> in msie6
2008-05-12T17:20:25  * TheSheep tries msie7
2008-05-12T17:20:58  <TheSheep> looks good
2008-05-12T17:21:13  <ThomasWaldmann> gna, attachment upload broken due to notification code :|
2008-05-12T17:21:21  <TheSheep> I don't have ff2 or safari handy
2008-05-12T17:22:55  <ThomasWaldmann> ok, then I add a.download also for the other builtin themes (missing completely there)
2008-05-12T17:29:25  * ThomasWaldmann bumps CIA-53 
2008-05-12T17:30:55  <ThomasWaldmann> btw, we need a xmpp link icon, currently it uses the email icon
2008-05-12T17:31:55  <ThomasWaldmann> (otoh, an envelope matches a chat notification as well as a email notification)
2008-05-12T17:37:01  <ThomasWaldmann> import MoinMoin.events.notification as notification
2008-05-12T17:53:04  <TheSheep> ThomasWaldmann: how about a lightbulb?
2008-05-12T17:53:18  <TheSheep> ThomasWaldmann: or would a speech baloon be better?
2008-05-12T17:54:36  <TheSheep> hmm... moin-edit would fit :)
2008-05-12T17:54:48  <TheSheep> I have a pencil icon that could replace it
2008-05-12T17:54:51  <ThomasWaldmann> I have no idea what's the usual thing for jabber.
2008-05-12T17:55:09  <TheSheep> http://sheep.art.pl/icon/edit-link.png
2008-05-12T17:55:19  <TheSheep> usual thing for jabber was a lightbulb
2008-05-12T17:56:30  <ThomasWaldmann> ok, then a small lighbulb (their logo scaled down?)
2008-05-12T17:56:55  <ThomasWaldmann> upload overwriting also broken
2008-05-12T17:59:41  <ThomasWaldmann> at least on wsgi, on standalone it works!?
2008-05-12T18:05:32  <TheSheep> http://atos.wmid.amu.edu.pl/~sheep/moin-jabber.png
2008-05-12T18:08:41  <ThomasWaldmann> hmm, i guess that's only recognizable if you have seen the big one before :)
2008-05-12T18:09:13  <TheSheep> yeah, stling is a hard thing in this size
2008-05-12T18:09:30  <TheSheep> otoh if you have a jabber account, you have probably seen it before
2008-05-12T18:20:21  <TheSheep> http://atos.wmid.amu.edu.pl/~sheep/moin-jabber2.png
2008-05-12T18:41:37  <ThomasWaldmann> well, the inner part can be recognized even worse
2008-05-12T18:41:53  <ThomasWaldmann> some logos don't scale
2008-05-12T18:54:49  * ThomasWaldmann .oO(AttachFile/Load DIE!)
2008-05-12T21:03:10  <gizmach> re
2008-05-12T21:03:56  * ThomasWaldmann rips Load action
2008-05-12T22:06:34  <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3591:15e5ca7240ab 1.7/ (3 files in 2 dirs): Load action: remove duplicated code, add comment field, refactor. AttachFile action: refactor. Fix bugs.
2008-05-12T22:15:06  <ThomasWaldmann> grzywacz: could you fix the notification bugs?
2008-05-12T22:15:47  <ThomasWaldmann> http://test17.moinmo.in/TestWiki17 just try to upload a new file there
2008-05-12T22:26:19  <grzywacz> oops
2008-05-12T22:26:22  <grzywacz> sure
2008-05-12T22:30:11  <ThomasWaldmann> grzywacz: and maybe review all places using 'body' and 'text'
2008-05-12T22:30:24  <dreimark> re
2008-05-12T22:30:41  <gizmach> dreimark:
2008-05-12T22:31:50  <grzywacz> ThomasWaldmann, did that already, running tests
2008-05-12T22:35:07  <grzywacz> 10 tests failing, none of "mine"
2008-05-12T22:35:39  <grzywacz> I'm going to test it for a few minutes and then commit. I don't really have time to extend the test suite.
2008-05-12T22:39:04  * dreimark reads logs
2008-05-12T22:41:12  <ThomasWaldmann> 10???
2008-05-12T22:41:27  * ThomasWaldmann has 1,2,3
2008-05-12T22:41:55  <ThomasWaldmann> dreimark: I hope you don't mind that i ripped Load.py
2008-05-12T22:42:39  <grzywacz> ThomasWaldmann, 10
2008-05-12T22:44:59  <grzywacz> 2 in test_wikidicts.py
2008-05-12T22:45:02  <ThomasWaldmann> upload the py.test output somewhere, please
2008-05-12T22:45:22  <grzywacz> one minute
2008-05-12T22:48:57  <grzywacz> ThomasWaldmann, http://kolos.math.uni.lodz.pl/~grzywacz/failing.txt
2008-05-12T22:49:04  <grzywacz> ThomasWaldmann, 9 this time, it's random :P
2008-05-12T22:49:44  <dreimark> grzywacz: which filesystem do you run the tests on?
2008-05-12T22:50:25  <CIA-53> Karol 'grzywacz' Nowak <grywacz@gmail.com> default * 3592:ff60ed56002a 1.7/MoinMoin/events/ (emailnotify.py jabbernotify.py notification.py): s/body/text/g to get rid of a stupid bug
2008-05-12T22:50:37  <grzywacz> dreimark, …
2008-05-12T22:50:40  <grzywacz> dreimark, reiserfs
2008-05-12T22:50:42  <grzywacz> 3
2008-05-12T22:56:23  <dreimark> grzywacz: which python version do you use ?
2008-05-12T22:56:42  <grzywacz> dreimark, 2.4.4
2008-05-12T22:58:21  <dreimark> hmm, seems you have in some of the tests the old url http://moinmoin.wikiwikiweb.de/something
2008-05-12T22:59:46  <grzywacz> I did hg pull -u beforehand.
2008-05-12T23:00:38  <dreimark> grzywacz: which mercurial version ?
2008-05-12T23:00:55  <dreimark> and from where do you pull
2008-05-12T23:01:30  <grzywacz> from http://hg.moinmo.in/moin/1.7
2008-05-12T23:01:51  <grzywacz> hg 0.9.5
2008-05-12T23:03:13  <ThomasWaldmann> grzywacz: check your interwiki map
2008-05-12T23:03:38  <ThomasWaldmann> (and maybe nuke test/wiki )
2008-05-12T23:04:39  <grzywacz> …
2008-05-12T23:20:31  <ThomasWaldmann> grzywacz: strange, i don't have that one formatter failure
2008-05-12T23:20:36  <ThomasWaldmann>         #page.formatter.setPage(page)
2008-05-12T23:20:51  <ThomasWaldmann> that looks suspicious (test_formatter, line 71)
2008-05-12T23:21:57  <ThomasWaldmann> grzywacz: no, ignore
2008-05-12T23:22:09  <grzywacz> ThomasWaldmann, 3 failing tests now
2008-05-12T23:22:16  <grzywacz> (after recreation of the test wiki)
2008-05-12T23:22:29  <ThomasWaldmann> strange nevertheless
2008-05-12T23:22:54  <ThomasWaldmann> ok, back to notification :) you fixed it?
2008-05-12T23:23:11  <ThomasWaldmann> ah, see it above
2008-05-12T23:23:20  * ThomasWaldmann retries on test17 wiki
2008-05-12T23:24:49  <ThomasWaldmann> lol @ shipment :))
2008-05-12T23:24:55  <grzywacz> :P
2008-05-12T23:37:51  <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3593:ece71db231f1 1.7/MoinMoin/_tests/test_wikidicts.py: test_wikidicts: optimize group membership calculation
2008-05-12T23:37:52  <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3594:c71228372904 1.7/MoinMoin/events/ (emailnotify.py jabbernotify.py notification.py): merged main
2008-05-12T23:38:39  <dreimark> ThomasWaldmann: how do you like to proceed with the mtime problem?
2008-05-12T23:40:05  <ThomasWaldmann> did you find the cause?
2008-05-12T23:48:06  <dreimark> I thought we have had agreed yesterday already that using mtime for time critical data is bad because of filesystem mtime granularity can be rather big.
2008-05-12T23:48:39  <ThomasWaldmann> yes
2008-05-12T23:49:27  <ThomasWaldmann> but reading the file contents is no good solution
2008-05-12T23:51:24  <dreimark> I know. Can we extend the filename of the cache file to dicts_groups.time
2008-05-12T23:53:41  <ThomasWaldmann> good idea, but that needs quite some changes in the caching module
2008-05-12T23:56:07  <dreimark> if the . as separator does make problems with M$ we can use naything else