2008-08-24T00:31:10  <ThomasWaldmann> xorAxAx: do you have an idea why i need that staticmethod(TestConfig)?
2008-08-24T00:31:28  <ThomasWaldmann> i am getting TestConfig from the class, not the instance
2008-08-24T01:38:05  <ThomasWaldmann> looks like I've a heisenbug
2008-08-24T01:38:32  <ThomasWaldmann> that import plugin test worked for some time and I fixed some other unrelated stuff
2008-08-24T01:38:40  <ThomasWaldmann> now it fails again :|
2008-08-24T02:01:36  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4027:0d6724b87856 1.8/ (16 files in 10 dirs): (log message trimmed)
2008-08-24T02:01:36  <CIA-55> Refactored TestConfig creation for py.test based unit tests.
2008-08-24T02:01:36  <CIA-55> The method used before had multiple problems: config creation did
2008-08-24T02:01:36  <CIA-55> not use inheritance (as it does when used the wiki in production).
2008-08-24T02:01:36  <CIA-55> It also didn't do the post processing done in __init__ of Config
2008-08-24T02:01:40  <CIA-55> class. Also, it first created the request with some default config,
2008-08-24T02:01:42  <CIA-55> then created the TestConfig (but some stuff in request was not
2008-08-24T02:01:59  <ThomasWaldmann> ...
2008-08-24T16:01:23  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4028:5c78ac77c98f 1.8/MoinMoin/ (conftest.py config/_tests/test_configs.py): tests: minor cleanups, remove unused code, fix (c)
2008-08-24T16:22:06  <xorAxAx> ThomasWaldmann: i tried without staticmethod
2008-08-24T16:22:12  <xorAxAx> ThomasWaldmann: and i get an error in py.test
2008-08-24T16:22:31  <xorAxAx> because it thinks that it is a test class
2008-08-24T16:22:59  <xorAxAx> so renaming TestConfig to Config will probably fix it
2008-08-24T16:23:32  <ThomasWaldmann> oops :)
2008-08-24T16:24:04  * xorAxAx tries
2008-08-24T16:24:51  <xorAxAx> yeah, works
2008-08-24T16:26:08  <xorAxAx> i let you rename it because you might have local mods and know all places where you used the class
2008-08-24T16:26:19  <ThomasWaldmann> ok
2008-08-24T16:26:52  * ThomasWaldmann has grep :P
2008-08-24T16:27:51  <xorAxAx> btw, i probably suggest something along the lines of Config ...
2008-08-24T16:28:03  <xorAxAx> TestConfig also had the disadvantage that it might confused with the old scheme
2008-08-24T16:31:21  <ThomasWaldmann> i removed all old stuff anyway
2008-08-24T16:31:44  <ThomasWaldmann> apropos old stuff
2008-08-24T16:31:58  <ThomasWaldmann> do you think we need that "unittest" hack?
2008-08-24T16:35:45  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4029:3d5c4ebe8f34 1.8/MoinMoin/ (5 files in 4 dirs): tests: do not use TestConfig class name because py.test thinks that is a test
2008-08-24T16:45:29  <xorAxAx> no, there are no unittest imports left anymore
2008-08-24T16:46:46  <xorAxAx> i can remove it :)
2008-08-24T17:33:57  * ThomasWaldmann debugs plugin loader
2008-08-24T17:34:53  <CIA-55> Alexander Schremmer <alex AT alexanderweb DOT de> default * 4030:8a1c8fb7c689 1.8/MoinMoin/ (conftest.py _tests/compat.py): Removed unittest compat code. All unit tests were migrated to py.test.
2008-08-24T18:03:09  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4031:68951e8e069d 1.8/MoinMoin/config/multiconfig.py: plugin module loader: fix _plugin_modules list for the case when module was already loaded before
2008-08-24T18:03:10  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4032:070d03f8fd7b 1.8/MoinMoin/wikiutil.py: plugin loader: minor cleanups
2008-08-24T18:03:11  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4033:404220520c63 1.8/MoinMoin/ (conftest.py _tests/compat.py): merged main
2008-08-24T18:54:50  <ThomasWaldmann> the apache moin wiki farm still uses 1.3.4 :|
2008-08-24T20:28:51  <dreimark> moin
2008-08-24T20:51:37  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4034:8ced48dc0a3d 1.8/wiki/server/test.wsgi: added test.wsgi script
2008-08-24T21:05:51  <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4035:fbf92e24f4d2 1.8/wiki/server/test.wsgi: test.wsgi: changed license to Python license, cosmetic changes, python path display fixed
2008-08-24T21:06:00  <ThomasWaldmann> zenhase: ^^

MoinMoin: MoinMoinChat/Logs/moin-dev/2008-08-24 (last edited 2008-08-23 22:45:02 by IrcLogImporter)