MoinMoin: MoinMoinChat/Logs/moin-dev/2008-11-18

2008-11-18T01:43:05  <dreimark> gn
2008-11-18T08:41:14  <ThomasWaldmann> moin
2008-11-18T08:52:00  <dreimark> moin
2008-11-18T15:27:59  <ThomasWaldmann> re
2008-11-18T18:16:26  <dennda> hmpf...
2008-11-18T18:16:50  * dennda just received 3 mails because $somebody found his wiki page be an appropriate sandbox...
2008-11-18T18:50:42  <ThomasWaldmann> hehe
2008-11-18T19:04:18  <dreimark> TheSheep: userprefs uses already request.args.get, does this mean it is converted ?
2008-11-18T19:04:24  <dreimark> ThomasWaldmann: ^^
2008-11-18T19:09:40  <CIA-58> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4425:e78462e0c7f1 1.9/MoinMoin/action/ (PackagePages.py SyncPages.py newpage.py): pre-1.9: request.form has qs args and post data, 1.9: .form only post data, .args only qs args, .values both
2008-11-18T19:16:15  <dreimark> argh eclipse won't start again
2008-11-18T19:23:14  <dreimark> bbl
2008-11-18T19:39:38  <ThomasWaldmann> dreimark: i didn't look at it yet, but esp. the stuff using request.form has to be reviewed
2008-11-18T19:39:54  <ThomasWaldmann> also if something uses [0]
2008-11-18T19:39:59  <ThomasWaldmann> bbl, too
2008-11-18T20:31:59  <ThomasWaldmann> dennda: if those files are not yours, please delete them
2008-11-18T21:29:36  <CIA-58> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4426:8982d8226218 1.9/MoinMoin/ (5 files in 3 dirs): pre-1.9: request.form has qs args and post data, 1.9: .form only post data, .args only qs args, .values both
2008-11-18T21:29:37  <CIA-58> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4427:06f33d1ce4cb 1.9/MoinMoin/action/ (PackagePages.py SyncPages.py newpage.py): merged main
2008-11-18T22:04:07  <CIA-58> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4428:ded09bdc3902 1.9/MoinMoin/ (5 files in 2 dirs): pre-1.9: request.form has qs args and post data, 1.9: .form only post data, .args only qs args, .values both
2008-11-18T22:04:49  <zenhase> hello there
2008-11-18T22:05:06  <zenhase> sorry i couldn't make it yesterday evening, though i promised in the mail :/
2008-11-18T22:10:09  <ThomasWaldmann> please review those changesets ^^
2008-11-18T22:10:42  <ThomasWaldmann> http://moinmo.in/MoinMoinTodo/Release 1.9/FormReview < and there is 1 file left :)
2008-11-18T22:17:43  <zenhase> hmm
2008-11-18T22:18:08  <zenhase> that is quite strange, i remember changing many occurences :o
2008-11-18T22:18:22  <zenhase> perhaps they got lost in a merge?
2008-11-18T22:19:25  <ThomasWaldmann> you can check that in the history
2008-11-18T22:19:42  <ThomasWaldmann> but I rather would guess you just forgot those
2008-11-18T22:30:52  <zenhase> yeah
2008-11-18T22:31:11  <zenhase> code review is easier in this case
2008-11-18T22:31:39  <zenhase> hmm
2008-11-18T22:32:04  <ThomasWaldmann> btw, all my changes are untested, you can also help by just testing them
2008-11-18T22:32:11  <zenhase> could be the reason for the 500-failing tests too
2008-11-18T22:37:02  <dreimark> the last test_Page test takes extremly long
2008-11-18T22:37:36  <dreimark> I thought this was fixed somehow in the past a wrong address or something like this
2008-11-18T22:38:00  <dreimark> zenhase: where is your changes file located
2008-11-18T22:57:32  <dreimark> ThomasWaldmann: http://www.resource-solutions.de/svgeditor/
2008-11-18T23:02:39  <dreimark> no gpl
2008-11-18T23:17:49  <dreimark> http://glipssvgeditor.sourceforge.net/index.html
2008-11-18T23:18:13  <dreimark> much better and it reads the svg's from twikidrawsvg
2008-11-18T23:19:10  <dreimark> but it is another java program
2008-11-18T23:19:35  <dreimark>  GNU Library or Lesser General Public License (LGPL)