MoinMoin: MoinMoinChat/Logs/moin-dev/2009-02-12

2009-02-12T00:53:11  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 5083:c54f13373ff7 1.8-dom-bblank/ (502 files in 89 dirs): Merge moin/1.9
2009-02-12T00:53:12  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 5084:091c6835f096 1.8-dom-bblank/MoinMoin/converter2/link.py: Link converter - Really fix wiki link generation
2009-02-12T01:26:48  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 5085:33537ed1d932 1.8-dom-bblank/MoinMoin/util/iri.py: Iri - Only remove dot segments on merge, return own class on getitem call with slice
2009-02-12T01:26:49  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 5086:625947891ba5 1.8-dom-bblank/MoinMoin/converter2/link.py: Link converter - Use Iri.extend, fix case with : in link but no matching interwiki definition
2009-02-12T01:36:54  <waldi> okay, request.root_url is not usable at all, it creates informations out of thin air
2009-02-12T09:16:32  <ThomasWaldmann> dreimark_: could you please change package action to not create package.zip as attachment
2009-02-12T09:35:04  <dreimark_> re
2009-02-12T09:35:06  <dreimark_> moin
2009-02-12T09:35:58  * dreimark_ forwards greetinngs from Heinrich 
2009-02-12T09:37:06  <dreimark_> ThomasWaldmann: will do
2009-02-12T09:42:29  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 5087:9610ecb43a28 1.8-dom-bblank/MoinMoin/util/iri.py: Iri - Don't copy unicode derived objects
2009-02-12T09:42:30  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 5088:b7da92c71ce7 1.8-dom-bblank/MoinMoin/util/iri.py: Iri - Make it possible to parse unquoted Iri, always carry quoted information
2009-02-12T10:03:17  <waldi> ThomasWaldmann: you asked about the i18n/wiki stuff yesterday. my plan was to replace the arguments of the getText function with "text, *args, **kwargs" and handle the expansion like the logging.* functions after all other translations have been carried out
2009-02-12T10:06:00  <ThomasWaldmann> waldi: so we'll keep wiki markup in i18n strings and run it through the wiki/dom + dom/x converter?
2009-02-12T10:07:46  <waldi> do you want to remove that?
2009-02-12T10:08:01  <ThomasWaldmann> hmm, if we have a variable pagename there, we need to replace it first, then run it through wiki converter
2009-02-12T10:08:32  <ThomasWaldmann> not if we can still do it
2009-02-12T10:09:43  <ThomasWaldmann> waldi: maybe add some ideas to the i18n section on the soc ideas page
2009-02-12T10:19:26  <waldi> ThomasWaldmann: another possibility is to backport the 2.6/3.0 str.format
2009-02-12T10:21:15  <ThomasWaldmann> that's a minor detail whether we use %(foo)s or $foo
2009-02-12T10:22:01  <ThomasWaldmann> but we have to be careful about escaping correctly
2009-02-12T10:22:37  <ThomasWaldmann> and about the sequence of doing things
2009-02-12T10:23:37  <waldi> yeah, but this would make it possible to ignore replacements for the initial translation step, as replacements have always a number or a name
2009-02-12T10:24:21  <ThomasWaldmann> for i18n it is better to have named placeholders anyway
2009-02-12T10:26:35  <ThomasWaldmann> hmm, i guess the i18n code will have to deal with domtree argument type
2009-02-12T10:28:40  <waldi> this format infrastructure would as even allow to embed trees into trees
2009-02-12T10:28:42  <ThomasWaldmann> so, if arg is unicode, replace it at the very beginning, if arg is domtree, replace it in the middle of processing
2009-02-12T12:12:21  * ThomasWaldmann feels we should have some 1.9 beta soon
2009-02-12T12:13:00  <ThomasWaldmann> to get more testers, esp. the ones not familiar with mercurial
2009-02-12T12:22:19  <ronny> yo
2009-02-12T12:22:50  <ronny> i came to the decission that i hate all common dvcs's
2009-02-12T12:23:23  <ThomasWaldmann> use rcs
2009-02-12T12:24:56  <ronny> hmm, there is no word for how i feel abour rcs
2009-02-12T12:25:04  <ronny> hate just isnt strong enough
2009-02-12T12:40:48  * ThomasWaldmann has vague ideas about a crapwrap wsgi middleware X)
2009-02-12T12:53:45  <ronny> oO
2009-02-12T12:53:50  <ronny> ThomasWaldmann: wrapping what crap?
2009-02-12T13:00:00  <ThomasWaldmann> http://moinmo.in/MoinMoinTodo/Release%201.9 see there, esp. that mailing list thread link
2009-02-12T13:01:37  <ThomasWaldmann> i don't care much about python3 problems yet, but a workaround for apache/win32/py2 seems doable
2009-02-12T13:02:41  <ThomasWaldmann> moin has code in 1.8 MoinMoin/request/__init__.py for that (removed in 1.9)
2009-02-12T13:04:41  <ThomasWaldmann> the real fix of course is a sane wsgi2 specification, not continuing with the insane CGI var encoding mess
2009-02-12T14:35:48  <dreimark> ThomasWaldmann: action backup is broken
2009-02-12T14:35:59  <dreimark> AttributeError: 'AllContext' object has no attribute 'emit_http_headers'
2009-02-12T14:36:12  <TheSheep> api changes, yay
2009-02-12T14:36:50  <dreimark> and undocumented
2009-02-12T14:37:32  <TheSheep> let me check what it was renamed to
2009-02-12T14:37:34  <dreimark> action cache is also broken by that
2009-02-12T14:38:36  <TheSheep>     try:
2009-02-12T14:38:36  <TheSheep>         emit_http_headers = request.emit_http_headers
2009-02-12T14:38:36  <TheSheep>     except AttributeError:
2009-02-12T14:38:36  <TheSheep>         emit_http_headers = request.http_headers
2009-02-12T14:38:36  <TheSheep>     emit_http_headers()
2009-02-12T14:38:45  <TheSheep> that's what my code does to be portable
2009-02-12T14:39:18  <TheSheep> once you are at it, also:
2009-02-12T14:39:23  <TheSheep>     try:
2009-02-12T14:39:24  <TheSheep>         send_title = request.theme.send_title
2009-02-12T14:39:24  <TheSheep>         send_title(_('Actions for %s') % pagename, page_name=pagename)
2009-02-12T14:39:24  <TheSheep>     except AttributeError:
2009-02-12T14:39:24  <TheSheep>         wikiutil.send_title(request, _('Actions for %s') % pagename, pagename=pagename)
2009-02-12T14:39:55  <dreimark> will add it similiar to arnica and do fix it in 1.9 without that try
2009-02-12T14:41:03  <TheSheep> that was changed somewhere between 1.6 and 1.8
2009-02-12T14:41:27  <dreimark> the last was at 1.7 I think
2009-02-12T14:42:35  * dreimark runs tests
2009-02-12T14:47:31  <dreimark> TheSheep: it is not request.http_headers in 1.9 me searches now
2009-02-12T14:48:24  <TheSheep> splendid
2009-02-12T15:02:56  <dreimark> .oO found much more problems
2009-02-12T15:03:02  * dreimark writes a bug report
2009-02-12T15:21:17  <CIA-38> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4571:41f1c2922ae7 1.9/MoinMoin/ (4 files in 3 dirs): fixed missing API changes of request.getScriptname() to request.url_root
2009-02-12T15:24:40  <dreimark> it looks like forms don't need now a new emit_headers but how can I cahnge the content type
2009-02-12T15:27:18  <dreimark> it looks like the replacement is to call e.g.
2009-02-12T15:27:26  <dreimark> filename_enc = "%s.txt" % self.page_name.encode(config.charset)
2009-02-12T15:27:31  <dreimark> dispo_string = '%s; filename="%s"' % (content_disposition, filename_enc)
2009-02-12T15:27:42  <dreimark> request.headers.add('Content-Disposition', dispo_string)
2009-02-12T15:40:34  <dreimark> can one review that patch http://paste.pocoo.org/show/103673/ I have never used the backup feature. I probably don't understand what the meaning of backup_include is
2009-02-12T15:41:01  <dreimark> it looks like I get as result an empty file stored
2009-02-12T16:51:26  <dreimark> bbl
2009-02-12T17:38:08  <ThomasWaldmann> dreimark: patch looks ok (i would just remove dispo_string and directly give it to the call)
2009-02-12T17:45:13  <ThomasWaldmann> dreimark: after collecting all the needed changes on some wiki page, we can think about what to do with that
2009-02-12T17:45:49  <ThomasWaldmann> we either can just document it, expecting extension authors to adapt their stuff for 1.9
2009-02-12T17:46:39  <ThomasWaldmann> or, if possible, we can add some compatibility wrappers that emit deprecation warnings for 1.9 and get removed in 2.0
2009-02-12T17:47:45  <ThomasWaldmann> that only makes sense, if we add such wrappers for all changes needed - maybe not easily possible
2009-02-12T22:22:12  <CIA-38> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4572:30cc750e28b4 1.9/MoinMoin/action/backup.py: action.backup: Because of API chnges emit_http_headers removed for the form of sendBackupForm and replaced by request.headers.add for sendBackup.
2009-02-12T22:29:45  <ThomasWaldmann> dreimark: that's wrong
2009-02-12T22:33:30  <dreimark> why
2009-02-12T22:34:31  <ThomasWaldmann> just read the diff :)
2009-02-12T22:35:25  <dreimark> shit
2009-02-12T23:08:40  <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/103741/ but that does not fix the current bug report
2009-02-12T23:12:50  <ThomasWaldmann> and can be still simplified
2009-02-12T23:14:20  <dreimark> sure inline must not be defined by substitution
2009-02-12T23:15:47  <dreimark> and I can save that line only 83 chars on the next one
2009-02-12T23:17:34  <ThomasWaldmann> yes, too much for a VGA mode 0
2009-02-12T23:18:41  <dreimark> -m"action.backup: silly bug of the previous commit fixed" ok ?
2009-02-12T23:21:17  <ThomasWaldmann> well, you said it doesn't fix the bug
2009-02-12T23:21:23  <ThomasWaldmann> of the bug report
2009-02-12T23:21:44  <ThomasWaldmann> does it now?
2009-02-12T23:22:02  <dreimark> it does send 46 bytes
2009-02-12T23:22:35  <dreimark> it can't fix TypeError: <lambda>() takes exactly 1 argument (2 given)
2009-02-12T23:24:47  <ThomasWaldmann> remove backup_exclude from your config
2009-02-12T23:25:25  <dreimark> done that gives 46 bytes
2009-02-12T23:26:32  <ThomasWaldmann> hmm, wait
2009-02-12T23:26:40  <dreimark> sorry, if I use backup_include only
2009-02-12T23:26:45  <dreimark> it gives another error
2009-02-12T23:28:21  <dreimark> and removing both gives 46bytes
2009-02-12T23:33:26  * ThomasWaldmann tries
2009-02-12T23:40:10  * dreimark looks at action cache 
2009-02-12T23:45:20  <ThomasWaldmann> error: (32, 'Broken pipe')
2009-02-12T23:50:35  <ThomasWaldmann>     backup_exclude = lambda self, fn: fn
2009-02-12T23:51:01  <ThomasWaldmann> (for wikiconfig_local.py as a temp fix for now)