MoinMoin: MoinMoinChat/Logs/moin-dev/2009-07-03

2009-07-03T01:30:31  *** amartani has joined #moin-dev
2009-07-03T02:25:40  <amartani> dennda: I've read the logs.. should I prepare something before running the tests?
2009-07-03T02:35:39  *** fxhp has quit IRC
2009-07-03T04:42:40  <CIA-36> Alexandre Martani <amartani AT gmail DOT com> default * 6035:6fa71f95d8f1 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/applets/Mobwrite/mobwrite_moinmoin.js: Real-time editor: send only necessary data on save and continue.
2009-07-03T05:33:53  *** amartani has quit IRC
2009-07-03T05:35:08  *** amartani has joined #moin-dev
2009-07-03T06:31:28  <dennda> amartani: No, I did exactly nothing (except creating the folders it moans about) after cloning a fresh copy
2009-07-03T08:02:36  <dreimark> amartani: and touch __init__.py in the plugin dir
2009-07-03T11:14:42  <ThomasWaldmann> dennda: there are some failing tests in the backend_router test
2009-07-03T11:20:41  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5977:93dfd5853cd3 2.0-storage/MoinMoin/storage/_tests/ (4 files): renamed some tests to match the module names they test
2009-07-03T11:20:44  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5978:92436f5ad6c4 2.0-storage/ (22 files in 11 dirs): merged main
2009-07-03T11:33:35  <dennda> ok will take a look at it after the lecture
2009-07-03T11:57:24  <xorAxAx> ThomasWaldmann: http://moinmo.in/MoinMoinBugs/1.6ErrorWhenFindNoResults
2009-07-03T11:57:31  <xorAxAx> ThomasWaldmann: why does it say confirmed and fixed?
2009-07-03T12:13:35  *** cankoy has joined #moin-dev
2009-07-03T12:19:16  *** czarny has joined #moin-dev
2009-07-03T12:44:13  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5979:b589fbc02a61 2.0-storage/MoinMoin/ (templates/rc.html theme/__init__.py): templating environment: add date_fmt / datetime_fmt filters
2009-07-03T12:51:05  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5980:c4556073a9dd 2.0-storage/MoinMoin/items/__init__.py: fix diff action (decode data to unicode)
2009-07-03T12:52:29  <CIA-36> Alexander Schremmer <alex AT alexanderweb DOT de> default * 4746:3f426468f743 1.9/MoinMoin/ (Page.py search/results.py): Fixed DeprecatedIsNotRespected regarding search ranking.
2009-07-03T12:52:31  <CIA-36> Alexander Schremmer <alex AT alexanderweb DOT de> default * 4747:aa598735a74a 1.9/MoinMoin/macro/WantedPages.py: Do not show links on deprecated pages when running WantedPages. Fixes pt. 2 of DeprecatedIsNotRespected.
2009-07-03T12:52:35  <CIA-36> Alexander Schremmer <alex AT alexanderweb DOT de> default * 4748:4fea31361567 1.9/ (62 files in 16 dirs): Merged main.
2009-07-03T13:17:07  *** czarny has quit IRC
2009-07-03T13:21:52  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5981:801469e73aa0 2.0-storage/MoinMoin/ (templates/rc.html theme/__init__.py): templating environment: add user_format filter
2009-07-03T13:48:43  <xorAxAx> i have been poking around in the history of testTitleSearchNegativeTerm and it has been failing since 2007
2009-07-03T13:48:53  <xorAxAx> so negative search terms are still broken?!?!
2009-07-03T13:48:55  <xorAxAx> dreimark:
2009-07-03T13:58:46  <CIA-36> Alexander Schremmer <alex AT alexanderweb DOT de> default * 4749:03ae8522b246 1.9/MoinMoin/search/_tests/test_search.py: (xoraxax with Safe) Fix page title in the test which had been broken since the beginning. Please do not check in failing tests to avoid this!
2009-07-03T13:58:57  <dreimark> xorAxAx: hmm, do you think that change was also wron from me
2009-07-03T13:58:59  <dreimark> http://hg.moinmo.in/moin/1.9/rev/ab70e33b037c
2009-07-03T13:59:11  <xorAxAx> ah, the test was broken, we fixed it
2009-07-03T13:59:38  <xorAxAx> no idea, dreimark
2009-07-03T14:04:37  <dreimark> that test_search starts failing after I did this change
2009-07-03T14:04:56  <dreimark> hg revert -r 4740 MoinMoin/_tests/test_packages.py
2009-07-03T14:05:05  <dreimark> and it doesn't fail
2009-07-03T14:05:41  <dreimark> xorAxAx: ^^
2009-07-03T14:06:09  <xorAxAx> i dont see any test_search failures anymore
2009-07-03T14:06:36  *** amartani has quit IRC
2009-07-03T14:12:58  <dreimark> me too :)
2009-07-03T14:31:32  <CIA-36> Alexander Schremmer <alex AT alexanderweb DOT de> default * 4750:617c9c236bf0 1.9/MoinMoin/parser/_tests/test_text_moin_wiki.py: (xorAxAx with safe) Comment out the last datetime test tuple even though it is showing a bug in moin. But we think that the problem is showing up too seldomly to be seen by users.
2009-07-03T14:39:52  *** MetalJoe has joined #moin-dev
2009-07-03T15:33:00  *** cankoy has quit IRC
2009-07-03T16:51:18  <CIA-36> Andy Dawkins <andydawkins@gmail.com> default * 4751:09c345615cd8 1.9/MoinMoin/ (search/_tests/test_search.py wsgiapp.py): Put the finish method back on the context object so we can delay process such as thread joined until the end
2009-07-03T17:10:47  *** MetalJoe has quit IRC
2009-07-03T17:25:39  <ThomasWaldmann> dennda: are you there?
2009-07-03T17:26:12  <ThomasWaldmann> _tests/wikiconfig.py:38 does it make any sense?
2009-07-03T17:37:14  *** ser has quit IRC
2009-07-03T17:40:08  *** ser has joined #moin-dev
2009-07-03T17:48:48  <CIA-36> Dmitrijs Milajevs <dimazest@gmail.com> default * 4811:f83b7b0b59c4 1.9-groups-dmilajevs/MoinMoin/ (28 files in 12 dirs): Groups2009: groups and dicts were merged inside of the datastruct module.
2009-07-03T18:20:36  <ThomasWaldmann> dennda: please check that file, it seems to be strange at other places to and looks like the reason why testing with a fresh clone does not work at all
2009-07-03T18:47:54  <dennda> i am, just survived a heavy thunderstorm
2009-07-03T18:49:37  <dennda> ThomasWaldmann: What does "not work at all" mean? They do work for me? (after creation of the missing folders the tests moan about)
2009-07-03T20:16:50  *** grzywacz has joined #moin-dev
2009-07-03T21:18:26  <dennda> Do we really want to have isinstance checks in tests?
2009-07-03T21:28:34  *** CIA-36 has quit IRC
2009-07-03T21:33:55  *** ser has quit IRC
2009-07-03T21:34:34  *** CIA-38 has joined #moin-dev
2009-07-03T21:43:33  *** ser has joined #moin-dev
2009-07-03T22:12:08  <ThomasWaldmann> dennda: the tests should work without manual intervention
2009-07-03T22:12:40  <dennda> ThomasWaldmann: I know that, but that was broken before I even touched anything
2009-07-03T22:12:45  <ThomasWaldmann> and line 38 looks strange, because it first seems to clone to some backend and then in line 38 it assigns to that backend
2009-07-03T22:13:21  <dennda> I have no idea what that test_num_pages is for, to be honest
2009-07-03T22:13:40  <ThomasWaldmann> i have a xml file ready to load the few important items into the wiki
2009-07-03T22:13:52  <dennda> perhaps those lines should be swapped
2009-07-03T22:13:59  <dennda> ok
2009-07-03T22:14:14  <dennda> ThomasWaldmann: there's a problem with the routing item wrapper
2009-07-03T22:14:16  <ThomasWaldmann> maybe just clean up a bit there so it works with the storage code
2009-07-03T22:14:40  <ThomasWaldmann> and 3 tests fail
2009-07-03T22:14:48  <dennda> only 1 here :-)
2009-07-03T22:14:50  <dennda> i'll push soon
2009-07-03T22:15:30  <dennda> ThomasWaldmann: you need the items to have the three serialization-related methods, yes?
2009-07-03T22:15:46  <dennda> but you *don't* actively do isinstance(item, Serializable) checks, yes?
2009-07-03T22:16:19  <ThomasWaldmann> no I don't
2009-07-03T22:16:22  <dennda> good
2009-07-03T22:16:28  <ThomasWaldmann> but maybe I should :)
2009-07-03T22:16:35  <dennda> nooo :-)
2009-07-03T22:16:45  <dennda> I have to use ducktyping here
2009-07-03T22:17:08  <dennda> unless someone has a better idea... that'll get more clear once I pushed
2009-07-03T22:17:09  <ThomasWaldmann> or hasattr
2009-07-03T22:17:19  <dennda> yes
2009-07-03T22:17:30  <dennda> i've thrown isinstance(item, Item) checks out of the generic backend tests as well
2009-07-03T22:17:47  <dennda> because they basically just deny usage of ducktyping
2009-07-03T22:43:48  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5982:ac6e7342d421 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterBackend: Start using Itemwrapper in order to make items aware of their full name
2009-07-03T22:43:50  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5983:86ae110e5e93 2.0-storage/MoinMoin/storage/_tests/test_backends_router.py: storage: tests: bug in test
2009-07-03T22:43:54  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5984:bbc9361d7141 2.0-storage/MoinMoin/storage/_tests/test_backends.py: storage: tests: remove isinstance checks from tests
2009-07-03T22:43:56  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5985:2816cfaedb57 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterBackend: Make iteritems yield wrapped RouterItems
2009-07-03T22:43:57  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5986:2c052ccb2f1b 2.0-storage/MoinMoin/storage/ (_tests/test_backends_router.py backends/router.py): storage: provide simple version of RouterItem.rename
2009-07-03T22:44:00  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5987:35906a3632f3 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterItem: Add explanatory docstring
2009-07-03T22:44:03  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5988:c7db4eaf2913 2.0-storage/MoinMoin/ (7 files in 4 dirs): merge remote 2.0-storage
2009-07-03T22:44:35  <dennda> ThomasWaldmann: Can you please take a look at that "explanatory docstring", see if you understand the issue with not inheriting from Item and tell me if you have a better idea? :-)
2009-07-03T22:44:39  <dennda> bbl
2009-07-03T23:45:14  * dreimark arrived
2009-07-03T23:46:14  <ThomasWaldmann> re
2009-07-03T23:46:38  <ThomasWaldmann> ah, wb dreimark. how's the weather?
2009-07-03T23:47:32  <dreimark> here it is warm and hasn't rained much.
2009-07-03T23:47:51  <dreimark> but Duesseldorf has currently lot's of problems
2009-07-03T23:48:10  <dreimark> my machine was redirected to koeln
2009-07-03T23:49:33  <dreimark> btw. you should ask on New Station for a possible train
2009-07-03T23:49:47  <dreimark> mine was direction london and next stop birmingham int
2009-07-03T23:50:29  <ThomasWaldmann> don't they go regularly in that direction anyway?
2009-07-03T23:51:18  <dreimark> they go in different directions
2009-07-03T23:52:14  <dreimark> and there are many
2009-07-03T23:58:22  *** grzywacz has quit IRC