MoinMoin: MoinMoinChat/Logs/moin-dev/2009-07-06

2009-07-06T00:08:10  <dennda> hmhmhm
2009-07-06T00:08:25  <dennda> cross-backend renames are more like moving an items
2009-07-06T00:08:27  <dennda> *item
2009-07-06T00:28:14  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5992:605cd2aedf97 2.0-storage/MoinMoin/theme/__init__.py: Backed out changeset 585957aa8fd1 -- TheSheep's broken changeset
2009-07-06T00:28:17  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5993:c0bc9da9f0fa 2.0-storage/ (MoinMoin/storage/backends/__init__.py wikiconfig.py): storage: Start to simplify storage configuration
2009-07-06T00:28:19  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5994:f0454167d89d 2.0-storage/MoinMoin/storage/ (_tests/test_backends_router.py backends/__init__.py): storage: RouterBackend: additional test
2009-07-06T00:28:20  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5995:0a0a6ccce29c 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterBackend: Fix for recent failing testcase
2009-07-06T00:28:26  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5996:9336cae76c71 2.0-storage/MoinMoin/storage/_tests/ (test_backends.py test_backends_router.py): storage: RouterBackend: additional test
2009-07-06T00:28:27  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5997:6a79bf91e07c 2.0-storage/MoinMoin/storage/_tests/test_backends_router.py: storage: RouterBackend: Add failing testcase
2009-07-06T00:28:32  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5998:7d46ea1ec9ca 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterBackend: First attempt to solve the cross-backend rename problem
2009-07-06T01:04:15  *** grzywacz has quit IRC
2009-07-06T07:09:24  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6040:82575f9b88fd 2.0-storage-editor-amartani/MoinMoin/ (3 files in 3 dirs): Real-time editor: show saved version after save and continue.
2009-07-06T09:11:54  <ThomasWaldmann> dennda: please refactor RouterBackend.__init__
2009-07-06T09:14:47  <ThomasWaldmann> and give a specification about how RouterBackend input shall look like
2009-07-06T09:18:36  <dreimark> moin
2009-07-06T09:34:09  <ThomasWaldmann> moin dreimark
2009-07-06T09:35:01  <ThomasWaldmann> dennda: _get_backend works incorrectly for mounpoint == "foo" and itemname == "foo", please add tests
2009-07-06T09:38:57  <ThomasWaldmann> dennda: RouterItem.name looks incorrect
2009-07-06T09:45:42  <ThomasWaldmann> dennda: refactor RouterItem.rename and other places you find item copying code to use a separate method for that
2009-07-06T10:31:10  <ThomasWaldmann> dennda:     1.25 +    This makes sure that an item in a specific backend only knows it's local name (as it
2009-07-06T10:31:16  <ThomasWaldmann> typo
2009-07-06T10:38:27  *** devilsadvocate has quit IRC
2009-07-06T10:42:58  *** devilsadvocate has joined #moin-dev
2009-07-06T11:30:39  <dreimark> devilsadvocate: you missed the meeting
2009-07-06T11:42:14  <xorAxAx> he wont reply in the next few days, been there, seen that
2009-07-06T11:42:34  <xorAxAx> he hasnt pushed anything for 12 days
2009-07-06T11:42:46  <xorAxAx> besides a merge
2009-07-06T11:57:25  <ThomasWaldmann> July 6:
2009-07-06T11:57:27  <ThomasWaldmann> ~12 noon PDT / 19:00 UTC  Mentors and students can begin submitting mid-term evaluations.
2009-07-06T11:57:44  <ThomasWaldmann> July 13:
2009-07-06T11:57:44  <ThomasWaldmann> 12 noon PDT / 19:00 UTC
2009-07-06T11:57:44  <ThomasWaldmann> * Mid-term evaluations deadline; * Google begins issuing mid-term student payments provided passing student survey is on file.
2009-07-06T11:58:59  <ThomasWaldmann> xorAxAx: waldi: dreimark: amartani: dennda: dimazest: devilsadvocate: ^^
2009-07-06T11:59:29  <xorAxAx> good to know
2009-07-06T12:00:56  * ThomasWaldmann suggests students look through their code, searching for TODO, XXX and similar stuff, polish their docstrings etc.
2009-07-06T12:02:12  <ThomasWaldmann> it is also a good idea to just READ all your code again, line by line, word by word. often you find some minor issues while doing that, like typos, wrong grammar, bad attribute/method/class names, etc.
2009-07-06T12:34:48  *** czarny has joined #moin-dev
2009-07-06T12:48:01  <czarny> hi
2009-07-06T12:48:06  <czarny> german ppl back from EuroPython?
2009-07-06T12:48:14  <czarny> had a safe flight? didn't get bored to much?
2009-07-06T13:03:11  <dreimark> czarny: me mostly besides the weather on DUS
2009-07-06T13:03:15  <dreimark> bbl
2009-07-06T13:40:10  <ThomasWaldmann> czarny: yeah, being back, travel was ok :)
2009-07-06T13:40:55  <czarny> we're flying today
2009-07-06T13:41:11  <czarny> it's 12:40 here and we've got the plane at 18:20 I guess
2009-07-06T13:53:01  <ThomasWaldmann> how was the museum tour?
2009-07-06T13:53:57  <TheSheep> great
2009-07-06T13:54:26  <TheSheep> riding on a historical bus, upstairs, is fun already
2009-07-06T13:54:50  <TheSheep> the pen museum had not only pens, but all sorts of antical typewriters too
2009-07-06T13:57:41  <czarny> yea --- it was all fun
2009-07-06T13:57:57  <czarny> and the super thing was, that in each of them was an attendant, that was all happy to show us things
2009-07-06T13:58:05  <czarny> and make us intruigued
2009-07-06T14:11:34  * dreimark has to remember that next time
2009-07-06T14:13:13  *** czarny has quit IRC
2009-07-06T14:20:17  * dreimark has to repair a server bbl
2009-07-06T14:42:12  * ThomasWaldmann fights with ubuntu 8.04 / OOo font rendering
2009-07-06T14:42:14  <dennda> I'm getting more and more convinced that we need nuke_item on the api level
2009-07-06T14:42:34  * ThomasWaldmann had that impression since last year :P
2009-07-06T14:43:25  <xorAxAx> sigh, wasnt this settled and some particular student refused to document the planning status / api design on a wiki page?
2009-07-06T14:44:24  <dennda> ...
2009-07-06T14:44:38  <dennda> I'm fairly sure not to have refused anything
2009-07-06T14:45:52  <xorAxAx> i often said that it should be documented, the api
2009-07-06T14:48:05  <ThomasWaldmann> the problem with that is that some backends (like hg) can't really "nuke" something
2009-07-06T14:50:07  <xorAxAx> dennda: didnt i suggest to fix this by copying the repo?
2009-07-06T14:50:53  <dennda> Your suggestion was a script that could be run
2009-07-06T14:51:00  <dennda> that does something like that, yes
2009-07-06T14:56:55  <dennda> but we will, of course, not have a method nuke_item(itemname) on the api level that, in the background, copies the entire backend
2009-07-06T14:58:37  <xorAxAx> well, locking is important
2009-07-06T15:55:43  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5999:ea7b900910ba 2.0-storage/MoinMoin/storage/backends/__init__.py: storage: Prepare clone method for usage with only one item
2009-07-06T15:55:46  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6000:f248e881bf6c 2.0-storage/MoinMoin/storage/backends/router.py: storage: Reduce code duplication. Use already existing method for item copying
2009-07-06T15:55:48  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6001:e43bd8749710 2.0-storage/ (MoinMoin/storage/backends/__init__.py wikiconfig.py): storage: Refactoring: Pull up item copying into seperate function
2009-07-06T15:55:51  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6002:b9daa9335f7b 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterBackend: Use copy_item instead of abusing the backend clone method
2009-07-06T16:01:36  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6003:9f2d29ee078b 2.0-storage/MoinMoin/storage/backends/enduser.py: storage: hg added a file that I forgot. needed to pull that code out due to an import cycle
2009-07-06T16:01:39  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6004:70fed96ac7de 2.0-storage/MoinMoin/storage/backends/__init__.py: storage: remove obsolete import
2009-07-06T16:04:40  *** LotekThirteen has joined #moin-dev
2009-07-06T16:04:52  <LotekThirteen> moinmoin
2009-07-06T16:05:10  <dreimark> moin LotekThirteen
2009-07-06T16:05:12  <LotekThirteen> did somebody saw also the security flaw from fckeditor
2009-07-06T16:05:15  <LotekThirteen> http://www.ocert.org/advisories/ocert-2009-007.html
2009-07-06T16:05:54  <LotekThirteen> seems it's also for fckeditor 2.6.4
2009-07-06T16:06:43  <LotekThirteen> read: An attacker can  exploit this vulnerability to install remote shells on the victim server among     other things,
2009-07-06T16:07:26  <dreimark> thx for reporting
2009-07-06T16:07:43  <dreimark> 2.6.4.1 (to be released on 2009-07-06 16:00 CET)
2009-07-06T16:08:54  <LotekThirteen> yes, I was just reading on heise about coldfusion: http://www.heise.de/newsticker/Luecke-in-ColdFusion-8-gefaehrdet-Sicherheit-von-Websites--/meldung/141633
2009-07-06T16:10:17  <dreimark> ThomasWaldmann: ^^^
2009-07-06T16:10:48  <dreimark> it seems not to be released currently, we need to wait some minutes
2009-07-06T16:11:51  <waldi> hmm, we don't use the fckeditor server componennt, or?
2009-07-06T16:17:52  <dreimark> we don't use the filebrowser
2009-07-06T16:18:47  <ThomasWaldmann> we don't use it, the question is whether it can be exploited nevertheless
2009-07-06T16:33:32  <dennda> ThomasWaldmann: You mentioned that _get_backend works incorrectly for mountpoint = itemname = 'foo'. This test, however, succeeds. Is this not the behaviour you expected? http://paste.pocoo.org/show/126909/
2009-07-06T16:36:32  <dennda> where self.child is mounted at 'child', of course
2009-07-06T16:37:27  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6523:a0b4f3127a8a 2.0-storage-dom-bblank/MoinMoin/util/ (_tests/test_mime.py mime.py): Add Type MIME helper
2009-07-06T16:37:32  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6524:4e5d9b774c22 2.0-storage-dom-bblank/MoinMoin/util/ (_tests/test_mime.py mime.py): Type MIME helper - Produce unparsed string
2009-07-06T16:37:34  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6525:829107ce4ff7 2.0-storage-dom-bblank/MoinMoin/items/__init__.py: Items - Use converters for all text items
2009-07-06T16:38:37  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6005:6245f2e56a95 2.0-storage/MoinMoin/storage/ (3 files in 2 dirs): storage: RouterBackend: Fix for items that are moved to another namespace AND renamed (e.g. foo/bar -> bum/boi)
2009-07-06T16:39:36  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6526:a632270b6dec 2.0-storage-dom-bblank/MoinMoin/converter2/text_in.py: Text input converter - Support new arguments usage
2009-07-06T16:39:38  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6527:ae8438c328ff 2.0-storage-dom-bblank/MoinMoin/macro2/GetText.py: GetText macro - Support new arguments usage
2009-07-06T16:42:14  <waldi>     from MoinMoin.storage.backends.enduser import get_enduser_backend
2009-07-06T16:42:20  <waldi> ImportError: No module named enduser
2009-07-06T16:42:28  <dennda> pull again
2009-07-06T16:42:40  <dennda> forgot to hg add
2009-07-06T16:43:49  <ThomasWaldmann> dennda: hmm, i just was confused about the "/" stuff. maybe because there is still no spec...
2009-07-06T16:44:57  <ThomasWaldmann> so just fix the other issues I mentioned
2009-07-06T16:45:26  <ThomasWaldmann> and read through your code
2009-07-06T16:47:04  <ThomasWaldmann> those _get_backend calls before creating the RouterItem somehow looks like they could go into some create classmethod of RouterItem
2009-07-06T16:47:08  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6528:820718f5e65c 2.0-storage-dom-bblank/MoinMoin/util/mime.py: Type MIME helper - Support comparison
2009-07-06T16:47:22  <dennda> 10:31 < ThomasWaldmann> dennda:     1.25 +    This makes sure that an item in a specific backend only knows it's local name (as it
2009-07-06T16:47:28  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6594:5fdfe21daf64 2.0-storage-dom-bblank/ (39 files in 14 dirs): Merge moin/2.0-storage
2009-07-06T16:47:29  <dennda> where's the typo?
2009-07-06T16:47:58  <ThomasWaldmann> the '
2009-07-06T16:48:29  <dennda> That's genitive s singular form in english, isn't it?
2009-07-06T16:48:38  <dennda> http://www.englisch-hilfen.de/grammar/genitiv.htm
2009-07-06T16:49:01  <ThomasWaldmann> no, that is possessive
2009-07-06T16:49:15  <ThomasWaldmann> like "his"
2009-07-06T16:49:20  <ThomasWaldmann> it's == it is
2009-07-06T16:50:34  <dennda> http://www.englishclub.com/grammar/nouns-possessive.htm
2009-07-06T16:51:00  <dennda> the boy's ball -> the item's name
2009-07-06T16:51:25  *** LotekThirteen has left #moin-dev
2009-07-06T16:51:42  <dennda> isn't that the same for the "it" when it stands for the item, then?
2009-07-06T16:51:43  <ThomasWaldmann> http://www.englishclub.com/grammar/pronouns-personal.htm
2009-07-06T16:52:08  <dennda> indeed
2009-07-06T16:52:12  <ThomasWaldmann> (I admit that this case sucks :)
2009-07-06T16:52:21  <dennda> convinced
2009-07-06T16:52:27  <dennda> thanks
2009-07-06T16:53:38  <ThomasWaldmann> they should teach some regular language at school, world-wide ...
2009-07-06T16:54:45  <dennda> Well I guess they did _back then_
2009-07-06T16:56:22  <ThomasWaldmann> back when?
2009-07-06T16:56:51  <dennda> back in the days when I was in school
2009-07-06T16:57:00  <ThomasWaldmann> esperanto?
2009-07-06T16:57:14  <ThomasWaldmann> for everybody?
2009-07-06T16:57:18  <dennda> ah
2009-07-06T16:58:41  <ThomasWaldmann> (of course the interest in such a policy in english or chinese speaking countries could be near to zero)
2009-07-06T17:01:14  <dennda> ThomasWaldmann: with "refactoring RouterBackend.__init__" you mean throwing out the checks whether the mapping satisfies the nonexisting spec and replacing that with an actual spec?
2009-07-06T17:01:35  <ThomasWaldmann> no
2009-07-06T17:01:44  <ThomasWaldmann> but you first check and then you normalize
2009-07-06T17:02:48  <ThomasWaldmann> also, not ==   ->  !=
2009-07-06T17:03:02  <dennda> ok
2009-07-06T17:03:46  <ThomasWaldmann> elif -> if
2009-07-06T17:04:27  <dennda> uh
2009-07-06T17:05:44  <ThomasWaldmann> and even the check for the root mountpoint is wrong...
2009-07-06T17:06:01  <ThomasWaldmann> (don't drink and code :D )
2009-07-06T17:06:24  <ThomasWaldmann> ehrm, no, ignore that
2009-07-06T17:06:39  <ThomasWaldmann> as it is a 2-tuple, it is correct
2009-07-06T17:08:05  <ThomasWaldmann> of course, if you normalize first, the check needs to check for ''
2009-07-06T17:08:51  <dennda> yes, just swapped
2009-07-06T17:10:48  <ThomasWaldmann>     63         This only iterates over all non-user and non-trash items. We don't
2009-07-06T17:10:51  <ThomasWaldmann>     64         want them to turn up in history.
2009-07-06T17:11:01  <ThomasWaldmann> that doesn't make too much sense when looking at the code below it
2009-07-06T17:12:26  <dennda> well yeah that assumes we are gonna go the trashbin way
2009-07-06T17:13:38  <ThomasWaldmann> Don't cross your bridges before you come to them.
2009-07-06T17:13:51  <ThomasWaldmann> (Kümmere dich nicht um ungelegte Eier.)
2009-07-06T17:14:11  * ThomasWaldmann .oO(dict.leo.org rules :)
2009-07-06T17:20:00  <ThomasWaldmann> btw, _has_backend returns mountpoint+'/', so it is not in the "normal form", maybe that is a little confusing
2009-07-06T17:20:20  <ThomasWaldmann> ehrm, _get_backend I mean
2009-07-06T17:20:43  <ThomasWaldmann> also, RouterItem wants that non-normal form
2009-07-06T17:21:30  <ThomasWaldmann> sometimes at least
2009-07-06T17:24:50  <ThomasWaldmann> and router.rename first copies with same name to other backend and then renames???
2009-07-06T17:27:56  <dennda> yeah I got an XXX here. it should first rename and then copy
2009-07-06T17:28:26  <ThomasWaldmann> can't it do both at once somehow?
2009-07-06T17:28:44  <dennda> well the problem is that the source backend may have an item with the target name already
2009-07-06T17:29:40  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6595:94eb5a6f10ac 2.0-storage-dom-bblank/MoinMoin/items/__init__.py: Items - Use Type objects
2009-07-06T17:29:42  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6596:a28668a9711d 2.0-storage-dom-bblank/MoinMoin/items/__init__.py: Items - Use new Creole media type
2009-07-06T17:29:43  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6597:f4f39eebe18b 2.0-storage-dom-bblank/MoinMoin/converter2/compatibility_in.py: Compatibility converter - Convert media type to string for old parsers
2009-07-06T17:29:45  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6598:025259256368 2.0-storage-dom-bblank/MoinMoin/converter2/text_in.py: Text input converter - Support new type object
2009-07-06T17:29:47  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6599:01466947325c 2.0-storage-dom-bblank/MoinMoin/converter2/creole_in.py: Creole input converter - Use new media type
2009-07-06T17:30:22  <dennda> which is why i did it this way around
2009-07-06T17:32:23  <dennda> :w
2009-07-06T17:32:25  <dennda> err
2009-07-06T17:33:21  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6006:b39e1c431ab4 2.0-storage/MoinMoin/storage/_tests/test_backends_router.py: storage: Add testcase for items whose names equal their mountpoints
2009-07-06T17:33:23  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6007:702e580e9bf7 2.0-storage/MoinMoin/storage/backends/router.py: storage: RouterBackend: Refactor __init__
2009-07-06T17:58:56  <dennda> ok i'm gonna get something to eat, bbl
2009-07-06T18:06:58  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6600:d32f19a77b52 2.0-storage-dom-bblank/MoinMoin/converter2/creole_in.py: Creole input converter - Update comments, regexps
2009-07-06T18:06:59  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6601:a12447c93dc0 2.0-storage-dom-bblank/MoinMoin/converter2/_registry.py: Converter registry - Use unicode
2009-07-06T18:07:01  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6602:8984b8d614e6 2.0-storage-dom-bblank/MoinMoin/converter2/creole_in.py: Creole input converter - Lookup sub converters via new type
2009-07-06T18:07:04  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6603:4ea0708af6b9 2.0-storage-dom-bblank/MoinMoin/converter2/creole_in.py: Creole input converter - Give arguments to sub converters
2009-07-06T18:07:06  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6604:f03a1c5f55cb 2.0-storage-dom-bblank/MoinMoin/items/__init__.py: Items - Use new Moin Wiki media type
2009-07-06T18:07:08  <CIA-38> Bastian Blank <bblank@thinkmo.de> default * 6605:78be9d400fe6 2.0-storage-dom-bblank/MoinMoin/converter2/moinwiki_in.py: Moin Wiki input converter - Use new media type
2009-07-06T18:14:37  *** czarny has joined #moin-dev
2009-07-06T18:39:26  <dreimark> wb czarny
2009-07-06T18:39:47  <czarny> no na chwilę
2009-07-06T18:39:49  <czarny> sry
2009-07-06T18:39:52  <czarny> only for a moment
2009-07-06T18:40:02  <czarny> we're sitting in the airport waiting for the gates to open
2009-07-06T18:41:02  <dreimark> before that happened for my flight 5 mins before it became delayed
2009-07-06T18:41:33  <dreimark> have a good flight back
2009-07-06T18:41:45  <czarny> we will :)
2009-07-06T18:50:39  *** czarny has quit IRC
2009-07-06T18:59:27  *** grzywacz has joined #moin-dev
2009-07-06T19:07:16  <dimazest> ThomasWaldmann: that commented code needs check
2009-07-06T19:08:29  <dimazest> dreimark: my flight was delayed when we were sitting in the plane
2009-07-06T19:09:49  <dimazest> so, i missed train and had to take another one (and buy a ticket)
2009-07-06T19:10:22  <dreimark> arg, I was able to redirect someone to pick me up in cologne instead of duesseldorf
2009-07-06T19:11:02  <dreimark> htg now bbl
2009-07-06T20:14:41  <ThomasWaldmann> re
2009-07-06T20:45:36  *** devilsadvocate has quit IRC
2009-07-06T20:45:54  *** devilsadvocate has joined #moin-dev
2009-07-06T21:04:16  *** cankoy has joined #moin-dev
2009-07-06T22:02:05  <amartani> hi.
2009-07-06T22:02:38  <amartani> ThomasWaldmann: sorry for running away yesterday.
2009-07-06T22:16:19  <dreimark> re
2009-07-06T23:49:18  *** cankoy has quit IRC
2009-07-06T23:57:42  <dreimark> bug in delete attachment.