2009-08-11T00:52:45 *** grzywacz has quit IRC
2009-08-11T03:27:26 *** amartani has joined #moin-dev
2009-08-11T08:22:59 *** tpfennig has joined #moin-dev
2009-08-11T08:39:44 <ThomasWaldmann> moin
2009-08-11T08:55:18 <dreimark> moin
2009-08-11T09:04:30 <dennda> moin
2009-08-11T10:33:06 <tpfennig> moin
2009-08-11T11:24:01 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6541:2807847e3400 2.0-storage/docs/ (CHANGES.storage CHANGES.storage_08): storage: Update CHANGES.storage
2009-08-11T11:37:48 <dennda> http://moinmo.in/4ct10n/diff/Storage2009?action=diff&rev1=98&rev2=99
2009-08-11T11:37:53 <dennda> Comments please ^
2009-08-11T12:05:23 <dennda> I don't really see a problem with just changing it to allow non-subsequent revnos at the moment. We could add that parameter just to make sure
2009-08-11T12:11:58 <dennda> and: do we also want to remove acl_rights_valid? I guess not
2009-08-11T12:45:19 *** grzywacz has joined #moin-dev
2009-08-11T12:52:08 <dennda> meh
2009-08-11T12:52:18 <dennda> stupidity my friend...
2009-08-11T13:09:09 * dennda is unsure where the acls specified in docs/config_examples/snippets/openid_teams_wikiconfig_snippet are used and whether he should just change that to teams_acl = dict(..)
2009-08-11T13:33:01 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6542:25a8fefe8a98 2.0-storage/MoinMoin/ (3 files in 3 dirs): storage: remove acl_rights_{before,default,after} from code
2009-08-11T13:33:03 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6543:b619065f3d61 2.0-storage/MoinMoin/ (security/__init__.py storage/backends/acl.py): storage: Fix tests after recent ripout of acl_rights_*
2009-08-11T13:33:05 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6544:1fd11672b5fd 2.0-storage/docs/config_examples/ (3 files in 3 dirs): storage: Further documentation cleanup
2009-08-11T14:39:28 <ThomasWaldmann> dennda: check_revno=True also sounds good
2009-08-11T14:40:36 <dennda> ok so we want that check?
2009-08-11T14:40:40 <dennda> I will change the API then
2009-08-11T14:42:08 <ThomasWaldmann> not sure, maybe we don't need that
2009-08-11T14:42:19 <ThomasWaldmann> editor code does last+1
2009-08-11T14:42:42 <ThomasWaldmann> and code that does not do that might have a good reason for it
2009-08-11T14:43:34 <ThomasWaldmann> so maybe you just remove the check and we'll see. please leave a comment with the reasoning in the src.
2009-08-11T14:43:38 <dennda> and could then just pass that param
2009-08-11T14:43:41 <dennda> it's not necessary
2009-08-11T14:43:48 <dennda> but maybe nice to catch problems
2009-08-11T14:43:56 <dennda> ok i will
2009-08-11T14:43:58 <dennda> thanks
2009-08-11T14:46:45 <ThomasWaldmann> btw, about acl_rights_valid: it could make sense to have a valid=... param like before=,...
2009-08-11T14:47:44 <dennda> ok
2009-08-11T14:48:06 <dennda> do you think that will be actually used by somebody? :-)
2009-08-11T14:48:12 <ThomasWaldmann> and the default for that being request.cfg.acl_rights_default
2009-08-11T14:48:34 <ThomasWaldmann> it is intended for extensions, but I personally don't know any using it
2009-08-11T14:48:46 <dennda> ok, that way you could modify the acls that your admins can use
2009-08-11T14:48:55 <ThomasWaldmann> maybe nobody got it, or everyone was satisfied with checking r/w/d/r
2009-08-11T14:50:49 <ThomasWaldmann> dennda: about the openid/teams stuff, better ask rowan kerr :)
2009-08-11T14:51:05 <dennda> i have checked the nicklist, but he doesn't seem to be here
2009-08-11T14:51:09 <dennda> or what is his nick?
2009-08-11T14:51:19 <ThomasWaldmann> rkerr iirc
2009-08-11T14:51:26 <ThomasWaldmann> see wiki
2009-08-11T14:51:30 <dennda> ok
2009-08-11T14:52:30 <dennda> hm obviously we had no test for non-matching revnos :-)
2009-08-11T14:53:43 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6545:c63838d9f065 2.0-storage/MoinMoin/storage/__init__.py: storage: Remove revision number check. You can now create monotone, but non-subsequent revisions, like 0, 1, 5, 9, 10.
2009-08-11T14:54:14 <dennda> - In some scenarios, the FSBackend keeps too many files open, which causes
2009-08-11T14:54:15 <dennda> an exception to be shown. See http://tinyurl.com/5paw95 for a traceback.
2009-08-11T14:54:18 <dennda> still an issue?
2009-08-11T14:55:22 <dennda> oh no I forgot to add the comment
2009-08-11T14:58:33 <ThomasWaldmann> try list(iteritems) with many items :)
2009-08-11T14:59:11 *** amartani has quit IRC
2009-08-11T14:59:53 <dennda> slow?
2009-08-11T15:00:00 <dennda> that's not really unexpected, is it?
2009-08-11T15:06:50 <ThomasWaldmann> it might run out of file handles
2009-08-11T15:07:20 <ThomasWaldmann> that is by design btw.
2009-08-11T15:07:24 <dennda> ahh that was in fs context
2009-08-11T15:07:49 <ThomasWaldmann> and the reason for some places looking silly like
2009-08-11T15:07:53 <ThomasWaldmann> count = 0
2009-08-11T15:08:00 <ThomasWaldmann> for i in iteritems():
2009-08-11T15:08:05 <dennda> well if that is by design I can remove that from "problems that need to be fixed", correct?
2009-08-11T15:08:05 <ThomasWaldmann> count += 1
2009-08-11T15:08:35 <ThomasWaldmann> because if you do just len(list(iteritems())), it explodes :)
2009-08-11T15:08:55 <ThomasWaldmann> there are some notes in the src pointing that out
2009-08-11T15:09:09 <ThomasWaldmann> it should be noted in the developer notes, though
2009-08-11T15:09:32 <ThomasWaldmann> so that storage api using developers don't open massive amounts of items at the same time
2009-08-11T15:09:38 <dennda> in CHANGES? (there's an extra file atm containing only that hint)
2009-08-11T15:10:02 <dennda> hm shouldn't that go into the api description then?
2009-08-11T15:10:06 <ThomasWaldmann> no, in st-api dev docs
2009-08-11T15:10:14 <dennda> jup
2009-08-11T15:24:02 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6546:9ea0adc5241e 2.0-storage/MoinMoin/storage/__init__.py: storage: Add stuff I forgot in my last changeset (like docs). Sorry. :-)
2009-08-11T15:47:57 <dennda> ok I added a section about iteration to the dev docs and included an IMPORTANT note
2009-08-11T15:53:27 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6547:e3d391dda964 2.0-storage/docs/STORAGE-DEVELOPMENT: storage: remove outdated document
2009-08-11T16:09:23 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6548:554509137614 2.0-storage/MoinMoin/ (security/__init__.py storage/backends/acl.py): storage: Allow specification of custom acl_rights_valid per backend. If nothing is specified, the default from cfg.acl_rights_valid is used
2009-08-11T16:14:01 <dennda> ThomasWaldmann: Anything else or shall I dive into sqlalchemy.org now? :-)
2009-08-11T16:14:38 <ThomasWaldmann> check your todolist :)
2009-08-11T16:14:45 <dennda> i did
2009-08-11T16:15:21 <ThomasWaldmann> (./) items done
2009-08-11T16:17:43 <ThomasWaldmann> 8 * Page and PageEditor are deprecated. < i am not sure they will still exist when I am done with them :)
2009-08-11T16:18:26 <ThomasWaldmann> 11 * Old-style deletion of pages and attachments is gone. < not sure $NORMALUSER understands that
2009-08-11T16:18:30 <dennda> I hope they won't
2009-08-11T16:18:45 * dennda rephrases
2009-08-11T16:19:49 <ThomasWaldmann> all storage related new features maybe should be like that:
2009-08-11T16:20:06 <ThomasWaldmann> * New Storage API with storage backends:
2009-08-11T16:20:09 <ThomasWaldmann> * ...
2009-08-11T16:20:42 <ThomasWaldmann> (there will be other new features aside from storage in that toplevel list)
2009-08-11T16:21:04 <dennda> ok
2009-08-11T16:21:50 <ThomasWaldmann> And maybe don't just talk about "possibilities", but also tell something helpful (e.g. a pointer to more info, or more info).
2009-08-11T16:22:31 <ThomasWaldmann> * ACL changes:
2009-08-11T16:22:34 <ThomasWaldmann> * ...
2009-08-11T16:23:21 <ThomasWaldmann> you don't tell how to do things
2009-08-11T16:23:40 <dennda> that's an anapher :P
2009-08-11T16:23:58 <dennda> well that's not a howto but a "new features" list
2009-08-11T16:24:15 <ThomasWaldmann> see the main CHANGES
2009-08-11T16:25:16 <ThomasWaldmann> PawelPacana: can we move the 2 doc files about MercurialBackend to a single one?
2009-08-11T16:37:12 <ThomasWaldmann> or even to the main CHANGES.storage?
2009-08-11T16:45:42 <peck> ~[5~[5~[6~[6~[6~[6~
2009-08-11T17:07:19 <dreimark> dimazest: alive and working?
2009-08-11T17:09:48 <dimazest> dreimark: yes
2009-08-11T17:09:57 <dimazest> trying to fix bugs
2009-08-11T17:21:00 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6549:5013a67f0802 2.0-storage/ (4 files in 3 dirs): storage: Docs cleanup. Processed router and AMW docstrings. Removed obsolete, added new.
2009-08-11T17:22:43 <PawelPacana> ThomasWaldmann: didn't have much time to do it yet, sorry. I'll do it later, after work
2009-08-11T17:31:38 <dimazest> dreimark: search code uses a lot of regexps (one for language was eliminated) but there still is for categories, it would be nice to provide such a functionality or by formatter, or add it to page.pi
2009-08-11T17:50:48 <dreimark> there could be multiple categories on a page
2009-08-11T17:51:34 <dreimark> dimazest: regex are wanted for text and title search
2009-08-11T17:52:02 <dreimark> what do you want to archieve?
2009-08-11T17:57:22 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6550:04e2aa18fa41 2.0-storage/MoinMoin/_tests/data/README: storage: Get rid of unnecessary folder
2009-08-11T18:03:31 * dennda opens sqlalchemy.org
2009-08-11T18:12:59 <dennda> MoinMoin/storage/_tests/test_backends_sqla.py[122] ..FF..FF..FF..FF..FF..FFF.FFF.FFF.FFF.FFF.FFF.FFF....FFFFFF.F.F.F.....F.FFF.F
2009-08-11T18:13:06 <dennda> it's a start at least :-)
2009-08-11T18:13:47 <dimazest> dreimark:yes, several categories are possible, my point is that there are several regexps that extracts categories from a page, it would be nice to have one
2009-08-11T18:17:49 <dreimark> dimazest: where do we have another one than cfg.page_category_regex?
2009-08-11T18:22:22 <dimazest> dreimark: http://hg.moinmo.in/moin/2.0-storage-editor-amartani/file/1bd9452a7d0b/MoinMoin/search/Xapian.py#l411
2009-08-11T18:22:27 <dimazest> http://hg.moinmo.in/moin/2.0-storage-editor-amartani/file/1bd9452a7d0b/MoinMoin/search/queryparser.py#l736
2009-08-11T18:22:58 <dimazest> (wrong repo, but files are the same)
2009-08-11T18:28:17 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6551:00c97380f99a 2.0-storage/ (MoinMoin/storage/backends/sqla.py wikiconfig.py): storage: SQLABackend: Implement Item.rename
2009-08-11T18:28:19 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6552:24975399f18e 2.0-storage/MoinMoin/storage/_tests/test_backends_sqla.py: storage: Add tests for SQLABackend
2009-08-11T18:28:21 <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6553:07af4c68944e 2.0-storage/MoinMoin/storage/_tests/test_backends_sqla.py: storage sqla: skip test that makes all tests hang
2009-08-11T18:52:46 <dreimark> dimazest: indeed that looks a bit buggy
2009-08-11T18:53:24 <dreimark> there should be only one
2009-08-11T18:54:48 <dimazest> that what i'm talking about
2009-08-11T18:56:37 <dreimark> dimazest: we likly don't want to change the regex in 1.9
2009-08-11T18:56:54 <dreimark> itselfs, where it is checked is a nother question
2009-08-11T18:58:53 <dimazest> debugging is a real nightmare, test behaves randomly :)
2009-08-11T19:03:10 <dreimark> you look currently on the category xapian test?
2009-08-11T19:04:27 <dreimark> I mean only on that I can look at .test_title_search_simple FAIL
2009-08-11T19:11:41 <dimazest> dreimark: i try to find out why test_title_search_simple
2009-08-11T19:11:49 <dimazest> it gets a hit from xapian
2009-08-11T19:12:28 <dreimark> http://paste.pocoo.org/show/133688/
2009-08-11T19:12:44 <dreimark> dimazest: in principle it works
2009-08-11T19:13:07 <dreimark> (if you call that you need in wikiconfig_local to enable xapian)
2009-08-11T19:13:47 <dimazest> but i do not know what is happening next (probably hits a re filtered out in builtin.py line ~470)
2009-08-11T19:15:04 <dreimark> dimazest: get_seracher typo!
2009-08-11T19:15:15 <dreimark> line 101
2009-08-11T19:15:24 <dreimark> in test_search
2009-08-11T19:15:53 <dimazest> thanks
2009-08-11T19:19:30 *** Sepp_ has joined #moin-dev
2009-08-11T19:19:37 <Sepp_> hello everybody
2009-08-11T19:20:12 <dreimark> Sepp_: you are at the developer channel if you have a third party question please join #moin
2009-08-11T19:20:35 <Sepp_> I'm so excited: found a few simple patches for improving the GUI editor: removing empty list elements after saving AND solving the <<BR>> issues
2009-08-11T19:20:59 <Sepp_> is this the right place for talking about bugs?
2009-08-11T19:21:26 <dreimark> yes together with a wiki page
2009-08-11T19:21:54 <Sepp_> ok. I'm writing one.
2009-08-11T19:23:49 <dimazest> dreimark: i need to go for a while
2009-08-11T19:24:10 <dimazest> bbl
2009-08-11T19:24:12 <dreimark> dimazest: ok, if I find something, I'll add a new pastebin
2009-08-11T19:24:26 <dimazest> ok
2009-08-11T19:52:15 <dreimark> dimazest: MoinSearchConnection(os.path.join(request.cfg.cache_dir, 'xapian/index')
2009-08-11T19:52:59 <dreimark> )
2009-08-11T19:53:32 <dreimark> and self.
2009-08-11T19:55:08 *** vinci_ has joined #moin-dev
2009-08-11T19:55:15 *** tpfennig has quit IRC
2009-08-11T19:58:03 <Sepp_> Here is my first patch: http://www.moinmo.in/MoinMoinPatch/GuiRemoveEmptyListItems
2009-08-11T19:58:32 <Sepp_> Can we discuss it? I have a lot more patches I like to post but want to know if I made everything right.
2009-08-11T19:59:14 <dreimark> Sepp_: please wait for ThomasWaldmann
2009-08-11T19:59:38 <dreimark> if there are changes to text_html_text_moin_wiki neccessary
2009-08-11T19:59:46 <Sepp_> Does he come today?
2009-08-11T20:00:07 <dreimark> yes, he is currently at work or travelling
2009-08-11T20:00:51 <Sepp_> Is there a chance that bugs are commited to revision 1.9?
2009-08-11T20:00:57 <dreimark> yes
2009-08-11T20:01:14 <dreimark> you can try py.test of 1.9 with your patches
2009-08-11T20:01:40 <Sepp_> Can I somehow speak german? My weak english is slowing me down a lot.
2009-08-11T20:02:06 <dreimark> http://hg.moinmo.in/moin/1.9
2009-08-11T20:02:49 <dreimark> Sepp_: bugfixes not bugs ;)
2009-08-11T20:03:00 <Sepp_> Ahm. Yes :-)
2009-08-11T20:03:36 <Sepp_> I like your wiki code so much. I tried 10 different wikis and this is far the best one.
2009-08-11T20:03:45 <dreimark> Sepp_: we can go to speak in german if there are much problems. but some of the people can't follow then
2009-08-11T20:03:52 <dreimark> thx
2009-08-11T20:04:49 <Sepp_> I'm coding a lot on the framework but I always have problems posting it to the community in the right way.
2009-08-11T20:05:15 <Sepp_> Especially the gui editor needs a lot of improvements.
2009-08-11T20:05:37 <Sepp_> I don't understand why so much people don't have a focus on the gui editor. Is there a reason for that?
2009-08-11T20:06:17 <dreimark> well at least me could type faster than using a hand on the mouse
2009-08-11T20:06:29 <ThomasWaldmann> re
2009-08-11T20:07:25 <Sepp_> Maybe. I'm working at Rohde&Schwarz a big bavarian company. I like to install MoinMoin as company wiki but there are a lot of guys which don't like to take care of wiki markup. This is a very very big issue for acceptance.
2009-08-11T20:08:29 <Sepp_> I'm running some kind of trial at the moment. I hate comments like: "Oh my god! My "----" is breaking the table!"
2009-08-11T20:09:30 <dreimark> I like to see some of the stuff fixed. but some more could be only fixed by 2.0++ because of a refactored parser
2009-08-11T20:09:47 <dreimark> ThomasWaldmann: ^^
2009-08-11T20:10:00 <Sepp_> But to be honest: MoinMoin has the best GUI editor implementation after MediaWiki. All the other Wikis I tried lack on a good implementation of WYSIWYG.
2009-08-11T20:10:23 * ThomasWaldmann has dinner
2009-08-11T20:10:36 <Sepp_> Enjoy :-)
2009-08-11T20:11:17 <Sepp_> I also found a quick solution for not seeing the <<BR>> macro in the GUI editor anymore. But with testing everything alone I'm lost.
2009-08-11T20:13:03 <dreimark> I've introduced that workaround. good if it could be fixed differently. a good page for testing the editor/converter is http://moinmo.in/MoinAPI/Beispiele
2009-08-11T20:13:22 <Sepp_> Can you recommend me a good way to test my GUI editor improvements? Do you have some kind of hardcore wiki markup/html code which will be parsed with some kind of unit test? Sorry for asking so much but I like to
2009-08-11T20:13:28 <Sepp_> contribute
2009-08-11T20:13:55 <dreimark> see http://moinmo.in/MoinDev
2009-08-11T20:14:00 <dreimark> we use py.test
2009-08-11T20:15:08 <dreimark> but for the gui editor itselfs it is not so useable
2009-08-11T20:15:45 <dreimark> using some pages and checking what it has changed
2009-08-11T20:16:20 <dreimark> you can do a package of the pages you want to test in your setup
2009-08-11T20:17:42 <Sepp_> In my opinion the GUI editor (FCKeditor) itself is rather good. The most issues with the GUI editor are in "text_html_text_moin_wiki.py".
2009-08-11T20:18:11 <Sepp_> Converting html to wiki markup and converting wiki markup to html is sometimes a little buggy.
2009-08-11T20:18:55 <Sepp_> @dreimark: what do you mean with "do a package of pages"? Do you mean I can send you my framework in a ZIP-file? This would ease things a lot :-)
2009-08-11T20:18:55 <moinBot> Sepp_: Error: "dreimark:" is not a valid command.
2009-08-11T20:19:13 <Sepp_> dreimark_: what do you mean with "do a package of pages"? Do you mean I can send you my framework in a ZIP-file? This would ease things a lot :-)
2009-08-11T20:19:13 <dreimark> yes, we know most will be easier to fix in http://hg.moinmo.in/moin/2.0-storage-dom-bblank/
2009-08-11T20:19:52 <dreimark> Sepp_: I mean you can a http://moinmo.in/MoinAPI/Beispiele?action=PackagePages
2009-08-11T20:20:20 <dreimark> and install that page in your wiki and try if it looks the same after your changes
2009-08-11T20:20:48 <Sepp_> dreimark_: I can try that but this page dont has lists.
2009-08-11T20:21:21 <dreimark> ah ok
2009-08-11T20:21:24 <Sepp_> ;-)
2009-08-11T20:22:20 <Sepp_> Is there a "GUI editor loving guy" in the MoinMoin team?
2009-08-11T20:22:51 <dreimark> none of us hates it, but if you want to be that man you are welcome
2009-08-11T20:23:03 * ThomasWaldmann finished
2009-08-11T20:23:13 <ThomasWaldmann> Sepp_: not really, that's the main problem
2009-08-11T20:23:23 <ThomasWaldmann> so, if you are, feel welcome :)
2009-08-11T20:25:37 <Sepp_> MoinMoin would do a rocket launch if it would have a better GUI editor. I'm convinced. Everybody in my environment loves it's features (ACL, PDF generation, history, navigation, macros, ...) but after the third table breaking in the GUI editor ... you don't want to the their faces. And "nobody" likes to program in Wiki markup. I assume that the linux guys love that but my engineer colleagues...
2009-08-11T20:25:38 <Sepp_> ...hate it ;-)
2009-08-11T20:25:54 <Sepp_> Yes yes ... throw the ball to me. I understand :-)
2009-08-11T20:26:37 <ThomasWaldmann> as dreimark already point out, there might be indirect improvements in the future (2.0):
2009-08-11T20:27:07 <Sepp_> Do you have a time schedule for the 2.0 (maybe a risky question, I know ;-) )
2009-08-11T20:27:12 <ThomasWaldmann> a) we might merge domtree code soon, that stuff is able to emit much cleaner (x)html than the current parser/formatter
2009-08-11T20:27:40 <ThomasWaldmann> b) mm20 can store any item type, so we could even store html -> no problems any more
2009-08-11T20:27:53 <ThomasWaldmann> well, except that you can't use the text editor then any more
2009-08-11T20:28:31 <Sepp_> I only use it to remove errors from the html <-> wiki markup conversion
2009-08-11T20:28:41 <ThomasWaldmann> BUT: there are no html -> domtree, domtree -> wiki markup converters yet in mm20
2009-08-11T20:29:01 <Sepp_> What does this mean in practice?
2009-08-11T20:29:09 <ThomasWaldmann> not before 2010/2011
2009-08-11T20:29:39 <ThomasWaldmann> that the gui editing stuff does not yet work in 2.0 as it does in 1.9
2009-08-11T20:29:47 <dreimark> dimazest: the good is that the second and third test of test_title_search_simple just works, the bad that it looks like SearchTestPage' isn't in the xapian index
2009-08-11T20:29:58 <ThomasWaldmann> but that it can be done better in 2.0 than in 1.9
2009-08-11T20:30:40 <Sepp_> Thomas_: I'm eager to see Version 2.0 running on my company on some day. But I hope that you are open for GUI editor improvements in the 1.9 and following versions.
2009-08-11T20:30:59 <ThomasWaldmann> so, if you like to help with gui editing, you can do that at 2 places :) Depending on your priorities.
2009-08-11T20:31:17 <ThomasWaldmann> yes, minor changes can still get into 1.9.
2009-08-11T20:31:34 <ThomasWaldmann> we just have to be careful not to fix one thing and break another.
2009-08-11T20:32:05 <ThomasWaldmann> (small fixes can also be done in 1.8 and pulled into 1.9)
2009-08-11T20:32:21 <Sepp_> Thomas_: Do you have time to quickly check my first patch and give me feedback? Don't know if my post is formally correct and useful: http://www.moinmo.in/MoinMoinPatch/GuiRemoveEmptyListItems
2009-08-11T20:32:37 <dreimark> Sepp_: please use the tab key for completion
2009-08-11T20:32:48 <dreimark> otherwise it won't be highligted
2009-08-11T20:33:11 <Sepp_> tab key? where?
2009-08-11T20:33:30 <dreimark> Sepp_: in my irc client it is the tab key on the keyboard
2009-08-11T20:33:41 <dreimark> which autocomplets the name
2009-08-11T20:33:44 <ThomasWaldmann> Sepp_: sure
2009-08-11T20:37:35 <ThomasWaldmann> Sepp_: i see like this suppresses list elements, but is that the root problem?
2009-08-11T20:38:10 <ThomasWaldmann> i mean, if you use the gui editor to make some empty list items, the converter should output this:
2009-08-11T20:38:13 <ThomasWaldmann> *
2009-08-11T20:38:15 <ThomasWaldmann> *
2009-08-11T20:38:16 <ThomasWaldmann> *
2009-08-11T20:38:40 <Sepp_> The converter makes something like this: "* * * "
2009-08-11T20:39:15 <Sepp_> Try it yourself. It even works on the MoinMoin pages.
2009-08-11T20:40:00 <Sepp_> Maybe the problem is that there is no line break after an empty list item.
2009-08-11T20:40:03 <ThomasWaldmann> the list parser/formatter is buggy
2009-08-11T20:40:25 <ThomasWaldmann> the above markup doesnt give 3 list items
2009-08-11T20:42:08 <Sepp_> No: I mean : If you create three empty list items in the GUI editor and you press save and you look at the result in the text editor then you will see "* * *" instead of
2009-08-11T20:42:09 <Sepp_> *
2009-08-11T20:42:11 <Sepp_> *
2009-08-11T20:42:13 <Sepp_> *
2009-08-11T20:42:39 <ThomasWaldmann> yeah, that's another bug :)
2009-08-11T20:42:51 <Sepp_> Great! My first bugfix :-) ??
2009-08-11T20:43:20 <ThomasWaldmann> your fix doesn't create any markup for empty list elements, right?
2009-08-11T20:43:31 <Sepp_> yes. thats right
2009-08-11T20:43:57 <ThomasWaldmann> that's maybe better than now, but not the right fix
2009-08-11T20:44:22 <Sepp_> cause three empty "*" (one row for each) in the text editor are also not interpreted the right way. You only get one empty list item
2009-08-11T20:44:42 <Sepp_> what would be the right fix?
2009-08-11T20:45:16 <Sepp_> I mean, why is it "not the right fix" ?
2009-08-11T20:45:36 <dreimark> dimazest: http://paste.pocoo.org/show/133710/
2009-08-11T20:46:03 <ThomasWaldmann> Sepp_: 3 empty list items wiki create 3 empty list items html
2009-08-11T20:46:04 <dreimark> shows that it has this page in the index but with the wrong rev no
2009-08-11T20:46:21 <ThomasWaldmann> 3 empty list items html need to create 3 empty list items wiki (not none)
2009-08-11T20:46:56 *** vinci_ has quit IRC
2009-08-11T20:47:12 <dreimark> dimazest: if I would have checked len it would tell true but then I won't get the assert
2009-08-11T20:47:51 <ThomasWaldmann> hmm, i guess I know where the real bug is
2009-08-11T20:48:13 <Sepp_> ThomasWaldmann_: You are using IE? I'm using Firefox 3.5. You are right. IE does shot it right. Hm....
2009-08-11T20:48:43 <Sepp_> ThomasWaldmann_: Please don't say it's included in version 2.0 ;-)
2009-08-11T20:49:59 <dreimark> no he doesn't
2009-08-11T20:50:45 <Sepp_> ThomasWaldmann_: In my opinion there is a missing line break after the "* ".
2009-08-11T20:51:40 <ThomasWaldmann> no IE here :)
2009-08-11T20:51:52 <ThomasWaldmann> Sepp_: i have an idea, do you want to try it?
2009-08-11T20:52:01 <Sepp_> fore sure
2009-08-11T20:52:12 <Sepp_> for sure (sorry : my bad english)
2009-08-11T20:53:24 <ThomasWaldmann> before, indent, markup = self._get_list_item_markup(node, i)
2009-08-11T20:53:25 <Sepp_> ThomasWaldmann_: Which browsers do you use? If you're using firefox than you also should see only one empty bullet instead of three
2009-08-11T20:53:46 <ThomasWaldmann> that is determining the correct indentation and markup
2009-08-11T20:53:52 <ThomasWaldmann> -> we need that
2009-08-11T20:54:04 <dreimark> dimazest: that is how SearchTestPage is in the index http://paste.pocoo.org/show/133718/
2009-08-11T20:54:16 <ThomasWaldmann> self.text.extend([before, indent, markup])
2009-08-11T20:54:27 <ThomasWaldmann> this writes it to the wiki markup output
2009-08-11T20:54:43 <ThomasWaldmann> i.e " *" (or so)
2009-08-11T20:55:05 <ThomasWaldmann> an empty list item requires a \n next
2009-08-11T20:55:06 <ThomasWaldmann> self.process_list_item(i, indent)
2009-08-11T20:55:16 <ThomasWaldmann> but this call is not doing that
2009-08-11T20:55:21 <Sepp_> ok
2009-08-11T20:55:31 <ThomasWaldmann> so, the fix has to be in that function
2009-08-11T20:55:44 <Sepp_> ok. i'll investigate that there
2009-08-11T20:56:29 <ThomasWaldmann> so check there for emptyness
2009-08-11T20:57:26 <ThomasWaldmann> if it is empty, it needs to do that:
2009-08-11T20:57:27 <ThomasWaldmann> self.text.append(self.new_line)
2009-08-11T20:57:50 <ThomasWaldmann> that terminates the wiki list item line and jumps to next line
2009-08-11T21:02:06 <Sepp_> yes
2009-08-11T21:02:13 <Sepp_> I came to the same solution
2009-08-11T21:03:14 <ThomasWaldmann> btw, if you create a patch, do not put your name into a inline comment
2009-08-11T21:03:30 <ThomasWaldmann> you can add it to the header or we add it to the commit comment
2009-08-11T21:03:53 <ThomasWaldmann> do you use hg?
2009-08-11T21:04:14 <Sepp_> yes
2009-08-11T21:04:52 <ThomasWaldmann> then have a good testing, commit a changeset to your local 1.8 repo clone
2009-08-11T21:05:04 <ThomasWaldmann> end then export that changeset
2009-08-11T21:05:10 <ThomasWaldmann> and...
2009-08-11T21:06:28 <Sepp_> and?
2009-08-11T21:06:53 <Sepp_> "export changeset" means that I will update the online repository?
2009-08-11T21:08:49 <dreimark> means that you get a file which we can use for updating
2009-08-11T21:09:47 <Sepp_> dreimark_: Ok. In which version would you commit this updates? To a 1.8.5 or to the 1.9 ?
2009-08-11T21:10:10 <dreimark> ThomasWaldmann: suggested 1.8 and we merge it into 1.9
2009-08-11T21:17:04 <Sepp_> I commited everything to my local repo. How can I export the changeset now? Don't find a context button for that.
2009-08-11T21:17:40 <dreimark> hg export -o name.patch csno
2009-08-11T21:18:10 <Sepp_> I'm using the GUI. Sorry. I'm a really GUI lover :-)
2009-08-11T21:18:56 <dreimark> in eclipse?
2009-08-11T21:19:33 <dreimark> or you can use the local server and click on a cs
2009-08-11T21:19:40 <dreimark> e.g
2009-08-11T21:19:43 <dreimark> http://hg.moinmo.in/moin/1.9/rev/dce251f8cfc3
2009-08-11T21:19:47 <Sepp_> I'm working on Windows Vista with the total commander
2009-08-11T21:19:56 <dreimark> that can be save to a file then
2009-08-11T21:20:15 <ThomasWaldmann> Sepp_: tortoise?
2009-08-11T21:20:18 <dreimark> that is unknown to me (both)
2009-08-11T21:20:27 <Sepp_> I found it. Now I have a automatically created patch file called "MoinMoin_rev4357.patch". Is this what you need? I'm using HG
2009-08-11T21:20:42 <ThomasWaldmann> what hg gui?
2009-08-11T21:21:01 <Sepp_> tortoisehg
2009-08-11T21:21:29 <ThomasWaldmann> attach it to that wiki page
2009-08-11T21:23:55 <Sepp_> ok
2009-08-11T21:26:25 <Sepp_> Updated my Patch page http://www.moinmo.in/MoinMoinPatch/GuiRemoveEmptyListItems
2009-08-11T21:26:35 <Sepp_> Is this what you mean?
2009-08-11T21:26:50 <Sepp_> Sorry: Is this like you want to have it?
2009-08-11T21:27:48 <ThomasWaldmann> Sepp_: do you know hg rollback? :)
2009-08-11T21:28:21 <Sepp_> No. What is that and why should I use it? Ok: I made another error :-) ?
2009-08-11T21:28:34 <dreimark> see copyright date string
2009-08-11T21:29:00 <dreimark> also the date info line 25 is not needed
2009-08-11T21:29:08 <dreimark> it is in in the repo
2009-08-11T21:29:20 <ThomasWaldmann> the docstring is not a history of changes (hg has that history in the commit comments), so it is just year and name there
2009-08-11T21:29:40 <ThomasWaldmann> and add a , at the end of the prev. line
2009-08-11T21:30:08 <ThomasWaldmann> line 25: the comment is too special
2009-08-11T21:30:13 <dreimark> also it is good to tell at the commit msg, text_html_text_moin_wiki:
2009-08-11T21:30:16 <ThomasWaldmann> no date
2009-08-11T21:30:34 <ThomasWaldmann> and it does not only apply to * lists, but also to other lists
2009-08-11T21:30:34 <dreimark> a reference to the moinbug page at the commit string
2009-08-11T21:30:49 <dreimark> "Empty list items in the GUI editor are converted to wrong wiki markup after saving the changes."
2009-08-11T21:30:59 <dreimark> that is hopefully the patch not doing
2009-08-11T21:31:23 <Sepp_> Ok. I'm confused now but I'm sure we can fix this. Could you summarize the changes that I have to do once for me? I have a lot of additional changes to the GUI editor and like to make the bugfixes for that.
2009-08-11T21:31:35 <ThomasWaldmann> # if this is a empty list item, we just terminate the line
2009-08-11T21:32:04 <ThomasWaldmann> did you commit all those changes to that repo?
2009-08-11T21:33:04 <Sepp_> no
2009-08-11T21:33:17 <Sepp_> I deleted the other changes to get a good diff file
2009-08-11T21:33:46 <Sepp_> If I didn't delete it, the diff file would contain the other changes also
2009-08-11T21:33:53 <ThomasWaldmann> if you just want to undo the last commit, you can use rollback
2009-08-11T21:34:02 <ThomasWaldmann> (if it is just local)
2009-08-11T21:34:13 <ThomasWaldmann> then do the change again, commit
2009-08-11T21:35:33 <ThomasWaldmann> ah, and please fix your user name in the [ui] section of hg configuration
2009-08-11T21:35:47 <ThomasWaldmann> that should be an email addr or something similar
2009-08-11T21:35:54 <ThomasWaldmann> you need to do that before committing
2009-08-11T21:36:26 <ThomasWaldmann> Sepp_: http://hg.moinmo.in/moin/1.8/rev/efd8087a3062 see that for a typical changeset
2009-08-11T21:55:32 <Sepp_> Ok. I uploaded a new diff file. Can you check it again, please and give me feedback?
2009-08-11T21:58:37 * ThomasWaldmann looks
2009-08-11T21:58:41 <Sepp_> ...
2009-08-11T21:59:33 <ThomasWaldmann> cool :)
2009-08-11T21:59:49 <ThomasWaldmann> did you test it? with some different cases?
2009-08-11T22:00:09 <Sepp_> yes
2009-08-11T22:00:17 <Sepp_> for now it works great.
2009-08-11T22:00:34 <Sepp_> but I'll test it again and again together with my colleagues in the office
2009-08-11T22:00:47 <Sepp_> in a live project wiki
2009-08-11T22:00:55 <Sepp_> for my development projects
2009-08-11T22:02:26 <ThomasWaldmann> Sepp_: you could run the office wiki from a hg workdir
2009-08-11T22:02:56 <Sepp_> what's the advantage?
2009-08-11T22:03:49 <dreimark> you have only to hg pull to be uptodate
2009-08-11T22:04:21 <CIA-38> Josef Meier (jo.meier@gmx.de) default * 4357:d5d9ef80d39b 1.8/MoinMoin/converter/text_html_text_moin_wiki.py:
2009-08-11T22:04:21 <CIA-38> Fixes a bug with empty list items in the GUI editor.
2009-08-11T22:04:21 <CIA-38> See also http://www.moinmo.in/MoinMoinPatch/GuiRemoveEmptyListItems
2009-08-11T22:05:02 <Sepp_> what does this mean <CIA-38> ???
2009-08-11T22:05:16 <dreimark> see cia.vc
2009-08-11T22:05:26 <dreimark> it is a bot and now you are famous
2009-08-11T22:05:57 <dreimark> http://cia.vc/stats/project/moin
2009-08-11T22:06:29 <Sepp_> hooray. I always wanted to be famous ;-)
2009-08-11T22:06:34 <ThomasWaldmann> :D
2009-08-11T22:07:33 <Sepp_> Is the change now available in the current version of MoinMoin if I download it through the MoinMoin site?
2009-08-11T22:08:03 <ThomasWaldmann> roundtripping works :)
2009-08-11T22:08:18 <ThomasWaldmann> if you clone the 1.8 repo, you have it
2009-08-11T22:08:34 <ThomasWaldmann> it will also be in 1.8.5 at some time
2009-08-11T22:09:02 <Sepp_> Ok.
2009-08-11T22:09:33 <Sepp_> Now I have a solution for http://www.moinmo.in/MoinMoinBugs/GuiEditorLineBreak
2009-08-11T22:09:43 <Sepp_> But it is so simple that I'
2009-08-11T22:09:49 <Sepp_> m not sure, it is a good solution :-)
2009-08-11T22:10:06 <ThomasWaldmann> btw, it also works without www.
2009-08-11T22:11:00 <dreimark> dimazest: found a bug http://paste.pocoo.org/show/133732/
2009-08-11T22:11:02 <Sepp_> Is it a good coding style to just replace the <<BR>> markup with <br> html tag?
2009-08-11T22:11:40 <Sepp_> I don't like to see the yellow <<BR>> in the GUI editor. So I replace the <<BR>> with HTML <br> before viewing it in the GUI editor
2009-08-11T22:12:24 <dimazest> dreimark: yes, i have not updated deleteon of a page, it wasn't covered by tests
2009-08-11T22:13:02 <dimazest> it tries to use old xapwrap which is not imported
2009-08-11T22:14:51 <dreimark> hmm, also I wonder about the 9999999 revno.
2009-08-11T22:15:07 <dimazest> me too
2009-08-11T22:15:07 <ThomasWaldmann> Sepp_: the <<BR>> macro is an explicit, wanted br
2009-08-11T22:15:52 <dreimark> dimazest: it is not the reason for the failing test I changed it too 1 for testing
2009-08-11T22:15:52 <ThomasWaldmann> if you transform it to <br>, you can't keep it apart from any br the gui editor might insert (and which you maybe don't want)
2009-08-11T22:16:35 <dreimark> dimazest: it looks like it could find underlay pages currently but nothing from data
2009-08-11T22:16:43 <Sepp_> ThomasWaldmann:I know that. But every line break in the GUI editor is automatically converted to the BR macro. And after calling the editor again, you always see the text <<BR>> and no line breaks. I don't like that. So I convert the <<BR>> to a HTML line break. Looks much better.
2009-08-11T22:17:32 <dreimark> Sepp_: and to what is that converted in the page on saving?
2009-08-11T22:18:00 <ThomasWaldmann> it is?
2009-08-11T22:20:32 <Sepp_> dreimark: a) In the GUI editor I make hard line breaks by pressing Shift+Enter. b) after saving the result I let the MoinMoin converter convert the <br> to <<BR>>I don't changed that. c) after opening the GUI editor again I convert the <<BR>> to <br> in the file "text_gedit.py". This only affects the visuals in the GUI editor.
2009-08-11T22:21:09 <ThomasWaldmann> Sepp_: it doesn't convert <br> to <<BR>> for me
2009-08-11T22:21:45 <Sepp_> ThomasWaldmann: I forgot that I made a change in text_html_text_moin_wiki.py again
2009-08-11T22:22:12 <Sepp_> def process_br(self, node):
2009-08-11T22:22:14 <Sepp_> self.text.append("<<BR>> ") #self.new_line)
2009-08-11T22:22:40 <Sepp_> Don't saw any negative effect by not using the "self.new_line". Didn't understand the comment nearby.
2009-08-11T22:22:57 <ThomasWaldmann> iirc the problem with br was that some browsers do to many of them
2009-08-11T22:23:42 <Sepp_> Where did you have this much <br>'s? In the wiki markup result or on the html page?
2009-08-11T22:24:00 <ThomasWaldmann> in html
2009-08-11T22:24:15 <Sepp_> Do you know, which browsers are affected?
2009-08-11T22:24:28 <ThomasWaldmann> the general problem with that stuff is that browsers behave differently
2009-08-11T22:24:43 <ThomasWaldmann> not sure, but IE is famous for making troubles :D
2009-08-11T22:25:14 <Sepp_> My IE works fine.
2009-08-11T22:25:39 <Sepp_> checked it (version 8). also checked it on Firefox.
2009-08-11T22:26:04 <Sepp_> Did the browsers crash or what was the problem?
2009-08-11T22:26:38 <dreimark> there was a bug page about itr
2009-08-11T22:29:16 <Sepp_> could you tell me the page, please? I think, that this <<BR>> thing is really anoying. Me and my colleagues don't like to see it in the GUI editor. It confuses people a lot. I'm sorry for surging so much ;-)
2009-08-11T22:29:23 <ThomasWaldmann> Sepp_: the problem is that you might get more <<BR>> than you want
2009-08-11T22:30:54 <Sepp_> But how can there be more <<BR>> than the ones I create? You mean that the GUI editor creates additional HTML <br> markups on the Internet explorer?
2009-08-11T22:31:03 <Sepp_> Then this has to be fixed in the GUI Editor
2009-08-11T22:32:24 *** franklin_ has quit IRC
2009-08-11T22:32:50 <dimazest> dreimark: may be it is good idea to use temporary generative test for test_title_search_simple, so we can see which pages are found and which are not
2009-08-11T22:33:07 <dreimark> yes
2009-08-11T22:33:20 <dimazest> also i would like to use form yiels 'some text', test_func, argument1, argument2
2009-08-11T22:33:29 <dimazest> it works only with py 1.0
2009-08-11T22:33:56 <dimazest> but just for a while, then i'll make tests compatible with an old py.version
2009-08-11T22:34:17 <dreimark> ok, but add py.skip if one has a too old py version
2009-08-11T22:36:42 <ThomasWaldmann> Sepp_: i don't remember it exactly, but I guess something created br for every time your press enter
2009-08-11T22:36:51 <ThomasWaldmann> or was it in empty table cells?
2009-08-11T22:37:27 <Sepp_> ThomasWaldmann: there is a big difference. Cause creating a <br> for every ENTER is correct in my opinion.
2009-08-11T22:37:39 <dreimark> dimazest: can you remove that dependency for xapidx too
2009-08-11T22:37:49 <dreimark> that makes it easier for me
2009-08-11T22:37:50 <ThomasWaldmann> Sepp_: rather </p>
2009-08-11T22:38:31 <Sepp_> ThomasWaldmann: GUI Editor creates a <p> if you press Enter. Thats correct. GUI editor creates a <br> if you press SHIFT
2009-08-11T22:38:36 <Sepp_> + ENTER. Also correct
2009-08-11T22:39:37 <ThomasWaldmann> that's ok, yes
2009-08-11T22:40:39 <dreimark> Sepp_: how behaves shift + enter in tables?
2009-08-11T22:40:50 <Sepp_> dreimark: It works also fine.
2009-08-11T22:40:59 <Sepp_> it creates <br>
2009-08-11T22:41:01 <Sepp_> now
2009-08-11T22:41:07 <dimazest> dreimark: http://paste.pocoo.org/show/133743/ skip like this?
2009-08-11T22:41:52 <dreimark> for now yes, later on the task2 version checker could be used ;)
2009-08-11T22:42:05 <Sepp_> <br> doesn't brake tables, cause the <<BR>> has no line break at the end. Line breaks break tables.
2009-08-11T22:42:31 <ThomasWaldmann> Sepp_: we can change that, but there needs to be some research before:
2009-08-11T22:42:40 <ThomasWaldmann> a) check different browsers
2009-08-11T22:42:49 <ThomasWaldmann> b) check different markup items
2009-08-11T22:43:29 <ThomasWaldmann> a) includes IE6,7,8,FF,Opera, maybe Safari
2009-08-11T22:43:42 <dreimark> Sepp_: nside a cell, type aaa<ENTER>aaa<SHIFT+ENTER>aaa
2009-08-11T22:43:48 <ThomasWaldmann> b) paragraphs, tables, ...
2009-08-11T22:44:44 <Sepp_> dreimark: Paragraphs don't work for me but I didn't take care about that for the moment. I will do that next.
2009-08-11T22:45:38 <Sepp_> SHIFT-ENTER in a cell produces a correct line Break. A simple ENTER doesn't create a line break. But this should also work if you append a <br> to the <p>
2009-08-11T22:45:39 <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4970:605b2da7765e 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: Test for xapian search was added which checks that index consists all required pages.
2009-08-11T22:46:09 <dreimark> I like to see Bug report pages and the patch on it so that it could be reporduced in current moin and after applying that it works
2009-08-11T22:46:11 <Sepp_> ThomasWaldmann: Which versions of Firefox?
2009-08-11T22:47:31 <Sepp_> dreimark: Should I add a comment for http://www.moinmo.in/MoinMoinBugs/GuiEditorLineBreak or create a new Patch page?
2009-08-11T22:48:39 <dreimark> please use this page, don't create dups (try to do not)
2009-08-11T22:50:24 <Sepp_> Hm ... you don't remember the bug report for the <<BR>> problem, isn't it? Would be of great help.
2009-08-11T22:51:33 <dreimark> later I can search for it too, currently I debug a problem in 1.9-xapian-dmilajevs
2009-08-11T22:54:48 <Sepp_> could you post it on the gui editor line break page? would be nice.
2009-08-11T22:57:32 <ThomasWaldmann> 3.x
2009-08-11T22:58:56 <dimazest> it also possible to search like "re:\bMoin\b"...
2009-08-11T23:01:04 <Sepp_> ThomasWaldmann: ?
2009-08-11T23:01:15 <ThomasWaldmann> (22:46) < Sepp_> ThomasWaldmann: Which versions of Firefox?
2009-08-11T23:01:33 <Sepp_> ThomasWaldmann: Before 3.x isn't important?
2009-08-11T23:02:08 *** franklin has joined #moin-dev
2009-08-11T23:02:11 <ThomasWaldmann> well, i think ff users are often quite up-to-date
2009-08-11T23:02:15 *** franklin has quit IRC
2009-08-11T23:05:35 <dreimark> dimazest: this _do_queued_updates crashes always if I call create_page
2009-08-11T23:06:32 <Sepp_> ThomasWaldmann: I would assume the same.
2009-08-11T23:07:05 <Sepp_> When do you think version 1.9 will be released?
2009-08-11T23:07:15 <dreimark> Sepp_: this year
2009-08-11T23:07:39 <dreimark> we have some soc work which we want to add beforehand
2009-08-11T23:07:39 <ThomasWaldmann> dennda: 2.23 + default acls:
2009-08-11T23:08:13 <ThomasWaldmann> (etc) - please note that acl == access control list and you only have one (the list has multiple entries, though)
2009-08-11T23:10:40 <dreimark> dimazest: IndexError("Mset index out of range") happens if I look for an indexed page of data
2009-08-11T23:12:05 <dreimark> whild it works if the page was in underlay
2009-08-11T23:12:10 <dreimark> s/d/e/
2009-08-11T23:16:53 <ThomasWaldmann> dennda: 1.14 + self.acl_rights_valod = valid
2009-08-11T23:18:26 <dimazest> dreimark: which pages are data pages?
2009-08-11T23:18:38 <dreimark> 1.9-xapian-dmilajevs/wiki/data
2009-08-11T23:18:46 <dreimark> the pages done by crea
2009-08-11T23:18:49 <dreimark> te_page
2009-08-11T23:19:10 <dennda> oha
2009-08-11T23:19:26 <dreimark> I think they are not correctly indexed
2009-08-11T23:19:30 <dennda> sorry, will fix that tomorrow
2009-08-11T23:20:19 <Sepp_> ThomasWaldmann : The <<BR>> issue also prevents that lists get broken. If you use SHIFT+ENTER in lists sometimes the <br> will be replaced by "\n" which breaks lists. "The old solution" handles lists and SHIFT+ENTER correct. But as promised I will check it with different browsers.
2009-08-11T23:21:17 <dimazest> dreimark: http://hg.moinmo.in/moin/1.9-xapian-dmilajevs/rev/605b2da7765e this test should check that all neded pages are indexed
2009-08-11T23:22:21 <dreimark> ok
2009-08-11T23:24:34 <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4971:77496dd99338 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: Search tests are skipped if py version is not 1.0.0
2009-08-11T23:24:36 <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4972:0e4eff722cac 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: Test for xapian_term builds queries which should not be empty, it also checks queries like 'case:moin' (without specified prefix like language:)
2009-08-11T23:25:25 <dreimark> dimazest: that 1.9 + return MoinSearchConnection('tests/wiki/data/cache/xapian/index') could be replaced by os.path.join(request.cfg.cache_dir, 'xapian/index')
2009-08-11T23:29:19 <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4973:8b51025823e0 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: pep8 and typo fixes.
2009-08-11T23:29:36 <dimazest> ok
2009-08-11T23:32:10 <dreimark> brb
2009-08-11T23:37:20 *** amartani has joined #moin-dev
2009-08-11T23:39:23 <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4974:d0c9c13dbeda 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: Xapian index location is not hardcoded in tests.
2009-08-11T23:49:27 <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4975:b73ced174002 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: test_title_search_simple is now generative test.
2009-08-11T23:53:56 <dreimark> re
2009-08-11T23:56:45 <dreimark> dimazest: do you have seen my message about SystemInfo?
2009-08-11T23:59:06 <dreimark> 18 failed, 57 passed in 143.14 seconds
2009-08-11T23:59:42 <dreimark> all three test_title_search_simple work now MoinMoin: MoinMoinChat/Logs/moin-dev/2009-08-11 (last edited 2009-08-10 23:00:02 by IrcLogImporter)
