MoinMoin: MoinMoinChat/Logs/moin-dev/2009-08-14

2009-08-14T01:03:42  *** amartani has quit IRC
2009-08-14T02:15:37  *** amartani has joined #moin-dev
2009-08-14T02:19:19  *** JosefMeier has quit IRC
2009-08-14T02:48:55  *** y84 has quit IRC
2009-08-14T03:48:44  *** amartani has quit IRC
2009-08-14T04:31:07  *** amartani has joined #moin-dev
2009-08-14T05:27:26  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6750:6558a2193252 2.0-storage-editor-amartani/MoinMoin/action/show.py: Real-time editor: Release lock on show action
2009-08-14T05:27:28  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6751:bd1d3645f7e6 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/common/js/text_editor.js: Real-time editor: After save, redirect releasing lock
2009-08-14T06:48:47  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6585:9f56aa14c42a 2.0-storage/MoinMoin/storage/backends/hg.py: PEP8 fix
2009-08-14T07:10:22  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6586:8b4b9d859689 2.0-storage/setup.py: add MoinMoin.items to setup.py
2009-08-14T08:06:54  <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4979:3277ee13b6c7 1.9-xapian-dmilajevs/MoinMoin/macro/SystemInfo.py: Xapian2009: System info uses XapianSearch to access information about xapian index.
2009-08-14T08:06:56  <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4980:bb2317d4984b 1.9-xapian-dmilajevs/MoinMoin/search/ (Xapian.py _tests/test_search.py): Xapian2009: Index field actions and names were updated.
2009-08-14T08:06:58  <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4981:dbec2f99c0dc 1.9-xapian-dmilajevs/MoinMoin/search/ (Xapian.py queryparser.py):
2009-08-14T08:06:58  <CIA-38> Xapian2009: BaseExpression._get_query_for_search_re() now checks all field
2009-08-14T08:06:58  <CIA-38> values, not only the first one. xapian_term() returns not empty queries for
2009-08-14T08:07:00  <CIA-38> link:re: and link:re:case:. Categories are stored as they are, they are not
2009-08-14T08:07:02  <CIA-38> lowercased. Comment why xapian_term for category:re: does not work is added.
2009-08-14T08:38:03  <ThomasWaldmann> dennda: moin
2009-08-14T08:38:30  <ThomasWaldmann> dennda: sqla code and the test has to check for minimum sqla version required
2009-08-14T08:39:00  <ThomasWaldmann> otherwise it will try to run the tests e.g. if you have sqla 0.4.8 and fail due to:
2009-08-14T08:39:12  <ThomasWaldmann> E   from sqlalchemy.orm.exc import NoResultFound
2009-08-14T08:39:12  <ThomasWaldmann> >   ImportError: No module named exc
2009-08-14T09:06:22  *** franklin has joined #moin-dev
2009-08-14T09:34:15  <dreimark> moin
2009-08-14T09:38:48  <dreimark> dimazest: there is not mimetype text/text defined
2009-08-14T09:52:55  <dreimark> some of our config options could be changed to set instead of list
2009-08-14T10:01:52  <ThomasWaldmann> be careful with that
2009-08-14T10:15:11  <dreimark> dimazest: please fix NEXT builtin because that (wrong request) has side effects to linkto tests
2009-08-14T10:16:31  <dreimark> after that is fixed remove your test pages from wiki/data/pages
2009-08-14T10:46:45  *** grzywacz has joined #moin-dev
2009-08-14T11:03:43  *** vinci_ has quit IRC
2009-08-14T11:18:28  *** adb has joined #moin-dev
2009-08-14T11:39:02  *** TheSheep has quit IRC
2009-08-14T11:40:00  *** TheSheep has joined #moin-dev
2009-08-14T12:02:30  *** adb has left #moin-dev
2009-08-14T12:25:17  *** franklin_ has joined #moin-dev
2009-08-14T12:35:17  *** franklin has quit IRC
2009-08-14T12:49:10  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6587:78370b29019c 2.0-storage/MoinMoin/storage/ (_tests/test_backends_sqla.py backends/sqla.py): storage: sqla: metadata locking fixes
2009-08-14T12:49:11  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6588:9bddc6b4e7cf 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: don't commit() after every chunk, but flush()
2009-08-14T12:49:13  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6589:715c7d2bbaa5 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: unique constraints for itemname and revision number
2009-08-14T12:49:16  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6590:605d6129305b 2.0-storage/MoinMoin/storage/ (_tests/test_backends_sqla.py backends/sqla.py): storage: sqla: testcase fixes
2009-08-14T12:49:18  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6591:2ebb379f4708 2.0-storage/MoinMoin/storage/_tests/test_backends_sqla.py: storage: sqla tests: test fixes. require sqla 0.5.4
2009-08-14T12:49:24  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6592:a0879f3aaf43 2.0-storage/ (MoinMoin/storage/backends/hg.py setup.py): storage: merge remote 2.0-storage
2009-08-14T13:06:03  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6593:00b28693d471 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: index important columns
2009-08-14T13:51:05  <dimazest> dreimark: which mimetype should i use?
2009-08-14T13:52:36  <dimazest> dreimark: i have not understoad about the next builtin
2009-08-14T15:18:19  <dreimark> dimazest: in builtin is a new request object builded
2009-08-14T15:18:28  <dreimark> this is using the wrong wikiconfig
2009-08-14T15:19:52  <dreimark> if the tests run, we already have a request, a cfg,  etc. - for the tests there is no need to reinvent that  all
2009-08-14T15:20:01  <dreimark> so the scriptrequest stuff should be only done when run  from a script (because the admin does and moin ...  index script cmd)
2009-08-14T15:20:22  <dreimark> repeating what ThomasWaldmann explained yesterday
2009-08-14T15:21:18  <dreimark> http://hg.moinmo.in/moin/1.9-xapian-dmilajevs/file/dbec2f99c0dc/MoinMoin/search/builtin.py#l267
2009-08-14T15:21:53  <dreimark> this may be usefull for the moin script command but for the tests it is not needed
2009-08-14T15:22:19  <dimazest> ok, i've just found that talk
2009-08-14T15:22:29  <dreimark> as mimetype you could use text/moin-wiki (ThomasWaldmann is that the right one)
2009-08-14T15:23:09  <dreimark> ok,
2009-08-14T15:23:12  <dreimark> bbl
2009-08-14T15:24:11  <dimazest> is text/wiki ok?
2009-08-14T15:37:43  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6594:66ff69d4bc5d 2.0-storage/MoinMoin/storage/ (_tests/test_backends.py backends/sqla.py): storage: sqla: start fixing revision metadata handling
2009-08-14T15:45:58  *** JosefMeier has joined #moin-dev
2009-08-14T15:49:07  <dreimark> dimazest: it is rather mimetype: text/moin-wiki
2009-08-14T15:51:10  <dreimark> may be there is an alias for text/wiki
2009-08-14T16:01:06  *** amartani has quit IRC
2009-08-14T16:06:42  <dreimark> dimazest: 9 failed, 68 passed in 29.28 seconds
2009-08-14T16:07:02  <dreimark> that were more than 3 bugfixes :)
2009-08-14T16:17:39  <dimazest> :)
2009-08-14T16:19:23  <dreimark> with fixing builtin two more will be correct, for testing I did http://paste.pocoo.org/show/134281/ /!\ not the solution
2009-08-14T16:21:36  <dimazest> dreimark: i think pages should be indexed in new thread
2009-08-14T16:22:39  <dreimark> also for the tests?
2009-08-14T16:22:53  <dimazest> yes
2009-08-14T16:22:59  <dreimark> then it needs to get the wikiconfig from tests
2009-08-14T16:23:06  <dreimark> but why first
2009-08-14T16:24:14  <dimazest> indexPagesInNewThread does not change request
2009-08-14T16:25:38  <dimazest> and i do not know how to wait while index is beeing built
2009-08-14T16:25:58  <dimazest> dreimark: what does request.finish does?
2009-08-14T16:26:37  <dreimark>  r = ScriptContext(request.url)
2009-08-14T16:27:57  <dreimark> get makes a new request object
2009-08-14T16:28:01  <dreimark> s(
2009-08-14T16:28:04  <dreimark> s/get//
2009-08-14T16:28:26  <dreimark> in _indexingRequest
2009-08-14T16:28:37  <dreimark> this is new initialized fron wikiconfig
2009-08-14T16:28:56  <dreimark> of wiki (unfortunately)
2009-08-14T16:29:08  <dreimark> then rootpagepath becomes wrong
2009-08-14T16:30:35  <dimazest> yes
2009-08-14T16:31:30  <dimazest> dreimark: but if insted of creating new request object, we just copy it
2009-08-14T16:32:36  <dreimark> we can copy it . if it is recreated there must be the same if causes as usual for the testwiki
2009-08-14T16:36:11  <dreimark> see getPageBasePath in Page and from where it is called
2009-08-14T16:37:04  <dreimark> I have to leave, will look later aqain
2009-08-14T16:37:11  <dreimark> bbl
2009-08-14T16:46:19  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6595:09402dba615a 2.0-storage/MoinMoin/storage/_tests/test_backends_sqla.py: storage: sqla tests: add comment
2009-08-14T16:46:20  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6596:5e31f05686ce 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: introduce first bunch of setup() methods
2009-08-14T16:56:21  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6597:3d17c2057f5a 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: fix iteritems
2009-08-14T17:02:57  *** jdmjdm has joined #moin-dev
2009-08-14T17:35:33  <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4982:8e0a95b9508a 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: text/wiki mimetype is used in tests.
2009-08-14T17:35:34  <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4983:2df0f9d09669 1.9-xapian-dmilajevs/MoinMoin/search/_tests/test_search.py: Xapian2009: grammar fix.
2009-08-14T17:35:36  <CIA-38> Dmitrijs Milajevs <dimazest@gmail.com> default * 4984:5b18f4b603d9 1.9-xapian-dmilajevs/MoinMoin/search/builtin.py: Xapian2009: BaseIndex._indexingRequest() does not creates new request object, but copies existing.
2009-08-14T17:38:12  <ThomasWaldmann> (hopefully that works ^^)
2009-08-14T18:41:53  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6598:48e5728bb17d 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: implement sqlarevision.size
2009-08-14T18:41:57  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6599:0abf9ed21592 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: fix cursor_pos bugs
2009-08-14T18:42:00  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6600:ddb7a3b26058 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: fix item.commit
2009-08-14T20:18:51  <dimazest> dreimark: now ineed to fix category search, the reason it fails is that is must use different regexps for moinsearch and for xapian search
2009-08-14T20:19:17  <ThomasWaldmann> re
2009-08-14T20:19:32  <dimazest> i think if i fix it, i'll also fix mimetype search
2009-08-14T20:19:43  <dimazest> ThomasWaldmann: hi
2009-08-14T20:21:30  <dimazest> since i will refactor LinkSearch and ategorySearch classes, i'll try to reduce repetition of code in the queryparser.py
2009-08-14T20:57:25  *** amartani has joined #moin-dev
2009-08-14T21:23:50  *** JosefMeier has quit IRC
2009-08-14T21:42:57  *** peck has quit IRC
2009-08-14T21:42:57  *** PawelPacana has quit IRC
2009-08-14T21:44:20  *** PawelPacana has joined #moin-dev
2009-08-14T21:45:04  *** peck has joined #moin-dev
2009-08-14T22:56:39  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6601:34902cec5131 2.0-storage/MoinMoin/storage/ (_tests/test_backends_sqla.py backends/sqla.py): storage: sqla: Major session cleanup.
2009-08-14T22:56:39  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6602:fc06bec409bb 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: sqla: more session cleanup
2009-08-14T22:56:42  <CIA-38> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6603:f03ea932ca90 2.0-storage/MoinMoin/storage/backends/sqla.py: storage: Add NAME_LEN constant
2009-08-14T23:29:22  *** amartani has quit IRC
2009-08-14T23:45:18  *** jdmjdm has quit IRC