MoinMoin: MoinMoinChat/Logs/moin-dev/2009-08-18

2009-08-18T00:05:11  *** amartani has joined #moin-dev
2009-08-18T00:31:16  *** amartani has quit IRC
2009-08-18T00:48:58  *** amartani has joined #moin-dev
2009-08-18T01:05:09  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6678:3ef024b36399 2.0-storage/MoinMoin/storage/ (_tests/test_backends_sqla.py backends/sqla.py): sqla backend: simplify Data.read, fix Data.seek, fix seek tests to not test undefined behaviour at beyond EOF.
2009-08-18T01:05:10  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6679:cef045472ad2 2.0-storage/MoinMoin/storage/backends/sqla.py: merged main
2009-08-18T01:35:29  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6680:b6599e9703bf 2.0-storage/MoinMoin/support/sqlalchemy/orm/identity.py: sqlalchemy: fix % rhs operand
2009-08-18T01:35:31  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6681:e7debdb97f97 2.0-storage/MoinMoin/storage/_tests/test_backends_sqla.py: sqla backend test: patch chunksize into class, not instance
2009-08-18T02:24:58  *** grzywacz has quit IRC
2009-08-18T02:55:54  <amartani> ThomasWaldmann: saving on Opera raises error
2009-08-18T02:55:58  <amartani> fix: http://paste.pocoo.org/show/134888/
2009-08-18T04:27:11  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6822:7cbe4058415f 2.0-storage-editor-amartani/MoinMoin/action/ajax_info.py: pep8 fix
2009-08-18T04:27:53  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6884:68b5479b9c7c 2.0-storage-editor-amartani/ (846 files in 197 dirs): merge 2.0-storage
2009-08-18T04:27:55  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6885:f8a5ca679400 2.0-storage-editor-amartani/MoinMoin/items/__init__.py: Real-time editor: Fix error calling method on None
2009-08-18T04:27:57  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6886:0ff9cbfc43b4 2.0-storage-editor-amartani/MoinMoin/items/__init__.py: Real-time editor: Fix merge on conflict detection.
2009-08-18T04:28:01  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6887:f7143173ab51 2.0-storage-editor-amartani/MoinMoin/ (action/ajax_info.py items/__init__.py): Real-time editor: Handle editor conflicts on ajax saving.
2009-08-18T04:28:03  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6888:24a22c9d13dc 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/common/js/text_editor.js: Real-time editor: On save and continue with conflicts, replace text contents and show alert.
2009-08-18T04:28:05  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6889:7e32a6d2ac68 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/common/js/text_editor.js: Real-time editor: Update client rev_no only when receiving new data text content.
2009-08-18T04:28:10  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6890:dab7442e26f6 2.0-storage-editor-amartani/MoinMoin/items/__init__.py: Real-time editor: Do not verify conflicts when saving from mobwrite
2009-08-18T04:28:13  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6891:b4df9eaf7298 2.0-storage-editor-amartani/MoinMoin/items/__init__.py: pep8 fix
2009-08-18T04:59:13  *** amartani has quit IRC
2009-08-18T05:19:29  <CIA-38> Alexandre Martani <amartani AT gmail DOT com> default * 6892:f9e98ea4cc15 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/common/js/text_editor.js: Real-time editor: Update client revision number after save success.
2009-08-18T07:42:46  <dreimark> dimazest: sorry me was extremly tired yesterday
2009-08-18T07:43:03  <dreimark> after nearly 12h sleep I feel much better now
2009-08-18T07:43:45  <dreimark> may be this is how you want to get the dectionary from the class http://paste.pocoo.org/show/134907/
2009-08-18T07:44:14  <dreimark> moin
2009-08-18T07:45:47  <dreimark> I would test for  assert len(d) - 1 == len(temp_dict)
2009-08-18T07:47:48  <dreimark> the test should better update the class and test that afterwards
2009-08-18T08:52:31  <ThomasWaldmann> moin
2009-08-18T08:56:02  * ThomasWaldmann tries the realtimeeditor
2009-08-18T09:37:08  * dreimark kills suse installations
2009-08-18T10:01:14  *** PawelPacana has quit IRC
2009-08-18T10:01:14  *** peck has quit IRC
2009-08-18T10:01:14  *** TheSheep has quit IRC
2009-08-18T10:01:14  *** dennda has quit IRC
2009-08-18T10:02:15  *** peck has joined #moin-dev
2009-08-18T10:02:17  *** PawelPacana has joined #moin-dev
2009-08-18T10:02:30  *** TheSheep has joined #moin-dev
2009-08-18T10:02:40  *** dennda has joined #moin-dev
2009-08-18T10:07:05  *** dennda has quit IRC
2009-08-18T10:07:06  *** dennda has joined #moin-dev
2009-08-18T10:07:11  *** dennda_ has joined #moin-dev
2009-08-18T10:12:10  *** ser has quit IRC
2009-08-18T10:12:10  *** CIA-38 has quit IRC
2009-08-18T10:13:57  *** CIA-34 has joined #moin-dev
2009-08-18T10:17:00  *** tpfennig has joined #moin-dev
2009-08-18T10:21:29  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6682:074d99f91581 2.0-storage/MoinMoin/storage/backends/__init__.py: sqla: use same constants for nsname expansion as for path setup for other backends
2009-08-18T10:21:30  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6683:5f544946d28b 2.0-storage/docs/config_examples/snippets/sqla_backend_wikiconfig_snippet: improved sqla config snippet
2009-08-18T10:22:25  *** ser has joined #moin-dev
2009-08-18T10:37:04  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6684:0aaa5c56e97c 2.0-storage/docs/config_examples/snippets/fs_backend_wikiconfig_snippet: add fs backend snippet
2009-08-18T12:20:19  <ThomasWaldmann> btw, we need more sqlalchemy testers. it's all there: http://hg.moinmo.in/moin/2.0-storage
2009-08-18T12:21:18  <ThomasWaldmann> (the default backend it uses is fs: but there is docs/config_examples/snippets/sqla_backend_wikiconfig_snippet)
2009-08-18T12:22:07  <ThomasWaldmann> also, some more testing of the default fs: backend on win32 would be good.
2009-08-18T12:30:27  <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-storage/rev/3ef024b36399#l2.1 < nice example of de-complicating code
2009-08-18T12:32:34  <dreimark> dimazest: do you have seen my comment ?
2009-08-18T12:34:22  * dreimark tries to guess what amount is used for
2009-08-18T12:35:49  <dreimark> .oO as german I pronounce chunk == junk
2009-08-18T12:35:57  <ThomasWaldmann> amount is how much you want to read
2009-08-18T12:36:32  <ThomasWaldmann> chunk = tschank, junk = dschank
2009-08-18T13:36:01  *** tpfennig has quit IRC
2009-08-18T13:40:35  <dimazest> dreimark: hi, for me yesterday was the same. (too hot here)
2009-08-18T13:43:52  <dimazest> dreimark: but it is not nice to access __ fields/methods just to update a dictionary
2009-08-18T14:35:20  <ThomasWaldmann> hi dimazest
2009-08-18T14:35:35  <ThomasWaldmann> what's the current state? you didn't update the diary since a week.
2009-08-18T14:36:56  <ThomasWaldmann> please also check the "Plan" section whether it is uptodate
2009-08-18T14:37:17  <ThomasWaldmann> also the stuff at the bottom (remove)
2009-08-18T14:41:47  <dreimark> dimazest: I know
2009-08-18T14:42:25  <dreimark> The test doing so does not test your code it will test dict.update
2009-08-18T14:44:17  <dimazest> ThomasWaldmann: yes, i need to update my wikipage
2009-08-18T14:44:59  <dreimark> dimazest: wikiconfig dicts can't be updated wihout doing a new request or?
2009-08-18T14:46:02  <dreimark> (in the scope of the wiki usage)
2009-08-18T14:51:57  <dimazest> dreimark: it is not possible to update them
2009-08-18T14:52:31  <dreimark> but the test tries, so the test should only do for other dicts
2009-08-18T14:54:08  <dimazest> no, test tries to update some dict with a wikidict, wikidict should not be changed
2009-08-18T14:55:09  <dimazest> the problem, that code in syncpages does options.update(WikiDict)
2009-08-18T14:55:34  <dimazest> that's why i added test which checks an update for a dict
2009-08-18T14:55:42  <dreimark> hmm, I look at home later again thought I've seen it trying two different dict classes
2009-08-18T15:04:46  <ThomasWaldmann> hmm, with fs backend your can revert to a rev with a 700MB ISO quite efficiently
2009-08-18T15:04:52  <ThomasWaldmann> (not with sqla)
2009-08-18T15:08:00  <dreimark> dimazest: it does options.update(self.request.dicts[self.pagename])
2009-08-18T15:08:28  <dreimark> so creating a page with the update does do it similiar
2009-08-18T15:09:28  <dreimark> ThomasWaldmann: then sqla needs more love
2009-08-18T15:29:45  * dreimark tries to find which test before test_search invoked does change the state
2009-08-18T15:30:28  <dimazest> dreimark: then i play with the search
2009-08-18T15:31:17  <dreimark> good, look if category search behaves similiart on Category pages with (or without xapian)
2009-08-18T15:32:02  <dreimark> dimazest: do you have already fixed this one failing test?
2009-08-18T15:33:27  <dreimark> s/one/last/
2009-08-18T15:37:26  <dimazest> no, i need find a solution, it looks that xapian doesn't return HelpOnEditor document if HelpOn is queried
2009-08-18T15:39:49  <dreimark> hmm you query for Help, isn't ThomasWaldmann wikiname splitter not active in your changes?
2009-08-18T15:40:56  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6685:fa1fb80e13d2 2.0-storage/MoinMoin/items/__init__.py: diff for image items
2009-08-18T15:40:58  <ThomasWaldmann> ^^ :)
2009-08-18T15:41:18  * ThomasWaldmann tested it with a original jpeg and a slightly modified copy of it
2009-08-18T15:41:46  <dreimark> cool, will look on it later, testing together with installing of some compiler
2009-08-18T15:41:59  <dreimark> fits better than playing with 2.0
2009-08-18T15:42:21  <dreimark> first time "(this may take some time)" from the install window is right
2009-08-18T15:44:31  <dreimark> dimazest: xapian can only find exact words and stemmed words.
2009-08-18T15:45:02  <dreimark> that's why thomas has added some splitting code in the past
2009-08-18T15:46:12  <dimazest> dreimark: yes, but there is a problem with negation
2009-08-18T15:49:59  * dreimark wonders currently on something different
2009-08-18T15:50:07  <dreimark> /moin-1.9-xapian-dmilajevs/MoinMoin > py.test datastruct/backends/_tests/__init__.py
2009-08-18T15:50:14  <ThomasWaldmann> bbl
2009-08-18T15:50:25  <dreimark> does not run any test inside of __init__
2009-08-18T15:50:45  <dreimark> while it does when it is called from toplevel dir
2009-08-18T15:57:18  <dimazest> dreimark: it shouldn't test for different backends inherit's from classes in __init__
2009-08-18T15:58:00  <dreimark> seen that with the next test it is always invoked (get clear to me at that point)
2009-08-18T15:58:51  <dreimark> there are not much tests left, may be it is not one test alone
2009-08-18T16:10:30  *** jdmjdm has joined #moin-dev
2009-08-18T16:28:34  <dreimark> argh it was the last test example
2009-08-18T16:31:47  <dreimark> dimazest: moin-1.9-xapian-dmilajevs/MoinMoin > py.test script/migration/_tests search/_tests/test_search.py
2009-08-18T16:31:48  <dimazest> there are some problems if xapian is installed but it is old version http://paste.pocoo.org/show/134986/
2009-08-18T16:34:20  <dreimark> it is very late when it tells "ConfigurationError: Xapian Python bindings installed, but need at least version 1.0.6" does it tell when one builds the index or on systeminfo page. So one knows it won'r work
2009-08-18T16:34:24  <dimazest> dreimark: in other order it works :)
2009-08-18T16:34:55  <dreimark> :)
2009-08-18T16:35:06  * dreimark looks at the mig scripts
2009-08-18T16:35:06  <dimazest> dreimark: it will be said before, since the check is done on import
2009-08-18T16:35:12  <dreimark> ok
2009-08-18T16:35:35  <dimazest> btw, does error message sound good?
2009-08-18T16:36:23  <dreimark> this one? 'Either disable Xapian completetly in your wikiconfig or upgrade your Xapian installation!'
2009-08-18T16:38:06  <dreimark> the other also sounds good. but me would write it
2009-08-18T16:39:03  <dreimark> Xapian Version 1.0.0 installed. Please upgrade to a recent version at least 1.0.6. ....
2009-08-18T16:40:23  <dimazest> it is quite hard to extract xapian version from the exception
2009-08-18T16:44:06  <dreimark> import xapian xapVersion = 'Xapian %s' % xapian.version_string()
2009-08-18T16:44:27  <dreimark> does SystemInfo
2009-08-18T16:58:46  <dreimark> from MoinMoin.script.migration._conv160_wiki import convert_wiki makes the problem
2009-08-18T17:04:46  <dreimark> it changes the state so that e.g. test_language_search_simple founds one page more than with skipping the test_conv160 scripts
2009-08-18T17:12:12  <dimazest> dreimark: does it creates revisions? because if it just renamed pages, test_language_search_simple should not find new documnets
2009-08-18T17:13:09  * dreimark reads currently
2009-08-18T17:17:10  *** JosefMeier has joined #moin-dev
2009-08-18T17:20:04  <JosefMeier> Moin
2009-08-18T17:22:25  <dimazest> moin
2009-08-18T17:26:36  <dreimark> moin JosefMeier
2009-08-18T17:27:40  <dreimark> dimazest: it happens because of from MoinMoin import i18n i18n.wikiLanguages = lambda: {}
2009-08-18T17:28:16  *** JosefMeier_ has joined #moin-dev
2009-08-18T17:28:38  <dimazest> dreimark: hmm
2009-08-18T17:29:05  <dimazest> dreimark: where is it done?
2009-08-18T17:29:49  <JosefMeier_> This "my applet doesn't start under Java 1.5" makes me angry
2009-08-18T17:30:04  <JosefMeier_> I have absolutely no idea what the problem is
2009-08-18T17:30:34  <dreimark> do you've asked on a java ml too?
2009-08-18T17:31:08  <JosefMeier_> java ml ?
2009-08-18T17:32:24  <dreimark> mailing liste
2009-08-18T17:34:52  <dreimark> ThomasWaldmann: can we kill http://hg.moinmo.in/moin/1.9-xapian-dmilajevs/file/fb0ddee3f5ff/MoinMoin/script/migration/_conv160_wiki.py#l31 also the same line in _conv160a_wiki.py
2009-08-18T17:36:38  <dreimark> without that line i have no additional tests failing and test_search shows only the same failure
2009-08-18T17:44:00  *** JosefMeier has quit IRC
2009-08-18T17:51:15  <CIA-34> Dmitrijs Milajevs <dimazest@gmail.com> default * 5004:a93283d1f827 1.9-xapian-dmilajevs/MoinMoin/ (events/xapian_index.py search/Xapian.py): Xapian2009: XAPIAN_MIN_VERSION is 1.0.6, events.xapian_index doesn't raise an exception when old xapian is installed.
2009-08-18T17:51:16  *** JosefMeier_ has quit IRC
2009-08-18T17:51:33  *** JosefMeier has joined #moin-dev
2009-08-18T18:00:04  * dreimark verifie on 1.9
2009-08-18T18:05:20  <dreimark> ThomasWaldmann: does the migration need this i18n.wikiLanguages = lambda: {} ?
2009-08-18T18:19:36  *** grzywacz has joined #moin-dev
2009-08-18T18:59:24  *** amartani has joined #moin-dev
2009-08-18T19:10:07  *** amartani has quit IRC
2009-08-18T19:10:51  *** amartani has joined #moin-dev
2009-08-18T19:19:43  *** amartani has quit IRC
2009-08-18T19:34:41  <dreimark> dimazest: what exactly is that neation problem
2009-08-18T19:35:59  <dreimark> s/neation/negation/
2009-08-18T19:58:00  <dimazest> dreimark: for title currently query is built wrong
2009-08-18T19:58:09  <dimazest> i'm fixing it
2009-08-18T19:58:23  <dimazest> hope negation proplem will gone :)
2009-08-18T20:00:02  <dreimark> ok
2009-08-18T20:17:47  <dimazest> dreimark: i think, when someone is searching for HelpOnTesting a query should be
2009-08-18T20:18:15  <dimazest> HelpOnTesting or (Help and On and Testing)
2009-08-18T20:18:27  <dimazest> it is without stamming
2009-08-18T20:19:01  <dimazest> HelpOnTesting or (Help and On and (Testing or Test)) -- with stemming
2009-08-18T20:19:42  <ThomasWaldmann> re
2009-08-18T20:19:57  <dreimark> dimazest: yes
2009-08-18T20:20:55  <dimazest> dreimark: now i need to implement it :))
2009-08-18T20:28:03  <dimazest> dreimark: this is important for the TextSearch, TitleSearch only, for others it is ok to query just for HelpOnTesting. Right?
2009-08-18T20:28:54  <dreimark> dimazest: it is important if you don't know the exact word.
2009-08-18T20:29:07  <dreimark> it could be written TitleSearch or Title Search
2009-08-18T20:33:15  <dimazest> i mean classes in the queryparser.expressions
2009-08-18T20:37:04  <dreimark> it is easier to start with make nosense for:
2009-08-18T20:37:29  <dreimark> DomainSearch
2009-08-18T20:37:38  <dreimark> LanguageSearch
2009-08-18T20:37:54  <dreimark> MimetypeSearch
2009-08-18T20:38:44  <dreimark> LinkSearch (as it searchs the term in the pagelinks)
2009-08-18T20:39:26  <dreimark> and I think it does not make sense for CategorySearch too
2009-08-18T20:39:39  <dreimark> so leftover is TitleSearch and TextSearch
2009-08-18T20:40:11  <dreimark> dimazest: right
2009-08-18T20:40:50  <dreimark> brb
2009-08-18T20:53:52  *** jdmjdm has quit IRC
2009-08-18T21:14:40  <dreimark> re
2009-08-18T21:14:53  <dreimark> dimazest: please update http://moinmo.in/Groups2009 too
2009-08-18T21:27:24  <dimazest> dreimark: ok, i'll do it
2009-08-18T21:28:22  <dimazest> the next what i want to do is to split Xapian.py to two parts - indexer and tokenizer
2009-08-18T21:29:09  <dimazest> then refactor tokenizer a little bit, so it would be possible to write tests for it
2009-08-18T21:29:35  <dimazest> and then do query parsing for title and content searches
2009-08-18T21:36:07  <dreimark> dimazest: plan sounds good
2009-08-18T21:38:11  <dimazest> searching is so tricky :)
2009-08-18T21:49:34  *** JosefMeier has quit IRC
2009-08-18T22:38:36  *** ronny has quit IRC
2009-08-18T23:02:49  *** grzywacz has quit IRC
2009-08-18T23:03:30  *** jdmjdm has joined #moin-dev
2009-08-18T23:08:47  *** grzywacz has joined #moin-dev
2009-08-18T23:23:02  <dreimark> gn
2009-08-18T23:26:02  *** amartani has joined #moin-dev
2009-08-18T23:29:09  <ThomasWaldmann> gn dreimark
2009-08-18T23:52:55  <amartani> ThomasWaldmann: http://paste.pocoo.org/show/134888/
2009-08-18T23:53:10  <amartani> saving on opera raises error without this
2009-08-18T23:55:12  * ThomasWaldmann looks
2009-08-18T23:55:41  <ThomasWaldmann> ok, thanks
2009-08-18T23:59:04  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6686:152e22e454b8 2.0-storage/MoinMoin/items/__init__.py: make item upload work on Opera (thanks to Alexandre Martani)