MoinMoin: MoinMoinChat/Logs/moin-dev/2009-08-25

2009-08-25T00:10:57  <dreimark> good night dimazest
2009-08-25T00:15:47  <ThomasWaldmann> http://xkcd.com/ haha
2009-08-25T00:20:36  *** amartani has quit IRC
2009-08-25T00:46:59  *** grzywacz has quit IRC
2009-08-25T02:30:34  *** amartani has joined #moin-dev
2009-08-25T03:43:27  *** TheSheep has quit IRC
2009-08-25T03:43:32  *** TheSheep has joined #moin-dev
2009-08-25T03:46:45  *** amartani has quit IRC
2009-08-25T07:57:51  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 396:42af39088fd4 extensions/data/plugin/action/ (SvgEditor.py SVG-editor.py): renamed SVG-editor to SvgEditor
2009-08-25T07:57:58  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 397:0fc829b55df6 extensions/htdocs/svg-edit/editor/svg-editor.js: renamed also action in svg-editor.js
2009-08-25T07:58:01  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 398:3bf5061ffc30 extensions/ (2 files in 2 dirs): SvgEditor: adds the decoded svg data to div id="svgdata"
2009-08-25T07:58:02  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 399:74b81223475a extensions/data/plugin/action/SvgEditor.py: SvgEditor: fixes empty content for not existing svg image
2009-08-25T08:26:48  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 400:a33628b071b2 extensions/ (3 files in 3 dirs): SvgEditor: fixed loading of all svg elements
2009-08-25T09:42:18  <dreimark> moin
2009-08-25T11:47:14  <ThomasWaldmann> moin
2009-08-25T12:31:07  <ThomasWaldmann> btw, i did some diff mm19 vs. mm19xapian and aside from some smaller issues, it looked quite ok
2009-08-25T12:33:07  <ThomasWaldmann> a bit of practical testing with the stuff mostly used (simple title and text searches, also with negation) didn't show regressions
2009-08-25T12:39:59  <ThomasWaldmann> dimazest: please have a look at builtin.py:652. if xappy is giving your str there, you have to decode it to unicode.
2009-08-25T12:42:51  <dreimark> :)
2009-08-25T12:44:05  <ThomasWaldmann> dimazest: (and that unicode -> str -> xappy -> str -> unicode must be done in general)
2009-08-25T12:53:46  <ThomasWaldmann> dimazest: builtin.py:640 is also not the nicest way to tell the admin he has to build an index ;)
2009-08-25T13:30:17  <ThomasWaldmann> dimazest: XXX must search_results be decoded?
2009-08-25T13:30:45  <ThomasWaldmann> i searched a bit around in the code and did some experiments. the answers seems "no".
2009-08-25T13:31:25  <ThomasWaldmann> xapian seems to pickle/unpickle that .data property, so if you put unicode in, you get unicode back
2009-08-25T13:40:16  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5029:712677d7023c 1.9-xapian-dmilajevs/MoinMoin/search/builtin.py: add note about .data being a pickle
2009-08-25T13:56:53  <dimazest> ThomasWaldmann: can creation of the index be moved into the XapianSearch.__init__?
2009-08-25T14:16:58  <ThomasWaldmann> well, it can take rather long
2009-08-25T14:19:32  <ThomasWaldmann> dimazest: i think it should keep behaviour similar to the old code
2009-08-25T14:21:00  <ThomasWaldmann> if (moin starts up or if someone tries to do a search) AND xapian_search is enabled, it should check xapian version (xappy has some code that automatically does that) and whether there is an index.
2009-08-25T14:22:21  <ThomasWaldmann> if that check fails, it should set cfg.xapian_search to False search and log some appropriate warning about the version requirement or the missing index.
2009-08-25T14:22:44  <ThomasWaldmann> and, if it was a search, just do the search with the slow code.
2009-08-25T14:25:13  <dimazest> ok
2009-08-25T14:26:31  <ThomasWaldmann> basically, the xapian version and xapian presence can be just checked by catching the ImportError of xappy
2009-08-25T14:26:51  <ThomasWaldmann> and just log str(err) then
2009-08-25T14:31:43  <ThomasWaldmann> btw, the version check you do in indexing.py is maybe never reached
2009-08-25T14:32:14  <ThomasWaldmann> because you import xappy on module level and that'll raise ImportError if xappy is unhappy with an old xapian lib
2009-08-25T14:36:39  <ThomasWaldmann> you maybe could try temporarily modifying xapian.py to test behaviour (so you don't need to uninstall/install a old version/reinstall new)
2009-08-25T14:39:12  <dimazest> ok
2009-08-25T14:43:58  <ThomasWaldmann> dimazest: AssertionError: XXX Assume that index exist, actually we should have thrown an exception, so MoinSearch could be used instead
2009-08-25T14:44:16  <ThomasWaldmann> currently it crashes there if I give it a xapian.py with faked 0.9.0
2009-08-25T14:45:30  <ThomasWaldmann> http://pastebin.com/f1cbbf2d < that way I faked it :)
2009-08-25T14:47:27  <ThomasWaldmann> >>> import xappy
2009-08-25T14:47:32  <ThomasWaldmann> ImportError: Xapian Python bindings installed, but need at least version 1.0.6 - got 0.9.0
2009-08-25T14:49:49  <ThomasWaldmann> btw, to disable xapian, you need request object (just logging the problem would even work without)
2009-08-25T14:56:20  <ThomasWaldmann> bbl
2009-08-25T16:06:32  <ThomasWaldmann> btw, interesting mail about mentor summit from LH yesterday on the mentor mailing list
2009-08-25T16:13:04  <ThomasWaldmann> in short: oct 24th + 25th, mountain view, ca, 2 mentors per invited org
2009-08-25T16:18:03  <dreimark> :)
2009-08-25T16:39:19  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4959:18474c316dd7 1.9/MoinMoin/ (Page.py action/__init__.py):
2009-08-25T16:39:19  <CIA-34> mimetype support for Page.send_raw() and "raw" action (thanks to John Marshall for the patch)
2009-08-25T16:39:19  <CIA-34> Usage: ...?action=raw&mimetype=what/ever
2009-08-25T16:39:19  <CIA-34> The mimetype given is minimally checked using a simple regex:
2009-08-25T16:39:19  <CIA-34> o type is usually quite short
2009-08-25T16:39:21  <CIA-34> o subtype can be quite long to support "tree"s (looking at RFC2045 and /etc/mime.types)
2009-08-25T17:03:39  <ThomasWaldmann> did someone try to start a background standalone server with 1.9?
2009-08-25T17:40:20  *** amartani has joined #moin-dev
2009-08-25T17:58:53  *** amartani has quit IRC
2009-08-25T18:14:15  * dreimark not yet
2009-08-25T18:35:10  <ThomasWaldmann> it doesn't work for me
2009-08-25T18:35:26  <ThomasWaldmann> but wait until my next commit, I am currently cleaning up there
2009-08-25T18:46:22  *** grzywacz has joined #moin-dev
2009-08-25T18:46:52  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4960:2a024d3e418f 1.9/ (3 files in 3 dirs): (log message trimmed)
2009-08-25T18:46:52  <CIA-34> simplify wikiserver configuration by using same names as werkzeug's run_simple
2009-08-25T18:46:52  <CIA-34> wikiserverconfig changes: use hostname=... now (not interface=... any more)
2009-08-25T18:46:52  <CIA-34> using --interface for the moin server standalone command still works (--hostname
2009-08-25T18:46:52  <CIA-34> is also supported)
2009-08-25T18:46:56  <CIA-34> we can add options/arguments for werkzeug's run_simple and our own run_server
2009-08-25T18:46:58  <CIA-34> now easily, just the option name needs to be listed in the kwargs processing.
2009-08-25T18:55:48  <dreimark> ThomasWaldmann: --start seems not to work
2009-08-25T18:58:53  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4961:022388540d94 1.9/MoinMoin/script/server/standalone.py: added comment about (non-)usage of werkzeug's run_simple(static_files=x)
2009-08-25T19:06:53  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4962:3c51f98f69d2 1.9/MoinMoin/script/server/standalone.py: added comment about forking wikiserver slowness
2009-08-25T19:26:20  <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4963:8a97bb0caafb 1.9/MoinMoin/script/server/standalone.py: fix the Daemon call
2009-08-25T19:26:33  <ThomasWaldmann> dreimark: ^^ try now :)
2009-08-25T19:30:05  <dreimark> yeah also stop works
2009-08-25T19:32:27  <ThomasWaldmann> and later we try that reloading stuff :)
2009-08-25T20:30:09  *** amartani has joined #moin-dev
2009-08-25T20:38:39  <ThomasWaldmann> dimazest: do you have pending stuff? just to avoid double work...
2009-08-25T20:58:28  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 401:b1a9b182d9fd extensions/htdocs/svg-edit/editor/svg-editor.css: SvgEditor: tools_bottom3 and version string set visible
2009-08-25T21:08:11  <dreimark> bbl
2009-08-25T21:12:12  <ThomasWaldmann> dimazest: http://www.flax.co.uk/blog/2009/04/02/xapian-search-architecture/
2009-08-25T21:19:53  *** amartani has quit IRC
2009-08-25T21:25:17  <dimazest> ThomasWaldmann: i've did to much changes, need to split them on several commits
2009-08-25T21:26:10  <dimazest> but finally importing of xapian is nicer and there are log messages about index absence, and wrong version of xapian
2009-08-25T21:26:18  <dimazest> and some tests
2009-08-25T21:29:24  <ThomasWaldmann> cool :) and good idea to split it.
2009-08-25T21:29:50  <ThomasWaldmann> i was thinking a bit about xapian and unicode vs. str
2009-08-25T21:30:19  <ThomasWaldmann> but i couldn't find where encode/decode happens
2009-08-25T21:41:16  <dreimark> ThomasWaldmann: is it that problem http://bazaar.launchpad.net/~miracle2k/django-xappy/trunk/revision/38
2009-08-25T21:43:09  <ThomasWaldmann> dimazest: http://code.google.com/p/xappy/issues/detail?id=28
2009-08-25T21:44:04  <dreimark> that is doing upper case search
2009-08-25T21:44:51  <ThomasWaldmann> dreimark: not quite a problem, it is just unclear what works and how it works
2009-08-25T21:45:07  <dreimark> it is defined for lowercase only
2009-08-25T21:45:28  <dreimark> it is a useability issue for the user and they need to fix it
2009-08-25T21:46:31  <ThomasWaldmann> http://code.google.com/p/xappy/issues/detail?id=23
2009-08-25T21:50:19  *** amartani has joined #moin-dev
2009-08-25T22:20:28  <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 402:50a89a6cdf6a extensions/ (3 files in 3 dirs): SvgEditor: fixed url for clickable tools
2009-08-25T22:22:19  <ThomasWaldmann> dimazest: xappy code tells that it raises a LockError if one tries multiple indexer connections
2009-08-25T22:25:36  <dimazest> yes, we should use it
2009-08-25T22:26:05  *** amartani has quit IRC
2009-08-25T22:27:38  <dimazest> ThomasWaldmann: since stamming is done by moin, language property should be removed (i need to do it)
2009-08-25T22:39:11  <dimazest> gn. Tomorrow i go home, so i won't be online, but try to code :) dvcs is a great thing
2009-08-25T22:40:26  <dreimark> gn dimazest
2009-08-25T22:41:44  <ThomasWaldmann> gn dimazest
2009-08-25T22:41:55  <ThomasWaldmann> if you have anything to push, do it :)
2009-08-25T22:42:44  <ThomasWaldmann> ah, the read locks are gone already. good.
2009-08-25T23:06:24  <dreimark> gn
2009-08-25T23:15:44  <ThomasWaldmann> gn dreimark