MoinMoin: MoinMoinChat/Logs/moin-dev/2009-11-04

2009-11-04T00:04:55  *** JosefMeier has joined #moin-dev
2009-11-04T00:05:05  <JosefMeier> Moin Moin
2009-11-04T00:05:21  <JosefMeier> reimar: My bug report is no problem of the FCKeditor distribution.
2009-11-04T00:05:51  <JosefMeier> it's a rather serious one. I'm wondering that nobody saw that before with IE
2009-11-04T00:11:03  <JosefMeier> Btw: Context menus in GUI editor don't work with IE8 anymore :-D
2009-11-04T00:11:45  <JosefMeier> but this problem was also with Moin 1.8. THIS seems to be a problem of FCKeditor.
2009-11-04T00:38:49  <ThomasWaldmann> i guess they won't fix fckeditor 2.6 for ie8
2009-11-04T01:49:39  <JosefMeier> Surely not. But my moinFCKeditor fix is a showstopper for gui editor in my opinion
2009-11-04T01:49:56  <JosefMeier> ah: the bug is a showstopper :-)
2009-11-04T01:49:58  <JosefMeier> gn8
2009-11-04T01:50:05  *** JosefMeier has quit IRC
2009-11-04T03:22:46  *** grzywacz has quit IRC
2009-11-04T06:44:33  *** xorAxAx has quit IRC
2009-11-04T06:44:51  *** xorAxAx has joined #moin-dev
2009-11-04T10:58:26  *** vpv has quit IRC
2009-11-04T10:58:52  *** vpv has joined #moin-dev
2009-11-04T11:01:59  *** vpv has quit IRC
2009-11-04T11:02:24  *** vpv has joined #moin-dev
2009-11-04T11:03:49  *** vpv has quit IRC
2009-11-04T11:04:15  *** vpv has joined #moin-dev
2009-11-04T11:06:07  *** vpv has joined #moin-dev
2009-11-04T11:09:01  *** vpv has quit IRC
2009-11-04T11:09:27  *** vpv has joined #moin-dev
2009-11-04T11:10:51  *** vpv has quit IRC
2009-11-04T11:11:18  *** vpv has joined #moin-dev
2009-11-04T11:12:41  *** vpv has quit IRC
2009-11-04T11:13:07  *** vpv has joined #moin-dev
2009-11-04T11:16:16  *** vpv has quit IRC
2009-11-04T11:16:42  *** vpv has joined #moin-dev
2009-11-04T11:18:06  *** vpv has quit IRC
2009-11-04T11:18:31  *** vpv has joined #moin-dev
2009-11-04T11:18:43  *** dimazest has quit IRC
2009-11-04T11:21:41  *** vpv has quit IRC
2009-11-04T11:22:07  *** vpv has joined #moin-dev
2009-11-04T11:23:57  *** vpv has joined #moin-dev
2009-11-04T11:25:47  *** vpv has joined #moin-dev
2009-11-04T11:25:54  *** grzywacz has joined #moin-dev
2009-11-04T11:27:11  *** vpv has quit IRC
2009-11-04T11:27:36  *** vpv has joined #moin-dev
2009-11-04T11:29:01  *** vpv has quit IRC
2009-11-04T11:29:28  *** vpv has joined #moin-dev
2009-11-04T11:30:51  *** vpv has quit IRC
2009-11-04T11:31:18  *** vpv has joined #moin-dev
2009-11-04T11:32:44  *** vpv has quit IRC
2009-11-04T11:33:25  *** vpv has joined #moin-dev
2009-11-04T11:36:46  *** vpv has quit IRC
2009-11-04T11:37:11  *** vpv has joined #moin-dev
2009-11-04T11:40:24  *** vpv has quit IRC
2009-11-04T11:40:48  *** dimazest has joined #moin-dev
2009-11-04T11:40:59  *** vpv has joined #moin-dev
2009-11-04T11:44:14  *** vpv has quit IRC
2009-11-04T11:44:49  *** vpv has joined #moin-dev
2009-11-04T11:48:02  *** vpv has quit IRC
2009-11-04T11:48:27  *** vpv has joined #moin-dev
2009-11-04T11:50:18  *** vpv has joined #moin-dev
2009-11-04T11:51:23  *** vpv has joined #moin-dev
2009-11-04T11:54:57  *** dimazest has quit IRC
2009-11-04T11:57:33  *** dimazest has joined #moin-dev
2009-11-04T15:31:41  <ThomasWaldmann> moin
2009-11-04T19:41:30  *** JosefMeier has joined #moin-dev
2009-11-04T20:02:08  <JosefMeier> Moin Moin
2009-11-04T20:42:50  <dreimark> moin JosefMeier
2009-11-04T21:06:56  <ThomasWaldmann> JosefMeier: the code in selection.js 134..145 looks suspicious
2009-11-04T21:10:09  <JosefMeier> ThomasWaldmann: I found no better method to get this fixed. IE crashes in a way, that you have to quit it with the task manager
2009-11-04T21:10:37  <JosefMeier> In my opinion its a good workaround. At least cause CKeditor is the next editor of choice
2009-11-04T21:18:25  <JosefMeier> but you are right: not exactly knowing what's the reason for an effect is not optimal. I debugged this code and saw, that it's running in an endless loop for some reason. Since I added this workaround we never had problems again with IE
2009-11-04T21:19:32  <JosefMeier> ThomasWaldmann: Ahm ... you aren't talking about my patch. You are talking about code in the FCKeditor, right?
2009-11-04T21:21:18  <ThomasWaldmann> i won't apply that patch as it doesn't fix the problem. it just limits the loop to 400 rounds.
2009-11-04T21:22:10  <ThomasWaldmann> but if you look at the code i referencered above, you see code that could lead to an endless loop
2009-11-04T21:24:30  <JosefMeier> ThomasWaldmann: but fckeditor runs in an endless loop in the custom selection code I wrote the patch for. How did you find this endless loop? Can you give me a hint?
2009-11-04T21:26:31  <ThomasWaldmann> you find it by looking at the code and thinking about it
2009-11-04T21:26:53  <JosefMeier> but the code is obfuscated
2009-11-04T21:27:12  <ThomasWaldmann> btw, i didn't try it, as i said: it LOOKS very suspicious
2009-11-04T21:28:00  <JosefMeier> if we would find a solution for the fckeditor, how long will it take so we could add an official release to Moin? It won't be ready before 1.9
2009-11-04T21:28:49  <ThomasWaldmann> bug fixes can be applied at any time
2009-11-04T21:30:23  <ThomasWaldmann> and this is a moin specific fckeditor extension, not fckeditor code
2009-11-04T21:32:46  <JosefMeier> ok. I think we misunderstood each other. Which selection.js do you mean?
2009-11-04T21:33:00  <ThomasWaldmann> the code you tried to fix
2009-11-04T21:33:17  <ThomasWaldmann> selection/fckplugin.js
2009-11-04T21:33:35  <JosefMeier> umpf. but there's no selection.js :-)
2009-11-04T21:34:11  <ThomasWaldmann> yeah, the name is the directory
2009-11-04T21:34:17  <JosefMeier> yes yes
2009-11-04T21:34:35  <JosefMeier> theres a fckeditor 2.6.5 ready
2009-11-04T21:34:46  <ThomasWaldmann> oh?
2009-11-04T21:34:52  <JosefMeier> at least in the trunk
2009-11-04T21:35:06  <JosefMeier> http://svn.fckeditor.net/FCKeditor/trunk/
2009-11-04T21:36:36  <JosefMeier> And I'll making clean changesets for my search button feature for image and attachment dialogs
2009-11-04T21:36:46  <JosefMeier> as described on my server
2009-11-04T21:37:36  <JosefMeier> I try to get my 1.8 modifications running in 1.9, also the search buttons
2009-11-04T21:39:44  <dreimark> JosefMeier: one cs for one feature
2009-11-04T21:41:11  <JosefMeier> for sure. but it's a rather big changeset
2009-11-04T21:41:55  <JosefMeier> I'll paste it on pastebin for a review if I'm ready
2009-11-04T21:46:35  <ThomasWaldmann> 2.6.5 changes look interesting
2009-11-04T21:52:36  <dreimark> rc2
2009-11-04T22:01:19  *** JosefMeier_ has joined #moin-dev
2009-11-04T22:01:51  *** JosefMeier has quit IRC
2009-11-04T22:02:00  *** JosefMeier_ is now known as JosefMeier
2009-11-04T22:06:19  <ThomasWaldmann> JosefMeier: http://moinmo.in/4ct10n/info/MoinMoinBugs/1.9GUIEditorIECrashesWithImages?action=diff&rev2=9&rev1=7
2009-11-04T22:14:05  <JosefMeier> ThomasWaldmann: I'll have a look on it.
2009-11-04T23:56:45  <JosefMeier> n8
2009-11-04T23:56:50  *** JosefMeier has quit IRC