1 2009-11-13T00:21:55 *** grzywacz
2 2009-11-13T07:25:15 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5275:adb58cd3ece2 1.9/MoinMoin/wsgiapp.py: main exception handler: include request url in log output
3 2009-11-13T08:12:48 *** ThomasWaldmann
4 2009-11-13T08:13:52 *** ronny_
5 2009-11-13T08:14:27 *** ThomasWaldmann
6 2009-11-13T08:14:45 *** ronny
7 2009-11-13T08:32:24 <ThomasWaldmann> moin
8 2009-11-13T09:27:07 <dreimark> moin
9 2009-11-13T09:37:37 <ThomasWaldmann> btw, i am thinking about 2 xapian indexing changes:
10 2009-11-13T09:37:54 <ThomasWaldmann> a) remove the moin locking, use xapian's locking
11 2009-11-13T09:39:04 <ThomasWaldmann> b) when changing some page/attachment, moin currently updates the update-queue/remove-queue. also it tries to consume some entries from those queues at that time.
12 2009-11-13T09:40:02 <ThomasWaldmann> but, if it can't get the lock, it can't. so the updates are waiting until that mechanism gets invoked again (== when next wiki change happens)
13 2009-11-13T09:41:46 <ThomasWaldmann> maybe that "indexing stuff from the queues" should be just tried any time some request is processed by the wiki
14 2009-11-13T09:46:49 <ThomasWaldmann> (in case of locking problems [like they happen almost daily with the current code] the queues can get rather long, thus the processing of them also takes very long, as it only consumes 5 entries per run)
15 2009-11-13T09:48:08 <ThomasWaldmann> also those 2 queues should be replaced by 1. that's easier and also likely more correct.
16 2009-11-13T10:14:03 <dreimark> dimazest: ^^
17 2009-11-13T10:48:05 * ThomasWaldmann currently works on b)
18 2009-11-13T12:20:23 * xorAxAx installs moin 1.9rc1
19 2009-11-13T12:20:35 <dreimark> xorAxAx: :)
20 2009-11-13T12:25:26 <ThomasWaldmann> moin xorAxAx
21 2009-11-13T12:26:59 <xorAxAx> moin dreimark, ThomasWaldmann
22 2009-11-13T12:34:13 *** JosefMeier
23 2009-11-13T12:35:23 <JosefMeier> Moin Moin
24 2009-11-13T12:50:57 *** moin7
25 2009-11-13T12:51:36 <ThomasWaldmann> hi JosefMeier
26 2009-11-13T12:52:54 <moin7> FlorianKoenigHeidinger
27 2009-11-13T12:53:03 *** moin7
28 2009-11-13T12:53:11 *** FlorianKoenigHei
29 2009-11-13T12:53:18 <Spitzohr> My name is to long ;)
30 2009-11-13T12:53:31 <Spitzohr> Hi
31 2009-11-13T12:53:57 *** grzywacz
32 2009-11-13T12:56:56 <ThomasWaldmann> hi Spitzohr
33 2009-11-13T12:57:54 <Spitzohr> Hi Thomas, nice to meet you.
34 2009-11-13T13:00:17 <Spitzohr> JosefMeier show me the moinmoin wiki system yesterday. It looks really great.
35 2009-11-13T13:05:12 <ThomasWaldmann> nice that it meets your needs :)
36 2009-11-13T13:10:30 <Spitzohr> I haven't installed it yet ;-) One of my first tests will be the integration of a single-sign-on function on a W2k3 server with Apache and mod_sspi.
37 2009-11-13T13:11:23 <dreimark> if that all are 3rd party talks may be continue on #moin
38 2009-11-13T13:12:17 <ThomasWaldmann> it's not 3rd party, but not development either :)
39 2009-11-13T13:15:44 <Spitzohr> Sorry dreimark. You are right. I have no development issues ... yet.
40 2009-11-13T15:37:15 <ThomasWaldmann> dimazest: what's the point of "fulltitle" vs. "pagename" field?
41 2009-11-13T17:15:56 <dimazest> moin
42 2009-11-13T17:16:50 <ThomasWaldmann> hi dimazest
43 2009-11-13T17:16:59 <dimazest> ThomasWaldmann: i've left it because it was previously
44 2009-11-13T17:17:06 <dimazest> if i remember right
45 2009-11-13T17:17:20 <dimazest> let me see the code
46 2009-11-13T17:17:34 <dreimark> bbl
47 2009-11-13T17:18:00 <dreimark> dimazest: read in the backlog from 09:37 < ThomasWaldmann>
48 2009-11-13T17:19:37 <ThomasWaldmann> btw, while digging in the code and removing the remove-queue, i found that processing the update and remove queue was wrong anyway
49 2009-11-13T17:20:23 <ThomasWaldmann> because of the potential time delay (and stuff happening in the wiki within that time), one can't queue "update" and "remove" jobs
50 2009-11-13T17:21:54 <ThomasWaldmann> so i am changing the code to just process request specific pages / page revs, attachments and decide then whether it needs updating or removing
51 2009-11-13T17:22:31 <dimazest> and the use of xapian logging should be smth. like "try to index a document, if exception accured put it to the queue"
52 2009-11-13T17:23:04 <dimazest> am i right?
53 2009-11-13T17:28:10 <ThomasWaldmann> or "put it into queue" and "try queue processing at end of every request"
54 2009-11-13T17:29:12 <dimazest> that is even simplier :)
55 2009-11-13T17:29:23 <ThomasWaldmann> yeah, and working better
56 2009-11-13T17:29:40 <ThomasWaldmann> because if the index is locked due to some bug, the queue gets rather long
57 2009-11-13T17:30:09 <ThomasWaldmann> and if just wiki edits reduce the queue by 5 entries, you need quite some edits until it has catched up
58 2009-11-13T17:31:48 * ThomasWaldmann works on a bigger changeset btw
59 2009-11-13T17:34:34 <ThomasWaldmann> dimazest: can you also have a look at _remove_item - that looks suspicious
60 2009-11-13T17:35:30 <ThomasWaldmann> esp. if the xapian index is to be shared in a wiki farm, i guess that would kill ALL pages with the given name, not just the ones in the given wiki
61 2009-11-13T17:42:05 <JosefMeier> ThomasWaldmann: I'm proud like a father: http://s15358202.onlinehome-server.info/1.9_modified/NewImageDialog
62 2009-11-13T17:46:03 <dimazest> ThomasWaldmann: fulltitle may be deleted, i do not see any reason to keep it
63 2009-11-13T17:46:22 <dimazest> and Xapian/indexing.py:440: docs_to_delete = search_connection.get_all_documents_with_field('fulltitle', pagename)
64 2009-11-13T17:46:35 <dimazest> should be changed to
65 2009-11-13T17:47:10 <dimazest> id_ = "%s:%s" % (wikiname, pagename); connection.delete(id_)
66 2009-11-13T17:48:01 <dimazest> stop, i need to check...
67 2009-11-13T17:50:10 <dimazest> page revisions have id like "%s:%s:%s" % (wikiname, pagename, revision)
68 2009-11-13T17:51:44 <ThomasWaldmann> i guess we have to build a query for wikiname and pagename
69 2009-11-13T17:53:21 <dimazest> yes
70 2009-11-13T18:05:44 <JosefMeier> ThomasWaldmann: If you like my new image dialog (i also have a new attachment dialog but more on that later), could we get it into the 1.9 ?
71 2009-11-13T18:07:28 <JosefMeier> dreimark: py.test ran without errors this time on my code changes ;-)
72 2009-11-13T18:12:21 <dreimark> JosefMeier: ok, will look at it
73 2009-11-13T18:12:49 <dreimark> if yo urequire a default value why don't you set it at creating your temp vars?
74 2009-11-13T18:14:01 <dreimark> why is the form with GET and not post?
75 2009-11-13T18:15:47 <dreimark> scriptname[-1] != "/": you mean endswith?
76 2009-11-13T18:16:37 <dreimark> btw. for what do you need the var scriptname ?
77 2009-11-13T18:18:05 <ThomasWaldmann> dimazest: hmm, if we don't index historical revs of a page, we need to kill the old rev(s) when indexing a fresh one
78 2009-11-13T18:22:00 <dimazest> ThomasWaldmann: what about this solution http://paste.pocoo.org/show/150448/
79 2009-11-13T18:22:57 <dreimark> JosefMeier: what is the meaning of attachments[0:0] = [new]
80 2009-11-13T18:23:04 <ThomasWaldmann> dimazest: good idea :)
81 2009-11-13T18:23:21 <dreimark> JosefMeier: and why do you harde code new = "<"+ _("New") + ">"
82 2009-11-13T18:23:42 <dreimark> _ = request.getText
83 2009-11-13T18:23:57 <dreimark> should be moved near to the method definition
84 2009-11-13T18:24:13 <dreimark> or function definition
85 2009-11-13T18:26:21 <JosefMeier> dreimark: I want to have the text "new" on the first line
86 2009-11-13T18:26:32 <JosefMeier> have you tried out the live demo ?
87 2009-11-13T18:26:32 <ThomasWaldmann> dimazest: so fields would be a dict then?
88 2009-11-13T18:27:02 <JosefMeier> dreimark: At this moment I haven't any idea of how to create translations.
89 2009-11-13T18:27:45 <dreimark> JosefMeier: it is ok to do the translation this way but usually we define _ at the start of the method/function
90 2009-11-13T18:27:52 <JosefMeier> ah ok
91 2009-11-13T18:28:05 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/be70689732eb#l22
92 2009-11-13T18:28:13 <dreimark> the "" is the default value
93 2009-11-13T18:28:36 <dreimark> if you want something different you don't need http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/be70689732eb#l29
94 2009-11-13T18:28:45 <JosefMeier> so I don't need to give the "" to the function?
95 2009-11-13T18:29:29 <dreimark> no you can give request.page.page_name
96 2009-11-13T18:29:35 <dimazest> yes, may be **kw should be used
97 2009-11-13T18:29:43 <dreimark> JosefMeier: instead of ""
98 2009-11-13T18:29:52 <JosefMeier> ok I understand
99 2009-11-13T18:29:54 <dimazest> ThomasWaldmann: ^^
100 2009-11-13T18:30:18 <JosefMeier> dreimark: most of the work is done in the javascript file fck_image.js
101 2009-11-13T18:30:47 <dreimark> i read that later
102 2009-11-13T18:31:14 <dreimark> you also could run pylint on the py code it should also give some hints
103 2009-11-13T18:32:00 <dreimark> "<" can be also escaped by the formatter or wikiutil.escape
104 2009-11-13T18:32:12 <dreimark> from a <
105 2009-11-13T18:32:55 <JosefMeier> ok
106 2009-11-13T18:34:00 <dreimark> and if new is only defined to add it to the attachments list you don't need this var
107 2009-11-13T18:35:56 <dreimark> JosefMeier: it looks like in the js it must be hardcoded for adding another another drawing method, thats not good
108 2009-11-13T18:36:20 <dreimark> and twikidraw does not create SVG
109 2009-11-13T18:37:17 <JosefMeier> dreimark: a) what do mean with "something is hardcoded in js" ?
110 2009-11-13T18:37:31 <JosefMeier> b) how could we call twikidraw if someone doesn't know what it is?
111 2009-11-13T18:37:37 <JosefMeier> had no idea for that
112 2009-11-13T18:38:18 <dreimark> well if you look at the action itselfs, and the config var. one can write a new action and has only to setup a config var for using the new drawing method
113 2009-11-13T18:38:36 <dreimark> he does not need to hack on any other code currently
114 2009-11-13T18:39:48 <JosefMeier> in theory: yes. but I don't see any additional editor before 2.0 at the moment. So I rather would let it as is.
115 2009-11-13T18:39:59 <dreimark> svg-edit works pretty good
116 2009-11-13T18:40:30 <dreimark> see e.g. http://moinmo.in/ReimarBauer/SvgEditor
117 2009-11-13T18:41:10 <JosefMeier> will svg-editor be added to 1.9 ?
118 2009-11-13T18:41:26 <dreimark> it is in the extensions repo
119 2009-11-13T18:41:35 <dreimark> this means there are people using it with 1.9
120 2009-11-13T18:41:52 <JosefMeier> whats the extension of a svg-editor drawing?
121 2009-11-13T18:42:05 <dreimark> svg
122 2009-11-13T18:42:42 <JosefMeier> {{drawing:test.svg}} ?
123 2009-11-13T18:42:43 <ThomasWaldmann> dimazest: yeah, i transformed it to **fields
124 2009-11-13T18:42:55 <dreimark> JosefMeier: http://paste.pocoo.org/show/150455/ from that description
125 2009-11-13T18:43:15 <dreimark> JosefMeier: yes
126 2009-11-13T18:45:11 <dreimark> http://svg-edit.googlecode.com/svn-history/r877/trunk/editor/svg-editor.html that is 4 revs behind my implementation
127 2009-11-13T18:46:54 <dimazest> cool, so you will commit changes
128 2009-11-13T18:46:59 <dimazest> i need to go
129 2009-11-13T18:47:19 <dimazest> c u
130 2009-11-13T18:47:25 <ThomasWaldmann> dimazest: yes, as soon as when I am sure not too much is broken :)
131 2009-11-13T18:47:30 <ThomasWaldmann> cu :)
132 2009-11-13T18:47:38 <dreimark> dimazest: cu :)
133 2009-11-13T18:48:23 <JosefMeier> dreimark: have you tried the new dialog? cause if I hack around than I like the idea that I don't have to change everything else again :-)
134 2009-11-13T18:49:06 <dreimark> JosefMeier: I play soon with it on a different system have to move
135 2009-11-13T18:49:11 <dreimark> for that
136 2009-11-13T18:49:58 <JosefMeier> move ?
137 2009-11-13T18:50:17 <JosefMeier> ah. to go to a different room
138 2009-11-13T18:50:29 <dreimark> btw. I have had today already some Freitag der 13. issues.
139 2009-11-13T18:51:53 <dreimark> hmm what an image is should cover the same data as we have in python
140 2009-11-13T18:52:46 <JosefMeier> dreimark: I didn't understand the last sentence
141 2009-11-13T18:54:22 <dreimark> if you look at the js code there is a check for images and drawings
142 2009-11-13T18:54:36 <dreimark> that is somehow duplicated in the python code too
143 2009-11-13T18:55:23 <dreimark> I think if we have different langs involved we should think about some meta data where they can retrieve this data
144 2009-11-13T18:55:54 <JosefMeier> ah ok
145 2009-11-13T18:56:56 <JosefMeier> I could send the http://paste.pocoo.org/show/150455/ extension_mapping to the js code through a POST-variable
146 2009-11-13T18:58:08 <dreimark> if you like to hide some data I think get is wrong
147 2009-11-13T18:58:31 <JosefMeier> ?
148 2009-11-13T18:59:01 <dreimark> input type hidden
149 2009-11-13T18:59:30 <dreimark> on the previous version
150 2009-11-13T18:59:44 <dreimark> currently I look at the gui editor form
151 2009-11-13T19:01:55 <dreimark> I think the editor must know the config var somehow. otherwise you show dialoges for tdraw and it could be disabled
152 2009-11-13T19:02:43 <dreimark> or you can make it less specific that you tell what drawing extensions can be used and don't tell that there is a extension mismatch
153 2009-11-13T19:03:26 <dreimark> so one knows adraw, tdraw, ... similiar to the images where one also can type png, gif, jpg
154 2009-11-13T19:03:54 <JosefMeier> indeed at the moment its realized like that. maybe it's better, you try the dialog before if you have time then
155 2009-11-13T19:04:09 <dreimark> currently i am looking at it
156 2009-11-13T19:06:04 <dreimark> JosefMeier: if i create e.g. test.adraw by the dialog it writes something on the page.
157 2009-11-13T19:06:34 <dreimark> Am I right that I have to save now or can I call the applet from whithin the gui?
158 2009-11-13T19:06:40 <JosefMeier> save now please
159 2009-11-13T19:08:31 <dreimark> something is wrong it saves the image to the wrong page
160 2009-11-13T19:08:41 <dreimark> it is saved to an undefined exaqmple page
161 2009-11-13T19:09:06 <dreimark> ah that was me
162 2009-11-13T19:09:31 <JosefMeier> ?
163 2009-11-13T19:09:52 <JosefMeier> you can enter a different page name. after pressing search all attachments for this page will be listed.
164 2009-11-13T19:09:54 <dreimark> I didn't understand "Name of page with attachments"
165 2009-11-13T19:10:16 <dreimark> it should be may be just Pagen Name
166 2009-11-13T19:10:17 <JosefMeier> if you have the image on a different page, than you can enter the page name there and press search after that
167 2009-11-13T19:10:33 <JosefMeier> just pagename is also ok
168 2009-11-13T19:10:40 <dreimark> well it does not check if you give a pagename which does not exists
169 2009-11-13T19:11:18 <dreimark> I have not checked but we should look what happens if you don't have write rights
170 2009-11-13T19:11:36 <JosefMeier> yes. but thats also the case with the old dialog. If it doesnt exist than the attachment icon will be shown
171 2009-11-13T19:11:50 <JosefMeier> don't have write rights where?
172 2009-11-13T19:12:01 <dreimark> on my wiki where I have acls
173 2009-11-13T19:12:24 * dreimark writes a note on that
174 2009-11-13T19:12:30 <dreimark> about
175 2009-11-13T19:13:20 <JosefMeier> my wife had a little car accident today. nothing bad but ... friday the 13th :-(
176 2009-11-13T19:13:55 <JosefMeier> have to leave for around a hour. please gimme more comments, reimar.
177 2009-11-13T19:13:57 <JosefMeier> brb
178 2009-11-13T19:16:50 <dreimark> JosefMeier: hmm, somehow I think the dialog must become different. e.g. Location shows a list which does not tell drawing but if you select 'type of image' you select between the Location list and drawing
179 2009-11-13T19:17:35 <dreimark> and it is just wrong to show attachment while you select a drawing.
180 2009-11-13T19:21:46 <JosefMeier> dreimark: the new meaning of "location" is, that it describes, where the image is
181 2009-11-13T19:21:54 <JosefMeier> on the attachments or in the internet
182 2009-11-13T19:21:59 <dreimark> may be we should rename Location to something better and add drawing there. then type of image is not needed. also on the place a text box can explain a bit more what with the selection can be done
183 2009-11-13T19:22:08 <JosefMeier> drawing was there before
184 2009-11-13T19:22:20 <JosefMeier> after that I had the problem that we have different types of drawings
185 2009-11-13T19:22:42 <JosefMeier> I think now it's much more clearer
186 2009-11-13T19:23:01 <JosefMeier> image is on attachments or internet and can be of type normal picture or drawing
187 2009-11-13T19:24:02 <dreimark> the dialog which is needed is only to write the right text in {{ }} brackets
188 2009-11-13T19:24:15 <dreimark> it is attachment:file.ext
189 2009-11-13T19:24:23 <dreimark> or drawing:file.ext
190 2009-11-13T19:24:28 <JosefMeier> don't understand that
191 2009-11-13T19:24:30 <JosefMeier> brb
192 2009-11-13T19:24:31 <dreimark> or a different location
193 2009-11-13T19:25:45 <dreimark> your dialog currently verifies that one who has selected adraw that he uses only this extension.
194 2009-11-13T19:26:48 <dreimark> while you also could check if one selects drawing from the pull down if is uses a valid drawing extension
195 2009-11-13T19:27:32 <dreimark> and what a valid drawing extension is should be better retrieved from the config var
196 2009-11-13T19:27:35 <dreimark> somehow
197 2009-11-13T19:30:10 <dreimark> the only difference in 1.9 between drawing and attachments is, that there is not action to manipulate an attachment
198 2009-11-13T19:30:41 <dreimark> s/not/no/
199 2009-11-13T19:33:23 <dreimark> choose image function is nice. but also by the extension it can be separated to get the prefix drawing
200 2009-11-13T20:05:05 * ThomasWaldmann tries to fix the xapian tests
201 2009-11-13T20:19:43 <ThomasWaldmann> dreimark: how many fails do the test in 1.9 have for you?
202 2009-11-13T20:19:59 * dreimark looks
203 2009-11-13T20:24:08 <dreimark> ThomasWaldmann: 1436 passed, 75 skipped in 146.62 seconds
204 2009-11-13T20:24:23 <dreimark> no test fails
205 2009-11-13T20:33:59 <dreimark> py.test --version
206 2009-11-13T20:34:13 <dreimark> This is py.test version 1.1.0
207 2009-11-13T21:22:44 <JosefMeier> bierbauch
208 2009-11-13T21:24:59 <JosefMeier> sorry. this was off topic. thought on homer simpson
209 2009-11-13T22:01:53 *** JosefMeier_
210 2009-11-13T22:03:19 *** JosefMeier
211 2009-11-13T22:03:33 *** JosefMeier_
212 2009-11-13T22:05:05 *** JosefMeier
213 2009-11-13T22:05:22 *** JosefMeier
214 2009-11-13T22:20:08 <JosefMeier> dreimark: Is it possible to add comments to the extension_mapping config variable ? I could show this comments in the gui editor after that and don't have the need to store data in MoinMoin and the image dialog twice.
215 2009-11-13T22:39:23 <dreimark> hmm, not sure if I unserstand it. what kind of comments?
216 2009-11-13T22:44:11 <JosefMeier> In the image dialog you can choose between different image formats. Beneath the type selector I show a describing text. e.g.: SVG editor AnyWikiDraw (.adraw). You suggested to not to double code text but to use global moin config variables instead, like the one in multiconfig
217 2009-11-13T22:48:55 <dreimark> ok, thats clear but how do you access the comment from the js
218 2009-11-13T22:49:50 <dreimark> adding comments is no problem. they should not show up by WikiConfigHelp
219 2009-11-13T22:49:58 <dreimark> JosefMeier: ^
220 2009-11-13T22:50:43 * dreimark tries to understand how to get destroy rights in 2.0
221 2009-11-13T22:51:13 <JosefMeier> I transfer variables through hidden fields from moin to javascript. That's common.
222 2009-11-13T22:52:40 <dreimark> is this specific now for this problem or generic
223 2009-11-13T22:57:45 <JosefMeier> I try to get a link from the extension_mapping (with a new comment for each drawing type) into the image dialog which is written in js to fullfill your request for not having doubled data storage
224 2009-11-13T23:10:02 <dreimark> ok.
225 2009-11-13T23:14:00 <CIA-43> Reimar Bauer <rb.proj AT googlemail DOT com> default * 6796:d1fb1e9611a8 2.0-storage/MoinMoin/ (_tests/__init__.py search/_tests/test_search.py): added nuke_item to test environment
226 2009-11-13T23:14:03 <CIA-43> Reimar Bauer <rb.proj AT googlemail DOT com> default * 6797:9af89299a687 2.0-storage/MoinMoin/ (13 files in 6 dirs): tests: renamed create_page to create_item and append_page to append_item
227 2009-11-13T23:14:31 <dreimark> ThomasWaldmann: nuke_item will work after I know how to get destroy rights
228 2009-11-13T23:15:15 <dreimark> I added it do get some more tests working where only some need to nuke
229 2009-11-13T23:16:06 <JosefMeier> dreimark: Can I add describing comments to extension_mapping in multiconfig?
230 2009-11-13T23:16:40 <dreimark> principle yes, but it should not show up in WikiConfigHelp
231 2009-11-13T23:17:59 <JosefMeier> how does this wikiconfighelp work?
232 2009-11-13T23:18:04 <JosefMeier> or what do you mean?
233 2009-11-13T23:21:01 <dreimark> see HelpOnConfiguration the macro is used there
234 2009-11-13T23:21:24 <dreimark> it reads multiconfig and creates the help there
235 2009-11-13T23:42:17 <JosefMeier> dreimark: how can I prevent that something is listed there?
236 2009-11-13T23:53:26 <JosefMeier> Ok. Found it out
