1 2010-02-13T00:00:09 <ThomasWaldmann> (23:38) < ThomasWal> valeuf: btw, if you just .replace("editlink", ""), please check different place where it can occur in arg string
2 2010-02-13T00:00:12 <ThomasWaldmann> (23:39) < ThomasWal> it could give (,otherargs) or (otherargs,) or (other,,args)
3 2010-02-13T00:00:53 <valeuf> ThomasWaldmann: yes I was actually checking
4 2010-02-13T00:01:05 <ThomasWaldmann> (in an even worse case, the editlink could be even a substring of something else there=
5 2010-02-13T00:05:35 <valeuf> hum ... I do not see any case where editlink could be a substring
6 2010-02-13T00:06:48 <ThomasWaldmann> <<Include(SomeTimesThereIsAProblemWitheditlin, ...)>>
7 2010-02-13T00:06:56 <ThomasWaldmann> +k
8 2010-02-13T00:07:00 <valeuf> ThomasWaldmann: arf ... I see
9 2010-02-13T00:07:16 <valeuf> ThomasWaldmann: I completely forget about such of case
10 2010-02-13T00:07:29 <ThomasWaldmann> won't happen too often, but is slightly unclean :)
11 2010-02-13T00:07:39 <valeuf> ThomasWaldmann: which is making the situation a little bit tricky
12 2010-02-13T00:07:49 <valeuf> ThomasWaldmann: yep now I see well what you mean
13 2010-02-13T00:08:08 <valeuf> ThomasWaldmann: I will try to find a better solution
14 2010-02-13T00:10:15 <ThomasWaldmann> thanks :) maybe see how Include parses
15 2010-02-13T00:10:33 <valeuf> ThomasWaldmann: it is ekactly what I am doing !
16 2010-02-13T00:10:39 <valeuf> *exactly
17 2010-02-13T00:12:45 <valeuf> ThomasWaldmann: I think I found, there is a regexp to match editlink
18 2010-02-13T00:12:56 <valeuf> ThomasWaldmann: I should use this instead of the basic replace
19 2010-02-13T00:21:40 <valeuf> ThomasWaldmann: I am going to finish tomorow, I am sleeping in front of my computer
20 2010-02-13T00:21:47 <valeuf> ThomasWaldmann: BTW thanks for the help
21 2010-02-13T00:27:49 <valeuf> quit
22 2010-02-13T00:27:53 *** valeuf
23 2010-02-13T01:05:14 <franklin_> Hi
24 2010-02-13T01:05:48 <franklin_> The removal of twisted isn't docuemented in moin 1.9 changelog ( http://hg.moinmo.in/moin/1.9/rev/27ea0a15a347 )
25 2010-02-13T01:15:19 *** moinBot
26 2010-02-13T01:16:12 *** ThomasWaldmann
27 2010-02-13T01:16:24 *** johill
28 2010-02-13T01:16:29 *** xorAxAx
29 2010-02-13T01:16:30 *** xorAxAx
30 2010-02-13T01:28:03 <dreimark> franklin_: we have had lots of issues related to modpython
31 2010-02-13T01:28:50 <dreimark> anyway you need a middleware
32 2010-02-13T01:29:24 <dreimark> moin is by 1.9 a wsgi app
33 2010-02-13T01:38:25 <franklin_> dreimark: It's just that those removal aren't mentioned in the changelog files.
34 2010-02-13T01:47:04 <ThomasWaldmann> hm?
35 2010-02-13T02:00:42 <ThomasWaldmann> franklin_: it tells that moin is a wsgi app now (that means we removed everything except wsgi). maybe we should tell that more clear.
36 2010-02-13T02:01:08 <ThomasWaldmann> we bundle flup, though, that adds a wrapper for everything supported by flup.
37 2010-02-13T02:01:40 <ThomasWaldmann> twisted should (IMHO) support wsgi meanwhile, so you can just use wsgi to talk to moin even when using twisted.
38 2010-02-13T02:09:00 <franklin_> I think I'll mostly document wsgi in Debian, since it's easy to install. (and maybe a few word about lighttpd. and a few word about CGI). For other uses, I'll point to "upstream".
39 2010-02-13T02:09:24 <ThomasWaldmann> point to wsgi server docs :)
40 2010-02-13T02:09:34 <ThomasWaldmann> that removes one indirection
41 2010-02-13T02:33:29 <dreimark> gn
42 2010-02-13T02:34:48 <franklin_> The README.Debian mostly contains a quickstart, and some Debian-specific information.
43 2010-02-13T02:41:30 *** ser
44 2010-02-13T02:44:16 <ThomasWaldmann> franklin_: before writing the lighty quickstart, look at the new moin.fcgi file in current 1.9 repo code
45 2010-02-13T02:44:46 <franklin_> ok
46 2010-02-13T07:52:01 *** kursor
47 2010-02-13T10:48:47 *** ser
48 2010-02-13T11:02:28 *** kursor
49 2010-02-13T11:25:06 <ronny> ThomasWaldmann: did you guys sometimes have issues with pep8.py returning a error while not printing anything to stdout?
50 2010-02-13T11:34:55 <ThomasWaldmann> ronny: not afaik
51 2010-02-13T11:35:32 <ronny> ThomasWaldmann: i just found that at least the recent version includes ignored items in the error count
52 2010-02-13T11:36:55 <ThomasWaldmann> we usually only use it within test_sourcecode.py
53 2010-02-13T11:39:46 <ronny> ThomasWaldmann: i wrote a pytest plugin that adds pyflakes/pep8 checking as test item to each source file
54 2010-02-13T11:43:06 * dreimark plays currently with http://countergram.com/open-source/pytidylib/
55 2010-02-13T11:51:57 <ThomasWaldmann> we need more release code testing :)
56 2010-02-13T11:52:35 <ThomasWaldmann> also, there seems to be a bug why wget works with 1.9
57 2010-02-13T11:53:18 <ThomasWaldmann> I have one more (maybe security related) issue to fix, then i want to get out new releases
58 2010-02-13T11:55:10 * dreimark needs this to feed the text_html_text_moin_wiki
59 2010-02-13T11:55:29 <dreimark> by this i am also testing lots of code
60 2010-02-13T11:55:57 <dreimark> I will look at the wget issue too
61 2010-02-13T11:56:41 <ronny> hmm, now i see why you added the xattr's
62 2010-02-13T12:11:49 *** CIA-41
63 2010-02-13T12:13:59 <dreimark> bbl
64 2010-02-13T13:49:40 *** grzywacz
65 2010-02-13T15:10:49 <dreimark> ThomasWaldmann: user_agent.browser seems to be None
66 2010-02-13T15:13:42 <TheSheep> I think you need to add apropriate mixin
67 2010-02-13T15:14:08 <TheSheep> to the request object
68 2010-02-13T15:14:54 <TheSheep> http://werkzeug.pocoo.org/documentation/0.5.1/wrappers.html#werkzeug.UserAgentMixin
69 2010-02-13T15:35:20 *** kursor
70 2010-02-13T15:44:48 <dreimark> TheSheep: request.user_agent is defined but i haven't found where
71 2010-02-13T15:50:35 <TheSheep> dreimark: in werkzeug
72 2010-02-13T15:51:13 <TheSheep> dreimark: on creation of the Request object
73 2010-02-13T16:19:58 *** twil
74 2010-02-13T16:20:03 <twil> hi all!
75 2010-02-13T16:20:51 <TheSheep> !hi | twil
76 2010-02-13T16:21:04 <twil> where can I see list of User properties? it seems http://docs.moinmo.in/moin/1.9/ shows only methods...
77 2010-02-13T16:21:39 <TheSheep> I didn't even know we have documentation O.o
78 2010-02-13T16:21:48 <twil> yep:)
79 2010-02-13T16:22:05 <twil> suppose it's buid automaticaly... but it's not full
80 2010-02-13T16:22:15 <TheSheep> I'd just look into the code
81 2010-02-13T16:22:46 <twil> well, it'll do the thing
82 2010-02-13T16:22:47 <TheSheep> most attributes are created at runtime, that's probably why the autogenerated docs can't catch them
83 2010-02-13T16:24:50 <twil> ok. then another question: is where a way to include javascript files in html header the way css files included?
84 2010-02-13T16:25:23 <twil> at this moment I had to rewrite entire html_header() in my theme
85 2010-02-13T16:25:41 <TheSheep> twil: maybe take alook at the mandaring theme
86 2010-02-13T16:25:47 <TheSheep> mandarin
87 2010-02-13T16:25:52 <TheSheep> I change the style links there
88 2010-02-13T16:26:04 <dreimark> twil: do you be a moin developer
89 2010-02-13T16:26:09 <dreimark> in advance ?
90 2010-02-13T16:26:13 <TheSheep> you can also always call the onld html_header, and append to its return value
91 2010-02-13T16:26:32 <dreimark> may be read title about
92 2010-02-13T16:26:39 <twil> TheSheep: ok, thanks...
93 2010-02-13T16:26:40 <dreimark> third party issues
94 2010-02-13T16:26:47 <dreimark> and move to #moin
95 2010-02-13T16:27:21 <dreimark> TheSheep: i think it is using this already http://hg.moinmo.in/moin/1.9/file/9101ca32b43d/MoinMoin/support/werkzeug/wrappers.py#l815
96 2010-02-13T16:27:47 <twil> hm... my issues ofcourse third party
97 2010-02-13T16:27:57 <twil> but I'd like to understand the API
98 2010-02-13T16:28:42 <twil> #moin I think is devoted to installation/configuration/usage I guess
99 2010-02-13T16:28:44 <dreimark> twil: sure but we are also talking with you in #moin
100 2010-02-13T16:28:58 <dreimark> no it is for all user request
101 2010-02-13T16:29:05 <TheSheep> dreimark: the problem is that moin's request has to inherit from that UserAgentMixin
102 2010-02-13T16:29:12 <TheSheep> dreimark: I don't see it doing that
103 2010-02-13T16:30:20 <twil> dreimark: ok. I'll move to #moin
104 2010-02-13T16:30:28 *** twil
105 2010-02-13T16:31:05 <dreimark> TheSheep: it works for firefox but not for curl and wget
106 2010-02-13T16:31:10 <dreimark> and i know why now
107 2010-02-13T16:31:22 <dreimark> http://paste.pocoo.org/show/177499/
108 2010-02-13T16:31:31 <dreimark> it is just an unknown browser
109 2010-02-13T16:32:26 <TheSheep> we should contribute our list of user agents upstream to werkzeug
110 2010-02-13T16:34:31 <dreimark> ThomasWaldmann: ^^
111 2010-02-13T16:35:23 <dreimark> TheSheep: yes, and the default None is also a problem
112 2010-02-13T16:53:12 <ThomasWaldmann> TheSheep: why? does werkzeug have something like that, that is worse?
113 2010-02-13T16:59:06 <dreimark> 16:31 < dreimark> http://paste.pocoo.org/show/177499/
114 2010-02-13T16:59:12 <dreimark> ThomasWaldmann: ^
115 2010-02-13T16:59:25 <dreimark> our uaspiders don't be knows by werkzeug
116 2010-02-13T16:59:38 <dreimark> s/s/n/
117 2010-02-13T17:32:44 <ThomasWaldmann> we just need the name of the UA as in the http headers, no preprocessed stuff
118 2010-02-13T17:43:31 <ThomasWaldmann> is it possible to enter \n into a text input form field using a browser? how?
119 2010-02-13T17:44:11 <TheSheep> copy-paste maybe?
120 2010-02-13T17:44:21 <TheSheep> I'd wager it depends on the browser
121 2010-02-13T17:44:41 <TheSheep> you surely can't realy on the browser validatingit
122 2010-02-13T17:45:18 <ThomasWaldmann> copy&paste seems to convert to blank
123 2010-02-13T17:46:02 <TheSheep> s/realy/rely
124 2010-02-13T17:46:42 <TheSheep> ThomasWaldmann: "the browser"?
125 2010-02-13T17:47:29 <ThomasWaldmann> ff
126 2010-02-13T17:47:48 <TheSheep> ah, the
127 2010-02-13T17:53:37 <ThomasWaldmann> http://hg.moinmo.in/moin/1.7/rev/232cad689a08 please review (I wasn't able to easily test it for the bad inputs)
128 2010-02-13T18:01:48 <dreimark> ThomasWaldmann: you could add a logging message to the exception handler
129 2010-02-13T18:01:56 <ThomasWaldmann> http://hg.moinmo.in/moin/1.7/rev/970d94ea19f2 that avoids some problems on the lower level
130 2010-02-13T18:02:20 <ThomasWaldmann> dreimark: you mean for the checkboxes?
131 2010-02-13T18:03:18 <dreimark> http://hg.moinmo.in/moin/1.7/rev/232cad689a08#l1.72
132 2010-02-13T18:03:23 <dreimark> yes
133 2010-02-13T18:03:54 <dreimark> i think it should be logged if something goes wrong here
134 2010-02-13T18:04:21 <dreimark> we never should get this error by our forms
135 2010-02-13T18:12:25 <ThomasWaldmann> and what do you do with that log then?
136 2010-02-13T18:18:31 <dreimark> I know that something is wrong for this user and I should disable him
137 2010-02-13T18:19:02 <dreimark> and look for a bug
138 2010-02-13T18:31:39 <dreimark> bbl
139 2010-02-13T18:54:53 <ThomasWaldmann> http://hg.moinmo.in/moin/1.7/rev/a7838f68fbcd < gna, reading before changing helps! :)
140 2010-02-13T18:56:16 <ThomasWaldmann> (btw, those changesets are just about fixing security, I want to keep them minimal, so if we want to add logging, that is 1.9)
141 2010-02-13T18:58:29 <ThomasWaldmann> where's CIA?
142 2010-02-13T19:30:33 * ThomasWaldmann updated i18n for 1.8 (and for 1.9 some hours ago)
143 2010-02-13T20:01:42 * ThomasWaldmann updated system pages on master wikis
144 2010-02-13T20:35:25 *** kursor
145 2010-02-13T20:45:25 <ThomasWaldmann> http://pastebin.com/f1ff6f9ab < user agent / spider detection fix
146 2010-02-13T20:47:57 <ThomasWaldmann> we need that stuff to work in an extensible way (i.e. add spider UAs via config), so moving it to werkzeug is no option imho
147 2010-02-13T20:48:10 <ThomasWaldmann> any better ideas?
148 2010-02-13T21:19:50 * ThomasWaldmann committed it
149 2010-02-13T22:30:49 <dreimark> re
150 2010-02-13T22:39:17 <dreimark> ThomasWaldmann: agreed
151 2010-02-13T22:45:21 <ThomasWaldmann> hi dreimark
152 2010-02-13T23:00:28 <dreimark> there might be an other location where we should look for the browser name
153 2010-02-13T23:00:39 <dreimark> currently i wonder how it is stored in to the log
154 2010-02-13T23:01:13 <dreimark> net is very slow currently
155 2010-02-13T23:12:00 <dreimark> http://hg.moinmo.in/moin/1.9/file/6698d5db825a/MoinMoin/logfile/eventlog.py#l44
156 2010-02-13T23:13:51 <dreimark> ThomasWaldmann: if i print the value it is empty
157 2010-02-13T23:15:11 <ThomasWaldmann> oh, yes, that needs a EnvironProxy
