1 2010-03-11T01:00:36 <dreimark> gn
2 2010-03-11T01:07:13 *** grzywacz
3 2010-03-11T05:48:02 *** mrht
4 2010-03-11T06:05:20 *** mrht
5 2010-03-11T07:47:53 *** kursor
6 2010-03-11T08:56:50 <ThomasWaldmann> moin
7 2010-03-11T09:01:15 <ronny> moinmoin
8 2010-03-11T09:36:01 <dreimark> moin
9 2010-03-11T11:36:31 <ThomasWaldmann> dreimark: it is still unclear to me what the cause of that "case:" related search bug is. maybe you could start with a cause description before trying to fix it?
10 2010-03-11T12:28:45 <CIA-47> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5626:07aa5349ad8b 1.9/MoinMoin/widget/browser.py: MoinMoin.widget.browser.sort_table: simplified isinstance call
11 2010-03-11T12:28:47 <CIA-47> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5627:dd04e0178c3d 1.9/MoinMoin/widget/browser.py: MoinMoin.widget.browser: small docstring fixes
12 2010-03-11T12:29:40 <dreimark> ThomasWaldmann: there are two bugs described in that bug page
13 2010-03-11T12:29:51 <dreimark> i splitt the page
14 2010-03-11T12:42:13 <dreimark> http://moinmo.in/MoinMoinBugs/1.9.2XapianTextSearchRegex
15 2010-03-11T12:42:45 <dreimark> i look next on the case issue
16 2010-03-11T12:44:58 <dreimark> currently I am still in the phase to try to understand it. and i did the patches for some documentation purposes
17 2010-03-11T12:46:38 * ThomasWaldmann was not asking for the bug, but for the root cause
18 2010-03-11T12:47:01 * dreimark wants to know that too.
19 2010-03-11T12:51:44 * dreimark looks at that
20 2010-03-11T15:15:36 <dreimark> forward and reverse sorting patch
21 2010-03-11T15:15:42 <dreimark> http://paste.pocoo.org/show/188360/
22 2010-03-11T16:43:26 <ThomasWaldmann> dreimark: maybe avoid such complex booleans as in 39++ if they are not really needed
23 2010-03-11T16:44:02 <ThomasWaldmann> if not sort_columns: returns rows
24 2010-03-11T16:44:28 <ThomasWaldmann> assert isinstance(sort_columns, (list, tuple))
25 2010-03-11T16:44:46 <ThomasWaldmann> assert isinstance(reverse, (list, tuple))
26 2010-03-11T16:45:13 <ThomasWaldmann> assert len(reverse) == len(sort_columns)
27 2010-03-11T16:48:55 <ThomasWaldmann> and the stuff in 81++ just complicates the API
28 2010-03-11T17:00:36 <dreimark> ok
29 2010-03-11T17:06:05 * dreimark tries to make 81++ easier
30 2010-03-11T17:07:40 <ronny> 81++ looks scarry
31 2010-03-11T17:08:11 <ronny> dreimark: is dataset.data[0] always a list?
32 2010-03-11T17:11:31 <dreimark> ronny: e.g.http://paste.pocoo.org/show/188421/ I am pretty sure it is
33 2010-03-11T17:11:55 <dreimark> simplifications are very welcome, I am currently writing tests for that function
34 2010-03-11T17:12:29 <ronny> dreimark: then you might want to generate the lists by [value]*len(...)
35 2010-03-11T17:12:52 <ronny> although i dont understand their purpose yet
36 2010-03-11T17:13:48 <dreimark> line 48 of the patch
37 2010-03-11T18:22:50 *** ThomasWaldmann
38 2010-03-11T18:23:01 *** ThomasWaldmann
39 2010-03-11T18:24:37 *** grzywacz
40 2010-03-11T19:38:48 <dreimark> any important tests missing ? http://paste.pocoo.org/show/188508/
41 2010-03-11T19:39:10 <dreimark> bbl
42 2010-03-11T21:07:22 *** kursor
43 2010-03-11T23:18:26 <ThomasWaldmann> re
44 2010-03-11T23:25:52 <dreimark> wb
MoinMoin: MoinMoinChat/Logs/moin-dev/2010-03-11 (last edited 2010-03-11 00:15:03 by IrcLogImporter)