MoinMoin: MoinMoinChat/Logs/moin-dev/2010-03-17

   1 2010-03-17T00:53:29  *** grzywacz has quit IRC
   2 2010-03-17T07:39:45  *** TheSheep has joined #moin-dev
   3 2010-03-17T09:28:58  <dreimark> moin
   4 2010-03-17T15:33:19  *** valeuf has quit IRC
   5 2010-03-17T15:40:03  *** valeuf has joined #moin-dev
   6 2010-03-17T18:50:10  *** grzywacz has joined #moin-dev
   7 2010-03-17T20:52:23  <dreimark> re
   8 2010-03-17T22:30:11  <ThomasWaldmann> re2
   9 2010-03-17T23:17:23  <dreimark> ThomasWaldmann: i want to add DictColumns, the tests do cover 91%
  10 2010-03-17T23:17:26  <dreimark> http://paste.pocoo.org/show/190958/
  11 2010-03-17T23:22:10  <ThomasWaldmann> MacroMarket or extensions repo
  12 2010-03-17T23:23:25  <dreimark> 1.9
  13 2010-03-17T23:24:16  <dreimark> we discussed this already i just rewrote CollectLists
  14 2010-03-17T23:24:25  <dreimark> to get it nicer and tests done
  15 2010-03-17T23:26:35  <ThomasWaldmann> +        assert len(result) == len(expected_result)
  16 2010-03-17T23:27:00  <ThomasWaldmann> that's exactly the same kind of test as in our search tests
  17 2010-03-17T23:27:33  <dreimark> this is only to check dubs removed by set in the next line
  18 2010-03-17T23:28:23  <dreimark> i like the set check more, but it has this limitation
  19 2010-03-17T23:30:07  <ThomasWaldmann> if you want to check whether something is in the result, you have to check THAT
  20 2010-03-17T23:30:27  <ThomasWaldmann> not do list size and set comparisons
  21 2010-03-17T23:30:56  <ThomasWaldmann> if such a test fails, you just know "oh, it's 3, but it should be 5"
  22 2010-03-17T23:31:32  <ThomasWaldmann> we already have that pain in the search tests, we don't need more of that
  23 2010-03-17T23:32:50  <ThomasWaldmann> also, everything that gets added to 1.9 needs to get ported to moin2
  24 2010-03-17T23:33:48  <dreimark> i know this too and because allmost all of our tables  are based on that
  25 2010-03-17T23:33:51  <ThomasWaldmann> so, we just stop adding
  26 2010-03-17T23:33:58  <dreimark> no
  27 2010-03-17T23:34:13  <ThomasWaldmann> you can use it as a plugin, what's the problem?
  28 2010-03-17T23:34:32  <dreimark> why not make it used on moinmo.in too
  29 2010-03-17T23:34:48  <dreimark> or some other wikis builtin
  30 2010-03-17T23:36:25  <dreimark> we added also a lot of stuff after 1.9.0 why not adding a macro
  31 2010-03-17T23:36:43  <ThomasWaldmann> let's reverse the question, why should we?
  32 2010-03-17T23:37:09  <dreimark> it makes tables much easier to handle than everything else.
  33 2010-03-17T23:37:45  <dreimark> and it just can collect status informations
  34 2010-03-17T23:38:29  <dreimark> i would prefer some table of our work on bugpages without
  35 2010-03-17T23:38:36  <ThomasWaldmann> and if you looks at docs/CHANGES, the "new features" are usually just very small things or modifications of existing code, nothing really new
  36 2010-03-17T23:38:38  <dreimark> searching on all
  37 2010-03-17T23:39:32  <dreimark> I don't need api changes for this macro
  38 2010-03-17T23:40:58  <dreimark> I also would need something very similar in 2.0 because i don't think we will have there a better way
  39 2010-03-17T23:41:01  <dreimark> to do this
  40 2010-03-17T23:47:20  <dreimark> also it uses lots of features of the browser widget
  41 2010-03-17T23:48:09  <ThomasWaldmann> sorry, but that code confuses me. put it on MacroMarket or into extension repo.
  42 2010-03-17T23:58:19  <dreimark> shit
  43 2010-03-17T23:58:30  <dreimark> http://moinmo.in/MoinMoinWiki
  44 2010-03-17T23:58:37  <dreimark> please remove the attachment