1 2010-05-29T00:55:22 <dreimark> gn
2 2010-05-29T02:59:49 *** Faxe
3 2010-05-29T04:41:12 *** amartani
4 2010-05-29T06:17:36 *** amartani
5 2010-05-29T06:34:21 *** amartani
6 2010-05-29T06:44:01 *** amartani
7 2010-05-29T08:32:06 *** kursor
8 2010-05-29T09:12:24 *** kursor
9 2010-05-29T11:03:24 <ThomasWaldmann> moin
10 2010-05-29T11:11:31 <valeuf> moi
11 2010-05-29T11:11:33 <valeuf> moin
12 2010-05-29T11:57:13 <valeuf> I passed my first test with my HTML_IN converter \o/
13 2010-05-29T11:57:38 *** DmitryAndreev
14 2010-05-29T11:58:21 <ThomasWaldmann> :)
15 2010-05-29T12:01:34 <CIA-47> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8229:ee7b3ed92cb8 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_html_in.py html_in.py): Add first support for basic tags in HTML_IN converter
16 2010-05-29T12:02:24 <valeuf> probably not yet clean, but I am waiting for your remarks
17 2010-05-29T12:02:55 <valeuf> argh
18 2010-05-29T12:05:18 <valeuf> the trailing whitespace stuff in PEP8 are really annoying sometimes :P
19 2010-05-29T12:24:52 <ThomasWaldmann> you use the vim pep8 plugin?
20 2010-05-29T12:26:07 <valeuf> ThomasWaldmann: yep, however, the devil trailing whitespace is not always shown by the plugin
21 2010-05-29T12:26:41 <ThomasWaldmann> ah, ok. well, run tests before commit then.
22 2010-05-29T12:26:45 <valeuf> but since I used this plugin, it is really much more comfortable to follow PEP 8 convention !
23 2010-05-29T12:27:09 <ThomasWaldmann> btw, you can selectively run some test with py.test -k somekeyword, e.g. py.test -k source
24 2010-05-29T12:27:56 <valeuf> ThomasWaldmann: yep, I do this befor I commit usually, however, I missed one trailing whitespace in a comment string
25 2010-05-29T12:28:55 <valeuf> I am reading : http://python.net/~goodger/projects/pycon/2007/idiomatic/handout.html these days too
26 2010-05-29T12:29:58 <valeuf> ThomasWaldmann: did you find many other PEP8 error in my code ?
27 2010-05-29T12:38:49 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/f03655db1733#l1.32 add a blank after the comma
28 2010-05-29T12:39:36 <valeuf> ah yep
29 2010-05-29T12:40:29 <ThomasWaldmann> recent changesets look quite ok
30 2010-05-29T12:40:44 <valeuf> ThomasWaldmann: it was an old commit, it has been fixed
31 2010-05-29T12:40:57 <valeuf> (I was not using PEP8 for vim at this time ...)
32 2010-05-29T12:41:40 <valeuf> xorAxAx: When you have time, I'd like to have your feedback about the way I choose for the HTML_IN converter,
33 2010-05-29T12:41:58 <valeuf> xorAxAx: so I can change the way if I am wrong, before I go ahead !
34 2010-05-29T12:42:21 <xorAxAx> ok
35 2010-05-29T12:45:08 <xorAxAx> valeuf: you should avoid single char variables
36 2010-05-29T12:46:00 <xorAxAx> valeuf: instead of spelling out ""visit_xhtml_div" functions, use getattr there as well
37 2010-05-29T12:46:10 <xorAxAx> valeuf: also ask waldi for feedback
38 2010-05-29T12:54:50 <valeuf> ok :)
39 2010-05-29T12:55:55 <valeuf> xorAxAx: what do you mean by spelling visit_xhtml_div ? I just spell visit_xhtml
40 2010-05-29T12:56:21 <xorAxAx> i mean implementing them
41 2010-05-29T12:56:33 <xorAxAx> currently it looks like they can be replaced by a generic piece of code
42 2010-05-29T12:56:46 <valeuf> xorAxAx: for one char var, you are right, will fik it ( I should say that I follow htmtl_out exemple ^ ^)
43 2010-05-29T12:57:49 <valeuf> xorAxAx: ah yes, I should see for that later, but for some elements you need a special behaviour, and some tests,
44 2010-05-29T12:58:11 <valeuf> xorAxAx: but I can try to define a generic behavior for basic tags
45 2010-05-29T13:01:02 <ThomasWaldmann> btw, i am still working on metadata indexing. my first try implementing it was on the level directly above storage backend
46 2010-05-29T13:01:08 <xorAxAx> valeuf: yes
47 2010-05-29T13:01:43 <valeuf> ThomasWaldmann: I will need to have a look about the metadata stuffs later, because I want to try to convert some of them too
48 2010-05-29T13:01:48 <ThomasWaldmann> but that level has the problem that it is only seeing the item names relative to the mountpoint of the backend
49 2010-05-29T13:02:13 <ThomasWaldmann> e.g. Trash/foo is only foo in the trash backend
50 2010-05-29T13:02:55 <ThomasWaldmann> the storage api deals with that in the router middleware using wrapper items that fix the names
51 2010-05-29T13:03:47 <ThomasWaldmann> but i wanted to have rather generic query infrastructure, so i am thinking about moving the indexing stuff to a level above the router
52 2010-05-29T13:05:21 <ThomasWaldmann> but it looks like both places have their pro and cons
53 2010-05-29T13:06:18 <ThomasWaldmann> the place above the router is likely better for generic search/select queries from moin code
54 2010-05-29T13:07:04 <ThomasWaldmann> but, if it indexes all stuff, it'll also have trash metadata, user metadata, etc. in the index
55 2010-05-29T13:08:32 <ThomasWaldmann> the place above the backend (subclassing the storage backend classes) might be nice to deal with some needs that come from the backend implementation itself
56 2010-05-29T13:08:58 <ThomasWaldmann> e.g. name <-> id lookups, maybe history
57 2010-05-29T13:09:29 <ThomasWaldmann> any ideas about this?
58 2010-05-29T15:49:06 *** DmitryAndreev
59 2010-05-29T17:46:26 *** ei-grad
60 2010-05-29T17:46:32 <ei-grad> moin
61 2010-05-29T17:49:51 <ei-grad> sorry, was not able to be in Internet, moved from Chelyabinsk (where my university located) to Miass (my home town)... and there provider have disabled my account
62 2010-05-29T17:51:29 <ThomasWaldmann> oh, great :|
63 2010-05-29T17:51:51 <ThomasWaldmann> so, it is fixed now?
64 2010-05-29T17:51:55 <ei-grad> yes
65 2010-05-29T17:53:01 <ThomasWaldmann> did you work on your soc project?
66 2010-05-29T17:54:02 <dreimark> moin
67 2010-05-29T17:54:12 <dreimark> hi ei-grad
68 2010-05-29T17:55:03 <dreimark> ei-grad: do you have looked into http://hg.moinmo.in/moin/1.9/file/203afc609f8a/MoinMoin/_tests/ldap_testdata.py
69 2010-05-29T17:55:21 <dreimark> and defined some groups there?
70 2010-05-29T17:58:21 <dreimark> and if so please push the changes to your repo
71 2010-05-29T19:16:01 * ThomasWaldmann write a clean acl regeneration for 1.9 -> 2.0
72 2010-05-29T20:07:47 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8241:b8fb72740d95 2.0-dev/MoinMoin/security/_tests/test_security.py: ACL tests: fix typos, add another test
73 2010-05-29T21:30:57 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8242:d74d87350aec 2.0-dev/MoinMoin/storage/ (_tests/test_backends_fs19.py backends/fs19.py): fs19 backend: regenerate ACL to cleanly remove invalid rights (delete and revert are gone)
74 2010-05-29T21:34:41 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8243:58a4c6df0864 2.0-dev/MoinMoin/security/_tests/test_security.py: fix pep8
75 2010-05-29T21:58:22 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8244:9a5f90d75952 2.0-dev/MoinMoin/ (4 files in 2 dirs): move constants for valid acl rights to MoinMoin.config
76 2010-05-29T22:13:25 <CIA-47> Dmitry Andreev <klieg.polar@gmail.com> default * 8225:639766245bad 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/moinwiki_out.py: Simple test is passed
77 2010-05-29T22:35:40 <CIA-47> Dmitry Andreev <klieg.polar@gmail.com> default * 8226:21d78690dce0 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/_tests/test_moinwiki_out.py: Simple test for moinwiki_out converter
78 2010-05-29T23:16:09 *** ei-grad
79 2010-05-29T23:45:04 <CIA-47> Dmitry Andreev <klieg.polar@gmail.com> default * 8227:4e07f2e5a2ca 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/ (_tests/test_moinwiki_out.py moinwiki_out.py): DOM->Moinwiki converter: simple list and table tests
