1 2010-07-03T00:12:03 *** RogerHaase
2 2010-07-03T00:38:41 *** franklin
3 2010-07-03T00:38:41 *** xorAxAx
4 2010-07-03T00:38:42 *** dreimark
5 2010-07-03T00:38:42 *** blathijs
6 2010-07-03T00:41:23 *** dreimark
7 2010-07-03T00:41:23 *** blathijs
8 2010-07-03T00:41:23 *** xorAxAx
9 2010-07-03T00:41:23 *** franklin
10 2010-07-03T00:43:43 *** xorAxAx
11 2010-07-03T00:44:26 *** xorAxAx
12 2010-07-03T03:59:02 <diofeher> good evening!
13 2010-07-03T05:55:54 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8477:1824fd0f6663 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/header.html theme/jinja.py): [templating] refactoring msg_list
14 2010-07-03T06:26:47 <diofeher> ops, sorry for the weird commit message :S
15 2010-07-03T06:32:12 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8478:4bf4b99aae30 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/head.html: [templating] added favicon support to html
16 2010-07-03T07:36:06 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8479:aa467cf32c5a 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] killed JinjaTheme.msg()
17 2010-07-03T07:38:30 <dreimark> moin
18 2010-07-03T07:38:56 <dreimark> ei-grad: please fix that path we recently discussed for the ldap testdata
19 2010-07-03T07:43:14 <dreimark> and run test_sourceode
20 2010-07-03T07:43:40 <dreimark> don't use "if processed_groups == None: "
21 2010-07-03T07:44:01 <dreimark> s/==/is/
22 2010-07-03T07:44:08 <dreimark> is better
23 2010-07-03T08:00:15 <dreimark> in http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/609a10534060/MoinMoin/datastruct/backends/ldap_groups.py#l140
24 2010-07-03T08:00:45 <dreimark> you can replace the \ by the parathesis of the next line
25 2010-07-03T08:05:35 <dreimark> http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/6300a9cbde07/MoinMoin/datastruct/backends/ldap_groups.py#l331
26 2010-07-03T08:05:44 <dreimark> what is the meaning of 2?
27 2010-07-03T08:06:21 <dreimark> why 2?
28 2010-07-03T08:07:59 <dreimark> http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/6300a9cbde07/MoinMoin/datastruct/backends/ldap_groups.py#l373 too
29 2010-07-03T08:08:20 <dreimark> may be add a comment
30 2010-07-03T08:24:45 <diofeher> gn
31 2010-07-03T08:24:50 <dreimark> gn diofeher
32 2010-07-03T08:30:47 *** grzywacz
33 2010-07-03T09:02:56 <ei-grad> moin
34 2010-07-03T09:56:22 <dreimark> ei-grad: do you have seen my remarks/questions from 07:38 < dreimark>
35 2010-07-03T09:56:51 <ei-grad> yes, ok
36 2010-07-03T10:02:05 <dreimark> http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/6300a9cbde07/MoinMoin/datastruct/backends/ldap_groups.py#l331
37 2010-07-03T10:02:14 <dreimark> why is it 2 ?
38 2010-07-03T10:09:37 <ei-grad> hm... it just remained from http://moinmo.in/Groups2009?action=AttachFile&do=view&target=ldap_group4.patch#CA-696e5cda59c4e743edbdc2762ba478d93ccc735c_246 , i didn't think why it is...
39 2010-07-03T10:22:18 <dreimark> ei-grad: if you look at the definitions of page_group_regex
40 2010-07-03T10:22:57 <dreimark> e.g. DefaultConfig or further examples at http://moinmo.in/ConfigMarket
41 2010-07-03T10:25:34 <dreimark> it will work if (?P<key> has this position.
42 2010-07-03T10:25:43 <dreimark> see grp.groupdict()
43 2010-07-03T10:27:27 * dreimark would prefer to address the "key" of the dict
44 2010-07-03T10:28:11 *** diofeher
45 2010-07-03T10:29:27 <dreimark> ei-grad: grp.group("key") instead of 2
46 2010-07-03T10:33:15 *** DmitryAndreev
47 2010-07-03T10:49:26 <ei-grad> ok, thanks
48 2010-07-03T10:55:31 *** DmitryAndreev
49 2010-07-03T10:58:56 <ThomasWaldmann> moin
50 2010-07-03T11:08:00 <ThomasWaldmann> apple-touch-icon with favicon.ico?
51 2010-07-03T11:10:04 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5767:862e623b7ca3 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ (_tests/test_ldap_groups.py ldap_groups.py): [LDAP2010] fixed issue with regex.group, group(2) -> group('key')
52 2010-07-03T11:10:25 <ei-grad> hi ThomasWaldmann
53 2010-07-03T11:13:49 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5768:076d162da69c 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed wrong group_name variable
54 2010-07-03T11:15:20 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5769:41fc4d8622e3 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed module docstring, there is not only lazy backend there
55 2010-07-03T11:16:20 <ei-grad> hm. crap...
56 2010-07-03T11:16:59 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5770:95714590cc8c 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed wrong group_name variable in other place
57 2010-07-03T11:20:12 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5771:8d46d7527f42 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] removed unused page_group_regex variable
58 2010-07-03T11:47:26 *** PawelPac1na
59 2010-07-03T12:11:00 *** DmitryAndreev
60 2010-07-03T12:34:27 *** DmitryAndreev
61 2010-07-03T12:36:48 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5772:8ed560b17eac 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed errors in LDAPGroup.__iter__
62 2010-07-03T12:48:21 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5773:85781cca3fe8 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed errors in LDAPGroups.groups_with_member
63 2010-07-03T12:48:26 <ei-grad> bbl
64 2010-07-03T13:55:34 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8327:8dab4d684890 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/ (rst_in.py rst_out.py):
65 2010-07-03T13:55:34 <CIA-98> ReStructuredText conversion:
66 2010-07-03T13:55:34 <CIA-98> fixed the problem of references with equal names
67 2010-07-03T13:55:34 <CIA-98> (anonymous references in ReStructuredText)
68 2010-07-03T13:55:35 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8328:cbc4ab2e51ec 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/rst_in.py: ReStructuredText->DOM: converts <docinfo> to table
69 2010-07-03T13:55:37 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8329:5f65141ab113 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/rst_out.py: DOM->ReStructuredText: footnote bugfix
70 2010-07-03T14:06:51 * ThomasWaldmann works on the uuid stuff
71 2010-07-03T14:25:02 *** valeuf
72 2010-07-03T14:25:09 *** valeuf
73 2010-07-03T14:27:21 *** kursor
74 2010-07-03T15:49:07 *** ritinardo
75 2010-07-03T16:05:15 <ei-grad> oh, where is my youth... Become too old to implement the algorithms... %(... /me implemented wrong alogrithm in groups_with_member :-(
76 2010-07-03T16:05:20 <ei-grad> :-D
77 2010-07-03T16:13:06 <ThomasWaldmann> ei-grad: how old are you? :D
78 2010-07-03T16:15:41 <ei-grad> 21)
79 2010-07-03T16:16:57 * ThomasWaldmann is more than double of that :P
80 2010-07-03T16:21:15 *** RogerHaase
81 2010-07-03T16:33:38 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5774:d054ec58fc3b 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed error in algorithm used by groups_with_member
82 2010-07-03T16:33:47 <dreimark> re
83 2010-07-03T16:34:00 * ei-grad thinking how to implement that with minimal number of queries... and what to do with NotExistingGroup
84 2010-07-03T16:38:45 <ei-grad> dreimark: could you check it with test_ldap_groups.py?.. i in doubt what to do with NotExistingGroup tests... It turns out you can add a link to a nonexistent object into the 'member', if you will do this after the creation of the group, using modify_s with MOD_ADD, for example, as i did it in the LDAPGroupsTestBase.setup_class...
85 2010-07-03T16:40:03 <ei-grad> in LDAPGroup.__iter__ should we add unexisted entries to result?
86 2010-07-03T16:42:54 *** ritinardo_
87 2010-07-03T16:44:03 <ei-grad> hm.. GroupsBackendTest expecting us to do... NotExistingGroup should be threated as user... right?
88 2010-07-03T16:46:09 *** ritinardo
89 2010-07-03T16:51:02 *** ritinardo_
90 2010-07-03T18:21:35 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8384:4fbcacc80393 2.0-dev/MoinMoin/storage/__init__.py: xml serialization: add uuid attr to item element
91 2010-07-03T18:21:37 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8385:d3ead65be1de 2.0-dev/MoinMoin/storage/backends/fs19.py: fs19: work with new uuid instead of old userid as user item name
92 2010-07-03T18:21:39 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8386:44d36a724248 2.0-dev/MoinMoin/storage/_tests/test_backends_fs19.py: storage: fix fs19 tests (FSPageBackend init was called wrong)
93 2010-07-03T18:21:42 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8387:1625c7ed42b8 2.0-dev/MoinMoin/storage/__init__.py: revert 8384:4fbcacc80393 (too early, need to do other stuff first)
94 2010-07-03T18:21:44 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8388:914b292bacbd 2.0-dev/MoinMoin/ (4 files in 3 dirs):
95 2010-07-03T18:21:44 <CIA-98> storage: move serialization support from base classes to mixin classes (used in router)
96 2010-07-03T18:21:44 <CIA-98> fix xml preload to use a temporary router backend / temporary memory backend.
97 2010-07-03T18:43:31 *** diofeher
98 2010-07-03T18:43:38 <diofeher> moin
99 2010-07-03T18:43:57 <diofeher> ThomasWaldmann: congratz to german soccer team :P
100 2010-07-03T19:07:45 <dreimark> diofeher: thx
101 2010-07-03T19:07:50 <ThomasWaldmann> i didn't train them :P
102 2010-07-03T19:09:49 <dreimark> ei-grad: i don't understand what you tell with "NotExistingGroup should be threated as user
103 2010-07-03T19:09:59 <dreimark> ei-grad: i don't understand what you tell with "NotExistingGroup should be threated as user"
104 2010-07-03T19:10:35 <dreimark> usually the check is if the member is in the Group
105 2010-07-03T19:10:50 <dreimark> if the group does not exists this also negate the question
106 2010-07-03T19:10:53 <dreimark> it is False
107 2010-07-03T19:11:46 <dreimark> we should have logging.debug message for this case
108 2010-07-03T19:12:55 <ThomasWaldmann> diofeher: you are working on your project?
109 2010-07-03T19:13:41 <dreimark> hmm, why would one add a nonexistent object into the 'member'?
110 2010-07-03T19:13:49 <dreimark> I mean what is the usecase?
111 2010-07-03T19:15:15 * dreimark wonders a bit about consistant checks of ldap configuration itselfs
112 2010-07-03T19:20:58 <diofeher> ThomasWaldmann yes
113 2010-07-03T19:21:09 <diofeher> ThomasWaldmann dreimark :P
114 2010-07-03T19:39:40 <diofeher> ThomasWaldmann: it's better to put static_href = Href(...) in jinjaTheme or request?
115 2010-07-03T19:51:33 <ei-grad> dreimark: now, if there is not existing member in the group, then silently ignored, and we do not put it in result of __iter__ (we can't get its name because only thing we have is a wrong dn)
116 2010-07-03T19:52:03 <ThomasWaldmann> diofeher: put it where the other one is
117 2010-07-03T19:52:50 <dreimark> ei-grad: if we have a page and there is a non existing member on that page
118 2010-07-03T19:54:04 <dreimark> then it is still a member of the group
119 2010-07-03T19:54:32 <dreimark> is it this what you want to tell?
120 2010-07-03T19:54:33 <ei-grad> other backends, like WikiGroups, has the user name, even if member doesn't exists
121 2010-07-03T19:55:18 <ei-grad> and their Group.__iter__ places that name in the result
122 2010-07-03T19:55:35 <diofeher> ThomasWaldmann: ok
123 2010-07-03T19:56:12 <ei-grad> i talk about if there is an unexisting member on XxxGroup page
124 2010-07-03T19:56:21 <ei-grad> (for WikiGroups)
125 2010-07-03T19:57:07 <dreimark> my problem in understanding is "unexisting"
126 2010-07-03T19:57:48 <dreimark> on a group page if you write usernames and they are not created
127 2010-07-03T19:57:52 <dreimark> is it tis ?
128 2010-07-03T19:57:58 <ei-grad> yes
129 2010-07-03T19:58:33 <dreimark> ok. for page groups it does not matter if it is a user and if it is created
130 2010-07-03T19:58:50 <dreimark> it is always only an item on a page
131 2010-07-03T19:59:18 <dreimark> this is separated from usermangment
132 2010-07-03T19:59:22 <dreimark> +a
133 2010-07-03T19:59:54 <dreimark> if acl security is used it checks the behavior if the logged in user is a member of the group
134 2010-07-03T20:00:06 <dreimark> (for example)
135 2010-07-03T20:00:49 <dreimark> it is always something like request.user.may.read ...
136 2010-07-03T20:01:20 <dreimark> this is completly separated from the *Group coded it is only asking
137 2010-07-03T20:01:55 *** diofeher
138 2010-07-03T20:04:56 <dreimark> ei-grad: if i understand the problem right then you can also create group members in ldap where you don't have a user in ldap for?
139 2010-07-03T20:05:57 <dreimark> but because that you don't have a user of that name you can't retrieve if it is the group?
140 2010-07-03T20:06:07 <dreimark> +in
141 2010-07-03T20:09:29 *** kursor
142 2010-07-03T20:15:25 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8480:45f7004390b0 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/head.html theme/jinja.py web/request.py): [templating] fixing url generation for static files (added a attribute to request object, static_href)
143 2010-07-03T20:15:43 <ei-grad> no... the problem was - if we adding a dn, that points to unexisting entry, to the 'member' attribute values of some group, then we can't determine what it is (and can't get its name), so the best way we have - just ignore this 'member' and send a message into logging.warning... i just need to adjust the tests, i forgot to remove CheckNotExistingGroup from expanded_groups, and test_iter asserts because
144 2010-07-03T20:15:45 <ei-grad> expecting it in the result...
145 2010-07-03T20:15:48 <ei-grad> dreimark:
146 2010-07-03T20:16:39 *** diofeher
147 2010-07-03T20:18:18 <ThomasWaldmann> diofeher: 2.7 +from werkzeug import Href
148 2010-07-03T20:18:27 <ei-grad> this can happens only if administrator of ldap changing it by hands, so if that would be just a lot of similar warnings in the logs, it will be normal)
149 2010-07-03T20:18:28 <ThomasWaldmann> for what is that?
150 2010-07-03T20:18:53 <ThomasWaldmann> diofeher: do you read hg diff before committing?
151 2010-07-03T20:20:05 *** ritinardo
152 2010-07-03T20:21:30 <diofeher> ThomasWaldmann: i read... i was trying to build url in JinjaTheme... but i gave up and forget to remove imort
153 2010-07-03T20:23:03 <diofeher> sry
154 2010-07-03T20:24:04 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5775:9ae8e11aa4d3 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/_tests/test_ldap_groups.py: [LDAP2010] corrected expanded_groups in TestLDAPGroups
155 2010-07-03T20:24:28 * ei-grad commited before running all tests again...
156 2010-07-03T20:25:59 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8481:2206f8373738 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] getting rid of warning messages related to _send_title_called and add_msg and removing _send_title_called
157 2010-07-03T20:26:02 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8482:d0b41234fed7 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] removing unused imports
158 2010-07-03T20:26:49 <ei-grad> but all tests passing...
159 2010-07-03T20:26:51 <ei-grad> )
160 2010-07-03T20:27:58 <ThomasWaldmann> diofeher: self.static_href = Href(config.url_prefix_static, self.charset, sort=True, key=sort_key)
161 2010-07-03T20:28:27 <ThomasWaldmann> that's not correct, please, for now, add a comment there # TODO: use cfg, not config
162 2010-07-03T20:28:51 <ThomasWaldmann> (there is no cfg there, we have to sort out that later)
163 2010-07-03T20:30:33 <ei-grad> dreimark: about path problem... seems like there are several common paths for openldap configs... for example - /etc/ldap/ on debian-like systems, /etc/openldap/ on ArchLinux, /usr/local/etc/openldap/ on FreeBSD... how to deal with it? may be just check what path exists and use it?
164 2010-07-03T20:31:39 <ei-grad> or we can make our own copy of schemas, in our temp environment...
165 2010-07-03T20:34:05 * dreimark was disconnected (silently) reads backlog now
166 2010-07-03T20:35:32 <diofeher> ThomasWaldmann: gonna add comment now
167 2010-07-03T20:37:26 <dreimark> ei-grad: ok to conclusion of 20:15 < ei-grad> no... the problem was. But please add this explaination as comment before the logging.warning and make (the warning) verbose
168 2010-07-03T20:39:05 <dreimark> the comment should include that the problem is caused from a wrong configuration of the ldap - not a prolem of moin
169 2010-07-03T20:40:17 <dreimark> ei-grad: best would be one can get it by the slapd command
170 2010-07-03T20:41:07 * dreimark stupid commercials about internet security with ie8 on kabeleins
171 2010-07-03T20:43:59 <dreimark> ei-grad: latter is also a good idea but not in /tmp the toplevel/tests dir may be better
172 2010-07-03T20:44:56 <dreimark> ThomasWaldmann: whats your opinion for saving ldap test configurations below e.g. moin-1.9/tests/ldap ?
173 2010-07-03T20:49:46 <ThomasWaldmann> do whatever makes sense
174 2010-07-03T20:50:26 <dreimark> ei-grad: ^
175 2010-07-03T20:50:29 <dreimark> ok
176 2010-07-03T21:24:13 <ei-grad> bbl
177 2010-07-03T21:42:45 *** vpv
178 2010-07-03T21:44:47 *** vpv
179 2010-07-03T21:56:49 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8483:e2f63167138d 2.0-dev-jinja2-plugins-dfeher/MoinMoin/web/request.py: [templating] adding TODO to request.static_href: use cfg, not config
180 2010-07-03T21:56:53 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8484:7dc9183cda30 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/editbar.html theme/jinja.py): [templating] renaming supplementatino_page_nameLink to has_supplementation_page and returning a boolean. rendering directly in template
181 2010-07-03T21:59:13 *** grzywacz
182 2010-07-03T22:03:30 <ThomasWaldmann> diofeher: did you test that ^^?
183 2010-07-03T22:21:32 <diofeher> ThomasWaldmann: yes, it's working :p
184 2010-07-03T22:27:22 <ThomasWaldmann> explain the "not" in the return expression
185 2010-07-03T22:28:23 <diofeher> ThomasWaldmann: because i changed the logic in the return
186 2010-07-03T22:28:48 <diofeher> in templates, we have to use a meaning name
187 2010-07-03T22:28:55 <diofeher> has_supplementation_page
188 2010-07-03T22:29:07 <diofeher> and I have to change the order that condition works
189 2010-07-03T22:29:20 <diofeher> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/7dc9183cda30#l2.25
190 2010-07-03T22:30:36 <ThomasWaldmann> well, it looks wrong
191 2010-07-03T22:30:51 <ThomasWaldmann> and besides,
192 2010-07-03T22:30:55 <ThomasWaldmann> not x and not y
193 2010-07-03T22:30:57 <dreimark> is test = item? so then the right name can be used
194 2010-07-03T22:31:00 <ThomasWaldmann> is not the same as
195 2010-07-03T22:31:05 <ThomasWaldmann> not (x and y)
196 2010-07-03T22:33:24 <diofeher> i know ThomasWaldmann ^^
197 2010-07-03T22:33:29 <ThomasWaldmann> and even if not looking at boolean logic, if you just look at the method name and at the return expression, you see it is wrong
198 2010-07-03T22:35:02 <ThomasWaldmann> and it should be "use_supplementation_page"
199 2010-07-03T22:35:21 <ThomasWaldmann> or link_suppl....
200 2010-07-03T22:40:17 <diofeher> ThomasWaldmann: hmm. well, talking about return pagename and None
201 2010-07-03T22:40:51 <diofeher> there's no need... because variables that we use are got by cfg
202 2010-07-03T22:40:56 <ThomasWaldmann> i tested it now, it doesn't work
203 2010-07-03T22:41:05 <diofeher> no? in what case?
204 2010-07-03T22:41:31 <ThomasWaldmann> if you create the foo/Discussion page, the link gets disabled
205 2010-07-03T22:42:30 <ThomasWaldmann> so maybe just believe me, kill the not and test again :P
206 2010-07-03T22:43:20 <ThomasWaldmann> and make an "or" out of the "and"
207 2010-07-03T22:43:45 <diofeher> hehe sorry for my mistake
208 2010-07-03T22:43:46 <ThomasWaldmann> return exists or user.may.write
209 2010-07-03T22:43:48 <diofeher> i putted an or
210 2010-07-03T22:43:51 <diofeher> put*
211 2010-07-03T22:44:08 <diofeher> but i thought that was wrong, when i made my logic table :P
212 2010-07-03T22:44:37 <ThomasWaldmann> well, a logic table can help formally, but you don't need it
213 2010-07-03T22:44:47 <ThomasWaldmann> you just need to think about how it should behave
214 2010-07-03T22:45:18 <ThomasWaldmann> and it simple shall show the link when there is the discussion page already there or if the user may create it
215 2010-07-03T22:45:32 <diofeher> yes.. thanks for the revision
216 2010-07-03T22:45:38 <diofeher> ^^
217 2010-07-03T22:46:08 <diofeher> should i have rename function again?
218 2010-07-03T22:46:53 <ThomasWaldmann> yes, because it is wrong
219 2010-07-03T22:47:18 <ThomasWaldmann> use_ or link_...
220 2010-07-03T22:47:44 <ThomasWaldmann> has_... tells that it just checks for existance, but that isn't true
221 2010-07-03T22:48:21 <diofeher> ok, understood
222 2010-07-03T22:48:28 <diofeher> i think use_ it's better
223 2010-07-03T22:48:40 <diofeher> mm, no no, link it's better
224 2010-07-03T22:49:31 <ThomasWaldmann> right, because it is still there (disabled) if you return False
225 2010-07-03T22:51:04 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8485:98a386febda1 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/editbar.html theme/jinja.py): [templating] renaming has_supplementation_page to link_supplementation_age and fixing logical error
226 2010-07-03T22:57:09 <diofeher> hmm, strange error
227 2010-07-03T22:57:36 <diofeher> when i click in discussion page for EncontrarPágina (FindPage in portuguese)
228 2010-07-03T22:58:04 <diofeher> return me this link: /EncontrarP%25C3%25A1gina/Discussion?do=modify&backto=EncontrarPágina%2FDiscussion&template=DiscussionTemplate
229 2010-07-03T22:58:15 <diofeher> and EncontrarP%25C3%25A1gina don't exist
230 2010-07-03T22:59:04 <diofeher> mm, escape!
231 2010-07-03T23:00:05 <diofeher> well, didn't worked
232 2010-07-03T23:00:55 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8486:197761d18458 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/editbar.html: [templating] escaping supplementation url
233 2010-07-03T23:12:34 <diofeher> please take a look later: http://paste.pocoo.org/show/233202/
234 2010-07-03T23:16:55 <diofeher> ThomasWaldmann: what the purpose of these quoted pagenames? http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/file/197761d18458/MoinMoin/theme/jinja.py#l856
235 2010-07-03T23:17:22 <diofeher> i've "grepped" and didn't found they use in anywhere
236 2010-07-03T23:17:39 <ThomasWaldmann> read your todo page, I've written it there
237 2010-07-03T23:18:04 <diofeher> oh, didn't saw this changeset
238 2010-07-03T23:18:08 <diofeher> thx
239 2010-07-03T23:19:15 <ThomasWaldmann> i looked at the pastebin. what exactly is the question?
240 2010-07-03T23:20:09 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8487:f1689315e0be 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/__init__.py: [templating] get rid of urlquoted pagenames used by old themes to building urls. now we have href in templates to build urls
241 2010-07-03T23:20:53 <diofeher> ops, i've made a weird commit.
242 2010-07-03T23:20:57 <TheSheep> diofeher: they add a q_page_FOO for every page_FOO in d, but I guess that should be done with a filter in the template
243 2010-07-03T23:21:36 <TheSheep> or with href
244 2010-07-03T23:21:45 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8488:3114cfe36140 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/ (__init__.py jinja.py): [templating] get rid of urlquoted pagenames used by old themes to building urls. now we have href in templates to build urls in JinjaTheme. reverting this in ThemeBase
245 2010-07-03T23:21:45 <ThomasWaldmann> that should be killed, as I wrote
246 2010-07-03T23:22:46 <diofeher> TheSheep ThomasWaldmann killed now :p
247 2010-07-03T23:33:20 <ThomasWaldmann> diofeher: you are still targeting html4, thus your favicon link tag is wrong
248 2010-07-03T23:33:49 *** diofeher
249 2010-07-03T23:41:40 *** diofeher
250 2010-07-03T23:41:44 <diofeher> ThomasWaldmann: question about pastebin is that when i click in supplementation in 'EncontrarP?gina', return me wrong Item: "EncontrarP%C3%C2gina"
251 2010-07-03T23:41:53 <diofeher> man, my internet is killing me :/
252 2010-07-03T23:45:08 <ThomasWaldmann> it's double urlquoting
253 2010-07-03T23:46:56 <ThomasWaldmann> the whole do=supplementation procedure seems to be a bit too complicated for what it does
254 2010-07-03T23:54:50 <ThomasWaldmann> diofeher: but you don't need to fix THAT, continue cleaning up the theme stuff
