1 2010-07-31T00:22:35 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9176:993c19713b7b 2.0-dev/MoinMoin/items/__init__.py: drawings: html5/xml and url_for() fixes
2 2010-07-31T00:27:04 <dreimark> gn
3 2010-07-31T00:46:10 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9177:02ab05423476 2.0-dev/MoinMoin/items/sendcache.py: sendcache: fix url generation
4 2010-07-31T04:49:53 *** grzywacz
5 2010-07-31T06:41:54 *** valeuf
6 2010-07-31T06:41:55 *** dennda
7 2010-07-31T06:44:37 *** valeuf
8 2010-07-31T06:44:43 *** dennda
9 2010-07-31T10:11:14 *** ebo^
10 2010-07-31T10:56:41 <valeuf> dreimark: your code is working with my patch for the smiley bug
11 2010-07-31T10:56:49 <valeuf> dreimark: there is test normally
12 2010-07-31T11:06:23 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9170:2c595885cfb4 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_smiley.py: Add test for bug with newline in a string for the smiley converter
13 2010-07-31T11:06:34 <valeuf> dreimark: hm, you were right, I forget to commit the test ^ ^
14 2010-07-31T11:14:25 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9178:cafcc6e2d287 2.0-dev/MoinMoin/items/__init__.py: fix status code handling
15 2010-07-31T11:14:33 <valeuf> /o\ I tried to merge with the main moin2.0 repos, but I have a lot of error now
16 2010-07-31T11:15:15 <valeuf> ThomasWaldmann: did you change stuff recently in the smiley converter ?
17 2010-07-31T11:17:05 <valeuf> ok, you use Iri function now :)
18 2010-07-31T11:23:09 <valeuf> hum, I cannot use url_for in the tests ...
19 2010-07-31T11:23:47 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9187:9a3f6ac5f66f 2.0-dev/MoinMoin/converter2/ (4 files in 2 dirs): merged moin/2.0-dev-docbook-html-vjaniaut
20 2010-07-31T11:23:48 <ThomasWaldmann> moin
21 2010-07-31T11:24:01 <valeuf> ThomasWaldmann: you merged my code?
22 2010-07-31T11:24:07 <valeuf> ThomasWaldmann: I cannot merged back actually
23 2010-07-31T11:24:12 <ThomasWaldmann> wait as sec :)
24 2010-07-31T11:25:03 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev < merged
25 2010-07-31T11:25:13 <ThomasWaldmann> cia is rather slow these days
26 2010-07-31T11:28:44 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9188:936d7c4b6d33 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Merged moin/2.0-dev
27 2010-07-31T11:29:50 <valeuf> well, everything is working, however test_smiley is broken because url_for does not work for test actually (url_for expect a request which we do not have yet in the tets)
28 2010-07-31T11:30:57 <ThomasWaldmann> test stuff needs a redesign
29 2010-07-31T11:32:02 <valeuf> ThomasWaldmann: yep, I am going to have my breakfast, and I have a look
30 2010-07-31T11:46:57 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9214:e95887084c22 2.0-dev/MoinMoin/ (45 files in 10 dirs): merged moin/2.0-dev-jinja2-plugins-dfeher
31 2010-07-31T11:52:56 *** dennda
32 2010-07-31T11:52:56 *** dennda
33 2010-07-31T12:02:10 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9215:f0ae4bcda4c8 2.0-dev/MoinMoin/ (config/multiconfig.py templates/layout.html): renamed cfg.custom_* to cfg.html_*
34 2010-07-31T12:25:16 *** grzywacz
35 2010-07-31T12:28:06 <ThomasWaldmann> hmm, something broke smileys again?
36 2010-07-31T12:31:11 *** ebo^
37 2010-07-31T12:31:35 *** ebo^
38 2010-07-31T12:47:14 <valeuf> ThomasWaldmann: after your last merge?
39 2010-07-31T12:49:16 <ThomasWaldmann> current main repo
40 2010-07-31T12:49:36 <ThomasWaldmann> saw it working recently, but now it isn't
41 2010-07-31T12:50:08 <ThomasWaldmann> and the smiley code looks a bit strange
42 2010-07-31T12:56:27 <valeuf> ThomasWaldmann: I will merge again and try to figure out why it does not work
43 2010-07-31T12:56:42 <valeuf> ThomasWaldmann: what do you find strange? I can maybe fix it
44 2010-07-31T12:58:35 <ThomasWaldmann> the way it treats the childs
45 2010-07-31T12:59:54 <ThomasWaldmann> in do_children
46 2010-07-31T13:10:09 <valeuf> ThomasWaldmann: Yep, it is a little bit tricky, I will see to add more comments, and see if there is not a better way to do it
47 2010-07-31T13:39:21 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9216:ed2d870b8a08 2.0-dev/MoinMoin/__init__.py: remove some unused stuff from MoinMoin.__init__
48 2010-07-31T13:57:59 *** ebo^
49 2010-07-31T13:58:25 *** ebo^
50 2010-07-31T14:07:04 <valeuf> ThomasWaldmann: I merged my repos with the main moin/2.0-dev repos, and smileys are working fine with me
51 2010-07-31T14:07:18 <valeuf> I could not find how I can make the unit test working
52 2010-07-31T14:07:35 <valeuf> should I set up something with flask to get the url_for() working in the test?
53 2010-07-31T14:13:46 <ThomasWaldmann> http://doodle.com/ky7zcvt93p6yy5ey
54 2010-07-31T14:26:02 <ThomasWaldmann> new options there ^^ (one can edit his vote, if one likes :)
55 2010-07-31T14:26:08 <ThomasWaldmann> ones*
56 2010-07-31T14:26:34 <valeuf> :)
57 2010-07-31T14:36:01 <ThomasWaldmann> valeuf: can you vote/for against omg/OMG options? (just edit your vote)
58 2010-07-31T14:36:35 <valeuf> ThomasWaldmann: I did, but my vote appear twice
59 2010-07-31T14:36:48 <valeuf> I do not know how I can edit my vote
60 2010-07-31T14:38:05 <ThomasWaldmann> ok, fixed it
61 2010-07-31T14:52:58 <ThomasWaldmann> new options :D
62 2010-07-31T15:13:09 *** valeuf
63 2010-07-31T15:13:45 *** valeuf
64 2010-07-31T15:15:08 <ThomasWaldmann> does anybody have bad feelings if I just kill all the non-wsgi stuff (flup, fallback_cgi, ...)?
65 2010-07-31T15:15:29 <valeuf> ThomasWaldmann: it is not anymore used with flask rightL
66 2010-07-31T15:15:30 <valeuf> ?
67 2010-07-31T15:16:01 <ThomasWaldmann> well, moin was and is a wsgi app, so that is just stuff wrapped around it
68 2010-07-31T15:16:23 <valeuf> ThomasWaldmann: moin2.0 is cleaning time anyway :)
69 2010-07-31T15:16:42 <ThomasWaldmann> there are is some complex support code that implementend commandline parsing and built wrappers according to options
70 2010-07-31T15:17:12 <ThomasWaldmann> that's somehow nice, but also limiting, because it only wrapped stuff in the way like foreseen/implemented there
71 2010-07-31T15:17:26 <ThomasWaldmann> so just having a small py script doing the wrapping is more flexible
72 2010-07-31T15:18:02 <ThomasWaldmann> and whoever wants cgi/fastcgi/... can just use flup and wrap moin with it
73 2010-07-31T15:28:05 <ThomasWaldmann> dreimark: eSyr: TheSheep: waldi: xorAxAx: zenhase: ^^
74 2010-07-31T16:22:48 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9217:908732a39a07 2.0-dev/ (30 files in 6 dirs): (log message trimmed)
75 2010-07-31T16:22:48 <CIA-50> remove flup/serving/deployment stuff not needed any more, see below
76 2010-07-31T16:22:48 <CIA-50> MoinMoin.util.daemon: not used any more
77 2010-07-31T16:22:48 <CIA-50> MoinMoin.web._fallback_cgi: if you want cgi, use flup
78 2010-07-31T16:22:48 <CIA-50> flup: removed, can be installed by users separately
79 2010-07-31T16:22:49 <CIA-50> MoinMoin.web.flup_frontend: removed this commandline interface for flup
80 2010-07-31T16:22:50 <CIA-50> Problem: It maybe did more harm than good. Although it was easier to use
81 2010-07-31T16:31:01 <zenhase> i felt a disturbance in the force ... like someone highlighting me on irc ;)
82 2010-07-31T16:42:39 <ThomasWaldmann> too late, Luke - the evil empire doing the flask integration has just killed some of your code :D
83 2010-07-31T16:56:23 <dreimark> moin
84 2010-07-31T16:57:37 <dreimark> yay ripping out that stuff
85 2010-07-31T17:12:42 * ThomasWaldmann just had a look at flask's app.logger, but it somehow doesn't seem to be useful for moin
86 2010-07-31T17:13:21 <ThomasWaldmann> (because it is just one logger, but moin can use multiple, differently configured loggers)
87 2010-07-31T17:13:33 <zenhase> ThomasWaldmann: that's ok, eliminating code that is otherwise better implemented in some third party library is a good thing
88 2010-07-31T17:13:59 <ThomasWaldmann> it isn't implemented otherwise
89 2010-07-31T17:14:20 <ThomasWaldmann> (see commit comment)
90 2010-07-31T17:15:25 <ThomasWaldmann> (we mostly had to use the newer moin.fcgi script, because one only can easily wrap with that, not with the frontend-based stuff)
91 2010-07-31T17:15:31 *** RogerHaase
92 2010-07-31T17:16:08 <ThomasWaldmann> http://doodle.com/ky7zcvt93p6yy5ey < poll about better name for flask.g
93 2010-07-31T17:23:22 * dreimark should have read the comments before voting
94 2010-07-31T17:32:50 <dreimark> bbl
95 2010-07-31T17:43:18 <ThomasWaldmann> you can edit your vote
96 2010-07-31T17:43:28 <RogerHaase> ThomasWaldmann: The underlay pages on moinmo.in are not current. Could you please copy over the current set when you have a moment?
97 2010-07-31T17:43:47 <ThomasWaldmann> yes
98 2010-07-31T17:44:07 <RogerHaase> Thanks.
99 2010-07-31T17:45:21 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9218:546d36af44f1 2.0-dev/MoinMoin/__init__.py: override Flask.jinja_options
100 2010-07-31T17:53:44 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9219:207b3ad76b48 2.0-dev/MoinMoin/__init__.py: use template_filter decorator
101 2010-07-31T20:07:11 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9220:c3e447f479b8 2.0-dev/MoinMoin/items/__init__.py: items: fix 304 handling for do_get
102 2010-07-31T20:24:12 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9221:b1e325a26499 2.0-dev/MoinMoin/support/flask/helpers.py: (log message trimmed)
103 2010-07-31T20:24:12 <CIA-50> flask: custom patch for send_file, fixes multiple problems, details below
104 2010-07-31T20:24:12 <CIA-50> send_file() as it was had multiple problems:
105 2010-07-31T20:24:12 <CIA-50> a) ugly first parameter, could be either file object or filename
106 2010-07-31T20:24:12 <CIA-50> This was cleaned up by defaulting first param to None and adding new
107 2010-07-31T20:24:13 <CIA-50> "file" and "filename" params at the end of the param's list.
108 2010-07-31T20:24:14 <CIA-50> You still can use the first param "filename_or_fp" as you used to,
109 2010-07-31T20:45:31 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9222:ea11c15b7b20 2.0-dev/MoinMoin/items/__init__.py: items: use the custom patched flask.send_file
110 2010-07-31T21:11:29 <valeuf> ThomasWaldmann: the new send file works well?
111 2010-07-31T21:14:11 <ThomasWaldmann> yes
112 2010-07-31T21:14:36 <ThomasWaldmann> but i just was notified that i missed flask 0.6 release, so that + patch will come soon...
113 2010-07-31T21:16:21 <valeuf> :)
114 2010-07-31T21:17:59 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9223:cb0a91a5847e 2.0-dev/MoinMoin/support/flask/ (10 files): upgrade to flask 0.6
115 2010-07-31T21:18:07 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9224:58eb8f978188 2.0-dev/MoinMoin/support/flask/helpers.py: (log message trimmed)
116 2010-07-31T21:18:08 <CIA-50> flask: custom patch for flask 0.6 send_file, fixes multiple problems, details below
117 2010-07-31T21:18:08 <CIA-50> a) ugly first parameter, could be either file object or filename
118 2010-07-31T21:18:08 <CIA-50> This was cleaned up by defaulting first param to None and adding new
119 2010-07-31T21:18:08 <CIA-50> "file" and "filename" params at the end of the param's list.
120 2010-07-31T21:18:08 <CIA-50> You still can use the first param "filename_or_fp" as you used to,
121 2010-07-31T21:18:09 <CIA-50> but you'll get a deprecation warning then.
122 2010-07-31T21:23:11 <ThomasWaldmann> now just the urls need more fixing...
123 2010-07-31T22:08:25 * ThomasWaldmann kills Item.url and .rev_url
124 2010-07-31T22:10:38 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9225:f6bd40d8c714 2.0-dev/MoinMoin/items/__init__.py: Item: kill .url() and .rev_url(), use url_for()
125 2010-07-31T22:13:35 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9226:084639345f3e 2.0-dev/MoinMoin/items/__init__.py: fix typo
126 2010-07-31T22:18:10 <valeuf> ThomasWaldmann: meeting tomorrow at 5:00 UTC as usual right?
127 2010-07-31T22:19:23 <ThomasWaldmann> no, at 17:00 UTC :P
128 2010-07-31T22:20:39 <ThomasWaldmann> there is quite some crap in the transclude methods it items/__init__.py
129 2010-07-31T22:22:10 <ThomasWaldmann> looks like we need converter there somehow
130 2010-07-31T22:35:07 <ThomasWaldmann> and the include converter needs some refreshing
131 2010-07-31T22:43:31 <valeuf> ThomasWaldmann: trnaslcude method has never been really clear for me actually
132 2010-07-31T22:43:51 <valeuf> ThomasWaldmann: maybe it is time to think to split and clean a little items/__init__.py ?
133 2010-07-31T22:56:10 <ThomasWaldmann> it looks like the transclude there is only called from there
134 2010-07-31T22:56:35 <ThomasWaldmann> well, the point is that we have 2 basic ops for items
135 2010-07-31T22:56:43 <ThomasWaldmann> link to them (easy :)
136 2010-07-31T22:57:02 <ThomasWaldmann> transclude them (include them) (not so easy :)
137 2010-07-31T22:57:12 <ThomasWaldmann> [[target]]
138 2010-07-31T22:57:18 <ThomasWaldmann> {{target}}
139 2010-07-31T22:58:44 <ThomasWaldmann> clearer now?
140 2010-07-31T22:59:51 <ThomasWaldmann> valeuf:
141 2010-07-31T23:03:21 <ThomasWaldmann> and the inner content area of an item rendering is also quite similar to what transclusion would show somewhere else
142 2010-07-31T23:03:37 <ThomasWaldmann> that is why for some items render_data just calls transclude
143 2010-07-31T23:05:54 <ThomasWaldmann> so i guess we need 2 kinds of things
144 2010-07-31T23:06:48 <ThomasWaldmann> a) converters for all mimetypes (important ones first, like images)
145 2010-07-31T23:07:09 <ThomasWaldmann> b) a refreshed generic include converter
146 2010-07-31T23:07:22 <valeuf> I see ^ ^
147 2010-07-31T23:07:47 <valeuf> still a lot of work with these stuff, I wont get bored after my SoC
148 2010-07-31T23:08:53 <ThomasWaldmann> btw, did you do more tests for the packaging/setup stuff?
149 2010-07-31T23:51:25 * ThomasWaldmann wrote image_in converter
150
