1 2010-08-03T00:02:47 <ThomasWaldmann> for render_data is somehow should just call html_conv(item_to_dom(thisitem))
2 2010-08-03T00:04:39 <ThomasWaldmann> and when some converter encounters {{itemname}}, it hangs the domtree of item_to_dom(itemname) into that place
3 2010-08-03T00:22:57 <valeuf> ThomasWaldmann: so you would have a converter picture-->dom which would just return <oject data="target_url"> ??
4 2010-08-03T00:23:18 <valeuf> ThomasWaldmann: no problem to move the internal_repr anyway
5 2010-08-03T00:23:57 <valeuf> your solution would split this internal_repr if I understand?
6 2010-08-03T00:24:15 <valeuf> btw, good night ^ ^
7 2010-08-03T00:25:55 <ThomasWaldmann> we have that image_in already :)
8 2010-08-03T00:27:09 <ThomasWaldmann> gn valeuf
9 2010-08-03T06:53:25 *** ebo^
10 2010-08-03T07:22:09 *** DmitryAndreev
11 2010-08-03T07:34:55 *** ebo^
12 2010-08-03T07:40:09 *** DmitryAndreev
13 2010-08-03T08:22:09 *** ebo^
14 2010-08-03T08:37:40 *** DmitryAndreev
15 2010-08-03T08:51:51 *** DmitryAndreev
16 2010-08-03T09:36:48 <valeuf> moin
17 2010-08-03T09:37:10 <valeuf> ThomasWaldmann: yes I saw your image in, but it means we will need to have something also for audio, video and so on...
18 2010-08-03T09:37:16 <valeuf> but I think it is not that bad
19 2010-08-03T09:37:35 <valeuf> anyway we should have this conversion stuff somewhere
20 2010-08-03T09:37:52 <valeuf> but for video it can be more difficult to output something for the DOMTroo
21 2010-08-03T09:37:55 <valeuf> *DOMTree
22 2010-08-03T09:38:10 <valeuf> or we need somekind of generic object tag
23 2010-08-03T09:39:30 *** DmitryAndreev
24 2010-08-03T09:41:15 *** DmitryAndreev
25 2010-08-03T09:47:39 *** DmitryAndreev
26 2010-08-03T09:57:43 *** DmitryAndreev
27 2010-08-03T10:04:19 *** DmitryAndreev
28 2010-08-03T10:05:02 *** DmitryAndreev
29 2010-08-03T10:17:09 *** DmitryAndreev
30 2010-08-03T10:17:27 *** DmitryAndreev
31 2010-08-03T10:20:10 *** DmitryAndreev_
32 2010-08-03T10:22:17 *** DmitryAndreev
33 2010-08-03T10:28:44 *** DmitryAndreev_
34 2010-08-03T10:34:06 *** DmitryAndreev
35 2010-08-03T10:49:20 *** ebo^
36 2010-08-03T10:53:54 *** ebo^
37 2010-08-03T11:33:44 *** DmitryAndreev
38 2010-08-03T11:58:21 <ThomasWaldmann> valeuf: yes, we'll need more converters and maybe some more capable domtree representation
39 2010-08-03T11:59:23 <valeuf> ThomasWaldmann: actually I thought that we can use the object tag but we could add some attribute
40 2010-08-03T11:59:37 <valeuf> ThomasWaldmann: something to specify the type (picture, audio, video ...)
41 2010-08-03T11:59:58 <ThomasWaldmann> yeah, maybe
42 2010-08-03T12:00:13 <valeuf> so it is easier for the output converter to handle it (img tag, flash player, specific handler in docbook ...)
43 2010-08-03T12:00:23 <ThomasWaldmann> i think i'll try today with the stuff we already have conv for
44 2010-08-03T12:01:14 <valeuf> if you add some specification to the DOM tree, please tell me, I try te keep up-to-date the current specification here : http://moinmo.in/ValentinJaniaut/GSoC/TreeOutputModification
45 2010-08-03T12:02:58 <ThomasWaldmann> that stuff should be at some more easy to find page after SOC
46 2010-08-03T12:03:34 <valeuf> ThomasWaldmann: I hope so :) it tooks a while to do it
47 2010-08-03T12:04:29 <valeuf> I have a little design problem about the DOM tree actually
48 2010-08-03T12:05:03 <valeuf> there is some inline element in many language which cannot be represented into the DOM tree because we do not have element
49 2010-08-03T12:05:17 <valeuf> (it is usually some tags like abbrev, accronym ...)
50 2010-08-03T12:05:42 <valeuf> I think we should not add specific tag for such of things because it would be complicate to have enough for each language
51 2010-08-03T12:06:22 <valeuf> I was using previously <span html-element='abbrev'>Moin</span>
52 2010-08-03T12:06:43 <valeuf> however I think we should not have something specific to the language but rather something generic
53 2010-08-03T12:07:08 <valeuf> I thought about using <span element='abbrev'>Moin</span>
54 2010-08-03T12:07:10 <ThomasWaldmann> span class="abbrev"?
55 2010-08-03T12:07:27 <valeuf> the problem with class, is that it can conflict with css
56 2010-08-03T12:07:45 <valeuf> since it will be converted into <span class='abbrev'> in HTML
57 2010-08-03T12:07:53 <valeuf> (but this behavior can be fixed)
58 2010-08-03T12:08:05 <ThomasWaldmann> isn't that what we want anyway?
59 2010-08-03T12:08:28 <ThomasWaldmann> span class="element-abbrev"?
60 2010-08-03T12:08:29 <valeuf> well, I think that it would be much nicer to get back <abbrev> since this elements exist in HTML
61 2010-08-03T12:08:47 <ThomasWaldmann> ah, ok
62 2010-08-03T12:09:16 <valeuf> but it is <abbr> in HTML (however, we just need to give a dictonnary of the equivalence, it should be ok)
63 2010-08-03T12:09:32 <ThomasWaldmann> sounds ok for me
64 2010-08-03T12:09:37 <ThomasWaldmann> waldi: ^^?
65 2010-08-03T12:09:49 <valeuf> :)
66 2010-08-03T12:54:53 *** TheSheep
67 2010-08-03T13:20:59 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9279:a1950a7e28cd 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Edit lis of ingnored tags for DocBook_IN converter
68 2010-08-03T13:21:33 *** DmitryAndreev_
69 2010-08-03T13:22:55 *** TheSheep
70 2010-08-03T13:25:55 *** DmitryAndreev
71 2010-08-03T14:04:50 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9282:521141332f76 2.0-dev/MoinMoin/ (6 files in 6 dirs): (log message trimmed)
72 2010-08-03T14:04:50 <CIA-50> alias flaskg for g - please EVER use flaskg, NEVER g
73 2010-08-03T14:04:50 <CIA-50> It is such a pain to find single-letter names. Even search regexes like \<g\>
74 2010-08-03T14:04:50 <CIA-50> don't help much, they also match "e.g." and lots of other stuff.
75 2010-08-03T14:04:50 <CIA-50> DO:
76 2010-08-03T14:04:50 <CIA-50> # please keep the flaskg import on a separate line, as shown below,
77 2010-08-03T14:04:51 <CIA-50> # so that in case we'll see a better official name in flask in the future,
78 2010-08-03T14:07:44 <ThomasWaldmann> diofeher: 1.7 + show_navigation=True if rev>-1 else False,
79 2010-08-03T14:08:30 <TheSheep> show_navigation = (rev > -1)
80 2010-08-03T14:08:47 <ThomasWaldmann> exactly :)
81 2010-08-03T14:09:06 <ThomasWaldmann> maybe even without the parens and with >= 0
82 2010-08-03T14:09:23 <TheSheep> without the parens it could be confusing
83 2010-08-03T14:10:25 <ThomasWaldmann> btw, don't forget todo review
84 2010-08-03T14:12:43 <TheSheep> yes, I'm sorry for the delay
85 2010-08-03T14:15:29 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9294:41be5bbfaf65 2.0-dev/MoinMoin/ (13 files in 4 dirs): merged moin/2.0-dev-jinja2-plugins-dfeher
86 2010-08-03T14:28:10 <ThomasWaldmann> eSyr: i would like to merge dmitry's stuff also, but I'ld like that you review it first and that the converter method is decided
87 2010-08-03T14:39:33 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9295:617e06a7b9a7 2.0-dev/MoinMoin/ (config/multiconfig.py templates/editbar.html):
88 2010-08-03T14:39:33 <CIA-50> add Show link to editbar
89 2010-08-03T14:39:33 <CIA-50> Of course one could also click on the last item in location breadcrumbs to show
90 2010-08-03T14:39:33 <CIA-50> current item, but that might be less obvious if the l.b. are not at the place
91 2010-08-03T14:39:33 <CIA-50> where they are currently located.
92 2010-08-03T14:39:45 *** DmitryAndreev_
93 2010-08-03T14:43:51 <eSyr> ThomasWaldmann: ok
94 2010-08-03T14:55:06 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9296:024f2a71209f 2.0-dev/MoinMoin/templates/history.html: item history: use "download" not "get" as linktext, remove not working check for revert with current rev
95 2010-08-03T15:08:52 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9280:921337a9938c 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_html_in.py html_in.py): Change html-element attribute to html for span element in the DOM Tree
96 2010-08-03T15:09:17 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9281:0ab9e8974832 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Edit comment according to the last commit
97 2010-08-03T15:09:17 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9282:32fd85b79e8a 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_docbook_in.py docbook_in.py): Add support for inline tags without equivalence for DocBook_IN converter
98 2010-08-03T15:09:21 <valeuf> it is really annoying to work without unit test in fact, I will try to see if I can solve the problem
99 2010-08-03T15:12:13 <ThomasWaldmann> great :)
100 2010-08-03T15:13:48 *** valeuf
101 2010-08-03T15:14:13 *** valeuf
102 2010-08-03T15:18:45 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9297:2d04c68c4128 2.0-dev/MoinMoin/ (6 files in 3 dirs):
103 2010-08-03T15:18:45 <CIA-50> have a separate metadata view
104 2010-08-03T15:18:45 <CIA-50> TODO: meta.html and show.html have almost duplicated code, optimize
105 2010-08-03T15:20:06 <ThomasWaldmann> diofeher: ^^ that means the new navigation code. it should be in a block or a macro or something. the endpoint it links to needs to be flexible and it needs to be at top of the page and look less ugly. :)
106 2010-08-03T15:21:50 <ThomasWaldmann> btw, about block names - is it only me or are they a little confusing?
107 2010-08-03T15:22:50 <valeuf> With this patch I can run most of the tests : http://paste.pocoo.org/show/245237/
108 2010-08-03T15:22:56 <valeuf> probably few part to clean up more
109 2010-08-03T15:23:12 <valeuf> (I kept the previous stuff in comments at this time)
110 2010-08-03T15:25:37 <valeuf> I commit this first quick patch in my repos, let me know if you see other way to fix that
111 2010-08-03T15:28:19 *** DmitryAndreev_
112 2010-08-03T15:39:04 <ThomasWaldmann> valeuf: can one use the app we have in MoinMoin/__init__.py?
113 2010-08-03T15:39:58 <valeuf> ThomasWaldmann: hm probably
114 2010-08-03T15:40:06 <valeuf> ThomasWaldmann: it was just quick and dirty, I will check
115 2010-08-03T15:44:32 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9283:9aa53af4047f 2.0-dev-docbook-html-vjaniaut/MoinMoin/conftest.py: Quick and dirty patch to be able to run again the tests
116 2010-08-03T15:44:34 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9284:bec8767773ec 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Fix trailing whitespace
117 2010-08-03T15:44:37 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9285:1ea1b21e9c80 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Fix small issue for the conversion of inline elements without equivalence for the DocBook_IN converter
118 2010-08-03T15:44:38 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9286:78bba7206228 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Move address from ignored_tags to inline_tags for DocBook_IN converter
119 2010-08-03T15:44:41 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9287:97da1cee5b6d 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_out.py: Change html-element attribute to element attribute for the span element for the HTML_OUT converter
120 2010-08-03T15:44:43 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9288:87ad7e654fa4 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Fix test for the HTML roundtrip converter
121 2010-08-03T15:52:55 <diofeher> moin
122 2010-08-03T15:57:27 <valeuf> 259 failed, 1694 passed, 18 skipped, 54 error in 131.29 seconds ...
123 2010-08-03T15:57:42 <valeuf> progress but still not working as I'd like
124 2010-08-03T15:59:28 <valeuf> here is the latest patch : http://paste.pocoo.org/show/245262/
125 2010-08-03T15:59:31 <valeuf> few question
126 2010-08-03T16:00:05 <valeuf> TestRequest is something specific to werkzeug in a request file in web module, I feel like these request and flask request are quite in conflict
127 2010-08-03T16:00:47 <valeuf> Secondly, I do not find really where is Client(Application()) now
128 2010-08-03T16:02:01 <ThomasWaldmann> if the test app / test request setup is as similar as possible to the real app / requests setup, that would be nice
129 2010-08-03T16:02:05 <valeuf> (it is supposed to be in request, and I can only find the import for client)
130 2010-08-03T16:02:26 <valeuf> ThomasWaldmann: actually the question is more : are you still using Request class from web module?
131 2010-08-03T16:03:54 <diofeher> 1694 tests? :O
132 2010-08-03T16:04:22 <valeuf> diofeher: but still 259 failed and 54 error :s
133 2010-08-03T16:04:29 <valeuf> the errors are the biggest problem
134 2010-08-03T16:04:47 <diofeher> valeuf, hm, i only have 1170 here ^^
135 2010-08-03T16:04:53 <ThomasWaldmann> valeuf: i think we currently have to. too much is still accessed with request.xxx (request == moin's do-it-all request)
136 2010-08-03T16:05:20 <diofeher> to replace request we will have a lot of work ^^
137 2010-08-03T16:05:27 <valeuf> ThomasWaldmann: ok, I need to see how I can merge flask and moin's request maybe
138 2010-08-03T16:05:41 <valeuf> diofeher: you have a request object in flask :p
139 2010-08-03T16:06:06 <valeuf> diofeher: test are working in your working directory?
140 2010-08-03T16:06:26 <diofeher> valeuf, i know ^^
141 2010-08-03T16:06:43 <diofeher> 2 failed / 3 error
142 2010-08-03T16:07:00 <valeuf> diofeher: delete wsgiapp.pyc ^ ^
143 2010-08-03T16:07:04 <valeuf> you will understand
144 2010-08-03T16:07:24 <valeuf> (zave it somewhere if tests are really important for you now)
145 2010-08-03T16:07:28 <valeuf> *save
146 2010-08-03T16:08:18 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9298:80bbf71709f4 2.0-dev/MoinMoin/ (apps/frontend/views.py templates/index.html): (log message trimmed)
147 2010-08-03T16:08:18 <CIA-50> streamline template params, details below
148 2010-08-03T16:08:18 <CIA-50> for now give item AND item_name, if possible, add some XXX comment if one of
149 2010-08-03T16:08:18 <CIA-50> them is missing
150 2010-08-03T16:08:18 <CIA-50> for index and global index, give the already computed index, so we don't need
151 2010-08-03T16:08:19 <CIA-50> to give the item (because for the global index, we don't really have a valid
152 2010-08-03T16:08:20 <CIA-50> item, just this pseudo root item)
153 2010-08-03T16:08:59 <ThomasWaldmann> valeuf: imho flask's request should rather stay as is (just having the http request stuff)
154 2010-08-03T16:09:26 <ThomasWaldmann> i think we could put moin's additional stuff into flaskg maybe
155 2010-08-03T16:09:44 <valeuf> I think I found a solution :)
156 2010-08-03T16:09:53 <ThomasWaldmann> diofeher: merge
157 2010-08-03T16:10:25 <diofeher> ThomasWaldmann, mitsuhiko started a discussion on ML of flask about what you talked with him
158 2010-08-03T16:10:31 <diofeher> too many votes to stay with g
159 2010-08-03T16:11:19 <ThomasWaldmann> i never suggested killing g right now, but aliasing it to something that is not single letter
160 2010-08-03T16:11:52 <diofeher> unrun, i know, suggestion is only about aliasing
161 2010-08-03T16:12:01 <diofeher> i mean to stay with name g, not to kill it ^^
162 2010-08-03T16:12:18 <ThomasWaldmann> but i don't care any more, i don't like to do endless discussions about a simple thing
163 2010-08-03T16:13:02 <diofeher> hm, tests don't even run without wsgiapp.pyc
164 2010-08-03T16:13:16 <ThomasWaldmann> see code in MoinMoin/__init__.py and just use flaskg :)
165 2010-08-03T16:13:17 <valeuf> diofeher: welcome in our nightmare :)
166 2010-08-03T16:13:28 <diofeher> hahahah
167 2010-08-03T16:13:38 <diofeher> ah, good news
168 2010-08-03T16:13:53 <diofeher> it looks my college will allow me to do my final paper about moin moin
169 2010-08-03T16:13:56 <diofeher> :D
170 2010-08-03T16:17:49 <ThomasWaldmann> ah, nice :)
171 2010-08-03T16:18:53 <diofeher> applying valeuf's patch: 110 failed, 888 passed, 27 skipped, 55 error
172 2010-08-03T16:19:11 <valeuf> \o/ :)
173 2010-08-03T16:19:18 <valeuf> but I am still woring on,
174 2010-08-03T16:19:34 <valeuf> and actually I just realized that many things in the latest commit from ThomasWaldmann will help me
175 2010-08-03T16:20:12 <diofeher> why these tests broken today?
176 2010-08-03T16:20:33 <valeuf> diofeher: broken along ago, you just never notice it because you kept wsgiapp.pyc
177 2010-08-03T16:20:37 <diofeher> someone deleted wsgiapp.pyc and discovered?
178 2010-08-03T16:20:43 <diofeher> ah ok ^^
179 2010-08-03T16:20:57 <valeuf> we are talking about since few days now ^ ^
180 2010-08-03T16:21:31 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9289:3968f7bee3a1 2.0-dev-docbook-html-vjaniaut/MoinMoin/conftest.py: Minor improvement to conftest
181 2010-08-03T16:21:37 *** ebo^
182 2010-08-03T16:21:42 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9318:fbb943c4478b 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (30 files in 14 dirs): Merge against moin/2.0-dev repos
183 2010-08-03T16:22:19 <diofeher> ah, didn't see :/
184 2010-08-03T16:24:02 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9299:2a8d62c30339 2.0-dev/MoinMoin/theme/__init__.py: add menu entry for 'Items with similar names' (LikePages in moin 1.x)
185 2010-08-03T16:26:31 <diofeher> TheSheep, ThomasWaldmann, i'm gonna move rev navigation to top, ok? or better stay in bottom?
186 2010-08-03T16:27:19 <ThomasWaldmann> as it is only shown when rendering some specific revision, it must be on top
187 2010-08-03T16:27:42 <ThomasWaldmann> so that people are aware that they are looking at something that maybe isn't the current rev
188 2010-08-03T16:28:10 <ThomasWaldmann> diofeher: merge main repo before touching that code
189 2010-08-03T16:28:21 <ThomasWaldmann> and fix it in show as well as meta template
190 2010-08-03T16:28:27 <valeuf> merged with moin/2.0-dev brokee my tests again
191 2010-08-03T16:28:46 <ThomasWaldmann> huh?
192 2010-08-03T16:29:03 <diofeher> already merged ^^
193 2010-08-03T16:29:06 <valeuf> something with flaskg ... not really clear
194 2010-08-03T16:29:15 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9300:f518895a058c 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/show.html: [templating] move rev navigation to top of the page
195 2010-08-03T16:29:27 <ThomasWaldmann> flaskg is only there if you import MoinMoin
196 2010-08-03T16:29:41 <ThomasWaldmann> because it is patched into flask there
197 2010-08-03T16:30:08 <valeuf> yep
198 2010-08-03T16:30:58 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9300:edc4268a45db 2.0-dev/MoinMoin/theme/__init__.py: actions menu: add a separator, adjust separator length
199 2010-08-03T16:32:22 <ThomasWaldmann> do we want to split that edit_bar into "views" and "actions"?
200 2010-08-03T16:33:23 <ThomasWaldmann> views: Show Meta History Index Discussion ...
201 2010-08-03T16:33:41 <ThomasWaldmann> ... = other supplementation pages, if any
202 2010-08-03T16:34:19 <ThomasWaldmann> actions: Modify Download + more actions menu
203 2010-08-03T16:35:30 <diofeher> i think yes, because editbar is becoming big
204 2010-08-03T16:35:59 <ThomasWaldmann> well, it won't get less, but views could be at left, actions at right
205 2010-08-03T16:36:41 <diofeher> using that tab scheme to separate? (mediawiki looking)
206 2010-08-03T16:36:51 <ThomasWaldmann> maybe, yes :)
207 2010-08-03T16:46:48 <ThomasWaldmann> valeuf: wrong chan :)
208 2010-08-03T16:47:17 <ThomasWaldmann> cfg is put into request after it was loaded from the wiki config
209 2010-08-03T16:47:51 <ThomasWaldmann> for the tests, there should be some way to override/specify config settings, so that misc. configurations can be tested automatically
210 2010-08-03T16:48:05 <valeuf> ThomasWaldmann: ffaaail
211 2010-08-03T16:48:24 <valeuf> ok I will try to find where it was before
212 2010-08-03T16:50:45 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9301:f4ad2028fc58 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (static/modernized/css/common.css templates/show.html): [templating] added rev navigation styles
213 2010-08-03T17:00:24 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9301:bef48d8a1661 2.0-dev/MoinMoin/ (3 files in 2 dirs): separate global index (inherits from layout) from item index (inherits from show)
214 2010-08-03T17:04:50 *** RogerHaase
215 2010-08-03T17:08:01 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9302:b528155e0575 2.0-dev/MoinMoin/apps/frontend/views.py: global index/history: get item_name from querystring, make it easy to return to same item
216 2010-08-03T17:08:26 <valeuf> not that great but, progress : http://paste.pocoo.org/show/245308/
217 2010-08-03T17:08:43 <valeuf> I think maybe I need to do an Application class, as there was one in wsgiapp.py
218 2010-08-03T17:11:00 <ThomasWaldmann> why do you need to duplicate the hack?
219 2010-08-03T17:12:11 *** ebo^
220 2010-08-03T17:12:34 <valeuf> ThomasWaldmann: hum I do not know, but otherwise I couldn't get flaskg
221 2010-08-03T17:12:38 <valeuf> oh wait
222 2010-08-03T17:13:42 <ThomasWaldmann> if you import the app from MoinMoin first, then importing flaskg from flask should work afterwards
223 2010-08-03T17:14:21 <ThomasWaldmann> (or even importing it from MoinMoin also)
224 2010-08-03T17:14:29 <valeuf> right :)
225 2010-08-03T17:15:13 <ThomasWaldmann> hmmm, that "Show" "Meta" in editbar somehow looks strange
226 2010-08-03T17:15:47 <ThomasWaldmann> i guess we either want "Data" "Meta", or both terms compatible with normal people
227 2010-08-03T17:16:21 <TheSheep> we need some normal people specimen
228 2010-08-03T17:16:37 <valeuf> http://paste.pocoo.org/show/245314/ --> conftest patch
229 2010-08-03T17:16:44 <ThomasWaldmann> "Show" "Info" maybe?
230 2010-08-03T17:17:05 <valeuf> well, there is still many things not clear for me in this conftest file, but at least I can run my tests for the converters :p
231 2010-08-03T17:19:40 <ThomasWaldmann> what is rv = c.get() good for?
232 2010-08-03T17:20:26 <valeuf> ThomasWaldmann: it simulate a request on '/'
233 2010-08-03T17:20:42 <valeuf> ThomasWaldmann: without it you do not have flask request if I understood well
234 2010-08-03T17:20:47 <valeuf> http://flask.pocoo.org/docs/testing/
235 2010-08-03T17:21:38 <valeuf> I still have few problem, with missing stuff in this request object
236 2010-08-03T17:22:01 <valeuf> I do not know well if I should add it manually as I did for the cfg, or if I should where it is added normally
237 2010-08-03T17:26:06 <ThomasWaldmann> well, if i understood it right, that get() will run a complete request
238 2010-08-03T17:26:42 <ThomasWaldmann> the old test setup was rather preparing a request and then giving it to the tests
239 2010-08-03T17:27:05 <valeuf> ThomasWaldmann: yes, it was what I said, there is some conflict between this two action
240 2010-08-03T17:27:26 <ThomasWaldmann> not wanting to say which method is better, just pointing out the difference
241 2010-08-03T17:27:26 <valeuf> ThomasWaldmann: but I am not sure I understood all the code for TestRequest
242 2010-08-03T17:27:57 <valeuf> I think the problem is that both has important things to do, and we quite need both, or a merged version
243 2010-08-03T17:28:15 <ThomasWaldmann> assuming that old way is somehow creepy maybe isn't far fetched :)
244 2010-08-03T17:28:22 <valeuf> :)
245 2010-08-03T17:29:08 <valeuf> ThomasWaldmann: I will keep this dirty patch in my repos for now, as soon we progress on the flask integration, and I see how we can improve that, I clean the conftest
246 2010-08-03T17:29:48 <valeuf> but I should continue my DocBook converter ^ ^ (and this patch let me run my tests correctly, since I am not using request stuff)
247 2010-08-03T17:30:20 <ThomasWaldmann> maybe you could just add some comments to it and we merge it into main
248 2010-08-03T17:30:31 <valeuf> ThomasWaldmann: no problem
249 2010-08-03T17:30:33 <ThomasWaldmann> having some tests working is better than none
250 2010-08-03T17:30:57 <valeuf> here I get the following result : 84 failed, 1199 passed, 18 skipped, 50 error in 115.33 seconds
251 2010-08-03T17:31:37 <ThomasWaldmann> maybe we can just kill some of the 84 because they are outdated anyway :)
252 2010-08-03T17:32:51 <valeuf> some of them are also due to missing stuff in request object, but that's true that some tests should be cleaned
253 2010-08-03T17:33:13 <ThomasWaldmann> diofeher: don't waste too much time on the nav thing
254 2010-08-03T17:33:30 <ThomasWaldmann> rather get the infrastructure things right
255 2010-08-03T17:40:48 <valeuf> ThomasWaldmann: after some cleaning : http://paste.pocoo.org/show/245327/
256 2010-08-03T17:45:40 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9303:50aca0f1e90b 2.0-dev/MoinMoin/apps/frontend/views.py: frontend views: add some missing stuff to robots.txt, move dispatch to beginning
257 2010-08-03T17:47:15 <ThomasWaldmann> rv = c.get('/') #Create a request for test in flask < isn't that "Run a request"?
258 2010-08-03T17:48:05 <ThomasWaldmann> about the config thing
259 2010-08-03T17:49:09 <ThomasWaldmann> as moin will be a nice wsgi app soon, I am thinking about killing the farmconfig url-based config loader
260 2010-08-03T17:49:50 <valeuf> ThomasWaldmann: you are right, run is more appropriate word
261 2010-08-03T17:50:47 <ThomasWaldmann> because one can easily use some existing dispatching based on url, so moin only deals with the single config it gets then
262 2010-08-03T17:51:35 <ThomasWaldmann> in that single config, noone is holding you back from using inheritance, so that part of farmconfig is still possible
263 2010-08-03T17:52:20 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9319:676403f9b2cf 2.0-dev-docbook-html-vjaniaut/MoinMoin/conftest.py: Add flaskg to the conftest
264 2010-08-03T17:52:21 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9320:7452e1371bef 2.0-dev-docbook-html-vjaniaut/MoinMoin/conftest.py: Clean a bit conftest
265 2010-08-03T17:52:23 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9321:a8fecdd6b513 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Add tests for the admonitions in DocBook_IN converter
266 2010-08-03T17:52:25 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9322:a7822c99c086 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Add admonition support in DocBook_IN converter
267 2010-08-03T17:52:26 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9323:a41a19eb7373 2.0-dev-docbook-html-vjaniaut/MoinMoin/conftest.py: Edit comment in conftest
268 2010-08-03T18:04:40 <valeuf> out for the evening, see you tomorrow!
269 2010-08-03T18:06:26 <diofeher> back from lunch time
270 2010-08-03T18:06:30 <diofeher> cya valeuf
271 2010-08-03T18:07:10 <ThomasWaldmann> cu valeuf
272 2010-08-03T18:08:52 <ThomasWaldmann> hmm, i think when creating an moin_page.object element in the dom, we should put its mimetype also in the attrs, if we know it
273 2010-08-03T18:09:28 <ThomasWaldmann> then the output converter can more easily decide what to do, without having to find out the type itself
274 2010-08-03T18:10:35 <ThomasWaldmann> e.g. for the html_out converter, it can create img, object, video, audio tags depending on mimetype
275 2010-08-03T18:11:18 <ThomasWaldmann> waldi: what do you think?
276 2010-08-03T18:12:45 <valeuf> ThomasWaldmann: as I said before, I agree with that ^ ^
277 2010-08-03T18:13:19 <ThomasWaldmann> :)
278 2010-08-03T19:09:44 * ThomasWaldmann tries audio/video support
279 2010-08-03T19:23:11 <ThomasWaldmann> audio works \o/
280 2010-08-03T19:23:19 <ThomasWaldmann> video behaves strange
281 2010-08-03T19:24:49 <ThomasWaldmann> and now it works also ?-)
282 2010-08-03T19:40:10 *** grzywacz
283 2010-08-03T19:52:01 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9304:b05ec697de78 2.0-dev/MoinMoin/converter2/ (html_out.py image_in.py audio_video_in.py): (log message trimmed)
284 2010-08-03T19:52:01 <CIA-50> converters: improved object support, image/audio/video supported now
285 2010-08-03T19:52:01 <CIA-50> added audio_video_in converter, currently registered for:
286 2010-08-03T19:52:01 <CIA-50> video/ogg
287 2010-08-03T19:52:01 <CIA-50> video/webm
288 2010-08-03T19:52:01 <CIA-50> audio/ogg
289 2010-08-03T19:52:01 <CIA-50> audio/wave
290 2010-08-03T20:18:41 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9305:fb477ae6103b 2.0-dev/MoinMoin/items/__init__.py: item type selection: remove types from list that are not supported
291 2010-08-03T20:27:14 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8556:864fde4c98e4 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: Mediawiki->DOM: conversion of tt/code/pre tags
292 2010-08-03T20:27:16 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8557:04113d83d66d 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: Mediawiki->DOM: fix disapearing line after single newline
293 2010-08-03T20:27:18 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8558:2bd07f113ce6 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: Mediawiki->DOM: import _Iter and _Stack from Moinwiki->DOM converter
294 2010-08-03T20:27:20 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8559:3d96c33a7ef1 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: Mediawiki->DOM: table attributes
295 2010-08-03T20:27:22 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8560:bbad663ab2fd 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: fix multiline text in table cell
296 2010-08-03T20:27:23 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8561:bc670265660b 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/_tests/test_mediawiki_in.py: Mediawiki->DOM: more tests
297 2010-08-03T20:27:24 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8562:2ee8ec9a3c97 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/rst_out.py: fixed line_break conversion
298 2010-08-03T20:27:26 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8563:c9982c714288 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/ (7 files in 2 dirs): remove 'print'
299 2010-08-03T20:27:28 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8564:6138879b5c64 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/_tests/ (9 files): rename variable 'file'
300 2010-08-03T20:27:30 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8565:fc50a57f80c4 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/_tests/test_moinwiki_in_out.py: pep8
301 2010-08-03T20:30:30 <ThomasWaldmann> hey, we use revision control :)
302 2010-08-03T20:43:24 <ThomasWaldmann> firefox <img src="svg"> -> fail
303 2010-08-03T20:43:52 <ThomasWaldmann> firefox <object data="svg"> -> half-of-a-fail
304 2010-08-03T20:47:20 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9306:8fc3d036e79f 2.0-dev/MoinMoin/converter2/html_out.py: svg items: workaround for firefox
305 2010-08-03T21:29:19 *** kursor
306 2010-08-03T21:55:09 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9307:5f81e2fd69b6 2.0-dev/MoinMoin/apps/frontend/views.py: use xml writer for highlight also
307 2010-08-03T21:56:59 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9308:5fb2fb99ae7b 2.0-dev/MoinMoin/templates/history.html: fix history display (colspan)
308 2010-08-03T22:22:51 *** kursor
309 2010-08-03T22:24:50 *** DmitryAndreev_
310 2010-08-03T23:01:36 <dreimark> re
311 2010-08-03T23:04:20 * ThomasWaldmann looks at converter registry and pygments conv.
312 2010-08-03T23:11:22 *** ebo^
313
