MoinMoin: MoinMoinChat/Logs/moin-dev/2010-08-31

   1 2010-08-31T00:05:08  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9802:572107f2eba3 2.0-dev/MoinMoin/ (formatter/text_html.py theme/__init__.py): move icons code to the formatter (it is only used from there)
   2 2010-08-31T00:24:46  <ThomasWaldmann> DmitryAndreev: in your new code, there are old style classes
   3 2010-08-31T00:25:05  <ThomasWaldmann> (in rst_in converter)
   4 2010-08-31T00:42:14  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9803:7ed485174183 2.0-dev/MoinMoin/ (11 files in 9 dirs): change some classes to newstyle (more of them still TODO)
   5 2010-08-31T01:00:11  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9804:619d69416b2c 2.0-dev/MoinMoin/theme/_tests/test_navi_bar.py: rewrite split_navilink tests, remove code duplication
   6 2010-08-31T01:00:21  <ThomasWaldmann> diofeher: ^^
   7 2010-08-31T01:02:31  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9805:3187b47efbee 2.0-dev/MoinMoin/theme/_tests/test_editbar_actions.py: remove non-sense tests
   8 2010-08-31T01:26:54  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9806:76db10d98d29 2.0-dev/MoinMoin/theme/__init__.py:
   9 2010-08-31T01:26:54  <CIA-36> theme: misc cleanup, see below
  10 2010-08-31T01:26:54  <CIA-36> * remove unused imports
  11 2010-08-31T01:26:54  <CIA-36> * simplify code
  12 2010-08-31T01:26:54  <CIA-36> * remove outdated comments
  13 2010-08-31T01:26:55  <CIA-36> * index items: remove non-existing / non-index items
  14 2010-08-31T01:26:55  <CIA-36> * remove outdated send_title method
  15 2010-08-31T01:44:30  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9807:364cbf6f5b05 2.0-dev/MoinMoin/theme/__init__.py: theme: fix homepage link for user_homewiki != Self
  16 2010-08-31T02:01:45  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9808:6b86d9ceb368 2.0-dev/MoinMoin/theme/__init__.py: theme: use list comprehension for actions menu
  17 2010-08-31T02:30:28  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9809:d68e542f6c19 2.0-dev/MoinMoin/ (4 files in 3 dirs):
  18 2010-08-31T02:30:28  <CIA-36> removed theme code plugins, see below
  19 2010-08-31T02:30:28  <CIA-36> After looking through the theme (support) code, I found it to be rather
  20 2010-08-31T02:30:28  <CIA-36> generic, so I guess switching the theme NAME should be enough.
  21 2010-08-31T02:30:28  <CIA-36> Currently, the theme name just determines the css files directory and also
  22 2010-08-31T02:30:29  <CIA-36> icons/images loaded by the css by relative URLs.
  23 2010-08-31T02:46:38  <ThomasWaldmann> TheSheep: diofeher: http://bitbucket.org/leafstorm/flask-themes/src/tip/docs/index.rst
  24 2010-08-31T06:08:26  <CIA-36> Dmitry Andreev <klieg.polar@gmail.com> default * 9810:87df49295df0 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/rst_in.py: change some classes to newstyle
  25 2010-08-31T06:08:42  <diofeher> ThomasWaldmann, nice ^^
  26 2010-08-31T06:08:56  <diofeher> i'm gonna take a look when i have free time
  27 2010-08-31T06:13:08  *** kursor has joined #moin-dev
  28 2010-08-31T07:20:03  *** kursor_ has joined #moin-dev
  29 2010-08-31T07:22:05  *** kursor has quit IRC
  30 2010-08-31T07:22:06  *** kursor_ is now known as kursor
  31 2010-08-31T07:38:18  *** DmitryAndreev has quit IRC
  32 2010-08-31T08:18:17  *** gwork has joined #moin-dev
  33 2010-08-31T08:21:34  *** kursor has quit IRC
  34 2010-08-31T08:34:55  <TheSheep> ThomasWaldmann: it's neat, I didn't know you could use functions in 'extends' and 'includes' clauses.
  35 2010-08-31T10:56:57  <ThomasWaldmann> moin
  36 2010-08-31T11:24:05  *** gwork has quit IRC
  37 2010-08-31T11:42:59  *** DmitryAndreev has joined #moin-dev
  38 2010-08-31T12:22:02  *** DmitryAndreev has quit IRC
  39 2010-08-31T13:29:09  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9810:a22388591674 2.0-dev/MoinMoin/ (__init__.py apps/feed/views.py theme/__init__.py): move theme / jinja2 related code to MoinMoin.theme
  40 2010-08-31T13:55:12  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9811:c4933f8963f4 2.0-dev/MoinMoin/theme/__init__.py: don't access app/flaskg from ThemeSupport methods except __init__
  41 2010-08-31T13:55:12  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9812:5f52898210d0 2.0-dev/MoinMoin/templates/ (base.html editbar.html): templates: access 'user' directly
  42 2010-08-31T14:03:43  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9813:7ec08e0a42c5 2.0-dev/MoinMoin/ (3 files in 2 dirs): add clock and storage to jinja globals, remove flaskg from jinja globals
  43 2010-08-31T14:15:05  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9814:56743c00bc2d 2.0-dev/MoinMoin/theme/__init__.py: remove trivial item_exists method
  44 2010-08-31T14:15:06  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9815:002498360242 2.0-dev/MoinMoin/ (4 files in 2 dirs): remove trivial item_readable/writable (was wrongly used anyway)
  45 2010-08-31T14:27:25  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9816:aea94f30d9ee 2.0-dev/MoinMoin/ (templates/base.html templates/layout.html theme/__init__.py): use translated_item_name via theme instance
  46 2010-08-31T14:48:31  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9817:3c623b7cacf0 2.0-dev/MoinMoin/ (4 files in 4 dirs): sendmail: remove unneeded request param
  47 2010-08-31T15:00:21  *** DmitryAndreev has joined #moin-dev
  48 2010-08-31T15:05:03  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9818:0a2741043fdf 2.0-dev/MoinMoin/ (i18n/__init__.py user.py): get_browser_language: remove unneeded request param
  49 2010-08-31T15:10:09  <dreimark> moin
  50 2010-08-31T15:29:53  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9819:8e1be2a14499 2.0-dev/MoinMoin/ (11 files in 7 dirs): (log message trimmed)
  51 2010-08-31T15:29:53  <CIA-36> remove event system and notifications, see below
  52 2010-08-31T15:29:53  <CIA-36> * code should be cleanly reimplemented:
  53 2010-08-31T15:29:53  <CIA-36> * using jinja2 templates for notification texts / configuration
  54 2010-08-31T15:29:53  <CIA-36> * use flatland for notifications configuration forms
  55 2010-08-31T15:29:53  <CIA-36> * using a better 3rd party event system(?)
  56 2010-08-31T15:29:54  <CIA-36> * only call new moin API
  57 2010-08-31T15:31:25  *** jdwcornell has quit IRC
  58 2010-08-31T16:40:22  *** RogerHaase has joined #moin-dev
  59 2010-08-31T16:44:23  *** eSyr has quit IRC
  60 2010-08-31T16:45:28  *** eSyr has joined #moin-dev
  61 2010-08-31T17:06:07  *** kursor has joined #moin-dev
  62 2010-08-31T17:10:50  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9820:fac9ee082de7 2.0-dev/MoinMoin/ (19 files in 12 dirs):
  63 2010-08-31T17:10:50  <CIA-36> User: remove unneeded request param (and also at some other places), clean up
  64 2010-08-31T17:10:50  <CIA-36> User: rename param 'id' to 'uid'
  65 2010-08-31T17:10:50  <CIA-36> removed unused user.getUserIdentification
  66 2010-08-31T17:10:52  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9821:5058fe9522ab 2.0-dev/MoinMoin/ (apps/frontend/views.py macro2/WikiConfig.py): fix flaskg.context (aka moin request) vs. (wsgi) request usage at some places, clean up
  67 2010-08-31T17:17:49  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9822:a27958870aad 2.0-dev/MoinMoin/apps/ (feed/views.py misc/views.py): more request vs. flaskg.context fixes
  68 2010-08-31T17:39:53  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9823:e9c49d82a1d8 2.0-dev/MoinMoin/items/__init__.py:
  69 2010-08-31T17:39:53  <CIA-36> Item: rename self.request to self.context (it is the moin request, not the wsgi request)
  70 2010-08-31T17:39:53  <CIA-36> Fix some places where we can just directly use the wsgi request contextlocal.
  71 2010-08-31T17:39:53  <CIA-36> Mark one place with XXX WRONG where request and response is confused.
  72 2010-08-31T17:46:33  <ThomasWaldmann> DmitryAndreev:         # This is part of old moinmoin rst parser. TODO: delete
  73 2010-08-31T17:47:23  <ThomasWaldmann> that Page stuff will soon not work anymore anyway
  74 2010-08-31T18:41:02  <ThomasWaldmann> DmitryAndreev: moinwiki_out -> return cls # XXX WRONG? shouldn't that be cls()?
  75 2010-08-31T18:41:28  <ThomasWaldmann> same in rst_out
  76 2010-08-31T18:52:33  <ThomasWaldmann> btw, I think we should kill the DesktopEdition setting
  77 2010-08-31T18:53:49  <ThomasWaldmann> as it checks for remote_addr == 127.0.0.1 it relies on IP address for giving e.g. superuser
  78 2010-08-31T18:54:08  <ThomasWaldmann> and in a proxy context, that maybe could be faked
  79 2010-08-31T18:55:09  <ThomasWaldmann> (not that running a DesktopEdition wiki behind a proxy is a supported configuration, but who knows...)
  80 2010-08-31T19:05:47  *** xjjk has quit IRC
  81 2010-08-31T19:05:55  *** xjjk has joined #moin-dev
  82 2010-08-31T19:38:26  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9824:8310d88afcf4 2.0-dev/MoinMoin/ (21 files in 8 dirs):
  83 2010-08-31T19:38:26  <CIA-36> items, converter2: removed unneeded (moin) request param
  84 2010-08-31T19:38:26  <CIA-36> This breaks some macro2 macros which still expect to get a request param, but don't.
  85 2010-08-31T19:38:26  <CIA-36> Most of them are likely broken anyway because they still have old code.
  86 2010-08-31T19:38:26  <CIA-36> Added some comments to moinwiki_out/rst_out factories about suspicious factory
  87 2010-08-31T19:38:27  <CIA-36> return value (the class, not the instance).
  88 2010-08-31T19:50:38  *** grzywacz has joined #moin-dev
  89 2010-08-31T20:17:55  * ThomasWaldmann kills DesktopEdition feature
  90 2010-08-31T20:30:34  *** DmitryAndreev has quit IRC
  91 2010-08-31T20:38:48  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9825:68d4b7ff18b5 2.0-dev/ (4 files in 4 dirs):
  92 2010-08-31T20:38:48  <CIA-36> remove DesktopEdition feature
  93 2010-08-31T20:38:48  <CIA-36> It relied on a remote_addr == 127.0.0.1 check to give higher privileges,
  94 2010-08-31T20:38:48  <CIA-36> this is potentially unsafe, especially in configurations with proxies
  95 2010-08-31T20:38:48  <CIA-36> and wsgi servers / middlewares that put stuff from X-Forwarded-For header
  96 2010-08-31T20:38:49  <CIA-36> into remote_addr.
  97 2010-08-31T20:45:23  *** kursor has quit IRC
  98 2010-08-31T20:57:08  <ThomasWaldmann> http://moinmo.in/KeyboardSequences < add yours there
  99 2010-08-31T20:57:48  *** DmitryAn1reev_ has quit IRC
 100 2010-08-31T20:58:59  *** DmitryAndreev_ has joined #moin-dev
 101 2010-08-31T21:08:25  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9826:9016cf9bb538 2.0-dev/MoinMoin/ (3 files in 3 dirs): remove unneeded request param from password_checker
 102 2010-08-31T21:09:00  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9827:74373a6c3dec 2.0-dev/MoinMoin/ (apps/frontend/views.py user.py): create_user: remove unneeded request param
 103 2010-08-31T21:16:27  <dreimark> ThomasWaldmann: this keyboard sequence is just for simplification or is it something we need in 1.9 too?
 104 2010-08-31T21:21:44  <ThomasWaldmann> see the default config
 105 2010-08-31T21:22:45  <ThomasWaldmann> (that code is there since quite a while)
 106 2010-08-31T22:05:50  *** DmitryAndreev has joined #moin-dev
 107 2010-08-31T22:15:29  *** DmitryAndreev_ has quit IRC
 108 2010-08-31T22:16:13  *** DmitryAndreev_ has joined #moin-dev
 109 2010-08-31T22:19:40  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9828:701fa6ea92b6 2.0-dev/MoinMoin/ (6 files in 3 dirs): auth code: remove unneeded (moin) request param
 110 2010-08-31T22:23:41  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9829:1119e999ebcd 2.0-dev/MoinMoin/auth/http.py: remove deprecated HTTPAuth (use GivenAuth / HTTPAuthMoin)
 111 2010-08-31T22:28:24  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9830:9af6dc8a4786 2.0-dev/MoinMoin/auth/smb_mount.py: smb_mount: remove unneeded request param
 112 2010-08-31T22:40:12  <dreimark> http://hg.moinmo.in/moin/1.9/file/7a83cc907f68/MoinMoin/script/migration/_tests/test_conv160_wiki.py#l118
 113 2010-08-31T22:40:28  <dreimark> does this look also strange encoded for you?
 114 2010-08-31T22:41:54  <ThomasWaldmann> looks like a utf-8 umlaut in a latin-1 file
 115 2010-08-31T22:42:34  <ThomasWaldmann> maybe we should switch encoding of source files to ascii (and utf-8 if needed) in moin2
 116 2010-08-31T22:42:37  <dreimark> i wonder why we don't have seen it before and why it didn't fail
 117 2010-08-31T22:43:05  <dreimark> yes agreed or always utf-8 ?
 118 2010-08-31T22:43:25  <ThomasWaldmann> usually source should be ascii and english
 119 2010-08-31T22:43:51  <ThomasWaldmann> only exception are special test cases
 120 2010-08-31T22:43:55  <dreimark> agreed again, but i am not sure if we have ascii editors on default
 121 2010-08-31T22:43:57  <ThomasWaldmann> and names with non-ascii
 122 2010-08-31T22:44:08  <TheSheep> what's wrong with utf-8?
 123 2010-08-31T22:44:10  <ThomasWaldmann> every editor does ascii :)
 124 2010-08-31T22:44:11  <dreimark> sometimes i think they are all at default utf-8
 125 2010-08-31T22:44:17  <TheSheep> if the file has encoding defined properly?
 126 2010-08-31T22:44:41  <ThomasWaldmann> TheSheep: if you edit on some old system, there might be some trouble with mbcs
 127 2010-08-31T22:45:00  <TheSheep> ThomasWaldmann: mbcs?
 128 2010-08-31T22:45:28  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9831:d1e24802bdfb 2.0-dev/MoinMoin/ (action/syspages_upgrade.py storage/backends/__init__.py): upgrade_syspages: remove unneeded request param
 129 2010-08-31T22:45:40  <ThomasWaldmann> multi-byte character sets
 130 2010-08-31T22:46:22  <TheSheep> ThomasWaldmann: do we need to make a survey of the oldest system usd by a moin developer?
 131 2010-08-31T22:47:03  <TheSheep> I'm not even sure python would compile on such a system
 132 2010-08-31T22:47:11  <dreimark> haha
 133 2010-08-31T22:47:12  <ThomasWaldmann> not too long ago I had that trouble, really :)
 134 2010-08-31T22:47:47  <ThomasWaldmann> it is also a matter of configuration. not every system that could be utf-8 in fact is.
 135 2010-08-31T22:48:08  <dreimark> i fear if one edits on windows it will mismatch if it isn't utf-8
 136 2010-08-31T22:48:13  * TheSheep is convinced
 137 2010-08-31T22:48:31  <dreimark> hmm yes
 138 2010-08-31T22:48:58  <dreimark> hmm but in 1.9 we have currently some files with wrong encoding
 139 2010-08-31T22:49:04  <dreimark> (likly)
 140 2010-08-31T22:49:05  <ThomasWaldmann> we can use utf-8 rather than latin-1, but I'ld only use it if really needed
 141 2010-08-31T22:49:12  <dreimark> ok
 142 2010-08-31T22:49:27  <ThomasWaldmann> and not in 1.9
 143 2010-08-31T22:49:36  <ThomasWaldmann> (R.I.P. :)
 144 2010-08-31T22:49:38  <TheSheep> ThomasWaldmann: if you want to use something simpler than utf-8, I'd go for ascii
 145 2010-08-31T22:49:38  <dreimark> yeah
 146 2010-08-31T22:49:48  <TheSheep> latin-1 makes no sense
 147 2010-08-31T22:49:56  <TheSheep> it doesn't have polish characters ;)
 148 2010-08-31T22:50:23  <ThomasWaldmann> hehe
 149 2010-08-31T22:50:39  <ThomasWaldmann> moin src needs more polish, definitely
 150 2010-08-31T22:51:04  <dreimark> >>> txt = file('test_conv160_wiki.py').read()
 151 2010-08-31T22:51:04  <dreimark> >>> import chardet
 152 2010-08-31T22:51:04  <dreimark> >>> chardet.detect(txt)['encoding']
 153 2010-08-31T22:51:04  <dreimark> 'TIS-620'
 154 2010-08-31T22:51:53  <dreimark> it means Thai
 155 2010-08-31T22:53:02  <TheSheep> ThomasWaldmann: it needs it as much as German
 156 2010-08-31T22:55:02  * dreimark things we need a test - not sure if chardet is always correct, but better as nothing
 157 2010-08-31T22:55:31  <dreimark> s/g/k/
 158 2010-08-31T23:00:04  <ThomasWaldmann> TheSheep: but the joke only works for polish :)
 159 2010-08-31T23:00:31  * ThomasWaldmann would just forget about chardet
 160 2010-08-31T23:01:05  <TheSheep> ThomasWaldmann: ah, that joke, ok
 161 2010-08-31T23:01:18  <TheSheep> ThomasWaldmann: sorry, I tend to forget about it
 162 2010-08-31T23:01:38  <TheSheep> and about poles too
 163 2010-08-31T23:04:08  * dreimark uses often iconv and that needs the encoding of the input. mostly chardet was right for getting it
 164 2010-08-31T23:05:21  <dreimark> also iconv can be replaced by a short py script
 165 2010-08-31T23:05:58  <dreimark> input were latex files.
 166 2010-08-31T23:06:42  * dreimark hates wrong data encoded in files
 167 2010-08-31T23:09:05  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9832:4326be11614d 2.0-dev/MoinMoin/ (Page.py user.py wikiutil.py): wikiutil: remove some request params and some unused stuff
 168 2010-08-31T23:11:52  *** grzywacz has quit IRC
 169 2010-08-31T23:41:45  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9833:6e6b5d4a6cd7 2.0-dev/MoinMoin/ (4 files in 4 dirs): remove editlog module and some (unused) code using it
 170 2010-08-31T23:52:09  <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9834:00c867086b03 2.0-dev/MoinMoin/ (3 files in 2 dirs): move logfile code to storage.backends.fs19_logfile