1 2010-12-06T00:00:13 <ronny> achshar: your question is a bit tricky to answer for me atm
2 2010-12-06T00:00:27 <achshar> yes that ould be one but it lacks flexility
3 2010-12-06T00:00:59 <ronny> yup, the tradeoff is readability vs flexibility as far as i can tell
4 2010-12-06T00:01:19 <ronny> personally im a bit strongly biased agains bbcode alike things
5 2010-12-06T00:02:09 <achshar> hmm thats sad, for me
6 2010-12-06T00:02:47 <ronny> thats why i'd like to have thomas/dreimark decide
7 2010-12-06T00:03:25 <achshar> this task, i believe was more of a 'discuss at irc' task
8 2010-12-06T00:04:06 <achshar> there is no way we could come up ith things commenting on a wiki page
9 2010-12-06T00:05:01 <ronny> yes, it needs discussion, i didnt expect to have that much of a bias
10 2010-12-06T00:05:41 <ronny> although you could compare a bit agains the current method of using the span macro (which feels slightly better than a span tag)
11 2010-12-06T00:06:04 <ronny> im part of the fraction that literaly hates html-ish stuff in wiki markup
12 2010-12-06T00:06:58 <achshar> in the end it would ome to personal prefrence
13 2010-12-06T00:07:38 <jbills> Got to go for now. I need to reorganize the items in my TOC. http://www.flickr.com/photos/jbills123/5235620965/ creole page in my current code
14 2010-12-06T00:07:39 <ronny> in the end it has to become something that helps its users
15 2010-12-06T00:08:27 <ronny> (i dont tend to care about color that much, more about decoying semantics)
16 2010-12-06T00:09:16 <achshar> so what do you think could be my next step towards the complition of my task?
17 2010-12-06T00:09:42 <achshar> its 4 39 am here and i need to go to bed before sunrise
18 2010-12-06T00:09:59 <achshar> i work at night lol
19 2010-12-06T00:12:17 <ThomasWaldmann> achshar: can you review the examples you give on the wiki page?
20 2010-12-06T00:12:32 <ThomasWaldmann> there seem to be some errors
21 2010-12-06T00:13:40 <achshar> which example exactly? i seem to be missing any erors
22 2010-12-06T00:14:37 <ThomasWaldmann> <color=red></> would give <span style="color:red"> red text </span>
23 2010-12-06T00:15:04 <dreimark> gn
24 2010-12-06T00:15:32 <achshar> sorry that was a stupid mistake.. let me correct it
25 2010-12-06T00:17:16 <achshar> actualy i was thinking if we could remove the text color markup from tables and make the one we come up with here a global markup?
26 2010-12-06T00:17:44 <achshar> whih would work eerywhere including tables
27 2010-12-06T00:19:32 <ThomasWaldmann> yes, that was the idea or, well, an option.
28 2010-12-06T00:19:57 <ThomasWaldmann> in any case where we change markup, we must provide conversion for existing data.
29 2010-12-06T00:20:07 <ThomasWaldmann> at least if the markup is rather popular.
30 2010-12-06T00:20:33 <ThomasWaldmann> "would it use css? if so, how would css look like? if not, why not?" can you add something about that to your submission?
31 2010-12-06T00:20:51 <achshar> right away..
32 2010-12-06T00:21:09 <achshar> i mus anser all three of the questions
33 2010-12-06T00:21:23 <ThomasWaldmann> i guess then you're done. ronny what do you think?
34 2010-12-06T00:21:55 <ronny> ThomasWaldmann: think so as well
35 2010-12-06T00:22:23 <achshar> so what markup are you guys going to impliment?
36 2010-12-06T00:23:07 <ThomasWaldmann> i guess that won't be decided today :)
37 2010-12-06T00:24:12 <ThomasWaldmann> if we provide conversion, we could use anything sane, maybe same for both spans and tables.
38 2010-12-06T00:24:44 <ThomasWaldmann> for tables, there is another thing to consider: iirc one can set table, row and cell style
39 2010-12-06T00:25:04 <achshar> hmm please add it to the wiki page once you are done.. i will get a notification :D
40 2010-12-06T00:25:35 <achshar> i didnt get you sorry?
41 2010-12-06T00:27:06 <ronny> achshar: hes talking about markup migration and semantic details of the makrkup
42 2010-12-06T00:28:34 <achshar> hmm btw 'would it use css?' here from css you mean external css, right?
43 2010-12-06T00:28:52 <ThomasWaldmann> not inline style
44 2010-12-06T00:30:30 <achshar> i wonder, how would it even be possible to color text without inline or external css of any kind?
45 2010-12-06T00:32:08 <achshar> 'not inline style' confuses me :O
46 2010-12-06T00:32:33 <ThomasWaldmann> you can have style defs at 3 places (at least): directly in the styled element, in some style section of the html file or externally in a css file
47 2010-12-06T00:33:40 <achshar> agreed. so 'css' in that question includes which of these three?
48 2010-12-06T00:34:41 <ThomasWaldmann> anything else than in the element
49 2010-12-06T00:36:11 <achshar> alright thanks.. i ahve the wiki page ready. would you like to see it first or should i submit it straight away?
50 2010-12-06T00:37:44 <ThomasWaldmann> you can submit a copy to melange, or just the url
51 2010-12-06T00:38:06 *** m4k3r
52 2010-12-06T00:39:03 <achshar> done :D http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964841
53 2010-12-06T00:40:14 <ThomasWaldmann> ah, one last thing - did you find the obvious reasons for creole not to have colour markup?
54 2010-12-06T00:42:11 <achshar> hmm sort of, the comment below gave the reason but i couldnt quiet understand ut
55 2010-12-06T00:42:31 <achshar> comment by nsomnia in last http://wikicreole.org/wiki/Font
56 2010-12-06T00:43:10 <achshar> if you could understand it, i would like to know why..
57 2010-12-06T00:44:18 <ThomasWaldmann> it's unclear. i think he refers to little contrast situations for foreground vs. background colour
58 2010-12-06T00:44:33 <ThomasWaldmann> like red on red
59 2010-12-06T00:45:00 <achshar> hmm maybe yes but hey the task is closed..! thanks alot to you and everybody else over here :D
60 2010-12-06T00:45:49 <achshar> its almost sunrise here and i need to go to bed :P
61 2010-12-06T00:46:50 <achshar> gn
62 2010-12-06T00:47:21 <ronny> ThomasWaldmann: i think its certainly related to problems with limited devices
63 2010-12-06T00:47:54 <ronny> (and somehow i think one should prefer sematical tags over color/size declarations
64 2010-12-06T00:47:58 <ThomasWaldmann> gn achshar
65 2010-12-06T00:48:10 <ronny> and then map via css classes and different device class ccc formats
66 2010-12-06T00:48:24 <ronny> (but my pov on that is rather puristic)
67 2010-12-06T00:48:27 <ronny> gn achshar
68 2010-12-06T00:48:40 <achshar> :D
69 2010-12-06T00:48:43 *** achshar
70 2010-12-06T00:49:06 <ThomasWaldmann> ronny: yes, that would be good for consistency
71 2010-12-06T00:50:16 <jbills> now can someone help me?
72 2010-12-06T00:50:50 <Kapace__> ThomasWaldmann: what do you think of this patch for an easy task fix http://dpaste.org/yxNa/
73 2010-12-06T00:51:36 <Kapace__> it fixes two tests, html_out and smiley, except for html_out's test_unknown (just worksaround it)
74 2010-12-06T00:52:23 <ThomasWaldmann> jbills: can you ask a specific question please?
75 2010-12-06T00:53:56 *** jordonwii
76 2010-12-06T00:54:00 <ThomasWaldmann> Kapace__: line 70/71 - please do not align the :
77 2010-12-06T00:54:14 <ThomasWaldmann> but keep the blank right to it
78 2010-12-06T00:54:15 <jordonwii> Moin
79 2010-12-06T00:54:31 <Kapace__> ThomasWaldmann: oops, that was just to avoid the test_sourcecode failure
80 2010-12-06T00:54:47 <Kapace__> didn't really want it in the final patch
81 2010-12-06T00:55:30 <ThomasWaldmann> and add a , at the end of 71
82 2010-12-06T00:56:08 <Kapace__> ok
83 2010-12-06T00:56:15 <ThomasWaldmann> and i guess we should not have 80..84
84 2010-12-06T00:56:34 <Kapace__> ok, leave it failing for now?
85 2010-12-06T00:56:49 <Kapace__> i've tried to contact valeuf and waldi but no success..
86 2010-12-06T00:57:12 <Kapace__> and without a reference, theres no way of telling which tags are valid or not...
87 2010-12-06T00:57:42 <ThomasWaldmann> yes, leave it failing. except some of the other mentors or even waldi can comment on what that should be.
88 2010-12-06T00:58:18 <ThomasWaldmann> Kapace__: you could also go back in history and find out when that test was added. i guess it did not fail ever.
89 2010-12-06T00:58:26 <Kapace__> ThomasWaldmann: I tried that, no luck
90 2010-12-06T00:58:40 <Kapace__> test was always failing, I guess
91 2010-12-06T00:58:56 <ThomasWaldmann> ok, then we leave it as is for now
92 2010-12-06T00:59:34 <Kapace__> ok so ill upload the patch with changes above, and maybe another mentor can comment on test_unknown
93 2010-12-06T01:00:20 <ThomasWaldmann> "And xfail means that you expect your test to fail because there is an implementation problem."
94 2010-12-06T01:00:30 <ThomasWaldmann> Kapace__: maybe that one is a xfail
95 2010-12-06T01:00:50 <Kapace__> ThomasWaldmann: is that from pytest's documentation?
96 2010-12-06T01:00:56 <ThomasWaldmann> yes
97 2010-12-06T01:01:08 <ThomasWaldmann> like skip, just different meaning
98 2010-12-06T01:01:13 <Kapace__> ok, ill take a look at that
99 2010-12-06T01:04:30 <jbills> ThomasWaldmann: I need help getting the items in The TOC mocro to be organized. http://www.flickr.com/photos/jbills123/5235620965/ creole page in my current code. My code: https://gist.github.com/727189
100 2010-12-06T01:05:24 <ThomasWaldmann> that's not a question
101 2010-12-06T01:06:28 <ThomasWaldmann> and indenting there looks broken
102 2010-12-06T01:06:55 <ThomasWaldmann> pep8 also
103 2010-12-06T01:12:55 <jbills> I wrote it in windows
104 2010-12-06T01:13:06 <jbills> Indentation is windows.
105 2010-12-06T01:16:27 <jordonwii> ThomasWaldmann or dreimark: I have a new patch for my task.
106 2010-12-06T01:16:31 <ThomasWaldmann> indentation is 4 spaces per level for every OS
107 2010-12-06T01:16:39 <jordonwii> The mouseover only appears if the cursor is within a 100x50 block in the upper-left corner of the object
108 2010-12-06T01:17:16 <jordonwii> Do those dimensions sound good?
109 2010-12-06T01:17:27 <ThomasWaldmann> what problem does this address again?
110 2010-12-06T01:18:11 <jordonwii> On single-line transcludes, the mouseover would cover up a large portion of the object
111 2010-12-06T01:18:31 <jordonwii> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966150#c31001
112 2010-12-06T01:22:36 <ThomasWaldmann> ok, upper left corner sounds good, but i guess the area should be rather small then
113 2010-12-06T01:22:57 <ThomasWaldmann> otherwise it makes no (big) difference
114 2010-12-06T01:23:43 <ThomasWaldmann> 20x20? should be easy to target though, so not 1x1 :)
115 2010-12-06T01:23:56 <jordonwii> K
116 2010-12-06T01:24:00 <jordonwii> I'll test that out
117 2010-12-06T01:24:09 <jordonwii> Also, what's wrong with 1x1? Sounds perfect
118 2010-12-06T01:24:11 <jordonwii> =p
119 2010-12-06T01:24:52 <jbills> Oh this is part of html_out.py it is lines 547-570. Copy past error
120 2010-12-06T01:25:28 <jordonwii> Ok, 20x20 ends up making it so you have to target the actual corner of the object, basically.
121 2010-12-06T01:25:35 <jordonwii> Not sure if that's good or bad
122 2010-12-06T01:26:35 <ThomasWaldmann> i guess we can make it bigger or smaller easily, if needed
123 2010-12-06T01:27:03 <jordonwii> Ok...so 20x20 is good for now?
124 2010-12-06T01:27:50 <ThomasWaldmann> yes
125 2010-12-06T01:27:56 <jordonwii> Sweet
126 2010-12-06T01:35:16 <jbills> ThomasWaldmann(Or anyone): Can you help me get the TOC Items to organize properly? I am only worrying about functionality right now.
127 2010-12-06T01:36:03 <ThomasWaldmann> can you start with asking a specific question?
128 2010-12-06T01:39:21 <ThomasWaldmann> jordonwii: btw, that code at the beginning of your patch is a bit too hackish imho
129 2010-12-06T01:39:32 <jordonwii> In html_out.py?
130 2010-12-06T01:39:37 <ThomasWaldmann> yes
131 2010-12-06T01:39:56 <jordonwii> Hmm...what do you mean?
132 2010-12-06T01:40:24 <ThomasWaldmann> it is too special at some places. might have troubles with non-ascii / urlquoted stuff
133 2010-12-06T01:40:39 <ThomasWaldmann> so, just having the item name would be better
134 2010-12-06T01:41:18 <jordonwii> Having the item name for what?
135 2010-12-06T01:41:37 <ThomasWaldmann> for displaying it
136 2010-12-06T01:41:55 <ThomasWaldmann> you extract it from the url in a rather hackish way
137 2010-12-06T01:42:18 <jordonwii> Heh, true
138 2010-12-06T01:42:22 <jordonwii> I'll work on that
139 2010-12-06T01:43:41 <ThomasWaldmann> and why _blank?
140 2010-12-06T01:44:03 <ThomasWaldmann> can't one just use middle mouse button if one wants to have a new tab?
141 2010-12-06T01:44:33 <jordonwii> They could...I figured that if someone was looking at one element of a wiki page, they'd likely want to keep the wiki page up
142 2010-12-06T01:44:42 <jordonwii> But I can remove that if you want
143 2010-12-06T01:46:29 <ThomasWaldmann> yes, please remove it. that stuff is rather deprecated / unwanted. in general the user has to decide about new tabs / windows.
144 2010-12-06T01:46:36 <ThomasWaldmann> + # Image's have alt text
145 2010-12-06T01:46:38 <ThomasWaldmann> no '
146 2010-12-06T01:47:29 <jordonwii> ?
147 2010-12-06T01:47:56 <ThomasWaldmann> plural has no '
148 2010-12-06T01:48:40 <jordonwii> Ah
149 2010-12-06T01:48:42 <jordonwii> I see
150 2010-12-06T01:49:06 <ThomasWaldmann> + if obj_type is not "object":
151 2010-12-06T01:49:16 <ThomasWaldmann> you know what that is doing?
152 2010-12-06T01:49:52 <jordonwii> Comparing whether obj_type and "object" reference the same spot in memory? I thought I read that that is what "is" does
153 2010-12-06T01:50:02 <jordonwii> That should be != though, right?
154 2010-12-06T01:50:07 <ThomasWaldmann> yes
155 2010-12-06T01:50:09 <ThomasWaldmann> right
156 2010-12-06T01:50:43 <ThomasWaldmann> please check all places where you use "is"
157 2010-12-06T01:51:28 <jordonwii> Ok
158 2010-12-06T01:51:54 <ThomasWaldmann> for objects like None, there is really only ONE of them in memory.
159 2010-12-06T01:52:03 <jbills> I need to get the items organized. I have modified the code to not post the current item. Instead it posts them the next time it loops. However this disorganizes the items in the way mentioned above. Can I have some help fixing that bug?
160 2010-12-06T01:52:05 <ThomasWaldmann> for these you use "is" or "is not"
161 2010-12-06T01:52:21 <jordonwii> Ah, ok. I was just about to ask whether using "is" for None works
162 2010-12-06T01:52:28 <jordonwii> Thanks
163 2010-12-06T01:52:58 <jordonwii> It looks like that was the only time I used "is"
164 2010-12-06T01:56:12 <ThomasWaldmann> jbills: can you please post a reformatted and refactored source, that maybe has some comments?
165 2010-12-06T01:59:07 <ThomasWaldmann> jbills: \ No newline at end of file
166 2010-12-06T01:59:43 <ThomasWaldmann> ehrm, jordonwii ^^
167 2010-12-06T02:00:16 <ThomasWaldmann> jordonwii: for the css, please use consistent formatting, i mean leave a blank after key:
168 2010-12-06T02:00:51 <ThomasWaldmann> jordonwii: btw, your task is a bit less easy than we thought
169 2010-12-06T02:03:04 *** jordonwii
170 2010-12-06T02:18:24 *** jordonwii
171 2010-12-06T02:19:19 <CIA-62> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10128:03e71bf1f0c6 2.0-dev/MoinMoin/converter/ (_tests/test_html_out.py _tests/test_smiley.py html_out.py): fixed html_out converter tests (thanks to David Czech, GCI 2010)
172 2010-12-06T02:40:33 <jbills> ThomasWaldmann: I really need a deadline extension.
173 2010-12-06T02:43:17 <jbills> Is anyone still here
174 2010-12-06T02:43:53 <jbills> ThomasWaldmann: https://gist.github.com/727189
175 2010-12-06T02:54:13 <jordonwii> jbills: ThomasWaldmann is here...
176 2010-12-06T02:55:33 <jbills> ThomasWaldmann: I have 14 hours left and really need a deadline extension.
177 2010-12-06T02:57:56 <jbills> Make that 13
178 2010-12-06T02:58:01 <jbills> hours
179 2010-12-06T02:58:09 <jbills> and 40 minutes
180 2010-12-06T03:00:42 *** jordonwii
181 2010-12-06T03:00:50 <ThomasWaldmann> jbills: post something for review. how much?
182 2010-12-06T03:01:21 *** jordonwii
183 2010-12-06T03:01:23 <jbills> I have posted something
184 2010-12-06T03:01:57 <jbills> A picture of how far I am. I still need work and so... I need a deadline extension
185 2010-12-06T03:08:06 <jbills> got 2 go for now
186 2010-12-06T03:09:47 <rfw> afternoon ThomasWaldmann
187 2010-12-06T03:09:51 <rfw> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129098518356 <-- requested this
188 2010-12-06T03:12:17 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129098518356 (textchas - make them more secure)
189 2010-12-06T03:12:54 *** jbills
190 2010-12-06T03:34:54 <ThomasWaldmann> hi rfw
191 2010-12-06T03:35:11 <rfw> yup, got it
192 2010-12-06T03:35:12 <rfw> thanks
193 2010-12-06T03:36:23 * ThomasWaldmann will sleep soon
194 2010-12-06T03:36:38 <ThomasWaldmann> rfw: any questions you have right now?
195 2010-12-06T03:36:45 <rfw> nope
196 2010-12-06T03:36:51 <rfw> feel free to sleep
197 2010-12-06T03:38:36 <ThomasWaldmann> ok :) gn
198 2010-12-06T05:15:28 *** kursor
199 2010-12-06T05:56:12 <rfw> there we go, textcha encryption implemented for moin1.9
200 2010-12-06T06:13:47 *** kursor
201 2010-12-06T06:19:39 *** jordonwii
202 2010-12-06T06:36:32 <Kapace__> rfw: pretty epic stuff there
203 2010-12-06T06:36:45 <Kapace__> why XTEA?
204 2010-12-06T06:36:50 <rfw> Kapace__: not really since the XTEA code isn't actually mine .__.
205 2010-12-06T06:37:01 <rfw> well, i wanted a symmetric block cipher
206 2010-12-06T06:37:16 <rfw> and XTEA was the first thing that came up
207 2010-12-06T06:37:20 <rfw> so "oh okay i'll just use XTEA"
208 2010-12-06T06:37:29 <Kapace__> cool
209 2010-12-06T06:38:23 <rfw> not sure if people like it yet though
210 2010-12-06T06:39:04 <rfw> should be secure-ish
211 2010-12-06T06:44:14 <Kapace__> rfw: so what are you looking at next?
212 2010-12-06T06:44:23 <rfw> no idea
213 2010-12-06T06:44:42 <rfw> i already got some 4 pointers from sahana which i felt really bad about after getting them
214 2010-12-06T06:45:01 <rfw> i even made up for it by fixing 2 bugs per task
215 2010-12-06T06:45:06 <rfw> still feels dirty :/
216 2010-12-06T06:45:09 <Kapace__> yeah i saw
217 2010-12-06T06:45:24 <rfw> dunno yet
218 2010-12-06T06:45:30 <rfw> i have quite a lead ahead of jumpyshoes
219 2010-12-06T06:45:35 <rfw> so i might take on some 2 pointers
220 2010-12-06T06:45:53 <Kapace__> hmm, you never know how many ASM functions patches he has stored up ;)
221 2010-12-06T06:46:13 <rfw> ahaha yeah
222 2010-12-06T06:46:54 <rfw> i could always fall back and do more sahana tasks
223 2010-12-06T06:47:02 <rfw> and feel really bad about it again
224 2010-12-06T06:49:08 <rfw> the mentor lives 3km away from me ._.
225 2010-12-06T06:49:48 <Kapace__> oh, thats cool
226 2010-12-06T06:50:03 <Kapace__> sometimes i feel like im surrounded by idiots, locally
227 2010-12-06T06:50:12 <rfw> i know what you mean
228 2010-12-06T06:50:32 <rfw> i don't know anyone irl interested in programming ._.
229 2010-12-06T06:50:57 <Kapace__> same, if you don't count "Game Maker" as programming
230 2010-12-06T06:51:02 <rfw> hahahaha
231 2010-12-06T06:51:12 <rfw> well
232 2010-12-06T06:51:18 <rfw> i don't know anyone who even uses game maker >_>
233 2010-12-06T06:51:41 <Kapace__> which, extremely unfortunately for and for the students in my programming class, is accepted into the course somehow..
234 2010-12-06T06:51:47 <Kapace__> *for me
235 2010-12-06T06:52:11 <rfw> my school has no programming classes :(
236 2010-12-06T06:52:22 <Kapace__> ah that sucks terribly!
237 2010-12-06T06:52:39 <Kapace__> but, I can assure you, your probably not missing out on much ;0
238 2010-12-06T06:52:51 <rfw> hah
239 2010-12-06T06:53:05 <rfw> my friend at another school has programming classes
240 2010-12-06T06:53:13 <rfw> and he had web design or something
241 2010-12-06T06:53:23 <rfw> and one of the questions on the quiz was "what are web-safe colors"
242 2010-12-06T06:53:28 <Kapace__> lol
243 2010-12-06T06:53:31 <rfw> no, we don't live in the 90s any more!
244 2010-12-06T06:54:17 <Kapace__> well, my friend has it worse: his "programming" course's exam consists of memorizing the menus for MS Office Word etc
245 2010-12-06T06:54:24 <rfw> LOL
246 2010-12-06T07:10:48 <rfw> sorry i was at dinner
247 2010-12-06T07:35:00 <Kapace__> no need to be sorry, unless... what were you eating?! :O
248 2010-12-06T07:40:12 <rfw> oh just
249 2010-12-06T07:40:13 <rfw> stuff
250 2010-12-06T08:39:36 <dreimark> moin
251 2010-12-06T08:44:11 <rfw> morning dreimark
252 2010-12-06T08:44:22 <rfw> would you mind taking a look at http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129098518356
253 2010-12-06T08:45:02 <rfw> i haven't forward ported it to moin2 yet
254 2010-12-06T09:06:46 *** gwork
255 2010-12-06T09:07:24 <dreimark> hi rfw - i look later on it, currently doing some requested admin work for my users
256 2010-12-06T09:07:31 <rfw> ah okay
257 2010-12-06T09:07:40 <rfw> no rush
258 2010-12-06T10:17:49 *** rfw
259 2010-12-06T11:12:47 *** greg_f
260 2010-12-06T11:37:55 *** jaydez
261 2010-12-06T11:45:09 <jaydez> I want to start deving on moinmoin
262 2010-12-06T11:45:15 <jaydez> how do I download the source?
263 2010-12-06T11:45:25 <jaydez> for 2.0
264 2010-12-06T11:47:34 <TheSheep> jaydez: http://moinmo.in/MoinDev/MercurialGuide
265 2010-12-06T11:51:12 <jaydez> thanks
266 2010-12-06T11:51:19 <jaydez> that's what I needed
267 2010-12-06T11:52:53 *** jaydez
268 2010-12-06T14:31:02 *** m4k3r
269 2010-12-06T14:36:48 *** m4k3r
270 2010-12-06T14:39:30 *** m4k3r
271 2010-12-06T14:51:12 *** maker__
272 2010-12-06T14:52:38 *** jbills
273 2010-12-06T14:53:07 <jbills> How would I get the next value of elem in the following loop: for elem, level, id in headings:
274 2010-12-06T14:53:24 *** m4k3r
275 2010-12-06T14:53:54 <TheSheep> jbills: next value in what sense?
276 2010-12-06T14:55:01 <TheSheep> jbills: something like for (elem, level, id), (next_elem, next_level, next_id) in zip(headings, headings[1:]): ?
277 2010-12-06T14:55:45 <jbills> I need the next value of elem in the current iteration
278 2010-12-06T15:00:26 <TheSheep> jbills: what if you are at the end?
279 2010-12-06T15:01:04 <jbills> I will not need the next value at the end.
280 2010-12-06T15:04:38 <TheSheep> jbills: the for loop I gave you will iterate over the headings, except for the last element, and give you the current and last item
281 2010-12-06T15:04:43 <TheSheep> s/last/next
282 2010-12-06T15:05:22 <jbills> Thanks
283 2010-12-06T15:06:41 *** maker__
284 2010-12-06T15:07:03 *** m4k3r
285 2010-12-06T15:15:06 <jbills> TheSheep: I got the following error: TypeError: 'generator' object is unsubscriptable
286 2010-12-06T15:15:24 <ronny> jbills: make it a list first?
287 2010-12-06T15:15:31 <TheSheep> jbills: ah, so headings is not a list...
288 2010-12-06T15:15:58 <TheSheep> jbills: in that case, you have to save the last item in a variable and use that
289 2010-12-06T15:16:26 <jbills> I need to get the next item in the current loop
290 2010-12-06T15:16:34 <jbills> iteration
291 2010-12-06T15:16:50 <TheSheep> jbills: then use the last item as your current one, then the current one becomes your next one
292 2010-12-06T15:17:08 <TheSheep> s/last/previous
293 2010-12-06T15:17:43 <jbills> TheSheep: Here is my code:https://gist.github.com/727189
294 2010-12-06T15:40:36 *** maker__
295 2010-12-06T15:41:00 *** m4k3r
296 2010-12-06T16:26:15 <jbills> TheSheep: Here is what I want https://gist.github.com/727189#comments
297 2010-12-06T16:27:11 *** kursor
298 2010-12-06T16:28:07 <TheSheep> jbills: do it with the saving of previous element
299 2010-12-06T17:00:30 *** gwork
300 2010-12-06T17:08:37 <jbills> TheSheep: Here is what happens when use your suggestion:http://imagebin.ca/view/FRFf_y.html
301 2010-12-06T17:09:47 <TheSheep> jbills: do you want me to write that for you?
302 2010-12-06T17:09:54 <TheSheep> jbills: because I won't
303 2010-12-06T17:09:56 <jbills> No
304 2010-12-06T17:10:51 <TheSheep> jbills: you can also do headings_list = list(headings) and use my first suggestion with headings_list instead of headings
305 2010-12-06T17:11:07 <TheSheep> jbills: but be aware that it skips the last step
306 2010-12-06T17:11:18 <jbills> k
307 2010-12-06T17:12:05 <TheSheep> so you probably want to move the inside of that loop into a function, call it in the loop and once more after the loop, for the last element
308 2010-12-06T17:12:24 <jbills> ok
309 2010-12-06T17:12:31 <jbills> thank you
310 2010-12-06T17:26:07 <jbills> TheSheep: If none the text is equal to the new one then how does it end up with doubles?
311 2010-12-06T17:27:43 <TheSheep> jbills: I don't understand
312 2010-12-06T17:29:25 <jbills> None of the text is equal to the next text see here:https://gist.github.com/727189#gistcomment-15592 the result is the same as the other image.
313 2010-12-06T17:30:35 <jbills> Oops might have forgotten to save before reloading :)
314 2010-12-06T17:33:46 <jbills> Did not make a difference :(
315 2010-12-06T17:45:50 *** pvinogradov
316 2010-12-06T18:44:32 *** kursor
317 2010-12-06T19:02:38 <dreimark> bbl
318 2010-12-06T19:29:00 *** rfw
319 2010-12-06T19:31:18 <rfw> moin :)
320 2010-12-06T19:33:18 <ThomasWaldmann> hi rfw
321 2010-12-06T19:33:46 <rfw> ThomasWaldmann: apart from the import in the wrong place, is it okay?
322 2010-12-06T19:36:18 <ThomasWaldmann> i left 2 comments, did you answer?
323 2010-12-06T19:37:36 <rfw> oh, i saw one in my email
324 2010-12-06T19:37:52 <rfw> ah, didn't catch that there
325 2010-12-06T19:37:55 <rfw> my bad
326 2010-12-06T19:38:13 <rfw> symmetric encryption is easier in terms of implementation
327 2010-12-06T19:38:51 <rfw> i think using public-key encryption is a bit overkill :|
328 2010-12-06T19:39:30 <ThomasWaldmann> my point was why you need to en- and decrypt?
329 2010-12-06T19:39:50 <rfw> well, to encrypt the question along with a timestamp
330 2010-12-06T19:39:57 <rfw> so they can't actually change it to whatever
331 2010-12-06T19:40:19 <rfw> and if it's x hours past the timestamp recorded on the question, then that question is no longer acceptable
332 2010-12-06T19:41:51 <ThomasWaldmann> well, the question is not secret, so it doesn't need encryption, but just signing
333 2010-12-06T19:42:09 <rfw> well, it is sorta signing
334 2010-12-06T19:42:44 <rfw> didn't want to resort to non-python external modules
335 2010-12-06T19:43:16 <ThomasWaldmann> there is sha1, hmac etc.
336 2010-12-06T19:43:40 <rfw> how does that help?
337 2010-12-06T19:43:50 <ThomasWaldmann> maybe check whether you can just use them, like passwords are stored, salted and hashed
338 2010-12-06T19:44:04 <rfw> hm but that doesn't solve the timestamp issue
339 2010-12-06T19:44:26 <rfw> i used symmetric encryption because i could tack a timestamp onto the client's version of the encrypted question
340 2010-12-06T19:44:33 <rfw> so i could actually expire the question
341 2010-12-06T19:44:51 <ThomasWaldmann> if you sign the (timestamp + random + question), one can not tamper it without invalidating it
342 2010-12-06T19:45:08 <rfw> hm but how do you get the timestamp back?
343 2010-12-06T19:45:20 <ThomasWaldmann> you can also include it in cleartext
344 2010-12-06T19:45:29 <ThomasWaldmann> it doesn't need to be secret
345 2010-12-06T19:45:39 <rfw> ah
346 2010-12-06T19:45:42 <ThomasWaldmann> you just need to notice if someone fscked with it :)
347 2010-12-06T19:45:42 <rfw> i see what you're getting at
348 2010-12-06T19:45:57 <rfw> sha1(timestamp + question + server secret)
349 2010-12-06T19:46:15 <ThomasWaldmann> or hmac? maybe read about hmac first :)
350 2010-12-06T19:46:22 <rfw> now i feel stupid :(
351 2010-12-06T19:46:31 <ThomasWaldmann> you aren't :)
352 2010-12-06T19:47:10 <rfw> ah, keyed hashing
353 2010-12-06T19:47:24 <ThomasWaldmann> the good thing: that's all in stdlib
354 2010-12-06T19:47:30 <rfw> yup
355 2010-12-06T19:47:41 <rfw> i was specifically avoiding the use of pycrypto
356 2010-12-06T19:47:43 <ThomasWaldmann> for 1.9 have a look at the python_compatibility.py we have in moin
357 2010-12-06T19:48:07 <ThomasWaldmann> because the hash stuff needs some compat code for misc. py versions
358 2010-12-06T19:48:20 <ThomasWaldmann> but that is all there already because we use it at other places also
359 2010-12-06T19:48:44 *** greg_f
360 2010-12-06T19:50:10 <rfw> ah
361 2010-12-06T19:50:27 <ThomasWaldmann> btw, about that timestamp
362 2010-12-06T19:50:41 <ThomasWaldmann> an hour is rather long
363 2010-12-06T19:51:20 <ThomasWaldmann> maybe check if we can use much less if we consider that a user with a failing textcha will just retry it (and only take a minute for the retry, even if he edited for an hour)
364 2010-12-06T19:58:21 <rfw> ThomasWaldmann: well, you could just change it in the settings
365 2010-12-06T19:59:31 <ThomasWaldmann> brb
366 2010-12-06T20:00:17 <rfw> hm well this hmac implementation works
367 2010-12-06T20:00:46 <rfw> <input type="hidden" name="textcha-question" value="Enter the first 9 digits of Pi. 1291662017ae7f04db60b2ce894be71902823eb7b9" />
368 2010-12-06T20:20:22 <ThomasWaldmann> re
369 2010-12-06T20:20:53 <rfw> ThomasWaldmann: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129098518356 submitted
370 2010-12-06T20:20:55 <ThomasWaldmann> you have it in the value?
371 2010-12-06T20:21:00 <rfw> yeah
372 2010-12-06T20:21:08 <rfw> it saves from having three differnt hidden fiels
373 2010-12-06T20:21:10 <rfw> fields*
374 2010-12-06T20:21:19 <ThomasWaldmann> ah, hidden, ok
375 2010-12-06T20:22:37 <ThomasWaldmann> remove unused imports
376 2010-12-06T20:22:50 <rfw> oh
377 2010-12-06T20:22:51 <rfw> doh
378 2010-12-06T20:23:16 <rfw> didn't notice those hiding up there
379 2010-12-06T20:23:19 <ThomasWaldmann> if you want the textcha expiry configurable, add it to config/default.py
380 2010-12-06T20:23:32 <ThomasWaldmann> then you won't need to use getattr
381 2010-12-06T20:23:48 <rfw> i odn't have a default.py :|
382 2010-12-06T20:23:57 <rfw> i have __init__ and multiconfig
383 2010-12-06T20:24:12 <ThomasWaldmann> maybe just textcha_expiry? isn't a expiry always a time?
384 2010-12-06T20:24:25 <rfw> yeah
385 2010-12-06T20:24:27 <ThomasWaldmann> ehrm, multiconfig for 1.9
386 2010-12-06T20:24:35 <rfw> ah
387 2010-12-06T20:25:11 <ThomasWaldmann> don't use textcha_secret, see secrets config value
388 2010-12-06T20:26:03 <ThomasWaldmann> don't use "not =="
389 2010-12-06T20:26:23 <rfw> hm so
390 2010-12-06T20:26:30 <rfw> combine both secrets?
391 2010-12-06T20:26:50 <ThomasWaldmann> both? which?
392 2010-12-06T20:27:07 <ThomasWaldmann> secrets is a dict
393 2010-12-06T20:27:21 <ThomasWaldmann> with some tolerance for admins just putting a string
394 2010-12-06T20:27:27 <rfw> oh
395 2010-12-06T20:27:31 <rfw> secrets = 'This string is NOT a secret, please make up your own, long, random secret string!'
396 2010-12-06T20:27:35 <rfw> but it says string :|
397 2010-12-06T20:27:56 <ThomasWaldmann> it works with a string, but then all secret dict values will be that string
398 2010-12-06T20:28:02 <rfw> ah
399 2010-12-06T20:28:15 <ThomasWaldmann> btw, "now" is a nice abbreviation for "current_time" :)
400 2010-12-06T20:28:30 <rfw> but it's not actually now
401 2010-12-06T20:28:34 <rfw> well, not always
402 2010-12-06T20:28:46 <rfw> more like current time [as per the textcha]
403 2010-12-06T20:30:16 <rfw> ThomasWaldmann: how would i go about using cfg.secrets in textcha?
404 2010-12-06T20:30:21 <ThomasWaldmann> it's not always current_time either :)
405 2010-12-06T20:30:42 <ThomasWaldmann> add a new key 'textchas'
406 2010-12-06T20:30:43 <rfw> i suppose
407 2010-12-06T20:30:55 <rfw> in secret_key_names = ['action/cache', 'wikiutil/tickets', 'xmlrpc/ProcessMail', 'xmlrpc/RemoteScript', ] ?
408 2010-12-06T20:31:18 <ThomasWaldmann> yes, so it is 'security/textchas'? see module name.
409 2010-12-06T20:31:26 <rfw> ah
410 2010-12-06T20:31:29 <rfw> if self.textchas:
411 2010-12-06T20:31:29 <rfw> secret_key_names.append('security/textcha')
412 2010-12-06T20:32:06 <ThomasWaldmann> make very sure that it works with no textchas then :)
413 2010-12-06T20:32:07 <rfw> and i can just get it with self.secret = self.request.cfg.secrets["security/textcha"] ?
414 2010-12-06T20:32:21 <ThomasWaldmann> yes
415 2010-12-06T20:32:28 <rfw> alright, let me test this again
416 2010-12-06T20:33:49 <ThomasWaldmann> don't use self.request if you already have request
417 2010-12-06T20:35:23 <rfw> ugh, i'm pretty sure i'm usually not this bad with coding style
418 2010-12-06T20:37:28 <ThomasWaldmann> btw, that success = ... looks suspicious
419 2010-12-06T20:37:45 <rfw> hm, where?
420 2010-12-06T20:38:07 <rfw> oh god did melange just crash
421 2010-12-06T20:38:11 <ThomasWaldmann> check_answer
422 2010-12-06T20:38:32 <rfw> hm, what's wrong with it?
423 2010-12-06T20:38:55 <ThomasWaldmann> melange is powered by a probability drive :D
424 2010-12-06T20:39:10 <rfw> :|
425 2010-12-06T20:39:23 <rfw> bah, melange is super-down
426 2010-12-06T20:39:35 <ThomasWaldmann> you killed kenny!!1
427 2010-12-06T20:39:39 <TheSheep> this is their take at quantum computing
428 2010-12-06T20:39:39 <rfw> i'll just shove it on pastebin and post it to melange later
429 2010-12-06T20:39:39 <rfw> haha
430 2010-12-06T20:39:47 <rfw> http://pastebin.com/GSAX4NQc
431 2010-12-06T20:40:14 <TheSheep> you know that there are parallel universes in which your request worked
432 2010-12-06T20:40:34 <TheSheep> gazillions of them
433 2010-12-06T20:40:38 <rfw> TheSheep: quantum physics and 9am do not go well together
434 2010-12-06T20:40:54 <ThomasWaldmann> no 20
435 2010-12-06T20:40:59 <TheSheep> rfw: good that it's 9 pm
436 2010-12-06T20:41:07 <rfw> oh i spotted that too
437 2010-12-06T20:42:37 <ThomasWaldmann> that hmac typerror is for what?
438 2010-12-06T20:42:53 <rfw> int cast
439 2010-12-06T20:43:18 <ThomasWaldmann> 51?
440 2010-12-06T20:43:50 <rfw> oh wait
441 2010-12-06T20:43:56 <rfw> ah right
442 2010-12-06T20:44:00 <rfw> that's if current_time is None
443 2010-12-06T20:45:25 *** nickr5
444 2010-12-06T20:47:17 <ThomasWaldmann> can that happen for valid input?
445 2010-12-06T20:47:47 <rfw> if someone's tampered with it yes
446 2010-12-06T20:48:39 <ThomasWaldmann> so that's invalid then
447 2010-12-06T20:48:43 <rfw> yeah
448 2010-12-06T20:48:48 <rfw> i just have it there for safety :)
449 2010-12-06T20:50:50 <ThomasWaldmann> i somehow feel that this all is one big boolean expression :)
450 2010-12-06T20:51:15 <rfw> it looks better than one at least :D
451 2010-12-06T20:52:11 <TheSheep> shouldn't it do 'return False' to short-circuit early when it fails?
452 2010-12-06T20:52:27 <TheSheep> or even raise something...
453 2010-12-06T20:52:36 <rfw> TheSheep: it logs it later
454 2010-12-06T20:52:42 <ThomasWaldmann> yeah
455 2010-12-06T20:52:51 <TheSheep> rfw: then it should be a separate function
456 2010-12-06T20:53:14 <ThomasWaldmann> btw, big boolean expression can be rather pretty
457 2010-12-06T20:53:29 <ThomasWaldmann> if (foo # comment about foo if needed
458 2010-12-06T20:53:29 <TheSheep> ThomasWaldmann: your sense of beauty is skewed ;)
459 2010-12-06T20:53:34 <ThomasWaldmann> and
460 2010-12-06T20:53:39 <rfw> TheSheep: i'm just following the style in the file
461 2010-12-06T20:53:42 <ThomasWaldmann> bar is not None # ...
462 2010-12-06T20:53:49 <ThomasWaldmann> ): ...
463 2010-12-06T20:53:59 <TheSheep> rfw: I was just generally commenting on that style
464 2010-12-06T20:54:06 <rfw> ah
465 2010-12-06T20:54:14 <ThomasWaldmann> rfw: it's not all your fault :)
466 2010-12-06T20:54:24 <rfw> :D
467 2010-12-06T20:54:26 <TheSheep> actually raising something might let you write some checks very easily
468 2010-12-06T20:54:55 <TheSheep> is there any case where you expect it to fail?
469 2010-12-06T20:56:28 <ThomasWaldmann> btw, maybe we should do no BIG cleanup in 1.9
470 2010-12-06T20:56:36 <ThomasWaldmann> that's what we have 2 for
471 2010-12-06T20:56:38 <TheSheep> ah, right
472 2010-12-06T20:57:33 <TheSheep> I hear you
473 2010-12-06T20:57:59 <ThomasWaldmann> you must hear me eating a yoghurt then :P
474 2010-12-06T20:58:35 <TheSheep> omnomnom
475 2010-12-06T20:58:43 <rfw> ThomasWaldmann: am i okay to forward port it to 2?
476 2010-12-06T20:59:15 <ThomasWaldmann> show a final diff please :)
477 2010-12-06T20:59:17 <rfw> argh
478 2010-12-06T20:59:18 <rfw> melange bugg
479 2010-12-06T20:59:38 <rfw> ThomasWaldmann: that was it, just remove line 20
480 2010-12-06T20:59:40 <ThomasWaldmann> btw, they called for contributions a while ago :)
481 2010-12-06T21:01:04 <ThomasWaldmann> 78/83 is a bit misleading. maybe "timestamp" rather?
482 2010-12-06T21:01:17 <rfw> ah okay
483 2010-12-06T21:01:23 <rfw> i should change current_time all to timestamp
484 2010-12-06T21:02:10 <ThomasWaldmann> maybe that's simplest, yes
485 2010-12-06T21:02:46 <ThomasWaldmann> 130 unit missing
486 2010-12-06T21:04:18 <rfw> oh
487 2010-12-06T21:04:43 <ThomasWaldmann> also check grammar
488 2010-12-06T21:05:31 <rfw> Time in seconds it takes for a !TextCha to expire.
489 2010-12-06T21:08:23 <ThomasWaldmann> Time [s] ...
490 2010-12-06T21:08:34 <ThomasWaldmann> others use [h] etc.
491 2010-12-06T21:08:35 <rfw> ah
492 2010-12-06T21:09:14 <ThomasWaldmann> ok, if you're finished with these changes, please do a test with and without textchas configured
493 2010-12-06T21:10:11 <ThomasWaldmann> btw, one can still cheat, but only for 1h
494 2010-12-06T21:10:55 <ThomasWaldmann> can you try what happens when it expires?
495 2010-12-06T21:11:10 <ThomasWaldmann> if one uses 60 for example
496 2010-12-06T21:11:19 <rfw> i have
497 2010-12-06T21:11:37 <rfw> it just says your textcha is invalid
498 2010-12-06T21:13:09 <ThomasWaldmann> and you get a new one?
499 2010-12-06T21:17:05 <rfw> yeayh
500 2010-12-06T21:21:11 <ThomasWaldmann> and if you fill out that one quicker, it works?
501 2010-12-06T21:28:08 <rfw> yes
502 2010-12-06T21:32:30 <ThomasWaldmann> ok, then maybe we want a bit shorter time for the default timeout?
503 2010-12-06T21:32:54 <rfw> ah
504 2010-12-06T21:32:57 <rfw> say, 1 minute?
505 2010-12-06T21:33:08 <ThomasWaldmann> 600s?
506 2010-12-06T21:33:36 <ThomasWaldmann> it shouldn't be so short that it almost always fails
507 2010-12-06T21:33:40 <rfw> yeah
508 2010-12-06T21:34:35 <ThomasWaldmann> ehrm, did you use python_compatibility?
509 2010-12-06T21:34:55 <ThomasWaldmann> see MoinMoin.support
510 2010-12-06T21:35:49 <rfw> er, hmac has been in python since 2.2
511 2010-12-06T21:36:05 <rfw> apparently
512 2010-12-06T21:36:25 <ThomasWaldmann> yes, but with wrong defaults
513 2010-12-06T21:36:41 <rfw> oh
514 2010-12-06T21:36:42 <rfw> right
515 2010-12-06T21:37:03 <rfw> so just
516 2010-12-06T21:37:04 <rfw> from MoinMoin.support import hmac_new ?
517 2010-12-06T21:37:08 <ThomasWaldmann> yes
518 2010-12-06T21:37:17 <ThomasWaldmann> no
519 2010-12-06T21:37:19 <ThomasWaldmann> :)
520 2010-12-06T21:37:26 <rfw> what .-.
521 2010-12-06T21:37:34 <ThomasWaldmann> python_compatibility?
522 2010-12-06T21:37:43 <rfw> oh
523 2010-12-06T21:37:45 <rfw> heh
524 2010-12-06T21:37:56 <rfw> drop in replacement for hmac.new?
525 2010-12-06T21:38:01 <ThomasWaldmann> yes
526 2010-12-06T21:42:17 <rfw> oh it's sha1
527 2010-12-06T21:42:28 <rfw> i was wondering why i wasn't getting the right offsets
528 2010-12-06T21:44:21 <rfw> ThomasWaldmann: submitted to melange
529 2010-12-06T21:44:26 <ThomasWaldmann> yes, md5 isn't quite state of the art
530 2010-12-06T21:44:39 <rfw> hehe
531 2010-12-06T21:44:44 <ThomasWaldmann> (and sha1 is also getting old)
532 2010-12-06T21:44:46 <rfw> better than crc32 at least :D
533 2010-12-06T21:47:04 <ThomasWaldmann> remove hmac import
534 2010-12-06T21:48:33 <ThomasWaldmann> also, please run the tests, esp. test_sourcecode
535 2010-12-06T22:17:59 <rfw> got it
536 2010-12-06T22:26:16 <dreimark> re
537 2010-12-06T22:26:35 <dreimark> is it now in h? because we have all other time values in seconds
538 2010-12-06T22:32:39 <dreimark> rfw: ^
539 2010-12-06T22:32:51 <rfw> dreimark: it's in seconds
540 2010-12-06T22:35:59 <dreimark> good
541 2010-12-06T22:40:30 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964696 (find a failing test, determine problem, fix it (difficulty: easy) 3/3)
542 2010-12-06T22:42:33 <ThomasWaldmann> latency...
543 2010-12-06T22:48:30 <dreimark> but which test
544 2010-12-06T23:07:41 <rfw> ThomasWaldmann: do i need python_compatability in moin2
545 2010-12-06T23:07:45 <rfw> compatibility*
546 2010-12-06T23:10:54 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964696 (find a failing test, determine problem, fix it (difficulty: easy) 3/3)
547 2010-12-06T23:12:21 <ThomasWaldmann> rfw: we require py 2.6 there
548 2010-12-06T23:12:27 <rfw> ah okay
549 2010-12-06T23:12:34 <rfw> so i can just import hmac and be fine?
550 2010-12-06T23:12:56 <ThomasWaldmann> yes, but use sh-1
551 2010-12-06T23:12:59 <ThomasWaldmann> yes, but use sha-1
552 2010-12-06T23:13:57 <rfw> got it
553 2010-12-06T23:42:05 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964696 (find a failing test, determine problem, fix it (difficulty: easy) 3/3)