1 2010-12-18T00:18:54  *** m4k3r has quit IRC
   2 2010-12-18T00:32:01  *** kursor has quit IRC
   3 2010-12-18T01:04:08  *** raignarok has quit IRC
   4 2010-12-18T01:05:38  *** jordonwii has joined #moin-dev
   5 2010-12-18T01:51:47  *** jordonwii has quit IRC
   6 2010-12-18T02:04:13  *** jordonwii has joined #moin-dev
   7 2010-12-18T02:30:41  *** grzywacz has quit IRC
   8 2010-12-18T02:52:24  *** jordonwii has quit IRC
   9 2010-12-18T04:01:58  *** jordonwii has joined #moin-dev
  10 2010-12-18T04:02:02  <jordonwii> Moin
  11 2010-12-18T04:14:39  *** jordonwii has quit IRC
  12 2010-12-18T06:28:49  *** skylamer` has joined #moin-dev
  13 2010-12-18T07:46:09  <dreimark> ThomasWaldmann: that is easy
  14 2010-12-18T07:51:01  <dreimark> to solve the amount issue
  15 2010-12-18T08:04:46  <dreimark> 1.9 move has no textcha
  16 2010-12-18T08:05:09  <dreimark> del too
  17 2010-12-18T08:09:36  <dreimark> http://paste.pocoo.org/show/306295/
  18 2010-12-18T08:09:57  <dreimark> and mimetypes_embed.append('image/svg+xml-compressed')
  19 2010-12-18T08:10:41  <dreimark> gives a download link, but embedding didn't work
  20 2010-12-18T08:21:25  *** kursor has joined #moin-dev
  21 2010-12-18T08:26:53  *** kursor_ has joined #moin-dev
  22 2010-12-18T08:30:34  *** kursor has quit IRC
  23 2010-12-18T08:30:35  *** kursor_ is now known as kursor
  24 2010-12-18T10:29:38  *** rfw has quit IRC
  25 2010-12-18T11:22:13  *** kursor has quit IRC
  26 2010-12-18T11:23:03  *** kursor has joined #moin-dev
  27 2010-12-18T11:57:38  *** NikitaUtiu has joined #moin-dev
  28 2010-12-18T12:16:17  *** kursor has quit IRC
  29 2010-12-18T12:22:30  *** grzywacz has joined #moin-dev
  30 2010-12-18T12:22:30  *** grzywacz has joined #moin-dev
  31 2010-12-18T13:14:52  <ThomasWaldmann> dreimark: 'image/svg+xml-compressed' where does that come from? why is it correct?
  32 2010-12-18T13:37:50  <NikitaUtiu> hello, all!
  33 2010-12-18T13:37:58  <NikitaUtiu> i have a question
  34 2010-12-18T13:38:42  <NikitaUtiu> is meta added when i use the meta action on a page or when i modify it ?
  35 2010-12-18T13:44:30  <ThomasWaldmann> meta and data are saved into a revision, the revision is not changed afterwards any more
  36 2010-12-18T13:45:58  <NikitaUtiu> thanks
  37 2010-12-18T14:06:27  *** pvinogradov_ is now known as pvinogradov
  38 2010-12-18T14:25:18  <ThomasWaldmann> xorAxAx: http://moinmo.in/MoinMoinBugs/1.9WikiSyncCorruptedSynctags could you have a look?
  39 2010-12-18T14:25:54  <dreimark> ThomasWaldmann: at first from 00:05 < gry> ThomasWaldmann: I'... at #moin but I also googled for it and it is used in variuos reports too
  40 2010-12-18T14:26:25  <dreimark> e.g. http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg508950.html
  41 2010-12-18T14:34:26  <dreimark> i don't think meanwhile it is correct
  42 2010-12-18T14:37:02  <ThomasWaldmann> franklin: ^^
  43 2010-12-18T14:50:20  *** gry has joined #moin-dev
  44 2010-12-18T15:04:36  <ThomasWaldmann> gry:  * moinmoin should add 'Content-Encoding: gzip' http header for *.svgz files
  45 2010-12-18T15:04:39  <ThomasWaldmann>   * if this is done, firefox will decompress the file, but nevertheless save it as example.svg.gz (or .svgz), which is wrong, because it is not gzipped any more.
  46 2010-12-18T15:05:02  * ThomasWaldmann thinks that compression/mimetype stuff is a mess
  47 2010-12-18T15:07:24  <gry> nope, it will save it as is
  48 2010-12-18T15:07:51  <gry> Content-Encoding is just instruction to how to vizualize things
  49 2010-12-18T15:08:14  <ThomasWaldmann> i tried it
  50 2010-12-18T15:08:53  *** greg_f has joined #moin-dev
  51 2010-12-18T15:09:22  <gry> so if you 'cat example.svgz' file you'll get clear text?
  52 2010-12-18T15:09:35  <gry> I mean saved from moinmoin
  53 2010-12-18T15:10:33  <gry> same as downloaded example.svg?
  54 2010-12-18T15:11:04  <ThomasWaldmann> $ file *svg.gz
  55 2010-12-18T15:11:04  <ThomasWaldmann> example(2).svg.gz: SVG Scalable Vector Graphics image
  56 2010-12-18T15:11:04  <ThomasWaldmann> example.svg.gz:    gzip compressed data, from FAT filesystem (MS-DOS, OS/2, NT)
  57 2010-12-18T15:11:44  <ThomasWaldmann> first try: download without content-encoding, second (2) with c-e: gzip
  58 2010-12-18T15:12:31  <ThomasWaldmann> and if one tries that with tgz, even bigger troubles appear
  59 2010-12-18T15:12:43  <ThomasWaldmann> firefox seems to get totally confused
  60 2010-12-18T15:12:46  <gry> thats strange :(
  61 2010-12-18T15:13:41  <gry> there is another http header
  62 2010-12-18T15:13:45  <gry> Content-Transfer-Encoding
  63 2010-12-18T15:13:55  <gry> can you try with it?
  64 2010-12-18T15:19:37  <gry> I'm sorry
  65 2010-12-18T15:19:54  <gry> there is no Content-Transfer-Encoding, there is Transfer-Encoding header
  66 2010-12-18T15:20:53  <ThomasWaldmann> that's for email
  67 2010-12-18T15:21:05  <ThomasWaldmann> c-f-e
  68 2010-12-18T15:22:55  <ThomasWaldmann> This differs from a content coding in that the transfer-coding is a property of the message, not of the original entity.
  69 2010-12-18T15:23:03  <ThomasWaldmann> so that's wrong for us
  70 2010-12-18T15:23:30  <ThomasWaldmann> we have a tgz item, so it is a property of the original entity
  71 2010-12-18T15:24:31  <ThomasWaldmann> Content coding values indicate an encoding transformation that has been or can be applied to an entity. Content codings are primarily used to allow a document to be compressed or otherwise usefully transformed without losing the identity of its underlying media type and without loss of information. Frequently, the entity is stored in coded form, transmitted directly, and only decoded by the recipient.
  72 2010-12-18T15:24:35  *** grzywacz has quit IRC
  73 2010-12-18T15:25:02  <ThomasWaldmann> that decoding is the problem
  74 2010-12-18T15:25:21  *** grzywacz has joined #moin-dev
  75 2010-12-18T15:25:46  <ThomasWaldmann> sometimes we want to just "store as is, no decode", e.g. when downloading a .tgz or .svgz and saving it to disk
  76 2010-12-18T15:26:08  *** grzywacz has quit IRC
  77 2010-12-18T15:28:07  <ThomasWaldmann> but in general, if the mimetype image/svg+xml is correct for both svg and svgz, we somehow need to spezify that the svgz is gzipped or we miss information
  78 2010-12-18T15:28:27  <pvinogradov> ThomasWaldmann: Hi
  79 2010-12-18T15:28:34  <ThomasWaldmann> so, is this a browser bug?
  80 2010-12-18T15:28:42  * ThomasWaldmann tried with ff36
  81 2010-12-18T15:28:55  <pvinogradov> i'm just submit some type of security review for Password Security Storafe
  82 2010-12-18T15:29:10  <pvinogradov> http://moinmo.in/MoinMoin2.0/SecurePasswordStorage
  83 2010-12-18T15:29:17  * ThomasWaldmann looks
  84 2010-12-18T15:29:43  <ThomasWaldmann> reread it, fixing typos
  85 2010-12-18T15:30:12  <ThomasWaldmann> and grammar
  86 2010-12-18T15:31:11  *** grzywacz has joined #moin-dev
  87 2010-12-18T15:31:12  *** grzywacz has joined #moin-dev
  88 2010-12-18T15:33:47  <ThomasWaldmann> pvinogradov: also it needs to be more clear what we really have and why and what was a recommendation from that security page
  89 2010-12-18T15:37:53  <pvinogradov> i will try to fix grammar and typos, but my english not so good:(
  90 2010-12-18T15:38:08  <pvinogradov> also i'm add more details
  91 2010-12-18T15:39:00  <ThomasWaldmann> 3rd person verbs usually get an "s" appended. E.g. "He likes moin."
  92 2010-12-18T15:40:29  * ThomasWaldmann can recommend daily reading of slashdot.org and http://planet.python.org/ to get more english training. :)
  93 2010-12-18T15:41:40  <ThomasWaldmann> pvinogradov: did you make up your mind about that 1000 rounds stuff?
  94 2010-12-18T15:43:20  <ThomasWaldmann> shall we create a medium or difficult research task about content-coding issues?
  95 2010-12-18T15:43:23  *** kursor has joined #moin-dev
  96 2010-12-18T15:43:42  <gry> ThomasWaldmann: *so, is this a browser bug?
  97 2010-12-18T15:44:07  <gry> or we should return different headers on get and view?
  98 2010-12-18T15:44:52  <ThomasWaldmann> sometimes i even had the impression that there is no common way to tell a browser "view this" or "download this to disk"
  99 2010-12-18T15:44:55  <ThomasWaldmann> brb
 100 2010-12-18T15:48:34  <gry> for this specific case there is a solution to return: c-t: image/svg+xml and c-e: bzip to view file
 101 2010-12-18T15:48:49  <gry> and to download return c-t: image/svg+xml-compressed
 102 2010-12-18T15:49:17  <gry> but that looks like workaround
 103 2010-12-18T15:50:31  <gry> that may differ among browsers, I'm using firefox-3.6.13
 104 2010-12-18T15:51:40  <gry> what you meant by "shall we create a medium or difficult research task about content-coding issues?", I didn't understand you
 105 2010-12-18T15:57:52  <ThomasWaldmann> gry: google code-in
 106 2010-12-18T16:01:45  <gry> there is Content-Disposition header which may do what we want
 107 2010-12-18T16:03:40  <ThomasWaldmann> yeah, "may" or "might" seems to fit :)
 108 2010-12-18T16:06:16  <gry> that's it, it really forces browser to download file
 109 2010-12-18T16:06:52  <ThomasWaldmann> but still no real solution
 110 2010-12-18T16:11:54  <gry> why do you think so? c-t + c-d forces browser to download as is
 111 2010-12-18T16:12:31  <gry> c-t + c-e(where necessary) forses it to display
 112 2010-12-18T16:12:50  *** Samm has joined #moin-dev
 113 2010-12-18T16:22:00  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10134:0e2e5750a9e0 2.0-dev/MoinMoin/storage/ (_tests/test_backends.py backends/indexing.py): mark history test as xfail and add some explanation (thanks to Roboraider, GCI 2010)
 114 2010-12-18T16:32:26  *** Samm has quit IRC
 115 2010-12-18T17:09:05  <NikitaUtiu> hi, all!
 116 2010-12-18T17:13:58  <ThomasWaldmann> wb NikitaUtiu
 117 2010-12-18T17:14:13  <NikitaUtiu> i think i got it
 118 2010-12-18T17:14:22  <xorAxAx> ThomasWaldmann: cant we make an easytodo task from it? :)
 119 2010-12-18T17:14:49  <NikitaUtiu> but i need to know what the atribute for transcluded items is called ?
 120 2010-12-18T17:14:59  <NikitaUtiu> *attribute
 121 2010-12-18T17:15:24  <NikitaUtiu> like page_href is for links
 122 2010-12-18T17:17:14  <ThomasWaldmann> xorAxAx: from what exactly?
 123 2010-12-18T17:17:48  <xorAxAx> ThomasWaldmann: from the bugreport you showed me
 124 2010-12-18T17:18:05  <ThomasWaldmann> ah :) you'll mentor it?
 125 2010-12-18T17:18:13  <xorAxAx> yes
 126 2010-12-18T17:18:25  <ThomasWaldmann> could you create the task also?
 127 2010-12-18T17:18:34  <xorAxAx> yes
 128 2010-12-18T17:18:42  <ThomasWaldmann> great :)
 129 2010-12-18T17:27:26  <ThomasWaldmann> btw, as student might have some more free time soon due to xmas vacactions, we could try to put in some more medium/difficult tasks
 130 2010-12-18T17:28:35  <gry> ThomasWaldmann: have you tried c-t header thing?
 131 2010-12-18T17:30:29  <ThomasWaldmann> c-t-e?
 132 2010-12-18T17:32:18  <gry> oh, I meant c-d
 133 2010-12-18T17:38:00  <ThomasWaldmann> we use that, see attachfile code
 134 2010-12-18T17:47:41  <ThomasWaldmann> NikitaUtiu: find out by looking? :)
 135 2010-12-18T17:48:04  <ThomasWaldmann> or by writing a test?
 136 2010-12-18T17:48:12  <dreimark> preferable ^^^
 137 2010-12-18T17:48:28  <NikitaUtiu> ThomasWaldmann: I'm running the server in debug mode to see
 138 2010-12-18T17:49:16  <NikitaUtiu> ThomasWaldmann: i'll get it soon
 139 2010-12-18T17:49:51  <ThomasWaldmann> you could also just look if we have a test for itemlinks
 140 2010-12-18T17:50:03  <ThomasWaldmann> you could add a similar one for your stuff
 141 2010-12-18T17:51:10  <gry> ThomasWaldmann: yes, but using c-d moinmoin explicitely tells browsers to inline content, even when we want to get file
 142 2010-12-18T17:52:27  <ThomasWaldmann> iirc we have experimented with that stuff a while ago
 143 2010-12-18T17:52:43  <ThomasWaldmann> and it was a mess due to browsers behaving differently and weirdly
 144 2010-12-18T18:03:11  <pvinogradov> ThomasWaldmann: I'm update storage description and try to fix some errors.
 145 2010-12-18T18:05:41  *** pvinogradov is now known as pvinogradov_
 146 2010-12-18T18:14:02  <ThomasWaldmann> pvinogradov_: you have finished updating it or are you still working on it?
 147 2010-12-18T18:20:30  *** NikitaUtiu has quit IRC
 148 2010-12-18T18:27:57  <gry> ThomasWaldmann: so, we have to test this thing with browsers?
 149 2010-12-18T18:28:17  <dreimark> gry: sure, with all avail. and future browsers
 150 2010-12-18T18:37:34  <ThomasWaldmann> dreimark will get copies of all future browsers :)
 151 2010-12-18T18:38:09  <ThomasWaldmann> http://moinmo.in/EasyToDo/redesign%20theme%20footer comments?
 152 2010-12-18T18:41:40  <dreimark> ThomasWaldmann: show timings should got to somewhere else but not only into the logging
 153 2010-12-18T18:41:50  <dreimark> t/got/go/
 154 2010-12-18T18:42:38  <dreimark> a debug view or somehing similiar
 155 2010-12-18T18:43:24  <dreimark> if you try to lookup something together with a user
 156 2010-12-18T18:43:32  <dreimark> you want to see those values
 157 2010-12-18T18:44:08  <ThomasWaldmann> the problem is a bit that we maybe want to show timers that are still running
 158 2010-12-18T18:44:39  <ThomasWaldmann> currently this is solved by the template stopping these timers, but it would be cleaner just doing it in the code and logging them
 159 2010-12-18T18:46:00  <dreimark> hmm, can we have that in meta?
 160 2010-12-18T18:47:06  <ThomasWaldmann> as i wrote, i don't think it needs to be on the ui
 161 2010-12-18T18:47:39  <ThomasWaldmann> if we just log stuff, we can read all the timings afterwards and configure it without needing a special setting
 162 2010-12-18T18:48:18  <ThomasWaldmann> i thought about maybe splitting the timings stuff into a separate task
 163 2010-12-18T18:48:27  <dreimark> i think i request a log file analyzer the next time
 164 2010-12-18T18:48:41  <dreimark> sometimes i don't have access to the server logs
 165 2010-12-18T18:49:10  <ThomasWaldmann> but then you are maybe not the person to worry about timings either on that server
 166 2010-12-18T18:50:11  <dreimark> depends, sometimes someone shows me what he thinks is a problem
 167 2010-12-18T18:50:21  <ThomasWaldmann> timings code can be simpler then also
 168 2010-12-18T18:50:25  <dreimark> and I have not my notebokk with me
 169 2010-12-18T18:50:38  <ThomasWaldmann> because we don't need to collect the timings, we can just log them when we stop a timer
 170 2010-12-18T18:50:45  <dreimark> true
 171 2010-12-18T18:51:50  <ThomasWaldmann> hmm, no, we need to collect start times anyway. but we can get rid of that dump_timers stuff
 172 2010-12-18T19:10:13  <dreimark> ThomasWaldmann: what do we do with page_footer* and page_header
 173 2010-12-18T19:34:05  <skylamer`> thomaswaldmann i can help for something
 174 2010-12-18T19:34:13  *** skylamer` has quit IRC
 175 2010-12-18T19:34:42  <dreimark> famous last words ...
 176 2010-12-18T19:35:11  <ThomasWaldmann> dreimark: the html stuff?
 177 2010-12-18T19:35:31  <ThomasWaldmann> i guess we keep it for compatibility for now.
 178 2010-12-18T19:35:46  <dreimark> i recognized that this was nonsense, we should make a task for that too
 179 2010-12-18T19:35:56  <dreimark> it must be moved to a template
 180 2010-12-18T19:36:09  <ThomasWaldmann> that would mean killing it :)
 181 2010-12-18T19:36:25  <dreimark> yes, thats why i said i recognized that
 182 2010-12-18T19:36:48  <ThomasWaldmann> btw, I'll close pavel's task, it is done.
 183 2010-12-18T19:36:53  <dreimark> :)
 184 2010-12-18T19:39:12  <CIA-56> pavel_vinogradov default * 5751:e4479bf1c820 1.9/MoinMoin/ (search/Xapian/indexing.py security/textcha.py): Fix 'trailing blanks' warnings in source code
 185 2010-12-18T19:41:42  *** kursor has quit IRC
 186 2010-12-18T19:42:11  <CIA-56> pavel_vinogradov default * 10135:78cecb4fba2c 2.0-dev/MoinMoin/ (user.py support/md5crypt.py): Forward support for new password hash from moin 1.9 to 2.0-dev
 187 2010-12-18T19:42:12  <CIA-56> pavel_vinogradov default * 10136:172f532d83c6 2.0-dev/MoinMoin/_tests/test_user.py: Forward unit test for new password hash from moin 1.9 to 2.0-dev
 188 2010-12-18T19:42:15  <CIA-56> pavel_vinogradov default * 10137:dced1390a42e 2.0-dev/MoinMoin/_tests/test_user.py: Fix in comment: htpassword command line argument for DES password generation
 189 2010-12-18T19:42:17  <CIA-56> Pavel Vinogradov <pavel.vinogradov@nixdev.net> default * 10138:597b317abe23 2.0-dev/MoinMoin/ (_tests/test_user.py user.py support/md5crypt.py): Forward new password hash support from 1.9
 190 2010-12-18T19:42:19  <CIA-56> pavel_vinogradov default * 10139:d16580a608f1 2.0-dev/MoinMoin/_tests/test_user.py: Update test 'auth with ssha256 password'
 191 2010-12-18T19:42:23  <CIA-56> pavel_vinogradov default * 10140:d28ce1702819 2.0-dev/MoinMoin/ (_tests/test_user.py user.py): Add support for auth with stored SSHA256 password
 192 2010-12-18T19:42:26  <CIA-56> pavel_vinogradov default * 10141:04143a39b66a 2.0-dev/MoinMoin/ (_tests/test_user.py converter/html_out.py user.py): Fix 'trailing blanks' warnings in source code
 193 2010-12-18T19:42:26  <CIA-56> pavel_vinogradov default * 10142:31725aeff9c5 2.0-dev/MoinMoin/_tests/test_user.py: Add test for "auto-upgrade passwords on login to SSHA256" feature
 194 2010-12-18T19:42:29  <CIA-56> pavel_vinogradov default * 10143:d66c77a90cb6 2.0-dev/MoinMoin/user.py: Update encodePassword function to generate ssha256 passwords
 195 2010-12-18T19:42:30  <CIA-56> pavel_vinogradov default * 10144:9cd92370c1fd 2.0-dev/MoinMoin/_tests/test_user.py: Fix encodePassword related tests with new ssha256 hash values
 196 2010-12-18T19:42:31  <CIA-56> pavel_vinogradov default * 10145:9976b73e73c4 2.0-dev/MoinMoin/ (_tests/test_user.py user.py): Auto upgrade SSHA password on login
 197 2010-12-18T19:42:34  <CIA-56> pavel_vinogradov default * 10146:4c9ae6472972 2.0-dev/MoinMoin/user.py: Remove deprecated SSHA password validation code
 198 2010-12-18T19:42:35  <CIA-56> pavel_vinogradov default * 10147:1b8ea82997ab 2.0-dev/MoinMoin/ (_tests/test_user.py user.py): Implement auth with stored ssha password
 199 2010-12-18T19:42:38  <CIA-56> pavel_vinogradov default * 10148:90e03e880b1d 2.0-dev/MoinMoin/user.py: Update _validatePassword and make it more clear and shorter (SSHA passwords)
 200 2010-12-18T19:42:40  <CIA-56> pavel_vinogradov default * 10149:a40abfa1aeb8 2.0-dev/MoinMoin/user.py: Update @return comment in encodePassword function
 201 2010-12-18T19:42:42  <CIA-56> pavel_vinogradov default * 10150:d1d190c805ae 2.0-dev/MoinMoin/user.py: Small code optimizations in _validatePassword (based on review by Thomas Waldmann)
 202 2010-12-18T19:42:43  <CIA-56> pavel_vinogradov default * 10151:7dce40135610 2.0-dev/MoinMoin/user.py: Update sha1 hash compute in _validatePassword
 203 2010-12-18T19:42:46  <CIA-56> pavel_vinogradov default * 10152:29ecd20d729c 2.0-dev/MoinMoin/user.py: Remove password.encode('utf-8') duplicate code in _validatePassword
 204 2010-12-18T19:42:47  <CIA-56> pavel_vinogradov default * 10153:296a33873d5e 2.0-dev/MoinMoin/user.py: _validatePassword: Use ssha256 check before password upgrade loop
 205 2010-12-18T19:42:48  <CIA-56> pavel_vinogradov default * 10154:e9cf0ce0fae0 2.0-dev/MoinMoin/user.py: Move ssha256 stuff into password check loop
 206 2010-12-18T19:42:53  <CIA-56> pavel_vinogradov default * 10155:eafcbf5cc205 2.0-dev/MoinMoin/user.py: Unify SSHA256 password validation in _validatePassword
 207 2010-12-18T19:42:55  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10156:676b3d0ce770 2.0-dev/MoinMoin/ (4 files in 4 dirs): merged https://bitbucket.org/pavel_vinogradov/gci10-moin-2.0-dev/
 208 2010-12-18T19:43:37  <ThomasWaldmann> pvinogradov_: good work :)
 209 2010-12-18T19:44:20  <ThomasWaldmann> pvinogradov_: maybe have a look at the wiki page diff, i did some fixes / rearrangements / shortened it a bit
 210 2010-12-18T19:46:13  *** jordonwii has joined #moin-dev
 211 2010-12-18T19:46:17  <jordonwii> moin
 212 2010-12-18T19:46:24  <dreimark> hi jordonwii
 213 2010-12-18T19:46:33  <jordonwii> Hi dreimark
 214 2010-12-18T19:47:03  <jordonwii> Can you tell me more about the issue you described in the task comments?
 215 2010-12-18T19:47:24  <dreimark> the comment of ronny?
 216 2010-12-18T19:47:27  <dreimark> ronny: ping
 217 2010-12-18T19:48:06  <dreimark> and mine was about that the ui does not change if you click on the quicklink
 218 2010-12-18T19:48:26  <dreimark> at the location of the chevront
 219 2010-12-18T19:48:28  <dreimark> -t
 220 2010-12-18T19:48:32  <jordonwii> What do you mean?
 221 2010-12-18T19:48:40  <jordonwii> How should the UI change?
 222 2010-12-18T19:48:46  <dreimark> if you have 20 quicklinks
 223 2010-12-18T19:48:59  <dreimark> and you show them by clicking on the chevron
 224 2010-12-18T19:49:21  <dreimark> then look waht happens if you click on the 4th, 5th, 6th etc
 225 2010-12-18T19:49:48  <jordonwii> I've got 7 quicklinks
 226 2010-12-18T19:50:05  <jordonwii> The quicklinks themselves work fine when I mouseover th chevron
 227 2010-12-18T19:50:06  * dreimark is commenting on a different task currently
 228 2010-12-18T19:50:20  <dreimark> can you pastebin your configs i try to make an image
 229 2010-12-18T19:50:51  <jordonwii> pastebin a patch?
 230 2010-12-18T19:51:27  <dreimark> you have a user_defaults var for setting up the quicklinks, but we can also use mine, i just need some minutes
 231 2010-12-18T19:51:34  <dreimark> to finish the review
 232 2010-12-18T19:51:45  <jordonwii> Ok -- I don't have user_defaults.
 233 2010-12-18T19:51:52  <jordonwii> I ended up just making quicklinks manually
 234 2010-12-18T19:52:17  <dreimark> oh, good to know it works - never thought ;)
 235 2010-12-18T19:52:50  <jordonwii> Hehe =p
 236 2010-12-18T20:01:24  <jordonwii> Also, dreimark: I'll make a patch after this task is done that moves the CSS from my first task to screen.css and puts semicolons in the JS from my second task
 237 2010-12-18T20:07:52  <ThomasWaldmann> ok, i split the footer redesign into 2 parts: first timings stuff redesign, then footer redesign
 238 2010-12-18T20:08:39  <dreimark> jordonwii: http://paste.pocoo.org/show/306568/
 239 2010-12-18T20:08:58  <dreimark> this is my wikiconfig_local.py
 240 2010-12-18T20:09:24  <jordonwii> Where should I put that?
 241 2010-12-18T20:09:35  <dreimark> in the dir where moin and wikiconfig.py is
 242 2010-12-18T20:09:58  <dreimark> the wikiconfig.py imports it
 243 2010-12-18T20:10:15  <dreimark> this saves us for doint unwanted commits if we need to try something
 244 2010-12-18T20:10:26  <dreimark> (we don't need to do it in wikiconfig.py)
 245 2010-12-18T20:10:59  <jordonwii> Ok, I'll test that quick
 246 2010-12-18T20:11:07  <dreimark> don't be logged in
 247 2010-12-18T20:11:22  <dreimark> at bild5 is the chevron for me
 248 2010-12-18T20:12:45  <ThomasWaldmann> http://moinmo.in/EasyToDo/reimplement%20timings%20display%20using%20logging see benefits if there are still doubts
 249 2010-12-18T20:12:57  <ThomasWaldmann> i think this one is ready for publishing^^
 250 2010-12-18T20:13:06  <dreimark> mom
 251 2010-12-18T20:13:15  <ThomasWaldmann> as well as the translation related ones
 252 2010-12-18T20:14:08  *** m4k3r has joined #moin-dev
 253 2010-12-18T20:14:36  <dreimark> ThomasWaldmann: diofeher was asking for being added to tasks too
 254 2010-12-18T20:14:54  <ThomasWaldmann> as mentor?
 255 2010-12-18T20:15:08  <dreimark> yes, i've not checked if he is on the list
 256 2010-12-18T20:15:14  <jordonwii> dreimark: Hmm, I still don't see an issue; Do you mean that clicking a quicklink should cause the quicklinks to collapse?
 257 2010-12-18T20:15:33  <dreimark> yes, and it does not if you click on bild5
 258 2010-12-18T20:15:39  <jordonwii> Ok
 259 2010-12-18T20:16:23  <dreimark> all the others collapses it
 260 2010-12-18T20:16:28  <ThomasWaldmann> dreimark: he is mentor
 261 2010-12-18T20:16:35  <ThomasWaldmann> ok, I'll add him
 262 2010-12-18T20:16:53  <dreimark> jordonwii: there can be two solutions.
 263 2010-12-18T20:17:04  <dreimark> a) don't collapse if clicked
 264 2010-12-18T20:17:11  <dreimark> b) collapse
 265 2010-12-18T20:17:20  <dreimark> I just want it consistant
 266 2010-12-18T20:17:49  <jordonwii> Ok...I don't see the quicklinks collapsing anywhere
 267 2010-12-18T20:17:54  <jordonwii> Hmm
 268 2010-12-18T20:18:05  <jordonwii> Ah, strike that
 269 2010-12-18T20:19:28  <dreimark> a) may be better if you want to open more than one
 270 2010-12-18T20:19:40  <dreimark> so it only collapse if you leave the region
 271 2010-12-18T20:20:00  <jordonwii> Do you know if jQuery has a function where you can make it so that a function's "this" is a particular variable?
 272 2010-12-18T20:20:40  <dreimark> sorry I don't
 273 2010-12-18T20:20:59  <jordonwii> I'm used to MooTools, and in that you can say:
 274 2010-12-18T20:21:04  *** greg_f has quit IRC
 275 2010-12-18T20:21:07  <jordonwii> somefunction.bind(myvar)
 276 2010-12-18T20:21:18  <jordonwii> And if you call somefunction, 'this' is always going to be somevar
 277 2010-12-18T20:21:28  <jordonwii> ~myvar
 278 2010-12-18T20:21:52  <dreimark> http://api.jquery.com/bind/
 279 2010-12-18T20:22:34  <dreimark> not sure if that is identical
 280 2010-12-18T20:23:22  <jordonwii> That looks like it's for events
 281 2010-12-18T20:24:05  <jordonwii> Anyway, I'll make it so that the quicklinks only collapse on mouseleave of the header
 282 2010-12-18T20:24:12  <dreimark> :)
 283 2010-12-18T20:25:34  <jordonwii> Found it, I think:
 284 2010-12-18T20:25:35  <jordonwii> https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Function/apply
 285 2010-12-18T20:25:45  <jordonwii> Looks like it's native to javascript
 286 2010-12-18T20:26:16  <ThomasWaldmann> http://moinmo.in/EasyToDo 5+ tasks ready for shooting
 287 2010-12-18T20:26:48  * dreimark looks
 288 2010-12-18T20:33:09  <dreimark> ThomasWaldmann: ok
 289 2010-12-18T20:39:53  <jordonwii> dreimark:  It looks like the only reason Bild5 stays open when the page changes is because the mouse is over the chevron, and so if it moves it all, then a mouseover is registered and the links expand
 290 2010-12-18T20:43:43  <jordonwii> There isn't much I can do about that without some kind of hack
 291 2010-12-18T20:43:57  <dreimark> ok
 292 2010-12-18T20:44:07  <dreimark> ThomasWaldmann: ^^
 293 2010-12-18T20:45:46  <ThomasWaldmann> ok, new tasks published
 294 2010-12-18T20:46:42  <dreimark> ThomasWaldmann: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970526
 295 2010-12-18T20:47:35  <dreimark> config http://paste.pocoo.org/show/306568/
 296 2010-12-18T20:47:50  <dreimark> the question is if we are lucky with the current behaviour
 297 2010-12-18T20:49:14  <dreimark> s/lucky/happy/
 298 2010-12-18T20:50:38  *** Roboraider has joined #moin-dev
 299 2010-12-18T20:54:18  <Roboraider> I'm looking to solve the find a failing test, fix a failing test task.  Would this failing test qualify? http://paste.pocoo.org/show/306583/
 300 2010-12-18T20:56:14  <ThomasWaldmann> Roboraider: this is likely an easy one. are there other serialization tests also failing?
 301 2010-12-18T20:57:54  <ThomasWaldmann> i just looked, there are 3 very similar fails
 302 2010-12-18T20:58:14  <ThomasWaldmann> likely only the strings need checking (and whether tests is at fault or code)
 303 2010-12-18T20:58:41  <Roboraider> Do you have any suggestions/recommendations?
 304 2010-12-18T20:58:50  <ThomasWaldmann> for?
 305 2010-12-18T20:59:13  <Roboraider> for a suitable failing test to solve
 306 2010-12-18T20:59:18  <ThomasWaldmann> Roboraider: does xpath tell you something?
 307 2010-12-18T21:00:46  <Roboraider> I'm not quite familiar with xpath
 308 2010-12-18T21:01:42  <jordonwii> dreimark: What should I do?
 309 2010-12-18T21:03:26  *** rfw has joined #moin-dev
 310 2010-12-18T21:03:28  *** rfw has joined #moin-dev
 311 2010-12-18T21:05:01  <ThomasWaldmann> Roboraider: fixing the mediawiki_in failures?
 312 2010-12-18T21:06:48  <ThomasWaldmann> are you rather looking for something easy, medium or difficult?
 313 2010-12-18T21:07:46  *** Roboraider has left #moin-dev
 314 2010-12-18T21:12:30  <ThomasWaldmann> dreimark: i don't think i can help much with js stuff
 315 2010-12-18T21:13:24  *** Roboraider has joined #moin-dev
 316 2010-12-18T21:13:36  <Roboraider> sorry.  My computer crashed
 317 2010-12-18T21:13:54  <Roboraider> I'm looking for easy-medium failing tests
 318 2010-12-18T21:14:37  <ThomasWaldmann> of course it is a bit hard to tell in advance, but the mediawiki stuff could be easy
 319 2010-12-18T21:15:08  <ThomasWaldmann> pity that we can't change difficulty after publishing
 320 2010-12-18T21:15:38  <ThomasWaldmann> or have a crystal ball :D
 321 2010-12-18T21:18:31  <ThomasWaldmann> Roboraider: btw, your computer or windows? :)
 322 2010-12-18T21:19:09  <Roboraider> ubuntu 10.10
 323 2010-12-18T21:19:35  <Roboraider> i could close windows and minimize things, but I couldnt resize or move them
 324 2010-12-18T21:19:39  <Roboraider> or type
 325 2010-12-18T21:19:41  <Roboraider> :(
 326 2010-12-18T21:20:10  <Roboraider> ./pytest consumed all my ram :P
 327 2010-12-18T21:20:45  <ThomasWaldmann> strange
 328 2010-12-18T21:20:55  <ThomasWaldmann> you have swap available?
 329 2010-12-18T21:21:08  <Roboraider> I don't have any space for it
 330 2010-12-18T21:21:22  <Roboraider> , but I have 4gb of ram
 331 2010-12-18T21:21:59  <ThomasWaldmann> oh. is that reproducable that it eats all your ram? i also have 4gb and it works for me.
 332 2010-12-18T21:22:26  <ThomasWaldmann> btw, do you use pae kernel?
 333 2010-12-18T21:23:50  <ThomasWaldmann> moinwiki19 failure looks like rather easy
 334 2010-12-18T21:24:48  <ThomasWaldmann> should be fixed with similar moinwiki_in failure
 335 2010-12-18T21:25:10  <Roboraider> I'm looking at the moinwiki19 failure right now
 336 2010-12-18T21:26:17  <ThomasWaldmann> looks like someone changed code or test, but not the other thing
 337 2010-12-18T21:26:48  <ThomasWaldmann> so the most difficult of that might be finding out what is at fault
 338 2010-12-18T21:27:57  <Roboraider> I'm not sure if I'm running a PAE kernel
 339 2010-12-18T21:28:22  <ThomasWaldmann> uname -r
 340 2010-12-18T21:28:35  <ThomasWaldmann> 2.6.35-23-generic-pae
 341 2010-12-18T21:29:52  <Roboraider> 2.6.35-23-generic
 342 2010-12-18T21:30:11  <ThomasWaldmann> i have an easy and free ram upgrade for you :)
 343 2010-12-18T21:30:17  <Roboraider> :)
 344 2010-12-18T21:30:24  <dreimark> jordonwii: the other way around it is another toggle for closing the quicklinks
 345 2010-12-18T21:30:36  <ThomasWaldmann> look at what "top" displays now
 346 2010-12-18T21:30:45  <ThomasWaldmann> and after booting the pae kernel
 347 2010-12-18T21:31:02  <jordonwii> dreimark: Other than a mouseover?
 348 2010-12-18T21:31:12  <dreimark> yes
 349 2010-12-18T21:31:32  <dreimark> mom
 350 2010-12-18T21:31:35  <ThomasWaldmann> one could even store the state into the session
 351 2010-12-18T21:31:45  <dreimark> jordonwii: or mouseover on a different location
 352 2010-12-18T21:31:47  <jordonwii> "mom"?
 353 2010-12-18T21:31:51  <dreimark> moment
 354 2010-12-18T21:31:55  <jordonwii> K, lol
 355 2010-12-18T21:32:29  <jordonwii> i.e. icon at the end of the quicklinks that's a big 'X' or something?
 356 2010-12-18T21:32:32  <ThomasWaldmann> yeah, for english speaking people it rather sounds like calling your mom :)
 357 2010-12-18T21:32:47  <dreimark> jordonwii: or what thomas told storing it in the session
 358 2010-12-18T21:32:57  <jordonwii> ThomasWaldmann: Exactly what I was thinking lol
 359 2010-12-18T21:33:14  <ThomasWaldmann> might be a bit complicated, though, as it happens client side, but session is managed server side
 360 2010-12-18T21:33:29  <ThomasWaldmann> so not a requirement for this task
 361 2010-12-18T21:33:52  <jordonwii> What exactly would be stored in the session?
 362 2010-12-18T21:34:09  <ThomasWaldmann> the expanded/collapsed state of quicklinks?
 363 2010-12-18T21:34:43  <dreimark> i think we go first with the X and a # TODO for improving it
 364 2010-12-18T21:35:49  <jordonwii> I like that. If I have time (since I'm on winter break now), I could just use a cookie (as oppose to the actual Python session)
 365 2010-12-18T21:36:02  <jordonwii> But whatever you guys want ;)
 366 2010-12-18T21:36:16  <dreimark> we can add a improvement task :)
 367 2010-12-18T21:36:38  <jordonwii> Hehehe =)
 368 2010-12-18T21:39:34  <jordonwii> Actually, should it be an 'X' or a reverse chevron?
 369 2010-12-18T21:39:55  <dreimark> reverse chevron
 370 2010-12-18T21:40:04  <jordonwii> «
 371 2010-12-18T21:40:05  <jordonwii> Kk
 372 2010-12-18T21:46:37  <ThomasWaldmann> Roboraider: how much MB difference was it?
 373 2010-12-18T21:47:42  <ThomasWaldmann> many*
 374 2010-12-18T21:49:27  *** Roboraider has quit IRC
 375 2010-12-18T21:51:13  <ThomasWaldmann> dreimark: easy: write a convertor for a draw item (twikidraw, anywikidraw, svg-edit)
 376 2010-12-18T21:51:27  <ThomasWaldmann> not sure that this is still easy
 377 2010-12-18T21:53:50  <dreimark> increased to medium, the question is if one makes all three
 378 2010-12-18T21:54:17  <dreimark> or after the first is done the others are quite similar and easier
 379 2010-12-18T21:54:23  <ThomasWaldmann> would make sense, but definitely more work then
 380 2010-12-18T21:54:42  <ThomasWaldmann> ...if the same guy gets them
 381 2010-12-18T21:55:16  * dreimark remembers wanted and orphaned
 382 2010-12-18T21:59:05  <dreimark> i think i add another idea for http://test.moinmo.in:8080/svgedit too
 383 2010-12-18T21:59:44  <jordonwii> dreimark: Should the quicklinks be collapsed on mouseover or click of the reverse chevron?
 384 2010-12-18T21:59:47  <dreimark> may be one of the students knows a way to redirect correctly after saving
 385 2010-12-18T22:00:50  <dreimark> jordonwii: for now on mouseover. i can't gurantee currently if i change my opinione after playing with it
 386 2010-12-18T22:00:56  *** rfw has quit IRC
 387 2010-12-18T22:00:59  <jordonwii> K
 388 2010-12-18T22:03:18  *** rfw has joined #moin-dev
 389 2010-12-18T22:03:18  *** rfw has joined #moin-dev
 390 2010-12-18T22:06:51  <jordonwii> Ok, I got something working.
 391 2010-12-18T22:06:57  <jordonwii> I'll upload the patch to Melange
 392 2010-12-18T22:08:10  <jordonwii> dreimark: ^^
 393 2010-12-18T22:08:33  * dreimark reloads
 394 2010-12-18T22:08:55  <jordonwii> Gah, Melange is giving me a "temporary blobstore error"
 395 2010-12-18T22:09:04  <jordonwii> mom
 396 2010-12-18T22:09:36  <jordonwii> There we go
 397 2010-12-18T22:09:57  <dreimark> recog. no change of state
 398 2010-12-18T22:10:17  <jordonwii> ?
 399 2010-12-18T22:10:18  <dreimark> oh if it is temporary it may vanish
 400 2010-12-18T22:10:41  <dreimark> i looked at your task and there was no state change
 401 2010-12-18T22:10:45  <jordonwii> it appears to be working now
 402 2010-12-18T22:10:54  <jordonwii> try now
 403 2010-12-18T22:13:31  <dreimark> please always a empty line before the next function
 404 2010-12-18T22:16:02  <jordonwii> Ok
 405 2010-12-18T22:16:47  <jordonwii> As a side note, this was the first time I've written a native JS "class" (not actually a class, but close enough)
 406 2010-12-18T22:18:36  <dreimark> unfortunately something did not work
 407 2010-12-18T22:18:44  <dreimark> i tried with the example
 408 2010-12-18T22:18:50  <dreimark> and it did not expand
 409 2010-12-18T22:21:39  <dreimark> jordonwii: http://moinmo.in/ReimarBauer?action=AttachFile&do=view&target=quicklinks3.png
 410 2010-12-18T22:22:04  <dreimark> ff 3.6.13
 411 2010-12-18T22:22:54  <dreimark> works in ff 4.0beta
 412 2010-12-18T22:23:59  <jordonwii> Hmm
 413 2010-12-18T22:24:01  <jordonwii> Ok
 414 2010-12-18T22:24:38  <jordonwii> Funny that a function in Mozilla's own MDC isn't actually part of the stable version of FF
 415 2010-12-18T22:25:57  <dreimark> yeah, but we need to look on other browser too
 416 2010-12-18T22:26:36  <dreimark> may be someone was too fast with updating
 417 2010-12-18T22:27:27  <jordonwii> So it's kind of a hack, ATM.  I'll fix that.
 418 2010-12-18T22:27:38  <dreimark> :)
 419 2010-12-18T22:28:46  <jordonwii> To access my "class"'s 'this' inside the event functions, I have to create a variable and set it equal to 'this' outside of the function
 420 2010-12-18T22:28:58  <jordonwii> ~functions
 421 2010-12-18T22:29:12  <jordonwii> Unless there's a better way to do it. =)
 422 2010-12-18T22:30:36  <jordonwii> Ok, I tested this one in FF
 423 2010-12-18T22:32:34  <jordonwii> dreimark: check Melange =)
 424 2010-12-18T22:33:56  * dreimark done
 425 2010-12-18T22:34:13  <dreimark> do you have looked at it with an other browser than ff?
 426 2010-12-18T22:35:17  <jordonwii> I do not have Windows on my computer (for testing IE)
 427 2010-12-18T22:36:31  <jordonwii> Konqueror works, however =)
 428 2010-12-18T22:36:55  <dreimark> i check opera
 429 2010-12-18T22:37:37  *** Kapace_ has joined #moin-dev
 430 2010-12-18T22:39:58  <Kapace_> hello
 431 2010-12-18T22:40:01  <Kapace_> another testfix html_in_out (mostly just updating class names etc) http://dpaste.com/288133/
 432 2010-12-18T22:41:01  <dreimark> jordonwii: opera works too
 433 2010-12-18T22:41:05  <jordonwii> Sweet =)
 434 2010-12-18T22:41:16  <jordonwii> Do you like the mouseover close?
 435 2010-12-18T22:41:36  <ThomasWaldmann> i tried the 21:09 diff from melange. should it work?
 436 2010-12-18T22:41:45  <ThomasWaldmann> nothing happens when i click on the >>
 437 2010-12-18T22:42:09  <jordonwii> ThomasWaldman: No... but the 21:30 should though
 438 2010-12-18T22:42:21  <ThomasWaldmann> ah, ok, seeing it
 439 2010-12-18T22:43:19  <jordonwii> I'm going to have to leave here in about 5 minutes
 440 2010-12-18T22:45:37  <dreimark> ThomasWaldmann: it works for you too ?
 441 2010-12-18T22:46:02  <ThomasWaldmann> works for ff3613
 442 2010-12-18T22:46:36  <dreimark> opera and konqueror is also tested
 443 2010-12-18T22:47:17  <dreimark> also ff40b
 444 2010-12-18T22:48:00  <dreimark> any wishes left - otherwise i think the task is done
 445 2010-12-18T22:48:07  <jordonwii> =D
 446 2010-12-18T22:48:23  <ThomasWaldmann> chromium also ok
 447 2010-12-18T22:48:55  <ThomasWaldmann> could we have some more like >> and <<
 448 2010-12-18T22:49:05  <jordonwii> ?
 449 2010-12-18T22:49:10  <ThomasWaldmann> that symbol almost looks like (( )) for small font
 450 2010-12-18T22:51:20  <dreimark> making it better visible - yes
 451 2010-12-18T22:51:23  <dreimark> jordonwii: ^
 452 2010-12-18T22:51:32  <jordonwii> It's this symbol: http://www.fileformat.info/info/unicode/char/27eb/browsertest.htm
 453 2010-12-18T22:51:43  <jordonwii> I could make the font size bigger
 454 2010-12-18T22:51:56  <ThomasWaldmann> and chevron sounds more like a car or gas :)
 455 2010-12-18T22:52:29  <ThomasWaldmann> jordonwii: font size should be same as the other stuff there
 456 2010-12-18T22:52:39  <jordonwii> Heh
 457 2010-12-18T22:52:49  <jordonwii> Ok, so should I change the symbol?
 458 2010-12-18T22:53:04  <dreimark> font size should not be changed on multiline this breaks the formatting
 459 2010-12-18T22:53:27  <dreimark> damn i have not all bookmarks on that notebook
 460 2010-12-18T22:53:40  *** maker__ has joined #moin-dev
 461 2010-12-18T22:53:44  <dreimark> where is that url with all unicode chars
 462 2010-12-18T22:54:21  <jordonwii> Here's one: http://www.smartvisit.com/tech/characters.htm
 463 2010-12-18T22:54:41  <ThomasWaldmann> + and - ? :)
 464 2010-12-18T22:55:37  <ThomasWaldmann> that chevron there looks different somehow
 465 2010-12-18T22:55:46  *** m4k3r has quit IRC
 466 2010-12-18T22:55:58  <jordonwii> It is...slightly
 467 2010-12-18T22:56:10  <ThomasWaldmann> < >
 468 2010-12-18T22:56:27  <jordonwii> It's tinier =p
 469 2010-12-18T22:56:42  <ThomasWaldmann> [ + ]
 470 2010-12-18T22:56:46  <ThomasWaldmann> [ - ]
 471 2010-12-18T22:56:51  <jordonwii> K
 472 2010-12-18T22:57:11  <jordonwii> That looks pretty good...it's still rather small
 473 2010-12-18T22:58:20  <jordonwii> I have to go though
 474 2010-12-18T22:58:33  <ThomasWaldmann> [ +++ ]
 475 2010-12-18T22:58:49  <ThomasWaldmann> ok, thanks so far :)
 476 2010-12-18T22:59:20  <jordonwii> I'll upload the plus version to Melange quick
 477 2010-12-18T22:59:49  <jordonwii> Thanks for staying on.  I might actually get this done before the deadline this time =D
 478 2010-12-18T23:00:17  <ThomasWaldmann> hmm, new idea :)
 479 2010-12-18T23:00:34  <ThomasWaldmann> can you detect how much would fit on screen width?
 480 2010-12-18T23:01:17  <jordonwii> I was thinking of that when I started.  I'll be back in about an hour or so. =)
 481 2010-12-18T23:02:59  <ThomasWaldmann> ok, cu
 482 2010-12-18T23:08:02  <ThomasWaldmann> hmm, too much stuff named *chevron*
 483 2010-12-18T23:13:54  <xorAxAx> s/vron/vrolet/
 484 2010-12-18T23:14:08  *** m4k3r has joined #moin-dev
 485 2010-12-18T23:15:21  <Kapace_> ThomasWaldmann: http://dpaste.com/288133/ what do you think?
 486 2010-12-18T23:15:51  *** maker__ has quit IRC
 487 2010-12-18T23:16:14  <ThomasWaldmann> xorAxAx: oil company
 488 2010-12-18T23:16:20  <xorAxAx> yes
 489 2010-12-18T23:16:58  <ThomasWaldmann> jordonwii: also please check code formatting, esp. remove too many empty lines
 490 2010-12-18T23:18:49  <ThomasWaldmann> Kapace_: you work on which task?
 491 2010-12-18T23:19:57  <Kapace_> oh, any of the easy test fixes
 492 2010-12-18T23:21:39  <ThomasWaldmann> Kapace_: that html-foo stuff, did you check where it comes from?
 493 2010-12-18T23:22:38  <Kapace_> like the abbr to span class='html-abbr'?
 494 2010-12-18T23:23:07  <ThomasWaldmann> yes
 495 2010-12-18T23:23:58  <Kapace_> no, I wasn't sure about that, I'll check the history see if that is correct
 496 2010-12-18T23:24:41  <ThomasWaldmann> if it is clear that the tests are what was broken (and not the code :), this is ok for an easy bugfix task
 497 2010-12-18T23:25:16  <Kapace_> ok
 498 2010-12-18T23:27:20  <ThomasWaldmann> you don't need to check the moin-foo stuff, that is known
 499 2010-12-18T23:27:24  <ThomasWaldmann> known good
 500 2010-12-18T23:32:03  <Kapace_> so how do you know if the converter output is correct or not?
 501 2010-12-18T23:34:45  <Kapace_> http://hg.moinmo.in/moin/2.0-dev/file/676b3d0ce770/MoinMoin/converter/html_in.py#l57 says that those tag should be inlined
 502 2010-12-18T23:38:11  <ThomasWaldmann> ah, ok
 503 2010-12-18T23:38:26  <ThomasWaldmann> ok, so i guess your fix is correct.
 504 2010-12-18T23:38:32  <ThomasWaldmann> was that all of that sort?
 505 2010-12-18T23:40:15  <Kapace_> yes, theres 5 of those in the same place test_span_html_element
 506 2010-12-18T23:40:20  <Kapace_> also, theres the last one
 507 2010-12-18T23:40:53  <Kapace_> which I'm not entirely sure of, but seems logical, the output just changed to include a wrapper div
 508 2010-12-18T23:45:15  <ThomasWaldmann> did you claim a task already?
 509 2010-12-18T23:45:24  <Kapace_> no not yet
 510 2010-12-18T23:46:31  <ThomasWaldmann> you can either submit for an easy one or, if you find more (different) stuff in that test file work on a medium one
 511 2010-12-18T23:47:25  <Kapace_> I need as many tasks as possible done, so I think I'll go for the easy one
 512 2010-12-18T23:48:06  <Kapace_> uh-oh, I've been staring at a stale task list... the easy one has been claimed
 513 2010-12-18T23:49:10  <ThomasWaldmann> i'll make another one, just a sec
 514 2010-12-18T23:49:35  <Kapace_> ok thanks
 515 2010-12-18T23:56:16  <ThomasWaldmann> look now

MoinMoin: MoinMoinChat/Logs/moin-dev/2010-12-18 (last edited 2010-12-17 23:45:03 by IrcLogImporter)