1 2010-12-22T00:15:09 *** Roboraider
2 2010-12-22T00:17:27 <jbills> TheSheep: http://pastebin.com/tXGXdK5Y I need to be able to do something like this for my code to work. any ideas on how to get it to work
3 2010-12-22T00:17:30 <jbills> ?
4 2010-12-22T00:24:48 <jbills> Anyone here
5 2010-12-22T00:31:06 <ThomasWaldmann> i am not sure it is understandable by that example code
6 2010-12-22T00:31:24 <ThomasWaldmann> but you could maybe try reading the parts of the jquery docs you need
7 2010-12-22T00:31:40 <jbills> I have tried.
8 2010-12-22T00:31:55 <ThomasWaldmann> i am not sure though how this is related to what we talked about
9 2010-12-22T00:32:31 <jbills> I can't do anything but have both tocs minimize at the same time
10 2010-12-22T00:32:48 <jbills> something like that would be required to do that
11 2010-12-22T00:33:55 <jbills> I am going back to my firstol code. you said u could live with tocs that minimized at the same time.
12 2010-12-22T00:36:36 <jbills> Can you test my patch which i submit
13 2010-12-22T00:36:44 <jbills> in a few
14 2010-12-22T00:36:49 <jbills> minutes
15 2010-12-22T00:37:57 <ThomasWaldmann> if you don't introduce regressions that were already gone, we can try :)
16 2010-12-22T00:38:19 <jbills> ok
17 2010-12-22T00:38:27 <jbills> thanks :)
18 2010-12-22T00:39:00 <jbills> I have been having a panic attack thinking that I would loose the task after all my work
19 2010-12-22T00:40:46 <ThomasWaldmann> cool down, this is not summer of code :)
20 2010-12-22T00:41:07 <jbills> http://pastebin.com/1NWAPeLR
21 2010-12-22T00:41:45 <jbills> hey 100 dollars are on the line.. more than my whole years allowance.
22 2010-12-22T00:47:15 <ThomasWaldmann> you didn't read the diff, right? :)
23 2010-12-22T00:47:18 <ThomasWaldmann> -div.table-of-contents {
24 2010-12-22T00:47:19 <ThomasWaldmann> +div.table-of-contents {
25 2010-12-22T00:47:30 <jbills> oops
26 2010-12-22T00:47:42 <jbills> how do u make a blush emoticon?
27 2010-12-22T00:47:49 * ThomasWaldmann should get 10 dollars per issue he finds :P
28 2010-12-22T00:48:02 <ThomasWaldmann> i would get RICH!!11
29 2010-12-22T00:48:07 <dreimark> hehe
30 2010-12-22T00:48:10 *** samt_gci
31 2010-12-22T00:48:22 <jbills> how do u make a blush emoticon?
32 2010-12-22T00:48:35 <dreimark> jbills: it is not blush it is ascii art
33 2010-12-22T00:48:39 <jbills> I skimmed
34 2010-12-22T00:48:45 <dreimark> a : and a )
35 2010-12-22T00:48:45 <jbills> the diff
36 2010-12-22T00:48:50 <dreimark> without the blanks
37 2010-12-22T00:49:10 <jbills> I no that
38 2010-12-22T00:49:32 <jbills> how do you make a blushing emoticon like in google talk?
39 2010-12-22T00:50:10 <ThomasWaldmann> no idea, but it doesn't work on irc if it requires non-ascii
40 2010-12-22T00:50:29 <jbills> ok :(
41 2010-12-22T00:50:31 <ThomasWaldmann> jbills: what's your localtime?
42 2010-12-22T00:50:39 <jbills> eastern us
43 2010-12-22T00:51:01 <ThomasWaldmann> 18:50?
44 2010-12-22T00:51:10 <jbills> sure
45 2010-12-22T00:51:25 <jbills> though my clock says 6:51
46 2010-12-22T00:52:14 <ThomasWaldmann> ok, we now close the task. you've done a major effort, but I guess we'll have to do some fine tuning. you win. :)
47 2010-12-22T00:52:52 <jbills> well I was going to post this http://pastebin.com/rnQ47JMT
48 2010-12-22T00:52:59 <jbills> but if you insist
49 2010-12-22T00:53:04 <ThomasWaldmann> ok, submit it to melange
50 2010-12-22T00:53:49 <jbills> k
51 2010-12-22T00:53:52 <ThomasWaldmann> next time, for whatever project you do a task, please use revision control
52 2010-12-22T00:54:16 <ThomasWaldmann> and work more systematically, fix one issue after another, continuously improving
53 2010-12-22T00:54:20 <jbills> ok *blushes*
54 2010-12-22T00:54:31 <jbills> ok
55 2010-12-22T00:54:36 <ThomasWaldmann> and do not submit stuff if you still have easy todo
56 2010-12-22T00:54:58 <ThomasWaldmann> if you get a hint "improve x", always check if you have more than one x
57 2010-12-22T00:55:21 <ThomasWaldmann> and read diffs (e.g. hg diff) before committing or submitting
58 2010-12-22T00:55:35 <ThomasWaldmann> that's improve quality and speed significantly
59 2010-12-22T00:55:39 <dreimark> the last pastebin removes again lines
60 2010-12-22T00:55:41 <ThomasWaldmann> *'ll
61 2010-12-22T00:55:54 <ThomasWaldmann> dreimark: I'll fix all those issues
62 2010-12-22T00:56:00 <dreimark> :)
63 2010-12-22T00:56:21 <ThomasWaldmann> it just takes too long and i guess jbills want to do something new also
64 2010-12-22T00:56:44 <dreimark> yeah sometimes it is better to make a break
65 2010-12-22T00:56:56 <dreimark> and be creative on something else
66 2010-12-22T00:57:41 <dreimark> s/make/take/
67 2010-12-22T00:57:45 <ThomasWaldmann> jbills: you know chess or some similar game?
68 2010-12-22T00:59:25 * dreimark likes wizard
69 2010-12-22T01:01:02 <dreimark> http://www.thehouseofcards.com/retail/wizard.html
70 2010-12-22T01:02:52 <samt_gci> hi, I'm making a gource video for the 2.0-dev repository, and I'm wondering if it's possible to find the date the repo was forked using Mercurial
71 2010-12-22T01:03:46 <samt_gci> I want to only render between now and when it was forked as per ThomasWaldmann's suggestion on the gci page
72 2010-12-22T01:11:38 <ronny> samt_gci: you could log all otgoing from the 2.x repo to the 1.9 repo maybe
73 2010-12-22T01:14:42 <ThomasWaldmann> samt_gci: maybe hg log both and find first difference
74 2010-12-22T01:15:38 <jbills> yes
75 2010-12-22T01:15:46 <jbills> I love chess
76 2010-12-22T01:16:48 <ThomasWaldmann> you always need to think in advance, what will happen next
77 2010-12-22T01:16:53 <dreimark> the
78 2010-12-22T01:17:16 <ThomasWaldmann> for coding, it is similar. if code is crap, it'll blow up or work badly, you loose. :)
79 2010-12-22T01:17:17 <dreimark> question what we define as start of moin-2.0
80 2010-12-22T01:17:28 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10174:93319cc6cc88 2.0-dev/MoinMoin/ (3 files in 3 dirs): condensing and expanding of headings for the TableOfContents (thanks to jbills, GCI 2010)
81 2010-12-22T01:17:35 <ThomasWaldmann> jbills: ^^
82 2010-12-22T01:17:59 <ThomasWaldmann> (I slightly changed spacing and added some ; )
83 2010-12-22T01:21:49 <dreimark> samt_gci: http://hg.moinmo.in/moin/2.0-dev/log?rev=Add+skeleton+for+html+output+converter
84 2010-12-22T01:22:07 <dreimark> just an idea if noone had a better one
85 2010-12-22T01:22:32 <samt_gci> ty dreimark
86 2010-12-22T01:23:23 <dreimark> if you find something by bastian a little bit older choose that date
87 2010-12-22T01:23:49 <dreimark> also you can look which date summer of code started in 2008
88 2010-12-22T01:23:55 <dreimark> and use that
89 2010-12-22T01:24:10 <samt_gci> ok, diffing the logs didn't yield anything unfortunately
90 2010-12-22T01:25:22 <dreimark> gn
91 2010-12-22T01:35:05 *** grzywacz
92 2010-12-22T01:35:28 *** samt_gci
93 2010-12-22T01:51:31 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10175:f6069da61f05 2.0-dev/MoinMoin/converter/html_out.py: toc generation: simplify code a bit by using less intermediates
94 2010-12-22T02:17:20 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10176:3fec36100caa 2.0-dev/MoinMoin/static/common/js/common.js: toc generation: simplify js code a bit, remove unused globals
95 2010-12-22T02:17:22 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10177:4a5e93557c56 2.0-dev/MoinMoin/ (converter/html_out.py static/common/js/common.js): toc: togglehead - remove unused args
96 2010-12-22T02:17:23 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10178:378f2bb3d7ca 2.0-dev/MoinMoin/converter/html_out.py: toc: remove unneeded counter and link class attr
97 2010-12-22T02:17:32 <ThomasWaldmann> jbills: ^^
98 2010-12-22T02:29:53 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10179:edcce33076c8 2.0-dev/MoinMoin/ (converter/html_out.py static/common/js/common.js): toc: remove unneeded firstOl class, just use ol child of table-of-contents class div
99 2010-12-22T02:49:59 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10180:6f4d7b45f799 2.0-dev/MoinMoin/ (3 files in 3 dirs): toc: use IDs where appropriate, remove unneeded css class
100 2010-12-22T02:50:05 <ThomasWaldmann> jbills: ^^
101 2010-12-22T03:25:55 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10181:0911d8017f69 2.0-dev/MoinMoin/ (converter/html_out.py static/common/js/common.js):
102 2010-12-22T03:25:55 <CIA-56> toc: vastly simplify code, see below
103 2010-12-22T03:25:55 <CIA-56> [+] and [-] was getting out of sync with state if the main toggle of the toc
104 2010-12-22T03:25:55 <CIA-56> was used. thus I abandoned those and just use [+] now (no [-]) for both expanding
105 2010-12-22T03:25:55 <CIA-56> and collapsing. code got much easier and could be inlined into the onclick attr.
106 2010-12-22T03:25:55 <CIA-56> because of not needing to update this, could remove some more unneeded ids/classes.
107 2010-12-22T05:14:26 *** kursor
108 2010-12-22T08:33:42 <dreimark> ThomasWaldmann: a + implies a -
109 2010-12-22T08:34:03 <dreimark> how is it to change it to a symbol like http://www.fileformat.info/info/unicode/char/262f/index.htm
110 2010-12-22T08:37:33 <dreimark> wp: "Yin yang are complementary opposites that interact within a greater whole, as part of a dynamic system"
111 2010-12-22T08:52:08 *** NikitaUtiu
112 2010-12-22T08:54:39 <NikitaUtiu> ThomasWaldmann: hi! should i also write a test for special cases like anchors and externals or do it in the same test?
113 2010-12-22T09:13:52 *** kursor
114 2010-12-22T09:18:59 *** Samm
115 2010-12-22T09:24:18 *** Samm_
116 2010-12-22T09:27:05 *** Samm
117 2010-12-22T09:40:58 <dreimark> NikitaUtiu: i prefer a separate test
118 2010-12-22T09:41:24 <dreimark> but i currently don't know how separate the code is
119 2010-12-22T09:42:11 <dreimark> i prefer it mostly for the case that one get more than one test failings at the same time
120 2010-12-22T09:43:25 <dreimark> it sometimes describes easier the situation of the problem
121 2010-12-22T09:44:17 <dreimark> if everything is in one test you just get the result of the first one in the line failing
122 2010-12-22T09:56:36 <NikitaUtiu> dreimark:it's pretty much the same code
123 2010-12-22T09:59:15 <NikitaUtiu> but can't you see what assertion failed when you run the test ?
124 2010-12-22T10:19:00 *** rfw
125 2010-12-22T10:32:16 *** kursor
126 2010-12-22T10:34:17 *** Samm_
127 2010-12-22T10:36:46 *** Samm
128 2010-12-22T10:40:04 *** kursor
129 2010-12-22T10:43:39 *** gwork
130 2010-12-22T10:44:52 *** kursor
131 2010-12-22T11:01:39 *** Samm
132 2010-12-22T11:06:34 *** greg_f
133 2010-12-22T12:02:56 <ThomasWaldmann> moin
134 2010-12-22T12:14:31 * ThomasWaldmann upgrade the wiki farm to 1.9.current
135 2010-12-22T12:24:51 *** skylamer`
136 2010-12-22T12:27:40 <NikitaUtiu> ThomasWaldmann: i think i found a bug in the code you told me to cleanup
137 2010-12-22T12:28:07 <NikitaUtiu> ThomasWaldmann: *deduplicate
138 2010-12-22T12:35:31 <ThomasWaldmann> yes?
139 2010-12-22T12:36:46 <ThomasWaldmann> show on paste.pocoo.org
140 2010-12-22T12:37:59 <NikitaUtiu> well i haven't fixed it yet
141 2010-12-22T12:38:32 <NikitaUtiu> that code is supposed to remove '/' and '..' from a path and convert it into a normal path
142 2010-12-22T12:39:04 <NikitaUtiu> and it converts .. only if it's the first thing in the path so
143 2010-12-22T12:39:32 <NikitaUtiu> ../../Home should be Home but it's current_page/../Home
144 2010-12-22T13:00:26 <ThomasWaldmann> ok, so i would suggest to, for this task, just do code-deduplication
145 2010-12-22T13:01:43 <ThomasWaldmann> and maybe put a comment there, like # XXX BUG ../../foo gets currentitem/../foo
146 2010-12-22T13:02:02 <ThomasWaldmann> you can claim another bugfix task for fixing it then
147 2010-12-22T13:03:15 <ThomasWaldmann> NikitaUtiu:
148 2010-12-22T13:03:20 <ThomasWaldmann> brb
149 2010-12-22T13:03:34 <NikitaUtiu> ok
150 2010-12-22T13:18:53 <ThomasWaldmann> and in that bugfix task, you'ld also add a test for that
151 2010-12-22T13:22:48 <NikitaUtiu> ok
152 2010-12-22T13:23:27 <ThomasWaldmann> btw, some code for making relative names to absolute ones exists since long
153 2010-12-22T13:23:41 <ThomasWaldmann> maybe it can be reused or refactored
154 2010-12-22T13:24:44 <NikitaUtiu> where is it?
155 2010-12-22T13:25:25 <ThomasWaldmann> in 1.9 it used to be in wikiutil
156 2010-12-22T13:25:38 <ThomasWaldmann> in moin2, you need to look around
157 2010-12-22T13:26:22 <ThomasWaldmann> abs rel absolute relative page/item name or so :)
158 2010-12-22T13:29:53 <NikitaUtiu> AbsItemName ?
159 2010-12-22T13:30:18 <ThomasWaldmann> yeah
160 2010-12-22T13:31:14 <ThomasWaldmann> it operates on strings / names, though. not iri path.
161 2010-12-22T13:32:18 <NikitaUtiu> brb
162 2010-12-22T13:44:00 <ThomasWaldmann> diofeher: dreimark: ronny: xorAxAx: waldi: valeuf: can you help on identifying some medium / difficult tasks (see EasyToDo and elsewhere) until the xmas vacations begin?
163 2010-12-22T13:44:26 <ronny> ThomasWaldmann: will take a look later this afternoon
164 2010-12-22T13:44:31 <ThomasWaldmann> valeuf: maybe you could make a medium or difficult task from the packaging stuff you have begun 6m ago
165 2010-12-22T13:56:29 <dreimark> ThomasWaldmann: sure
166 2010-12-22T14:01:59 <ThomasWaldmann> Officially, the panel is called the WikiLeaks Task Force. But at CIA headquarters, it's mainly known by its all-too-apt acronym: W.T.F.
167 2010-12-22T14:44:07 <NikitaUtiu> ThomasWaldmann: i fixed the bug. should i write a unit test for it?
168 2010-12-22T14:46:48 <xorAxAx> NikitaUtiu: you should have written it first :)
169 2010-12-22T14:47:37 <NikitaUtiu> xorAxAx: well i know, i kinda forgot to :) , should it be separate than the other test?
170 2010-12-22T14:47:50 <xorAxAx> NikitaUtiu: makes sense
171 2010-12-22T14:47:56 <NikitaUtiu> ok
172 2010-12-22T14:57:17 <NikitaUtiu> is duplicated code a problem in unit tests ?
173 2010-12-22T14:58:01 <xorAxAx> less than in normal code, but still a problem
174 2010-12-22T15:02:15 <NikitaUtiu> only the methods with the prefix 'test' are run as tests ?
175 2010-12-22T15:02:30 <xorAxAx> yes
176 2010-12-22T15:26:52 *** m4k3r
177 2010-12-22T15:29:58 <NikitaUtiu> wrote the unit test
178 2010-12-22T15:30:18 <NikitaUtiu> http://pastebin.com/d4VURMBA this is the diff
179 2010-12-22T15:47:30 <ThomasWaldmann> NikitaUtiu: maybe use u"..." for item names
180 2010-12-22T15:49:02 <ThomasWaldmann> NikitaUtiu: you are double sorting some stuff
181 2010-12-22T15:50:01 <ThomasWaldmann> maybe do the sorted() call in 35/36 not in the asserts in 40/41
182 2010-12-22T15:56:53 <NikitaUtiu> http://pastebin.com/rJCt87Bk removed the double sorted and used unicode
183 2010-12-22T15:58:54 <ThomasWaldmann> NikitaUtiu: why are you using .quoted?
184 2010-12-22T15:59:09 <ThomasWaldmann> s/page/item/g
185 2010-12-22T15:59:37 <NikitaUtiu> to get the path as a string
186 2010-12-22T16:00:12 <ThomasWaldmann> try it with Hänsel&Gretel :)
187 2010-12-22T16:00:27 <ThomasWaldmann> and see if you get the string you expect
188 2010-12-22T16:00:58 <ThomasWaldmann> btw, you want to do that all within your current task?
189 2010-12-22T16:02:43 <NikitaUtiu> isn't it part of the task ?
190 2010-12-22T16:03:00 <ThomasWaldmann> add docstring elements to absolute_path specifying argument types, meaning and return type and meaning
191 2010-12-22T16:03:12 <ThomasWaldmann> i told you to do the fixing in the next task :)
192 2010-12-22T16:03:28 <ThomasWaldmann> that the path code was broken was not your fault :)
193 2010-12-22T16:03:43 *** gwork
194 2010-12-22T16:03:58 <NikitaUtiu> ok, btw i get some weird characters for the a with umlaut
195 2010-12-22T16:04:09 <ThomasWaldmann> but now, as you've done it anyway, we'll make sure your next task is quick :)
196 2010-12-22T16:04:23 <ThomasWaldmann> %xx ?
197 2010-12-22T16:04:50 <NikitaUtiu> u'H\xe4nsel&Gretel'
198 2010-12-22T16:05:01 <ThomasWaldmann> that's perfect
199 2010-12-22T16:05:14 <NikitaUtiu> so the quoted works
200 2010-12-22T16:05:22 <ThomasWaldmann> \xe4 is the unicode char for ä
201 2010-12-22T16:05:28 <NikitaUtiu> oh.. ok
202 2010-12-22T16:06:36 <NikitaUtiu> should i use docstrings for all functions when i write them ?
203 2010-12-22T16:09:37 <ThomasWaldmann> yes
204 2010-12-22T16:09:56 <dreimark> always
205 2010-12-22T16:10:11 <dreimark> btw. look sometimes with pylint on your code
206 2010-12-22T16:10:18 <ThomasWaldmann> that avoids that other people use your stuff and will have to reverse engineer it first :)
207 2010-12-22T16:11:11 <NikitaUtiu> :) that would be a time waster
208 2010-12-22T16:12:39 *** m4k3r
209 2010-12-22T16:13:17 <dreimark> bbl
210 2010-12-22T16:19:54 *** m4k3r
211 2010-12-22T16:20:54 <NikitaUtiu> what about tests, should they be docstringed ?
212 2010-12-22T16:30:21 <ThomasWaldmann> if they are complicated, it does no harm
213 2010-12-22T16:30:43 <ThomasWaldmann> if they are somehow self explaining, it's not a must
214 2010-12-22T16:34:29 *** Samm
215 2010-12-22T16:46:43 <NikitaUtiu> http://pastebin.com/ZKqYA8Ge this is the new one, docstringed the functions
216 2010-12-22T16:50:53 <ThomasWaldmann> btw, you maybe could also try to make that xml more readable
217 2010-12-22T16:51:05 <ThomasWaldmann> e.g. by using a multiline string
218 2010-12-22T16:51:10 <ThomasWaldmann> """foo
219 2010-12-22T16:51:13 <ThomasWaldmann> bar
220 2010-12-22T16:51:17 <ThomasWaldmann> baz
221 2010-12-22T16:51:18 <ThomasWaldmann> """
222 2010-12-22T16:52:23 <ThomasWaldmann> for absolute_path: @return ...
223 2010-12-22T16:53:17 <NikitaUtiu> oh...
224 2010-12-22T16:53:27 <NikitaUtiu> forgot about it
225 2010-12-22T17:09:45 <NikitaUtiu> http://pastebin.com/6Bdb03we done!
226 2010-12-22T17:20:00 <ThomasWaldmann> patch unexpectedly ends in middle of line
227 2010-12-22T17:20:25 <ThomasWaldmann> could you somehow upgrade your tools or use another pastebin, so this doesn't happen all the time?
228 2010-12-22T17:29:24 <NikitaUtiu> ThomasWaldmann: http://paste.pocoo.org/show/308444/ maybe this one
229 2010-12-22T17:30:28 <ThomasWaldmann> NikitaUtiu: i get a lot of failures in test_link
230 2010-12-22T17:30:41 <ThomasWaldmann> due to the name change of the methods
231 2010-12-22T17:31:20 <ThomasWaldmann> please run the complete test_link and test_sourcecode before next submission / pastebin
232 2010-12-22T17:31:33 <NikitaUtiu> ok
233 2010-12-22T17:33:59 <NikitaUtiu> the test_sourcecode didn't fail but the other one does
234 2010-12-22T17:44:50 <ThomasWaldmann> that was just for the case :)
235 2010-12-22T17:48:33 <NikitaUtiu> gotta rename all method calls
236 2010-12-22T17:50:19 <ThomasWaldmann> use some automated search
237 2010-12-22T17:55:29 <NikitaUtiu> strange, testRelativeItems passes when i run it but fails when i run test_link
238 2010-12-22T17:55:44 <dreimark> NikitaUtiu: then something changes the state
239 2010-12-22T18:00:17 <NikitaUtiu> had the failures in the moinwiki_in_out test been there before i started or am i causing them ?
240 2010-12-22T18:05:00 <dreimark> if you try it in a clone without your patch your know
241 2010-12-22T18:05:08 <dreimark> i usually have several clones
242 2010-12-22T18:05:18 <dreimark> one which is the master from hg
243 2010-12-22T18:05:30 <dreimark> and then some which are a clone from that
244 2010-12-22T18:09:19 <NikitaUtiu> i also found out that the converter base cannot be reused
245 2010-12-22T18:10:03 <NikitaUtiu> that caused the failure, it just appends items to the set even if it's a new call
246 2010-12-22T18:14:53 *** kursor
247 2010-12-22T18:15:19 *** kursor
248 2010-12-22T18:19:25 *** kursor
249 2010-12-22T18:19:38 *** kursor
250 2010-12-22T18:21:45 *** m4k3r
251 2010-12-22T18:21:50 *** grzywacz
252 2010-12-22T18:21:50 *** grzywacz
253 2010-12-22T18:25:47 *** kursor
254 2010-12-22T18:26:56 <NikitaUtiu> i noticed it and i think it's a bug
255 2010-12-22T18:28:59 *** kursor
256 2010-12-22T18:35:15 *** kursor
257 2010-12-22T18:35:22 *** kursor
258 2010-12-22T18:49:14 * ThomasWaldmann must go, bbl
259 2010-12-22T18:54:21 *** kursor_
260 2010-12-22T18:54:50 *** kursor
261 2010-12-22T18:57:50 <NikitaUtiu> ThomasWaldmann: nvm, i fixed the problem, ConverterItemRefs can now be called repeatedly without any problems
262 2010-12-22T18:58:30 *** kursor_
263 2010-12-22T18:58:37 *** kursor
264 2010-12-22T19:06:37 *** kursor_
265 2010-12-22T19:06:55 *** kursor
266 2010-12-22T19:10:39 *** kursor
267 2010-12-22T19:11:05 *** kursor_
268 2010-12-22T19:25:27 *** greg_f
269 2010-12-22T19:28:15 <ThomasWaldmann> NikitaUtiu: submit something when you are ready, i maybe can have a look later today
270 2010-12-22T19:28:22 * ThomasWaldmann runs :)
271 2010-12-22T19:28:31 *** kursor_
272 2010-12-22T19:28:59 *** kursor
273 2010-12-22T19:28:59 *** kursor_
274 2010-12-22T19:29:06 <NikitaUtiu> ThomasWaldmann: new patch http://paste.pocoo.org/show/308518/ , it also fixes the thing with converterbase
275 2010-12-22T19:36:59 *** kursor
276 2010-12-22T19:37:14 *** kursor
277 2010-12-22T19:37:44 <dreimark> NikitaUtiu: why do you sort, isn't it a set?
278 2010-12-22T19:38:14 <NikitaUtiu> dreimark: which one?
279 2010-12-22T19:38:55 <dreimark> sorry i was wrong, it is a set which is converted to a list
280 2010-12-22T19:41:01 <dreimark> but that also means you can use it as set
281 2010-12-22T19:41:18 <dreimark> and don't need to sort
282 2010-12-22T19:42:22 *** kursor
283 2010-12-22T19:42:37 <NikitaUtiu> i didn't want to do that so that if someone else writes another converter, it fails if he has duplicated items
284 2010-12-22T19:43:04 <dreimark> you can't get duplicated items, because of set
285 2010-12-22T19:44:00 <NikitaUtiu> i know 'I' use a set, but what if someone else doesn't
286 2010-12-22T19:44:37 <dreimark> the meta data lists are list(set) at least it was last time i looked at the code
287 2010-12-22T19:46:21 <NikitaUtiu> is the list converted to a set after the ConverterItemRefs?
288 2010-12-22T19:51:02 <dreimark> http://hg.moinmo.in/moin/2.0-dev/file/0911d8017f69/MoinMoin/converter/link.py#l179
289 2010-12-22T19:51:05 *** kapace__
290 2010-12-22T19:51:21 <dreimark> for links it is collected as set see http://hg.moinmo.in/moin/2.0-dev/file/0911d8017f69/MoinMoin/converter/link.py#l158
291 2010-12-22T19:51:32 <dreimark> and returned as a list
292 2010-12-22T19:51:52 <dreimark> so the wiki meta data on save has only unique items
293 2010-12-22T19:51:58 <dreimark> as list
294 2010-12-22T19:53:17 <NikitaUtiu> i'll fix it tomorrow, i gotta go
295 2010-12-22T19:53:18 <NikitaUtiu> by
296 2010-12-22T19:53:24 <dreimark> and if some borked process uses itemlinks with dubs then the next save of the item makes it unique again
297 2010-12-22T19:53:25 *** NikitaUtiu
298 2010-12-22T20:03:37 *** rfw
299 2010-12-22T20:14:38 <dreimark> bbl
300 2010-12-22T20:31:20 *** NikitaUtiu
301 2010-12-22T20:32:01 *** raignarok
302 2010-12-22T20:37:57 *** NikitaUtiu
303 2010-12-22T20:38:40 *** skylamer`
304 2010-12-22T21:42:52 *** m4k3r
305 2010-12-22T22:06:18 <dreimark> re
306 2010-12-22T22:08:11 *** jbarber
307 2010-12-22T22:08:26 *** jbarber
308 2010-12-22T22:36:58 *** Samm
309 2010-12-22T23:07:23 *** m4k3r
310 2010-12-22T23:57:49 *** raignarok
311
