MoinMoin: MoinMoinChat/Logs/moin-dev/2011-02-17

   1 2011-02-17T04:02:41  *** izibi has quit IRC
   2 2011-02-17T04:07:12  *** grzywacz has quit IRC
   3 2011-02-17T05:22:53  *** Marchael has joined #moin-dev
   4 2011-02-17T06:08:59  <Marchael> moin
   5 2011-02-17T06:09:57  <Marchael> http://paste.pocoo.org/show/340011/ After running pytest I fixed some issues with trailing whitespaces
   6 2011-02-17T07:26:38  *** Marchael has quit IRC
   7 2011-02-17T08:14:59  *** Marchael has joined #moin-dev
   8 2011-02-17T08:34:56  <ThomasWaldmann> moin
   9 2011-02-17T08:36:16  <ThomasWaldmann> Marchael: good, but the render_template calls are still formatted inconsistently, see what we talked yesterday
  10 2011-02-17T08:41:35  <CIA-65> Reimar Bauer <rb.proj AT googlemail DOT com> default * 546:ca0f831afd76 extensions/data/plugin/macro/DictColumns.py: DictColumns: mdl markup of multiple elements in table changed to enumeration
  11 2011-02-17T08:45:15  *** Marchael has quit IRC
  12 2011-02-17T08:49:38  *** Marchael has joined #moin-dev
  13 2011-02-17T08:52:15  <Marchael> sometimes I feel what understanding moin code much easier than doing a right commit :)
  14 2011-02-17T08:55:05  <Marchael> http://paste.pocoo.org/show/340117/
  15 2011-02-17T09:03:22  <ThomasWaldmann> why is item in line 23 at a different indentation than in line 24?
  16 2011-02-17T09:04:36  <ThomasWaldmann> why is ) in line 33 at a different indentation than in line 23?
  17 2011-02-17T09:04:52  <ThomasWaldmann> Marchael: this is what i mean and it is still wrong
  18 2011-02-17T09:05:24  <ThomasWaldmann> (at many places)
  19 2011-02-17T09:08:49  <dreimark> moin
  20 2011-02-17T09:09:04  <dreimark> Marchael: do you use python.vim which I mentioned yesterday?
  21 2011-02-17T09:12:27  <dreimark> please remove modifications of moin, pytest and quickinstall
  22 2011-02-17T09:14:29  <dreimark> applying the  patch shows http://paste.pocoo.org/show/340119/
  23 2011-02-17T09:15:31  <ThomasWaldmann> the patch seems defect in some respects.
  24 2011-02-17T09:16:15  <Marchael> hm, I don`t put my changes to moin, pytest and quickinstall to diff
  25 2011-02-17T09:16:20  <dreimark> ok, the python.vim syntax highlighter seems not to annoy for indenting in that case
  26 2011-02-17T09:16:52  <ThomasWaldmann> Marchael: just read your diff, esp. the lines with "diff -r"
  27 2011-02-17T09:17:36  <dreimark> Marchael: my fault, the browser had openen an older version too
  28 2011-02-17T09:18:10  <dreimark> I check again
  29 2011-02-17T09:19:27  <ThomasWaldmann> dreimark: no, the issues are there
  30 2011-02-17T09:19:41  <dreimark> seeing now too line 426
  31 2011-02-17T09:19:51  <dreimark> still broken
  32 2011-02-17T09:20:41  <dreimark> htg bbl
  33 2011-02-17T09:21:38  * Marchael failed strong
  34 2011-02-17T09:26:55  <Trip_> it seems to me that this change to kvstore.py is implied by that class's description, and by the error that this fixes:  http://paste.pocoo.org/show/340124/
  35 2011-02-17T09:28:25  <Trip_> although it's probably time that I go learn how to run the test cases to make sure...
  36 2011-02-17T09:32:51  <Trip_> I got winpdb working in the virtualenv, by the way. unfortunately, it was ridiculously difficult and I neglected to take good notes about the steps that worked.
  37 2011-02-17T09:33:00  <Trip_> but, it works, and seems nice
  38 2011-02-17T09:48:17  <Marchael> http://paste.pocoo.org/show/340130/
  39 2011-02-17T09:52:49  <ThomasWaldmann> Marchael: 344 check indentation
  40 2011-02-17T09:54:10  <ThomasWaldmann> other than that, formatting looks good now
  41 2011-02-17T09:54:50  <ThomasWaldmann> Marchael: are you working in a hg workdir?
  42 2011-02-17T09:57:33  <Marchael> http://paste.pocoo.org/show/340132/
  43 2011-02-17T09:57:42  <Marchael> ThomasWaldmann: yes
  44 2011-02-17T10:03:47  <ThomasWaldmann> did you set your name/email in .hgrc?
  45 2011-02-17T10:03:54  <Marchael> yes
  46 2011-02-17T10:04:30  <ThomasWaldmann> ok, I'll have a try with your code and maybe you can then commit it, soon :)
  47 2011-02-17T10:04:43  <ThomasWaldmann> did you try it yourself?
  48 2011-02-17T10:05:18  <Marchael> commit changes to repo?
  49 2011-02-17T10:06:04  <ThomasWaldmann> (you'll commit it locally, then export changeset or, if you have a bb repo, push it to your bb repo)
  50 2011-02-17T10:07:46  *** Trip_ has quit IRC
  51 2011-02-17T10:08:09  *** Trip_ has joined #moin-dev
  52 2011-02-17T10:09:33  *** Trip_ is now known as MattMaker_
  53 2011-02-17T10:10:05  <ThomasWaldmann> (with trying i meant to use all functionality modified by the patch, in case THAT was unclear)
  54 2011-02-17T10:15:17  *** MattMaker_ is now known as MattMaker
  55 2011-02-17T10:27:29  *** Marchael has quit IRC
  56 2011-02-17T11:05:15  *** greg_f has joined #moin-dev
  57 2011-02-17T13:44:22  *** Marchael has joined #moin-dev
  58 2011-02-17T14:49:55  *** RogerHaase has joined #moin-dev
  59 2011-02-17T14:53:58  *** moinBot has joined #moin-dev
  60 2011-02-17T15:41:31  <RogerHaase> ThomasWaldmann: Did you get my bitbucket pull request of several days ago?
  61 2011-02-17T15:42:24  <ThomasWaldmann> ehrm.
  62 2011-02-17T15:43:04  <ThomasWaldmann> not sure. did you succeed in merging the stuff now?
  63 2011-02-17T15:43:31  <RogerHaase> I merged last Saturday, or maybe Friday.
  64 2011-02-17T15:43:59  <ThomasWaldmann> ok
  65 2011-02-17T15:44:05  <ThomasWaldmann> and it worked? :)
  66 2011-02-17T15:45:57  <ThomasWaldmann> new functionality on the bb forks page
  67 2011-02-17T15:46:10  <ThomasWaldmann> it now can show changes between repos
  68 2011-02-17T15:46:42  <RogerHaase> There were 6 collisions. One was a duplicate fix, I backed off my TOC change, merged the other 4.  I ended with fewer test failures.  Per my manual tests, it works.
  69 2011-02-17T15:47:01  <ThomasWaldmann> ok, i pull :)
  70 2011-02-17T15:48:09  <ThomasWaldmann> fsck, gvimdiff jumping at me (merge tool not configured here :)
  71 2011-02-17T15:52:12  <ThomasWaldmann> and with pink on red / green on red colours %-)
  72 2011-02-17T15:56:52  <dreimark> famous colors
  73 2011-02-17T16:00:31  <RogerHaase> revert.html was one of the collisions.  Looks like my version has an unmatched <dd> </dl>.
  74 2011-02-17T16:00:45  <ThomasWaldmann> i removed the dd/dl
  75 2011-02-17T16:01:15  * ThomasWaldmann merged, just running py.test and a short manual test on it
  76 2011-02-17T16:02:54  <ThomasWaldmann> ehrm, foo(bar=baz) is correct
  77 2011-02-17T16:03:05  <ThomasWaldmann> no spaces for args
  78 2011-02-17T16:03:30  <ThomasWaldmann> did our checker complain about that?
  79 2011-02-17T16:03:46  <ThomasWaldmann> https://bitbucket.org/RogerHaase/moin-2.0-dev/changeset/c141f18e25f4
  80 2011-02-17T16:05:34  <ThomasWaldmann> nice, less test failures \o/
  81 2011-02-17T16:07:05  <RogerHaase> The output of pytest was less than useful.  I ended up running pep8.py and probably fixed complaints that were suppressed in pytest.py.
  82 2011-02-17T16:08:24  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10454:b089874e3fa0 2.0-dev/MoinMoin/ (3 files in 2 dirs): Add moin- prefix to TOC and separator (hr tag). Add line height support to separator. Float TOC to right. Move wiki parser CSS next to admonitions.
  83 2011-02-17T16:08:26  <ThomasWaldmann> ah, yeah, it does some wrong detections
  84 2011-02-17T16:08:28  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10455:10205c506be3 2.0-dev/MoinMoin/ (4 files in 2 dirs): add "standard" moin-form styling to copy, revert, and modify_applet templates
  85 2011-02-17T16:08:30  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10457:8a92f4ee7a51 2.0-dev/MoinMoin/ (3 files in 2 dirs): add styling for footnotes; fix crash on footnote placing -- but placing remains a todo
  86 2011-02-17T16:08:32  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10458:21e1bb7e1fd1 2.0-dev/ (91 files in 18 dirs): merge
  87 2011-02-17T16:08:33  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10459:a9b49669329b 2.0-dev/MoinMoin/converter/_tests/test_html_in_out.py: correct 6 failing tests by adding moin- classname prefix
  88 2011-02-17T16:08:35  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10460:da63d18a78b2 2.0-dev/docs/ (4 files in 3 dirs): merge
  89 2011-02-17T16:08:37  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10462:58540ded6c5c 2.0-dev/MoinMoin/converter/ (_tests/test_moinwiki_in.py moinwiki_in.py): fix and add tests for old style table markup; minor changes to error wording and style parameter; 1 test still broken
  90 2011-02-17T16:08:42  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10465:657764127229 2.0-dev/MoinMoin/ (13 files in 4 dirs): merge
  91 2011-02-17T16:08:45  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10467:eb7d04ad78e1 2.0-dev/MoinMoin/templates/base.html: merge
  92 2011-02-17T16:08:47  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10468:c141f18e25f4 2.0-dev/MoinMoin/converter/ (4 files in 2 dirs): pep8 corrections + fix import location of _
  93 2011-02-17T16:08:49  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10469:c9db7b26dcb0 2.0-dev/MoinMoin/ (templates/base.html themes/__init__.py): merge
  94 2011-02-17T16:08:50  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10453:ec74db3e4951 2.0-dev/MoinMoin/converter/ (html_out.py moinwiki_in.py): enhanced support for tables; added old style table markup and error messages
  95 2011-02-17T16:08:55  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10456:473911b70a95 2.0-dev/MoinMoin/ (converter/link.py themes/modernized/static/css/common.css): add support for icons inserted before external links -- www, mailto, attachment, interwiki, and action need more work
  96 2011-02-17T16:08:57  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10461:d77bd2434ae0 2.0-dev/MoinMoin/converter/ (6 files in 2 dirs): rework separator (hr tag) processing in convertors; correct and expand tests
  97 2011-02-17T16:08:59  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10463:d8864c4a5534 2.0-dev/MoinMoin/converter/_tests/test_moinwiki_in.py: fix broken test that checks syntax error handling within table
  98 2011-02-17T16:09:07  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10464:cb9802167737 2.0-dev/ (2186 files in 247 dirs): Merge
  99 2011-02-17T16:09:11  <CIA-65> Roger Haase <crosseyedpenguin@yahoo.com> default * 10466:64c48e901064 2.0-dev/ (4 files in 3 dirs): merge
 100 2011-02-17T16:09:13  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10470:ee8892b6a322 2.0-dev/MoinMoin/ (13 files in 4 dirs): merged Roger Haase's repo
 101 2011-02-17T16:09:27  <dreimark> ...
 102 2011-02-17T16:09:27  <ThomasWaldmann> RogerHaase: thanks a lot :)
 103 2011-02-17T16:09:35  <RogerHaase> yea :)
 104 2011-02-17T16:12:23  <RogerHaase> The change I backed off changed the TOC CSS to float right - I decided I should look at the TOC expand/contract first.  I still think the TOC is more functional if floated right.
 105 2011-02-17T16:13:25  <RogerHaase> The TOC also has a bunch of obsolete browser-specific CSS that should be replace by CSS3 equivalents.
 106 2011-02-17T16:13:48  <ThomasWaldmann> yeah, top right is maybe nicer. we just have to make sure it doesn't overlap content or disturb otherwise
 107 2011-02-17T16:14:09  <dreimark> that will be on rtl left or?
 108 2011-02-17T16:14:21  <ThomasWaldmann> dreimark: yeah, maybe :)
 109 2011-02-17T16:15:04  <ThomasWaldmann> hah, bitbucket bug. it now shows the new merge changeset as incoming changeset for ALL forks
 110 2011-02-17T16:18:02  <ThomasWaldmann> ok, i think we have now merged most stuff, except some unfinished stuff from ronny and some aborted work from some gci contributors
 111 2011-02-17T16:19:06  <ronny> ThomasWaldmann: i'll take a look at making my stuff more ready tommorow
 112 2011-02-17T16:19:12  <RogerHaase> dreimark:  If we use cssjanus for rtl languages, I think stuff floated right will be converted to float left by default.
 113 2011-02-17T16:19:32  * ThomasWaldmann updated/restarted the test wiki
 114 2011-02-17T16:20:08  <ThomasWaldmann> ronny: don't kill the tests :)
 115 2011-02-17T16:20:21  <ronny> ThomasWaldmann: i wont kill them
 116 2011-02-17T16:20:34  <ronny> but they might catch up some qualities of zombies :P
 117 2011-02-17T16:20:42  <ThomasWaldmann> hehe
 118 2011-02-17T16:21:10  * ThomasWaldmann watched "They live" yesterday. Old, but good. :)
 119 2011-02-17T16:22:51  <RogerHaase> The logon form has a problem:  http://paste.pocoo.org/show/340244/ -- the label class="optional" used to be class="required"
 120 2011-02-17T16:23:19  *** kasun has quit IRC
 121 2011-02-17T16:26:53  *** greg_f has quit IRC
 122 2011-02-17T16:27:15  <ThomasWaldmann> RogerHaase: maybe due to openid being possible now, too?
 123 2011-02-17T16:29:30  <RogerHaase> Yes, I think that change effected the class, but I haven't been able to determine why (or even find where the class is created).
 124 2011-02-17T16:30:30  <ThomasWaldmann> it is likely in the flatland jinja2 support macros in template/forms.html
 125 2011-02-17T16:31:14  <ThomasWaldmann> btw, what exactly is the "problem"?
 126 2011-02-17T16:35:53  <RogerHaase> If you want to highlight required fields on forms or build client side Javascript tests to verify required fields have data, then the class="required" is useful.
 127 2011-02-17T16:37:19  <ThomasWaldmann> sure, but they aren't required any more
 128 2011-02-17T16:37:57  <ThomasWaldmann> (practically some are required, but we don't know before which fields the user will use)
 129 2011-02-17T16:39:33  <dreimark> 29 failed, 2146 passed, 256 skipped, 3 xfailed, 4 xpassed, 2 error in 417.41 seconds
 130 2011-02-17T16:40:06  <RogerHaase> Ah, OK, one or the other is required.  My mistake, class="optional" is correct.
 131 2011-02-17T16:59:23  *** kasun has joined #moin-dev
 132 2011-02-17T17:04:22  <Marchael> How long usually my changes pushing to bb repo?
 133 2011-02-17T17:04:37  <Marchael> Im wairing for about 10 minutes
 134 2011-02-17T17:04:42  <Marchael> *waiting
 135 2011-02-17T17:09:07  <ThomasWaldmann> Marchael: pushing a small change usually should be a few seconds and for sure < 1 min
 136 2011-02-17T17:14:57  <eSyr> hehehe
 137 2011-02-17T17:15:25  <eSyr> it's hg, after merge rewinding can take up to 20 minutes or more on slow connection.
 138 2011-02-17T17:16:45  <ThomasWaldmann> ehrm, really? how slow is that slow? :D
 139 2011-02-17T17:17:03  <eSyr> (4096kbps down / 768 kbps up)
 140 2011-02-17T17:17:20  <ThomasWaldmann> my connection is not faster and i never have seen that
 141 2011-02-17T17:17:22  <Marchael> Im just afraid what my cathedral proxy quota ends while I pushing changes
 142 2011-02-17T17:17:53  <eSyr> ThomasWaldmann: because you always do the merge :)
 143 2011-02-17T17:18:34  <ThomasWaldmann> is it due to our big repo size or does it have other reasons?
 144 2011-02-17T17:19:14  <eSyr> (i mean commits such as http://hg.moinmo.in/moin/1.9/rev/80fb5c4ed169 )
 145 2011-02-17T17:19:30  *** greg_f has joined #moin-dev
 146 2011-02-17T17:19:46  <eSyr> (after them looks like hg transferring all the repo)
 147 2011-02-17T17:20:21  <ThomasWaldmann> hmm, sounds too strange
 148 2011-02-17T17:20:52  <eSyr> btw, may be this due to old local hg version.
 149 2011-02-17T17:21:00  <ThomasWaldmann> esp. since you have to pull and merge to not create multiple remote heads
 150 2011-02-17T17:21:24  <ThomasWaldmann> so when you are ready for push, it just transfers a few changesets + the merge changeset of yours
 151 2011-02-17T17:21:37  <eSyr> hm.
 152 2011-02-17T17:22:04  * ThomasWaldmann has hg 1.4.3 here
 153 2011-02-17T17:25:15  <ThomasWaldmann> and the server runs hg 1.2 X)
 154 2011-02-17T17:25:27  <eSyr> >_<"
 155 2011-02-17T17:25:30  <ThomasWaldmann> (server = hg.moinmo.in)
 156 2011-02-17T17:26:09  <ThomasWaldmann> soon 1.6.4 :)
 157 2011-02-17T17:30:12  <dreimark> ThomasWaldmann: oh
 158 2011-02-17T17:30:17  <dreimark> that can be a problem
 159 2011-02-17T17:30:31  <dreimark> there is some incompatibility
 160 2011-02-17T17:32:25  *** izibi has joined #moin-dev
 161 2011-02-17T17:32:47  <Marchael> ThomasWaldmann: I wont be able to create public repo on bb because my traffic quota is ended :(
 162 2011-02-17T17:34:42  <Marchael> and unfortunately I cant enlarge it
 163 2011-02-17T17:35:07  <Marchael> stupid proxy...
 164 2011-02-17T17:44:14  <ThomasWaldmann> dreimark: url?
 165 2011-02-17T17:44:53  <ThomasWaldmann> Marchael: you can export the changeset and put it on pastebin or email it to me
 166 2011-02-17T17:45:49  <Marchael> ok, I try
 167 2011-02-17T17:46:41  *** m4k3r has joined #moin-dev
 168 2011-02-17T17:49:40  <dreimark> ThomasWaldmann: forwarded to JörgBlank, because he asked me so solve committing problem on the server, but i can't remember the exact problem currently
 169 2011-02-17T17:50:11  <dreimark> but it was something like someone had committed with 1.4 into a 1.6 repo
 170 2011-02-17T17:50:31  *** Marchael has quit IRC
 171 2011-02-17T17:50:56  <dreimark> bbl
 172 2011-02-17T18:33:37  *** kasun has quit IRC
 173 2011-02-17T18:40:40  *** Marchael has joined #moin-dev
 174 2011-02-17T18:44:41  *** Marchael has quit IRC
 175 2011-02-17T18:56:12  <MattMaker> how long should running tests take? I started them last night and they are still running when I get up this morning...
 176 2011-02-17T18:59:39  *** Marchael has joined #moin-dev
 177 2011-02-17T19:08:33  *** Marchael has quit IRC
 178 2011-02-17T19:09:07  *** Marchael has joined #moin-dev
 179 2011-02-17T19:22:32  <ThomasWaldmann> MattMaker: 5 minutes? depends on speed of machine.
 180 2011-02-17T19:22:53  <MattMaker> ok, I must have done it wrong then :)
 181 2011-02-17T19:23:19  <ThomasWaldmann> usually one just enters the virtualenv and runs pytest:
 182 2011-02-17T19:23:27  <ThomasWaldmann> . env/bin/activate
 183 2011-02-17T19:23:31  <ThomasWaldmann> ./pytest
 184 2011-02-17T19:23:41  <MattMaker> that is what I did
 185 2011-02-17T19:23:56  <MattMaker> perhaps one test was stuck, or something
 186 2011-02-17T19:23:58  <ThomasWaldmann> your machine is what?
 187 2011-02-17T19:25:17  <MattMaker> an old server, here in my room. runs two wikis just fine, but nothing fancy
 188 2011-02-17T19:26:17  <ThomasWaldmann> that 5 mins referred to 2x1.2ghz/4gb/ssd
 189 2011-02-17T19:26:42  <MattMaker> oh, I bet I know what I did, I had it in debug mode, so it maybe was wasting a lot of cycles on debug output to stderr
 190 2011-02-17T19:27:17  <MattMaker> ok, definitely not having an SSD, this server : )
 191 2011-02-17T19:28:00  <ThomasWaldmann> it shouldn't take more than 2-3x longer on any current machine
 192 2011-02-17T19:29:16  <ThomasWaldmann> it should output something now and then btw.
 193 2011-02-17T19:47:12  *** greg_f has quit IRC
 194 2011-02-17T19:51:02  <MattMaker> I am still engaged in my adventures of trying to import my 1.9.3 wiki.
 195 2011-02-17T19:51:23  <ThomasWaldmann> bleeding edge :)
 196 2011-02-17T19:51:36  <eSyr> 1.9.3 is stable iirc
 197 2011-02-17T19:51:47  <MattMaker> the bleeding has been quite educational
 198 2011-02-17T19:51:47  <ThomasWaldmann> eSyr: he means into moin2
 199 2011-02-17T19:51:54  <eSyr> ah.
 200 2011-02-17T19:52:28  <ThomasWaldmann> MattMaker: did you try modifying fs19 so the rest finds what it expects?
 201 2011-02-17T19:53:38  * ThomasWaldmann tries moin2 on squeeze/apache2/modwsgi now
 202 2011-02-17T19:53:43  <MattMaker> ThomasWaldmann I tried either fixing, or papering over the errors at each step, and I got all the way to having my content in moin2, served by moin2, but without history
 203 2011-02-17T19:53:54  <ThomasWaldmann> (in preparation of moving moinmo.in to squeeze)
 204 2011-02-17T19:53:56  <MattMaker> so I am going back to step 1
 205 2011-02-17T19:54:16  <MattMaker> and trying, as you suggest, to fix fs19 first
 206 2011-02-17T19:54:55  <MattMaker> since that is clearly generating incorrect information in the xml, and moin2 probably shouldn't have to deal with that.
 207 2011-02-17T19:54:57  <ThomasWaldmann> apropos history: i recently stumbled over mtime stuff. like it is maybe not in the xml, but should be.
 208 2011-02-17T19:55:26  <MattMaker> uh oh
 209 2011-02-17T19:55:28  <ThomasWaldmann> so if one imports the xml, all revisions / history look like from now
 210 2011-02-17T19:55:44  <ThomasWaldmann> i didn't have a deeper look yet, though
 211 2011-02-17T19:56:50  <MattMaker> I expect I will have some tiny patches today for fs19 here and there, if you have time to contemplate them
 212 2011-02-17T19:57:13  <ThomasWaldmann> sure
 213 2011-02-17T19:59:47  <MattMaker> for my current understanding of the code, it helps to be able to instrument pieces of it and have them output little debug messages so I can observe what order things are happening in before an error, that sort of thing
 214 2011-02-17T20:00:03  <MattMaker> question: any recommendations there? special decorators?
 215 2011-02-17T20:03:25  <ThomasWaldmann> logging.debug
 216 2011-02-17T20:03:27  *** Marchael has quit IRC
 217 2011-02-17T20:03:36  <ThomasWaldmann> you need to load a logging.conf then
 218 2011-02-17T20:03:38  <MattMaker> and especially, ways to apply such things without changing the source file in question, might be clever. like if I wanted to fully trace certain classes without inserting code in the source files, so as not to confuse hg diff about what I am actually considering for putting in a patch, as opposed to having to put in and then remove again a bunch of debug lines
 219 2011-02-17T20:03:57  <MattMaker> yes, I have plenty of logging.debug calls
 220 2011-02-17T20:04:29  <ThomasWaldmann> if the stuff you put in is in general useful for debugging, you can leave it there
 221 2011-02-17T20:04:30  <MattMaker> but that is bothersome because of such changes appearing in diffs
 222 2011-02-17T20:04:39  <MattMaker> ah, a good point
 223 2011-02-17T20:05:01  <ThomasWaldmann> try to make output meaningful :)
 224 2011-02-17T20:05:14  <MattMaker> yes :)
 225 2011-02-17T20:08:14  *** Marchael has joined #moin-dev
 226 2011-02-17T20:13:19  *** m4k3r has quit IRC
 227 2011-02-17T20:14:00  *** m4k3r has joined #moin-dev
 228 2011-02-17T20:24:34  *** Marchael has quit IRC
 229 2011-02-17T20:24:37  <ThomasWaldmann> http://test.moinmo.in works - with apach2/modwsgi/virtualenv/moin2 :)
 230 2011-02-17T20:31:40  <MattMaker> nice! was it tricky to persuade it? :)
 231 2011-02-17T20:33:51  <ThomasWaldmann> no
 232 2011-02-17T20:34:05  <ThomasWaldmann> followed modwsgi docs
 233 2011-02-17T20:34:21  <ThomasWaldmann> wasn't quite intuitive, but easy
 234 2011-02-17T20:38:52  *** ChanServ sets mode: +o ThomasWaldmann
 235 2011-02-17T20:38:56  *** ThomasWaldmann changes topic to "upgrading *.moinmo.in right now, expect some downtime"
 236 2011-02-17T21:04:50  *** moinBot has joined #moin-dev
 237 2011-02-17T21:08:13  <MattMaker> oooh, I caught a good one
 238 2011-02-17T21:09:54  <MattMaker> patch: maintain password as a unicode string, don't accidentally change it to str    http://paste.pocoo.org/show/340431/
 239 2011-02-17T21:12:23  *** ThomasWaldmann changes topic to "MoinMoin Developer Channel - User or third-party issues should go to #moin. Note that you are  publicly logged here."
 240 2011-02-17T21:12:32  *** ChanServ sets mode: -o ThomasWaldmann
 241 2011-02-17T21:14:09  <ThomasWaldmann> MattMaker: it's unicode everywhere else?
 242 2011-02-17T21:14:47  <ThomasWaldmann> that upgrade was painless :)
 243 2011-02-17T21:14:50  <MattMaker> yes, I looked, although I am still novice
 244 2011-02-17T21:17:51  <MattMaker> I got the error because I had a user account in my moin193 wiki that was not sha256, and at some point kvstore was unhappy that my password had become a str
 245 2011-02-17T21:18:53  <ThomasWaldmann> ah, yeah, suspected that :)
 246 2011-02-17T21:21:14  * ThomasWaldmann is not quite sure whether all those functions (base64, sha, ...) are happy with a unicode object
 247 2011-02-17T21:22:07  <MattMaker> possibly it could vary somewhat with the user's Python version, but the relevant changes are marked as having been introduced in Python 2.2
 248 2011-02-17T21:22:50  <MattMaker> that reminds me,  is there a way for me to run only selected pytests?
 249 2011-02-17T21:24:25  <MattMaker> also, I made this very related patch suggestion yesterday:  http://paste.pocoo.org/show/340439/   , because it really, really does seem that everything associated with metadata in MoinMoin expects unicode strings
 250 2011-02-17T21:26:23  <MattMaker> although that might have surprise side effects if kvstore is used to hold some unicode-aware custom type (one that implements a __unicode__() method, which this would cause to be called)
 251 2011-02-17T21:26:42  <ThomasWaldmann> ./pytest -k user
 252 2011-02-17T21:27:30  <MattMaker> cool, thanks
 253 2011-02-17T21:28:50  <MattMaker> possibly, though, kvstore is better off throwing the exceptions it does, to catch other places in code that accidentally use str type. maybe it should warn.
 254 2011-02-17T21:31:13  <ThomasWaldmann> well, better be strict and not cause even stranger trouble SOMETIMES
 255 2011-02-17T21:35:33  <MattMaker> I agree, but I also think that in practice, the wiki server should not crash in this case
 256 2011-02-17T21:37:22  <MattMaker> good grief, I am reading the docs at http://pytest.org , but nothing there is telling me what the output symbols represent. I understand "." and "F", but what is "S" ?
 257 2011-02-17T21:37:24  <ThomasWaldmann> yes, exactly because of that it should be strict
 258 2011-02-17T21:37:43  <ThomasWaldmann> because if it is not, it will only crash for some values
 259 2011-02-17T21:37:53  <ThomasWaldmann> see unicode/str in py2 and py3
 260 2011-02-17T21:38:12  <ThomasWaldmann> s is skipped
 261 2011-02-17T21:38:30  <ThomasWaldmann> x is xfailed
 262 2011-02-17T21:39:01  <MattMaker> ah, ok
 263 2011-02-17T21:41:10  <MattMaker> ThomasWaldmann so in this case, what do you mean by "be strict"? what should the code do, where should the code punish us?
 264 2011-02-17T21:41:19  <MattMaker> or whom
 265 2011-02-17T21:46:59  <ThomasWaldmann> it should insist on str being str and unicode being unicode
 266 2011-02-17T21:47:14  <ThomasWaldmann> and we must be consistent
 267 2011-02-17T21:52:36  <MattMaker> ahh, I just read the docs for KVStore() and I think I understand now
 268 2011-02-17T21:54:06  <MattMaker> so, it will catch you if you accidentally change the value type you are storing
 269 2011-02-17T21:57:12  <ThomasWaldmann> ok, hg is at 1.6.4 now
 270 2011-02-17T21:58:47  <MattMaker> I withdraw my kvstore patch suggestion, then. However, perhaps kvstore should define an exception to throw rather than asserting
 271 2011-02-17T22:00:10  <MattMaker> oh, I see the advantage, asserts are optimized out in production code
 272 2011-02-17T22:00:15  * MattMaker reads some more
 273 2011-02-17T22:02:27  <MattMaker> ThomasWaldmann suggestion: add http://paste.pocoo.org/ to this channel's topic; I keep going over to #moin to remember it :)
 274 2011-02-17T22:04:01  *** ChanServ sets mode: +o ThomasWaldmann
 275 2011-02-17T22:04:42  *** ThomasWaldmann changes topic to "MoinMoin Developer Channel - User or third-party issues should go to #moin. Note that you are publicly logged here. Use http://paste.pocoo.org/."
 276 2011-02-17T22:04:50  *** ChanServ sets mode: -o ThomasWaldmann
 277 2011-02-17T23:04:19  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10471:e61447e6dee8 2.0-dev/MoinMoin/ (_template.py app.py): app/init/template: minor cleanups, update (c)
 278 2011-02-17T23:23:58  * ThomasWaldmann kills MoinMoin.support
 279 2011-02-17T23:27:13  *** m4k3r has quit IRC
 280 2011-02-17T23:40:45  *** RogerHaase has left #moin-dev
 281 2011-02-17T23:46:30  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10472:c8d66980bc42 2.0-dev/ (16 files in 6 dirs):
 282 2011-02-17T23:46:30  <CIA-65> remove MoinMoin.support package + related sys.path hack
 283 2011-02-17T23:46:30  <CIA-65> moved remaining modules to MoinMoin.util: